Skip to content

fix: simplify litegraph ECS compatibility paths - #16409

Merged
DrJKL merged 2 commits into
fix/ecs-fu-15930from
fix/pr-16235-review-followups
Aug 31, 2026
Merged

DrJKL merged 2 commits into
fix/ecs-fu-15930from
fix/pr-16235-review-followups

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Addresses the remaining review findings on #16235 by removing two hidden state mechanisms and restoring one source of truth for each behavior.

Reasoning

#16235 added a private widget-name alias to preserve duplicate public names. It also retained rejected link endpoint writes so a later setter could complete them. Both mechanisms made behavior depend on state that callers and other subsystems could not observe. The alias disagreed with rendering and serialization. The retained endpoint patch made an unrelated future write replay an earlier failure.

This PR removes both mechanisms. Code that changes multiple endpoint fields now states that intent with one atomic operation. Widget registration returns to the existing canonical-name contract. The other two fixes narrow temporary state and disconnect behavior to their intended lifetimes and targets.

Design invariants

  1. One widget identity. WidgetId is graphId:nodeId:name, so widget names are unique within a node. Registration, rendering, restoration, and named serialization use that same name. label remains the display value. Duplicate names receive deterministic #N suffixes.
  2. Restoration lasts only for configuration. configure() installs restoration before existing widgets and onConfigure consume it. A finally block clears it before configure() returns, including when an extension callback throws. Widgets added later start with their declared defaults.
  3. Failed mutations have no future effect. A rejected endpoint setter leaves the link unchanged and stores nothing. A node-and-slot move uses updateEndpoints() so the link store validates and applies the complete destination once.
  4. Targeted disconnects affect only the target. disconnectOutput(slot, target) removes regular links to that target. Output-side floating links have no target and remain attached. disconnectOutput(slot) still removes both regular and floating links.

Changes

  • Delete widgetStorageNames and reuse ensureUniqueWidgetNames().
  • Delete pendingEndpointPatches and migrate paired first-party writes to LLink.updateEndpoints().
  • Clear widget restoration after onConfigure with finally.
  • Skip floating-link cleanup during targeted output disconnects.

Compatibility

Extensions that create duplicate widget names now observe deterministic suffixes such as name#1. This restores the documented WidgetId invariant and prevents duplicate renderer keys and named-value collisions.

Individual legacy endpoint setters remain non-throwing. Callers that need to change both the node and slot must use the atomic operation instead of relying on a failed write being replayed later.

Test plan

  • Test-only commit reproduces all four regressions: 7 failures and 94 passes.
  • Fix commit: 8 focused files and 285 tests pass.
  • pnpm typecheck
  • pnpm lint with 0 errors and existing warnings only
  • pnpm format:check
  • pnpm knip
  • Fallow diff audit passes with no introduced findings

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a294da57-173f-4afb-87a0-cb5d871aab51

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1888 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1867 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/31/2026, 07:26:13 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 127ms TBT · 91.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.0 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 32ms TBT · 157.3 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 541ms TBT · 167.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 488ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 57.3 MB
canvas-idle: DOM nodes -284
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 38ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 914ms
canvas-mouse-sweep: script duration 158ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.1 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -156
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 359ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.1 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 443ms
dom-widget-clipping: script duration 160ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 80.0 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 606ms
large-graph-idle: script duration 31ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.9 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1615ms
large-graph-pan: script duration 780ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.0 MB
large-graph-pan: DOM nodes -276
large-graph-pan: event listeners -168
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1660ms
large-graph-zoom: script duration 739ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.6 MB
large-graph-zoom: DOM nodes 1
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1887ms
legacy-node-drag: script duration 923ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.1 MB
legacy-node-drag: DOM nodes 2
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 570ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.7 MB
minimap-idle: DOM nodes -133
minimap-idle: event listeners -76
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 402ms
subgraph-dom-widget-clipping: script duration 138ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.0 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 495ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 58.5 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 833ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.0 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 885ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 127ms
subgraph-transition-enter: heap used 91.9 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5737ms
viewport-pan-sweep: script duration 2569ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.7 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -138
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16504ms
vue-large-graph-idle: script duration 267ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.0 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 20730ms
vue-large-graph-pan: script duration 881ms
vue-large-graph-pan: TBT 32ms
vue-large-graph-pan: heap used 157.3 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 86ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6022ms
vue-node-resize-workload: script duration 104ms
vue-node-resize-workload: TBT 541ms
vue-node-resize-workload: heap used 167.8 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 9
workflow-execution: task duration 89ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.4 MB
workflow-execution: DOM nodes 114
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-08-31T19:37:58.262Z",
  "gitSha": "06a476e4e6714668bdc2964ab5b91266fb933675",
  "branch": "fix/pr-16235-review-followups",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2023.5099999999875,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.226999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.534,
      "heapDeltaBytes": 62980,
      "heapUsedBytes": 63756784,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.851,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2034.509000000071,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.535999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.942,
      "heapDeltaBytes": -13205944,
      "heapUsedBytes": 56509152,
      "domNodes": -286,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.524000000000003,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1999.5770000000448,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 40.873,
      "layouts": 14,
      "layoutDurationMs": 4.437,
      "taskDurationMs": 965.4050000000001,
      "heapDeltaBytes": -8801456,
      "heapUsedBytes": 61043460,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 168.313,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1780.6000000000495,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 34.817,
      "layouts": 14,
      "layoutDurationMs": 4.101999999999999,
      "taskDurationMs": 862.3740000000001,
      "heapDeltaBytes": -9125100,
      "heapUsedBytes": 60792408,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 148.37699999999998,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1750.327000000027,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 17.69,
      "layouts": 6,
      "layoutDurationMs": 1.123,
      "taskDurationMs": 353.44199999999995,
      "heapDeltaBytes": 4414580,
      "heapUsedBytes": 74485528,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.131,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.7379999999357,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.697,
      "layouts": 6,
      "layoutDurationMs": 1.161,
      "taskDurationMs": 365.059,
      "heapDeltaBytes": 4606344,
      "heapUsedBytes": 74639448,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.416000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 625.8740000000103,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.044,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.65500000000003,
      "heapDeltaBytes": 18441584,
      "heapUsedBytes": 87770424,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 162.8,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 645.0059999999667,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.624000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.623,
      "heapDeltaBytes": 17408508,
      "heapUsedBytes": 80089208,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 157.111,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.5420000000304,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.957,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 589.59,
      "heapDeltaBytes": -13504620,
      "heapUsedBytes": 86730664,
      "domNodes": -267,
      "jsHeapTotalBytes": -1609728,
      "scriptDurationMs": 30.92,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2048.541,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.468999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 621.965,
      "heapDeltaBytes": -12991728,
      "heapUsedBytes": 87155964,
      "domNodes": -268,
      "jsHeapTotalBytes": -1347584,
      "scriptDurationMs": 30.640999999999988,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2251.7899999999713,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 8.786000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1562.532,
      "heapDeltaBytes": 17947244,
      "heapUsedBytes": 83976244,
      "domNodes": -274,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 771.614,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2295.0309999999945,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 9.873,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1668.015,
      "heapDeltaBytes": 3637472,
      "heapUsedBytes": 79623248,
      "domNodes": -277,
      "jsHeapTotalBytes": -372736,
      "scriptDurationMs": 787.7769999999999,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3432.2910000000206,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 9.892000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.296000000000001,
      "taskDurationMs": 1619.4569999999999,
      "heapDeltaBytes": 8794720,
      "heapUsedBytes": 75709212,
      "domNodes": 2,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 722.51,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3565.093999999931,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.332,
      "layouts": 60,
      "layoutDurationMs": 11.389,
      "taskDurationMs": 1699.901,
      "heapDeltaBytes": 9110216,
      "heapUsedBytes": 76472636,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 755.6270000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3073.6689999999953,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.407000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1857.0359999999998,
      "heapDeltaBytes": 22720868,
      "heapUsedBytes": 89470432,
      "domNodes": 4,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 931.546,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3059.050999999954,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.6080000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1916.789,
      "heapDeltaBytes": 23824520,
      "heapUsedBytes": 91064980,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 914.441,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2043.2309999999916,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.529999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.3359999999999,
      "heapDeltaBytes": -14620532,
      "heapUsedBytes": 87369724,
      "domNodes": -267,
      "jsHeapTotalBytes": -823296,
      "scriptDurationMs": 34.562999999999995,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.4589999999735,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.8320000000000028,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.965,
      "heapDeltaBytes": 21702616,
      "heapUsedBytes": 88109952,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.21099999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 587.306999999953,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.847,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.802,
      "heapDeltaBytes": 14294136,
      "heapUsedBytes": 86251108,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 140.92000000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 580.7889999999816,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.097,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.10400000000004,
      "heapDeltaBytes": 13965652,
      "heapUsedBytes": 85638396,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 135.787,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.690999999952,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.525000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.24500000000006,
      "heapDeltaBytes": -10152580,
      "heapUsedBytes": 61447376,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.636999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.1019999999562,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.861,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.449,
      "heapDeltaBytes": -10494844,
      "heapUsedBytes": 61340700,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.460999999999998,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1734.6239999999966,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.51199999999999,
      "layouts": 18,
      "layoutDurationMs": 5.3100000000000005,
      "taskDurationMs": 840.208,
      "heapDeltaBytes": -529000,
      "heapUsedBytes": 71548364,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 110.83999999999999,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1738.5399999999436,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 36.541000000000004,
      "layouts": 18,
      "layoutDurationMs": 4.983,
      "taskDurationMs": 826.1510000000001,
      "heapDeltaBytes": -11341452,
      "heapUsedBytes": 60537796,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 112.371,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1367.0040000000654,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.103000000000005,
      "layouts": 15,
      "layoutDurationMs": 15.518,
      "taskDurationMs": 885.45,
      "heapDeltaBytes": -1658372,
      "heapUsedBytes": 96373668,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 28.612000000000005,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8349.82100000002,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 34.86,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5680.156999999999,
      "heapDeltaBytes": -19576520,
      "heapUsedBytes": 80287352,
      "domNodes": -268,
      "jsHeapTotalBytes": -1122304,
      "scriptDurationMs": 2557.001,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8712.33200000006,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 34.518,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5793.18,
      "heapDeltaBytes": -10529744,
      "heapUsedBytes": 88933300,
      "domNodes": -268,
      "jsHeapTotalBytes": -630784,
      "scriptDurationMs": 2581.216,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16552.52300000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15792.717,
      "heapDeltaBytes": -28364144,
      "heapUsedBytes": 174092236,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2125824,
      "scriptDurationMs": 249.48399999999998,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18117.569000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17215.864999999998,
      "heapDeltaBytes": -33526896,
      "heapUsedBytes": 174027696,
      "domNodes": -6548,
      "jsHeapTotalBytes": -9711616,
      "scriptDurationMs": 284.371,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20363.036999999964,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 16.31100000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19933.476,
      "heapDeltaBytes": -41755716,
      "heapUsedBytes": 167206556,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4632576,
      "scriptDurationMs": 863.026,
      "eventListeners": -7474,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21942.920999999955,
      "styleRecalcs": 179,
      "styleRecalcDurationMs": 17.122999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21526.724000000002,
      "heapDeltaBytes": -39607056,
      "heapUsedBytes": 162593064,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 899.491,
      "eventListeners": -7465,
      "totalBlockingTimeMs": 58,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5902.818000000025,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.09499999999997,
      "layouts": 20,
      "layoutDurationMs": 22.87199999999999,
      "taskDurationMs": 5825.748999999999,
      "heapDeltaBytes": -22833500,
      "heapUsedBytes": 178491208,
      "domNodes": -6548,
      "jsHeapTotalBytes": 14667776,
      "scriptDurationMs": 103.179,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 463,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6321.5020000000095,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 90.27800000000002,
      "layouts": 20,
      "layoutDurationMs": 28.971999999999998,
      "taskDurationMs": 6218.641,
      "heapDeltaBytes": -34470836,
      "heapUsedBytes": 173334440,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4390912,
      "scriptDurationMs": 105.58,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 618,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 106.96800000005169,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.869,
      "layouts": 3,
      "layoutDurationMs": 0.895,
      "taskDurationMs": 81.864,
      "heapDeltaBytes": 3248376,
      "heapUsedBytes": 70935812,
      "domNodes": 110,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.915999999999999,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 462.3109999999997,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 18.945999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.8490000000000002,
      "taskDurationMs": 96.89199999999998,
      "heapDeltaBytes": 5050632,
      "heapUsedBytes": 68262708,
      "domNodes": 117,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.569000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 31, 2026
@DrJKL
DrJKL requested a review from christian-byrne August 31, 2026 19:34
@codecov

codecov Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/LLink.ts 50.00% 6 Missing ⚠️
src/lib/litegraph/src/canvas/FloatingRenderLink.ts 0.00% 6 Missing ⚠️
src/lib/litegraph/src/Reroute.ts 0.00% 1 Missing ⚠️
@@                Coverage Diff                @@
##           fix/ecs-fu-15930   #16409   +/-   ##
=================================================
  Coverage             83.24%   83.25%           
=================================================
  Files                  2022     2022           
  Lines                116981   116936   -45     
  Branches              32708    32680   -28     
=================================================
- Hits                  97383    97355   -28     
+ Misses                19245    19227   -18     
- Partials                353      354    +1     
Flag Coverage Δ
e2e 66.64% <51.85%> (+0.02%) ⬆️
unit 76.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraph.ts 77.92% <100.00%> (-0.02%) ⬇️
src/lib/litegraph/src/LGraphNode.ts 69.24% <100.00%> (-0.33%) ⬇️
src/lib/litegraph/src/widgets/BaseWidget.ts 83.47% <100.00%> (-1.85%) ⬇️
src/lib/litegraph/src/Reroute.ts 79.45% <0.00%> (+0.27%) ⬆️
src/lib/litegraph/src/LLink.ts 71.33% <50.00%> (+1.09%) ⬆️
src/lib/litegraph/src/canvas/FloatingRenderLink.ts 1.75% <0.00%> (+0.30%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL merged commit 4aaa547 into fix/ecs-fu-15930 Aug 31, 2026
96 of 98 checks passed
@DrJKL
DrJKL deleted the fix/pr-16235-review-followups branch August 31, 2026 19:54
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants