Repository navigation
[Backport cloud/1.52] feat: open Settings on Plans & Credits from a ?settings= deep link - #16403
Closed
dante01yoon wants to merge 1 commit into
Closed
dante01yoon wants to merge 1 commit into
dante01yoon wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
🎨 Storybook: 🚧 Building...🎭 Playwright: ⏳ Running... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.52 #16403 +/- ##
=============================================
Coverage ? 74.04%
=============================================
Files ? 1822
Lines ? 97777
Branches ? 29327
=============================================
Hits ? 72401
Misses ? 25208
Partials ? 168
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports #15808 to
cloud/1.52so?settings=plan-creditsworks in the frontend release currently promoted to Cloud production.Why
cloud/1.52branched before #15808 merged, and the original backport labels only covered 1.51. As a result, Cloud production currently strips or ignores the deep-link intent and does not open Plans & Credits.Slack context: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1787597535486829
Changes
cloud/1.52Verification
pnpm typecheckpassedpnpm knippassedScreenshots
Behavior and UI are unchanged from #15808; see the original PR for AS IS / TO BE evidence.