Skip to content

[Backport cloud/1.52] feat: open Settings on Plans & Credits from a ?settings= deep link - #16403

Closed
dante01yoon wants to merge 1 commit into
Comfy-Org:cloud/1.52from
dante01yoon:backport-15808-to-cloud-1.52
Closed

dante01yoon wants to merge 1 commit into
Comfy-Org:cloud/1.52from
dante01yoon:backport-15808-to-cloud-1.52

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Summary

Backports #15808 to cloud/1.52 so ?settings=plan-credits works in the frontend release currently promoted to Cloud production.

Why

cloud/1.52 branched before #15808 merged, and the original backport labels only covered 1.51. As a result, Cloud production currently strips or ignores the deep-link intent and does not open Plans & Credits.

Slack context: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1787597535486829

Changes

Verification

  • 18 targeted unit/integration tests passed
  • pnpm typecheck passed
  • ESLint passed for all changed source files
  • Pre-push pnpm knip passed

Screenshots

Behavior and UI are unchanged from #15808; see the original PR for AS IS / TO BE evidence.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c2c8359b-032b-4917-97a4-230391bb3e56

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: 🚧 Building...

🎭 Playwright: ⏳ Running...

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.52   #16403   +/-   ##
=============================================
  Coverage              ?   74.04%           
=============================================
  Files                 ?     1822           
  Lines                 ?    97777           
  Branches              ?    29327           
=============================================
  Hits                  ?    72401           
  Misses                ?    25208           
  Partials              ?      168           
Flag Coverage Δ
unit 74.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants