Skip to content

fix: secure fork E2E coverage handoff - #16402

Closed
benjcooley wants to merge 3 commits into
v2-nodes-apifrom
bencooley/fe-1888-fix-fork-checkout-failure-in-e2e
Closed

benjcooley wants to merge 3 commits into
v2-nodes-apifrom
bencooley/fe-1888-fix-fork-checkout-failure-in-e2e

Conversation

@benjcooley

Copy link
Copy Markdown
Collaborator

Summary

Package E2E coverage in the unprivileged originating run so the trusted workflow_run can upload fork coverage without checking out untrusted source. This also commits the slot's existing bounded system-monitor API work.

Changes

  • What: Merge LCOV, validate source mapping, and generate HTML in the originating E2E run; the trusted follow-up only downloads and republishes fixed artifacts before uploading to Codecov.
  • What: Preserve Codecov branch, commit, and PR overrides from ci: attribute e2e Codecov uploads to the triggering run's head commit #15339 and add a structural regression test for the trust boundary.
  • What: Expose a validated system.monitor() Node API capability with bounded hardware metrics and unit coverage.

Review Focus

The workflow_run path never checks out fork source or inherits secrets into the untrusted packaging job. Codecov still receives the triggering run's head SHA and branch; fork PRs with an empty pull_requests array continue to associate by authoritative commit SHA.

Fixes #16002
Linear: FE-1888 — https://linear.app/comfyorg/issue/FE-1888/fix-fork-checkout-failure-in-e2e-coverage-workflow-run

Verification

  • go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 .github/workflows/ci-tests-e2e-coverage.yaml .github/workflows/ci-tests-e2e.yaml
  • pnpm test:unit scripts/cicd/e2e-coverage-workflow.test.ts
  • pnpm test:unit src/platform/nodeApi/systemHandle.test.ts src/platform/nodeApi/comfyApi.test.ts src/platform/nodeApi/apiSurface.test.ts
  • pnpm typecheck
  • pnpm exec oxfmt --check on changed files

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a2bd90ce-8042-4115-ae65-00119b7a5267

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@benjcooley

Copy link
Copy Markdown
Collaborator Author

Superseded by #16404, which contains only the FE-1888 workflow fix on top of main. Closing this mixed branch so the unrelated Node API commit cannot be merged with the CI change.

@benjcooley benjcooley closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant