Repository navigation
fix: secure fork E2E coverage handoff - #16402
benjcooley wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Superseded by #16404, which contains only the FE-1888 workflow fix on top of main. Closing this mixed branch so the unrelated Node API commit cannot be merged with the CI change. |
Summary
Package E2E coverage in the unprivileged originating run so the trusted
workflow_runcan upload fork coverage without checking out untrusted source. This also commits the slot's existing bounded system-monitor API work.Changes
system.monitor()Node API capability with bounded hardware metrics and unit coverage.Review Focus
The
workflow_runpath never checks out fork source or inherits secrets into the untrusted packaging job. Codecov still receives the triggering run's head SHA and branch; fork PRs with an emptypull_requestsarray continue to associate by authoritative commit SHA.Fixes #16002
Linear: FE-1888 — https://linear.app/comfyorg/issue/FE-1888/fix-fork-checkout-failure-in-e2e-coverage-workflow-run
Verification
go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 .github/workflows/ci-tests-e2e-coverage.yaml .github/workflows/ci-tests-e2e.yamlpnpm test:unit scripts/cicd/e2e-coverage-workflow.test.tspnpm test:unit src/platform/nodeApi/systemHandle.test.ts src/platform/nodeApi/comfyApi.test.ts src/platform/nodeApi/apiSurface.test.tspnpm typecheckpnpm exec oxfmt --checkon changed files