Repository navigation
[Phase 6c] Replace PrimeVue Dialog and remaining simple components #16352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
aeb1048
refactor: replace PrimeVue Dialog and remaining simple components
ampagent cbde988
test: observe migrated text-preview skeleton directly
ampagent 12c0db0
fix: forward InputKnob disabled state to KnobControl
DrJKL 745e96d
test: stack node search over a real directive-registered dialog
DrJKL 0f512dc
fix: settle confirm dialogs once and prove their focus and dismissal
DrJKL 4d6ab08
refactor: drop the dialog renderer option and close dialog props
DrJKL dc331ed
refactor: drop PrimeVue overlay selectors from dialog dismissal guards
DrJKL 289fceb
refactor: rename leftover primeVueOverlay locals
DrJKL ea79808
test: map knob pointer presses across the 270 degree arc
DrJKL 5384f9a
fix: keep node search boxes at their intended size and inside the vie…
DrJKL bee1ca2
test: cover nested confirm dialog focus trap and dismissal in e2e
DrJKL 154d4db
fix: let the canvas toolbar keep the shared floating panel radius
DrJKL 1345140
fix: mark design-system skeletons with data-slot
DrJKL 626d09a
refactor: sort keys in touched dialog, knob, and skeleton types
DrJKL b0cc837
refactor: derive Escape dismissal from the active dialog
DrJKL e6cbf32
refactor: name outside-pointer dismissal after the Reka event
DrJKL 5f1a7ee
refactor: drop the dialog-child z-index helper the selects already cover
DrJKL 0550c52
refactor: size skeletons with classes instead of PrimeVue props
DrJKL 512c8e8
refactor: move the knob into the design system as ui/knob
DrJKL e12dde9
test: prove dialog maximize by behavior instead of Tailwind classes
DrJKL 26b4241
refactor: open Settings, Manager and legacy pricing as modal dialogs
DrJKL c2a81df
fix: let searchable select take focus inside modal dialogs
DrJKL 9ac5fc5
fix: default design-system dialogs to modal
DrJKL 27b825e
refactor: make GlobalDialog always modal
DrJKL ab46036
docs: drop PrimeVue history from dialog comments
DrJKL c5ae0df
refactor: open the folder customization dialog as modal and drop the …
DrJKL 694f22d
fix: color the subscription dialog's cloud badge with the dialog surf…
DrJKL 1fee0c3
fix: keep toasts above dialogs and clear of the dialog header
DrJKL 982e689
refactor: replace caller dialog classes with design-system sizes
DrJKL bf9204d
fix: keep node search keyboard focus inside its modal dialog
DrJKL ccba411
fix: close keybinding confirmations when saving fails
DrJKL d2d0da3
fix: let clicks pass through a closing dialog overlay
DrJKL 59fa4c0
[automated] Update test expectations
invalid-email-address 8c61365
fix: let the top dialog take Escape and outside pointers
DrJKL 2da3c44
fix: clear node search filters on every close
DrJKL 424b0a2
fix: keep node search open when a toast is clicked
DrJKL 1952b0d
fix: split the knob's dead zone at its midpoint
DrJKL 987cb90
fix: follow only drags that start on the knob
DrJKL b85c4d6
fix: keep Reka's open focus when the autofocus target cannot take it
DrJKL 2fd6b47
fix: name the node search dialog for assistive tech
DrJKL 413f664
fix: close the legacy node search on one Escape
DrJKL 103be21
test: blur the auto-focused step before publish layout screenshots
DrJKL 300c7bd
fix: restore Home, End, PageUp and PageDown on the knob
DrJKL d82df35
refactor: type the knob's class prop like other ui components
DrJKL f4f8306
refactor: drop the unused alignment class from the node search overlay
DrJKL 7c157b2
[automated] Update test expectations
invalid-email-address ea6e654
test: start each publish dialog test from an empty workflows folder
DrJKL d490d2c
fix: let native modal dialogs take clicks over an open dialog
DrJKL e54ca19
fix: keep knob inputs numeric when the step is 0
DrJKL f050843
Merge remote-tracking branch 'origin/main' into primevue-removal/phas…
DrJKL 5766895
fix: open the SSO outside-organization dialog as a headless dialog
DrJKL 61bf236
Merge remote-tracking branch 'origin/main' into primevue-removal/phas…
DrJKL c5c3330
Merge branch 'main' into primevue-removal/phase-6-dialog
DrJKL 9af02bf
fix: keep toasts below a maximized dialog's header
DrJKL c0fb15d
test: keep a toast raised before a dialog above it
DrJKL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+491 Bytes
(100%)
...s/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-2xl-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+345 Bytes
(100%)
...ts/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-lg-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+476 Bytes
(100%)
...ts/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-md-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+167 Bytes
(100%)
...ialogs/publishDialog.spec.ts-snapshots/publish-dialog-mobile-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+471 Bytes
(100%)
...ts/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-sm-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+37 Bytes
(100%)
.../dialogs/publishDialog.spec.ts-snapshots/publish-dialog-wide-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+122 Bytes
(100%)
...ts/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-xl-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+101 Bytes
(100%)
...ditor.spec.ts-snapshots/mask-editor-dialog-from-context-menu-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+108 Bytes
(100%)
...s/tests/maskEditor.spec.ts-snapshots/mask-editor-dialog-open-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+723 Bytes
(100%)
...mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-518 Bytes
(100%)
...templates.spec.ts-snapshots/template-cards-with-overlay-tags-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+13 Bytes
(100%)
...ates.spec.ts-snapshots/template-filter-bar-select-components-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: This blur workaround isn't deterministic, and the golden it was re-baselined against is red in CI at this head.
The causal chain is clear enough from the diff:
DialogContentnow focuses an[autofocus]descendant on open the way the native<dialog>does, so the publish dialog paints a focus ring where it previously painted none, which perturbed all seven layout goldens. Thisblur()is the compensation, and the seven PNGs were recaptured with it in place.82 pixels at ratio 0.01 is about the size of a focus ring or a caret — so the compensation is landing most of the time but not reliably. Two things could produce that, and they want different fixes: Reka's focus scope restoring focus after this
blur()resolves (a race, fixable by waiting on the real readiness boundary instead of blurring once), or the baseline having been captured somewhere other than the CI container, which is precisely the drift the owner-triggered refresh label exists to prevent.Worth distinguishing before re-baselining again — recapturing through the label would fix the symptom either way, but if it's the race, the other six
publish-dialog-*goldens and the twomask-editor-dialog-*ones are sitting on the same coin flip and will start flaking later instead of now.Separately, blurring the focused element right before the capture means these screenshots no longer witness the focus behaviour this PR introduces. Given
DialogContentautofocus is one of the riskier changes here — andfocusAutofocusTargetalready has an open thread about disabled/hidden targets — it'd be worth one assertion somewhere that the intended element is focused on open, rather than only evidence that nothing is focused at capture time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changed: the blur is deterministic, and the red
lggolden predates it. Four facts from this head's CI and history:publish-dialog-*PNGs come from the label run in3db38ca(2026-10-10 19:36 UTC). The blur landed later, in5e46a64(2026-10-11 01:56 UTC). That label run used--grep @screenshot, solgwas the first layout test in its worker and saved through the keyboard prompt. The ring in that golden is a keyboard-modality focus ring on step 1.9249984(playwright-tests-chromium-sharded (3, 16)andplaywright-video-new-tests (chromium, 1, 3)) fail onlylg, with exactly 82 pixels different on every attempt. That is the same count as the run before the blur, when the actual image also had no ring. In the video job the other six breakpoints pass:xl,2xlandwidehave step 1 focused and blurred exactly aslgdoes, and match goldens captured without the ring. If Reka's focus scope restored focus after the blur, those three would fail too. Locally, after a keyboard save,:focus-visiblematched step 1 before the blur and nothing after it.[autofocus]is involved. The publish dialog has no[autofocus]descendant. Step 1 is focused by Reka's default open focus (first tabbable), which main already used through its ownonRekaOpenAutoFocus. Main's golden had no ring only because its run reachedlgthrough the mouse-click Overwrite path.confirmDialog.test.tsasserts that Cancel (autofocus) is focused on open and that a disabledautofocustarget falls back to the dialog's Close button.GlobalDialog.test.tsasserts theFilenamefield is focused on open. The layout screenshots stay focus-neutral so they test layout only.The fix for
lgis one more owner-triggered "New Browser Test Expectations" run. With the blur in place, that run no longer depends on test order.