Repository navigation
Parse optional doc_update.op_ids for per-op effect attribution (DQ-9 FE leg) - #16321
christian-byrne wants to merge 2 commits into
Conversation
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1914 passed, 48 failed · 3 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-30T22:16:07.069Z",
"gitSha": "c0667ffb4b4d7370351f737f3e41bd4195969a40",
"branch": "fix/enact7-doc-update-op-ids",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.7309999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.216000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.098,
"heapDeltaBytes": 3055932,
"heapUsedBytes": 99321096,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 11.275,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2048.3600000000024,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.165999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.588,
"heapDeltaBytes": 3044260,
"heapUsedBytes": 99396144,
"domNodes": 14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.120000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2254.4599999999946,
"styleRecalcs": 82,
"styleRecalcDurationMs": 49.23000000000001,
"layouts": 14,
"layoutDurationMs": 5.343,
"taskDurationMs": 1289.292,
"heapDeltaBytes": -7399548,
"heapUsedBytes": 88886384,
"domNodes": 64,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 163.80100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2256.3390000000254,
"styleRecalcs": 84,
"styleRecalcDurationMs": 49.172000000000004,
"layouts": 14,
"layoutDurationMs": 5.364,
"taskDurationMs": 1212.304,
"heapDeltaBytes": -7770260,
"heapUsedBytes": 86108596,
"domNodes": 65,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 150.085,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6180000000209,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.27,
"layouts": 6,
"layoutDurationMs": 1.264,
"taskDurationMs": 376.0330000000001,
"heapDeltaBytes": 5519740,
"heapUsedBytes": 102475268,
"domNodes": 76,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 12.148999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.854000000023,
"styleRecalcs": 31,
"styleRecalcDurationMs": 25.303,
"layouts": 6,
"layoutDurationMs": 4.45,
"taskDurationMs": 402.951,
"heapDeltaBytes": 5857296,
"heapUsedBytes": 102268112,
"domNodes": 76,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 12.621,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 1005.5420000000481,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.672999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 712.074,
"heapDeltaBytes": 6857616,
"heapUsedBytes": 103914912,
"domNodes": 8,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 148.805,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 971.95099999999,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.760999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.545,
"heapDeltaBytes": 7210760,
"heapUsedBytes": 104070728,
"domNodes": 14,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 146.796,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2002.2270000000049,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.7469999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.348,
"heapDeltaBytes": 16849812,
"heapUsedBytes": 120666108,
"domNodes": 6,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 39.422,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.4540000000525,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.842999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.993,
"heapDeltaBytes": 16816376,
"heapUsedBytes": 119865096,
"domNodes": 8,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 39.300000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3269.3199999999933,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.223999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2533.881,
"heapDeltaBytes": -6313612,
"heapUsedBytes": 98720640,
"domNodes": 8,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 871.1869999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3197.4119999999857,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2501.981,
"heapDeltaBytes": -6256484,
"heapUsedBytes": 98696484,
"domNodes": 8,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 875.6039999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 4421.288000000004,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.895999999999999,
"layouts": 60,
"layoutDurationMs": 15.315999999999999,
"taskDurationMs": 2605.992,
"heapDeltaBytes": 3417104,
"heapUsedBytes": 113489004,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 865.808,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4394.782999999961,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.472000000000003,
"layouts": 60,
"layoutDurationMs": 14.991000000000001,
"taskDurationMs": 2515.522,
"heapDeltaBytes": 10749220,
"heapUsedBytes": 121114808,
"domNodes": 26,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 851.9720000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 4783.94000000003,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3592.21,
"heapDeltaBytes": -12867760,
"heapUsedBytes": 98983468,
"domNodes": 6,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 984.784,
"eventListeners": 192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 4984.368000000018,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.0569999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3800.2569999999996,
"heapDeltaBytes": -13668092,
"heapUsedBytes": 98732588,
"domNodes": 2,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 1031.432,
"eventListeners": 192,
"totalBlockingTimeMs": 9,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2024.058000000025,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.708,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.1779999999999,
"heapDeltaBytes": 17065576,
"heapUsedBytes": 121807928,
"domNodes": 10,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 39.348000000000006,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.0699999999752,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.837999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.398,
"heapDeltaBytes": 16870816,
"heapUsedBytes": 122835804,
"domNodes": 8,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 37.550000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 721.1560000000077,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.652,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.435,
"heapDeltaBytes": -5664612,
"heapUsedBytes": 91309408,
"domNodes": 14,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 140.379,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 747.0080000000507,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.89,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.817,
"heapDeltaBytes": -5743512,
"heapUsedBytes": 91917068,
"domNodes": 18,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 145.08300000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.166999999954,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.256999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.145,
"heapDeltaBytes": 3206296,
"heapUsedBytes": 100791588,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 10.113000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.0920000000806,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.124999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.225,
"heapDeltaBytes": 3066748,
"heapUsedBytes": 100743620,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8.647,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1939.5850000000223,
"styleRecalcs": 82,
"styleRecalcDurationMs": 50.090999999999994,
"layouts": 18,
"layoutDurationMs": 6.8180000000000005,
"taskDurationMs": 1167.7930000000001,
"heapDeltaBytes": 6645380,
"heapUsedBytes": 104078620,
"domNodes": 70,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 120.678,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1901.075999999989,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.844,
"layouts": 18,
"layoutDurationMs": 6.514000000000001,
"taskDurationMs": 1114.649,
"heapDeltaBytes": 6076420,
"heapUsedBytes": 102499920,
"domNodes": 66,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 112.51,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.7689999999684,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.399000000000008,
"layouts": 14,
"layoutDurationMs": 12.915999999999997,
"taskDurationMs": 980.2239999999997,
"heapDeltaBytes": 23110128,
"heapUsedBytes": 119199016,
"domNodes": 13671,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 33.184,
"eventListeners": 2383,
"totalBlockingTimeMs": 119,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 12343.11299999996,
"styleRecalcs": 247,
"styleRecalcDurationMs": 43.217999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8694.066,
"heapDeltaBytes": -2292032,
"heapUsedBytes": 102403568,
"domNodes": -282,
"jsHeapTotalBytes": -2539520,
"scriptDurationMs": 2899.024,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12482.348999999998,
"styleRecalcs": 245,
"styleRecalcDurationMs": 41.263999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8850.495,
"heapDeltaBytes": -14572800,
"heapUsedBytes": 89798916,
"domNodes": -284,
"jsHeapTotalBytes": -1683456,
"scriptDurationMs": 2923.739,
"eventListeners": -173,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18737.092999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18415.175000000003,
"heapDeltaBytes": -21561676,
"heapUsedBytes": 208882760,
"domNodes": -6548,
"jsHeapTotalBytes": 8589312,
"scriptDurationMs": 367.0950000000001,
"eventListeners": -7455,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19228.385000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18903.679,
"heapDeltaBytes": -28751448,
"heapUsedBytes": 187713120,
"domNodes": -6548,
"jsHeapTotalBytes": 14237696,
"scriptDurationMs": 371.14300000000003,
"eventListeners": -7461,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 24197.28200000003,
"styleRecalcs": 182,
"styleRecalcDurationMs": 23.763999999999953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23926.129000000004,
"heapDeltaBytes": -20944156,
"heapUsedBytes": 189843736,
"domNodes": -6548,
"jsHeapTotalBytes": 10829824,
"scriptDurationMs": 957.2610000000002,
"eventListeners": -7445,
"totalBlockingTimeMs": 190,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 24234.95200000002,
"styleRecalcs": 182,
"styleRecalcDurationMs": 28.012999999999955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24014.149,
"heapDeltaBytes": -2485224,
"heapUsedBytes": 213681652,
"domNodes": -6548,
"jsHeapTotalBytes": 12595200,
"scriptDurationMs": 1001.6370000000001,
"eventListeners": -7451,
"totalBlockingTimeMs": 227,
"frameDurationMs": 18.329999999999806,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "workflow-execution",
"durationMs": 182.5339999999187,
"styleRecalcs": 9,
"styleRecalcDurationMs": 31.977999999999998,
"layouts": 3,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 146.601,
"heapDeltaBytes": 3847732,
"heapUsedBytes": 97447420,
"domNodes": 107,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.549999999999999,
"eventListeners": 51,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 151.03499999997894,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.492,
"layouts": 7,
"layoutDurationMs": 3.215,
"taskDurationMs": 121.22100000000002,
"heapDeltaBytes": 3940920,
"heapUsedBytes": 96588860,
"domNodes": 146,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.833000000000001,
"eventListeners": 54,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-panel-v1 #16321 +/- ##
============================================================
+ Coverage 80.67% 82.97% +2.30%
============================================================
Files 2339 2009 -330
Lines 120790 115757 -5033
Branches 35560 33303 -2257
============================================================
- Hits 97444 96049 -1395
+ Misses 22849 19367 -3482
+ Partials 497 341 -156
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 349 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
|
Retarget disposition at exact head The remaining delta in this PR is only malformed-array semantics: #16321 treats a mixed array as wholly unattributed, while main filters string members. Cloud |
doc_update.op_ids[]→DocUpdate.opIds(tolerant parse)Full context for agent readers
What
FE alignment leg of DQ-9 (per-op effect attribution). The cloud relay will emit
op_ids: string[]ondoc_updateframes so followers can attribute Yjs update effects to the specificdoc_opsbatch entries that produced them. This PR teaches the FE parser to carry that field:DocUpdategains optionalopIds?: string[]— doc comment states absence means "unattributed", never "no ops" (catch-up frames legally fold many ops into one snapshot; pre-DQ-9 hosts never send it).WireDatagainsop_ids?: unknown;parseServerDocFrameaccepts it only when it is an array whose every member is a string (isStringArrayguard), following the existing spread-conditional house pattern used foractor.[null]) →opIdsomitted, frame still parses and applies. Attribution is diagnostic metadata, not a gate.LayoutFollowerBridgere-dispatches the parsedDocUpdateobject as-is, soopIdspropagates todoc_updatelisteners with zero bridge changes — covered by a pass-through test.Deliberately NOT in this PR: pending-op ledger clearing keyed on
opIds(owned by a separate task in the dispatcher stack).Ordering vs cloud
The cloud emit leg is staged on cloud branch
christian-byrne/gap1-doc-update-op-ids@5c30160062(stacked on #7870). The FE leg is safe to land first: with noop_idson the wire,opIdsis simplyundefinedeverywhere, which is the pre-existing behavior.Diagram
Test evidence
pnpm vitest run src/workbench/extensions/agent/crdt/→ 9 files, 67/67 passed.pnpm typecheck, eslint,oxfmt --checkon changed files all clean.Glossary
op_idsfor effect attribution.doc_opsbatch entries whose effects adoc_updateframe carries.