Skip to content

Parse optional doc_update.op_ids for per-op effect attribution (DQ-9 FE leg) - #16321

Closed
christian-byrne wants to merge 2 commits into
nathaniel/agent-panel-v1from
fix/enact7-doc-update-op-ids
Closed

christian-byrne wants to merge 2 commits into
nathaniel/agent-panel-v1from
fix/enact7-doc-update-op-ids

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor
  • New optional doc_update.op_ids[] → DocUpdate.opIds (tolerant parse)
  • Backward-compatible: absent/malformed field never rejects a frame
  • Green: 67/67 crdt tests, typecheck, lint, format
Full context for agent readers

What

FE alignment leg of DQ-9 (per-op effect attribution). The cloud relay will emit op_ids: string[] on doc_update frames so followers can attribute Yjs update effects to the specific doc_ops batch entries that produced them. This PR teaches the FE parser to carry that field:

  • DocUpdate gains optional opIds?: string[] — doc comment states absence means "unattributed", never "no ops" (catch-up frames legally fold many ops into one snapshot; pre-DQ-9 hosts never send it).
  • WireData gains op_ids?: unknown; parseServerDocFrame accepts it only when it is an array whose every member is a string (isStringArray guard), following the existing spread-conditional house pattern used for actor.
  • Malformed field (non-array, mixed-type array, [null]) → opIds omitted, frame still parses and applies. Attribution is diagnostic metadata, not a gate.
  • LayoutFollowerBridge re-dispatches the parsed DocUpdate object as-is, so opIds propagates to doc_update listeners with zero bridge changes — covered by a pass-through test.

Deliberately NOT in this PR: pending-op ledger clearing keyed on opIds (owned by a separate task in the dispatcher stack).

Ordering vs cloud

The cloud emit leg is staged on cloud branch christian-byrne/gap1-doc-update-op-ids@5c30160062 (stacked on #7870). The FE leg is safe to land first: with no op_ids on the wire, opIds is simply undefined everywhere, which is the pre-existing behavior.

Diagram

cloud relay ──doc_update {v, workflow_id, seq, update_b64, op_ids?}──▶ apiTransport
                                                                          │
                                                    parseServerDocFrame(…)│  tolerant:
                                                    op_ids string[] → opIds; else omit
                                                                          ▼
                                              LayoutFollowerBridge.onDocUpdate
                                        (seq gap check → apply → KA-11 schema gate)
                                                                          │
                                       re-dispatch CustomEvent('doc_update', {detail})
                                                                          ▼
                                          listeners see DocUpdate.opIds unchanged

Test evidence

pnpm vitest run src/workbench/extensions/agent/crdt/ → 9 files, 67/67 passed. pnpm typecheck, eslint, oxfmt --check on changed files all clean.

Glossary

  • DQ-9 — design question ruling: relay emits per-frame op_ids for effect attribution.
  • opIds / op_ids — IDs of the doc_ops batch entries whose effects a doc_update frame carries.
  • catch-up frame — the snapshot-style update sent after (re)subscribe; folds many ops, so it carries no attribution.
  • KA-11 — read-time schema gate: a follower may not project a doc whose declared schema version this build was not written against.
  • LayoutFollowerBridge — FE component that subscribes to a workflow doc, applies remote updates to the follower Yjs doc, and re-dispatches frames.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 5 minutes.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2e661c08-1edf-43fe-a9ab-c3cf33a2bc1a

📥 Commits

Reviewing files that changed from the base of the PR and between 583ad3b and 5913395.

📒 Files selected for processing (4)
  • src/renderer/extensions/vueNodes/composables/processedWidgetRenderModel.ts
  • src/workbench/extensions/agent/crdt/docFrameClient.test.ts
  • src/workbench/extensions/agent/crdt/docFrameClient.ts
  • src/workbench/extensions/agent/crdt/followerSubscription.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/30/2026, 09:51:05 PM UTC

Links

🎭 Playwright: ❌ 1914 passed, 48 failed · 3 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1903 / ❌ 43 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 8 / ❌ 5 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 97.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 114.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 111.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 5ms TBT · 94.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 116.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 98.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 119ms TBT · 113.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.6 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 189.1 MB heap
vue-large-graph-pan: · 54.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 209ms TBT · 192.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 553ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 94.8 MB
canvas-idle: DOM nodes 15
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 49ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 83
canvas-mouse-sweep: task duration 1251ms
canvas-mouse-sweep: script duration 157ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 83.4 MB
canvas-mouse-sweep: DOM nodes 65
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 21ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 389ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 97.6 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 707ms
dom-widget-clipping: script duration 148ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 99.2 MB
dom-widget-clipping: DOM nodes 11
dom-widget-clipping: event listeners 3
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 580ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 114.7 MB
large-graph-idle: DOM nodes 7
large-graph-idle: event listeners 5
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 2518ms
large-graph-pan: script duration 873ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 94.1 MB
large-graph-pan: DOM nodes 8
large-graph-pan: event listeners 8
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 2561ms
large-graph-zoom: script duration 859ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 111.9 MB
large-graph-zoom: DOM nodes 25
large-graph-zoom: event listeners 11
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 3696ms
legacy-node-drag: script duration 1008ms
legacy-node-drag: TBT 5ms
legacy-node-drag: heap used 94.3 MB
legacy-node-drag: DOM nodes 4
legacy-node-drag: event listeners 192
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 548ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 116.7 MB
minimap-idle: DOM nodes 9
minimap-idle: event listeners 4
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 533ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 87.4 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 515ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 96.1 MB
subgraph-idle: DOM nodes 17
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 7ms
subgraph-mouse-sweep: style recalc duration 45ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 81
subgraph-mouse-sweep: task duration 1141ms
subgraph-mouse-sweep: script duration 117ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 98.5 MB
subgraph-mouse-sweep: DOM nodes 68
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 980ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 119ms
subgraph-transition-enter: heap used 113.7 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 8772ms
viewport-pan-sweep: script duration 2911ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 91.6 MB
viewport-pan-sweep: DOM nodes -283
viewport-pan-sweep: event listeners -165
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18659ms
vue-large-graph-idle: script duration 369ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 189.1 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7458
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 26ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 182
vue-large-graph-pan: task duration 23970ms
vue-large-graph-pan: script duration 979ms
vue-large-graph-pan: TBT 209ms
vue-large-graph-pan: heap used 192.4 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7448
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 26ms
workflow-execution: layout count 5
workflow-execution: style recalc count 9
workflow-execution: task duration 134ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 92.5 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 53
Raw data
{
  "timestamp": "2026-08-30T22:16:07.069Z",
  "gitSha": "c0667ffb4b4d7370351f737f3e41bd4195969a40",
  "branch": "fix/enact7-doc-update-op-ids",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2035.7309999999984,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.216000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 569.098,
      "heapDeltaBytes": 3055932,
      "heapUsedBytes": 99321096,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 11.275,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2048.3600000000024,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.165999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 536.588,
      "heapDeltaBytes": 3044260,
      "heapUsedBytes": 99396144,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.120000000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2254.4599999999946,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 49.23000000000001,
      "layouts": 14,
      "layoutDurationMs": 5.343,
      "taskDurationMs": 1289.292,
      "heapDeltaBytes": -7399548,
      "heapUsedBytes": 88886384,
      "domNodes": 64,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 163.80100000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2256.3390000000254,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 49.172000000000004,
      "layouts": 14,
      "layoutDurationMs": 5.364,
      "taskDurationMs": 1212.304,
      "heapDeltaBytes": -7770260,
      "heapUsedBytes": 86108596,
      "domNodes": 65,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 150.085,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.6180000000209,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.27,
      "layouts": 6,
      "layoutDurationMs": 1.264,
      "taskDurationMs": 376.0330000000001,
      "heapDeltaBytes": 5519740,
      "heapUsedBytes": 102475268,
      "domNodes": 76,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 12.148999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.854000000023,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 25.303,
      "layouts": 6,
      "layoutDurationMs": 4.45,
      "taskDurationMs": 402.951,
      "heapDeltaBytes": 5857296,
      "heapUsedBytes": 102268112,
      "domNodes": 76,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 12.621,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 1005.5420000000481,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.672999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 712.074,
      "heapDeltaBytes": 6857616,
      "heapUsedBytes": 103914912,
      "domNodes": 8,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 148.805,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 971.95099999999,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.760999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 701.545,
      "heapDeltaBytes": 7210760,
      "heapUsedBytes": 104070728,
      "domNodes": 14,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 146.796,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2002.2270000000049,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.7469999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 605.348,
      "heapDeltaBytes": 16849812,
      "heapUsedBytes": 120666108,
      "domNodes": 6,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 39.422,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2007.4540000000525,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.842999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 553.993,
      "heapDeltaBytes": 16816376,
      "heapUsedBytes": 119865096,
      "domNodes": 8,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 39.300000000000004,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3269.3199999999933,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.223999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2533.881,
      "heapDeltaBytes": -6313612,
      "heapUsedBytes": 98720640,
      "domNodes": 8,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 871.1869999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3197.4119999999857,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.389000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2501.981,
      "heapDeltaBytes": -6256484,
      "heapUsedBytes": 98696484,
      "domNodes": 8,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 875.6039999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4421.288000000004,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.895999999999999,
      "layouts": 60,
      "layoutDurationMs": 15.315999999999999,
      "taskDurationMs": 2605.992,
      "heapDeltaBytes": 3417104,
      "heapUsedBytes": 113489004,
      "domNodes": 24,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 865.808,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4394.782999999961,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.472000000000003,
      "layouts": 60,
      "layoutDurationMs": 14.991000000000001,
      "taskDurationMs": 2515.522,
      "heapDeltaBytes": 10749220,
      "heapUsedBytes": 121114808,
      "domNodes": 26,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 851.9720000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4783.94000000003,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.556,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3592.21,
      "heapDeltaBytes": -12867760,
      "heapUsedBytes": 98983468,
      "domNodes": 6,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 984.784,
      "eventListeners": 192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4984.368000000018,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.0569999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3800.2569999999996,
      "heapDeltaBytes": -13668092,
      "heapUsedBytes": 98732588,
      "domNodes": 2,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 1031.432,
      "eventListeners": 192,
      "totalBlockingTimeMs": 9,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.058000000025,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.708,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.1779999999999,
      "heapDeltaBytes": 17065576,
      "heapUsedBytes": 121807928,
      "domNodes": 10,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 39.348000000000006,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2008.0699999999752,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.837999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 554.398,
      "heapDeltaBytes": 16870816,
      "heapUsedBytes": 122835804,
      "domNodes": 8,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 37.550000000000004,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 721.1560000000077,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.652,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.435,
      "heapDeltaBytes": -5664612,
      "heapUsedBytes": 91309408,
      "domNodes": 14,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 140.379,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 747.0080000000507,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.89,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 538.817,
      "heapDeltaBytes": -5743512,
      "heapUsedBytes": 91917068,
      "domNodes": 18,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 145.08300000000003,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.166999999954,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.256999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 549.145,
      "heapDeltaBytes": 3206296,
      "heapUsedBytes": 100791588,
      "domNodes": 16,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 10.113000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.0920000000806,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.124999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.225,
      "heapDeltaBytes": 3066748,
      "heapUsedBytes": 100743620,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 8.647,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1939.5850000000223,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 50.090999999999994,
      "layouts": 18,
      "layoutDurationMs": 6.8180000000000005,
      "taskDurationMs": 1167.7930000000001,
      "heapDeltaBytes": 6645380,
      "heapUsedBytes": 104078620,
      "domNodes": 70,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 120.678,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1901.075999999989,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 40.844,
      "layouts": 18,
      "layoutDurationMs": 6.514000000000001,
      "taskDurationMs": 1114.649,
      "heapDeltaBytes": 6076420,
      "heapUsedBytes": 102499920,
      "domNodes": 66,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 112.51,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.7689999999684,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.399000000000008,
      "layouts": 14,
      "layoutDurationMs": 12.915999999999997,
      "taskDurationMs": 980.2239999999997,
      "heapDeltaBytes": 23110128,
      "heapUsedBytes": 119199016,
      "domNodes": 13671,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 33.184,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 119,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12343.11299999996,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 43.217999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8694.066,
      "heapDeltaBytes": -2292032,
      "heapUsedBytes": 102403568,
      "domNodes": -282,
      "jsHeapTotalBytes": -2539520,
      "scriptDurationMs": 2899.024,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12482.348999999998,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 41.263999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8850.495,
      "heapDeltaBytes": -14572800,
      "heapUsedBytes": 89798916,
      "domNodes": -284,
      "jsHeapTotalBytes": -1683456,
      "scriptDurationMs": 2923.739,
      "eventListeners": -173,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18737.092999999957,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18415.175000000003,
      "heapDeltaBytes": -21561676,
      "heapUsedBytes": 208882760,
      "domNodes": -6548,
      "jsHeapTotalBytes": 8589312,
      "scriptDurationMs": 367.0950000000001,
      "eventListeners": -7455,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19228.385000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18903.679,
      "heapDeltaBytes": -28751448,
      "heapUsedBytes": 187713120,
      "domNodes": -6548,
      "jsHeapTotalBytes": 14237696,
      "scriptDurationMs": 371.14300000000003,
      "eventListeners": -7461,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24197.28200000003,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 23.763999999999953,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23926.129000000004,
      "heapDeltaBytes": -20944156,
      "heapUsedBytes": 189843736,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10829824,
      "scriptDurationMs": 957.2610000000002,
      "eventListeners": -7445,
      "totalBlockingTimeMs": 190,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24234.95200000002,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 28.012999999999955,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24014.149,
      "heapDeltaBytes": -2485224,
      "heapUsedBytes": 213681652,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12595200,
      "scriptDurationMs": 1001.6370000000001,
      "eventListeners": -7451,
      "totalBlockingTimeMs": 227,
      "frameDurationMs": 18.329999999999806,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "workflow-execution",
      "durationMs": 182.5339999999187,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 31.977999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.9929999999999999,
      "taskDurationMs": 146.601,
      "heapDeltaBytes": 3847732,
      "heapUsedBytes": 97447420,
      "domNodes": 107,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.549999999999999,
      "eventListeners": 51,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 151.03499999997894,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 20.492,
      "layouts": 7,
      "layoutDurationMs": 3.215,
      "taskDurationMs": 121.22100000000002,
      "heapDeltaBytes": 3940920,
      "heapUsedBytes": 96588860,
      "domNodes": 146,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.833000000000001,
      "eventListeners": 54,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@comfy-pr-bot
comfy-pr-bot requested a review from a team as a code owner August 30, 2026 21:49
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 30, 2026
@christian-byrne christian-byrne self-assigned this Aug 30, 2026
@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                     Coverage Diff                      @@
##           nathaniel/agent-panel-v1   #16321      +/-   ##
============================================================
+ Coverage                     80.67%   82.97%   +2.30%     
============================================================
  Files                          2339     2009     -330     
  Lines                        120790   115757    -5033     
  Branches                      35560    33303    -2257     
============================================================
- Hits                          97444    96049    -1395     
+ Misses                        22849    19367    -3482     
+ Partials                        497      341     -156     
Flag Coverage Δ
e2e 66.88% <ø> (-0.02%) ⬇️
unit 75.87% <100.00%> (+0.07%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vueNodes/composables/processedWidgetRenderModel.ts 97.12% <ø> (ø)
.../workbench/extensions/agent/crdt/docFrameClient.ts 90.36% <100.00%> (+0.36%) ⬆️

... and 349 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@christian-byrne

christian-byrne commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor Author

Retarget disposition at exact head 59133959421ea1243323559ac382a3c4acdfea70: closing as superseded instead of force-updating this dead-base PR. Current FE main@f954e479a37b168a9596aa05a1ce1dec1e9a93b4 already carries optional doc_update.op_ids through DocUpdate.opIds and the ECS follower attribution path, and the required integration heads FE #16373 aaf12099e37fd6e0907d37346fc5631e74509842 and FE #16375 f66fce266695b3c5c5cd49a197914a60cc02bcc9 leave that parser contract unchanged.

The remaining delta in this PR is only malformed-array semantics: #16321 treats a mixed array as wholly unattributed, while main filters string members. Cloud main@623c3bd636346189b7c50b4fa8c7bfe1c826c62d, cloud #7870, and cloud #7823 do not emit op_ids on DocUpdateFrame at all, so the typed producer does not require choosing this stricter malformed-field rule before retiring the stale branch. Focused FE verification on main passed: docFrameClient.test.ts, ecsFollowerAdapter.integration.test.ts, and opSender.test.ts were 26/26. Program evidence: reports/pr-lifecycle/retgt-16321-disposition.md.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support risk:high PR risk grade (advisory shadow check; grader-owned) size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants