Skip to content

[slice-16] add target-aware graph references and navigation - #16290

Closed
christian-byrne wants to merge 1 commit into
christian-byrne/slice-15from
christian-byrne/slice-16
Closed

christian-byrne wants to merge 1 commit into
christian-byrne/slice-15from
christian-byrne/slice-16

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

TL;DR

  • Routes graph references by explicit workflowId plus stable node_locator_id; never resolves against the active canvas by fallback.
  • Activates only on a user click, verifies the target became active, then resolves and focuses; background resolution has no activation/focus side effect.
  • Fail-closes reference rendering and canvas-selection watchers behind AGENT_IN_APP_EXPERIENCE.
Full context for agent readers

Contract

This is chain slice 16, stacked on christian-byrne/slice-15 at fb0493305abe3fc21154125aaa05cec2bcf637ac. It introduces a typed target resolver with recoverable missing_target, closed_target, activation_failed, and missing_node outcomes. TabLinkCard carries the stable locator from agent_active_tab and delegates explicit node clicks to the resolver. Plain workflow links retain their existing behavior.

Target identity flow:

{workflowId, locatorId}
        |
workflow/tab binding registry
        |
explicit click -> activate bound tab -> verify active target -> resolve locator in target -> focus
        |
background resolve -------------------------------> no activation / no focus

G1 scorecard

  • Exact base: fb0493305abe3fc21154125aaa05cec2bcf637ac
  • Rebase: remote slice-15 re-fetched immediately before commit; unchanged, no rebase required
  • Flag off: TabLinkCard renders no action; useCanvasSelection does not install its selection watcher until enabled
  • Target isolation: duplicate local node IDs in workflows A/B resolve by target graph fixture; A never samples active B
  • Background behavior: resolver test proves no activation or focus side effect
  • Recoverability: typed errors cover missing/closed target, failed activation, and stale locator
  • Core regression: no core workflow helper changes and no unconditional agent branch
  • Tests: 62 agent-extension files / 715 tests green
  • Typecheck: green
  • Lint: green with 187 pre-existing warnings and zero errors
  • E2E: not run locally; browser environment was not started

Slice-15 integration

useAgentTargetNavigation.ts contains one marked STAND-IN(slice-15) over the shipped workflow/tab binding store because slice 15 does not yet expose a separate GraphDocument registry. Replace that adapter on rebase when the registry lands; the pure resolver contract and tests remain unchanged.

Scope / invariants

No semantic op application, queue, awareness, presence, automatic focus, or slice-17 activation surface is added. Follower behavior and CRDT reset/resync code are unchanged; the complete existing follower suite remains green.

Glossary

  • Graph reference: explicit workflow identity plus stable graph-aware node locator.
  • Target resolver: maps workflow identity to its bound open document without consulting the active canvas as fallback.
  • Background resolution: target lookup used by non-navigation effects; it cannot activate or focus.
  • Slice-15 stand-in: narrow adapter to the current binding registry, designed to be replaced by the final GraphDocument registry seam.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 30, 2026
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b6c3ef7b-a1df-4f0a-a947-1bb0a25ac616

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/30/2026, 10:18:50 AM UTC

Links

🎭 Playwright: ❌ 1887 passed, 1 failed

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1866 / ❌ 1 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 132ms TBT · 82.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.0 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 211ms TBT · 174.1 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 494ms TBT · 176.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 560ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.6 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 40ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 911ms
canvas-mouse-sweep: script duration 148ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.7 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 380ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.5 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 458ms
dom-widget-clipping: script duration 154ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.8 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 653ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.0 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -169
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1568ms
large-graph-pan: script duration 752ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.5 MB
large-graph-pan: DOM nodes -271
large-graph-pan: event listeners -154
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1711ms
large-graph-zoom: script duration 759ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.5 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1952ms
legacy-node-drag: script duration 958ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.0 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 626ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.2 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 410ms
subgraph-dom-widget-clipping: script duration 140ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 81.8 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 506ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.8 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 829ms
subgraph-mouse-sweep: script duration 105ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 56.1 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1019ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 132ms
subgraph-transition-enter: heap used 82.2 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 5870ms
viewport-pan-sweep: script duration 2611ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.0 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -138
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17685ms
vue-large-graph-idle: script duration 299ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.0 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 166
vue-large-graph-pan: task duration 21826ms
vue-large-graph-pan: script duration 932ms
vue-large-graph-pan: TBT 211ms
vue-large-graph-pan: heap used 174.1 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 34ms
vue-node-resize-workload: style recalc duration 77ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6356ms
vue-node-resize-workload: script duration 117ms
vue-node-resize-workload: TBT 494ms
vue-node-resize-workload: heap used 176.2 MB
vue-node-resize-workload: DOM nodes -6550
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 87ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.2 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-08-30T10:30:44.681Z",
  "gitSha": "05d5601c3a1bdd47340f50fd6baa2bbdda6ff0b3",
  "branch": "christian-byrne/slice-16",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2100.100999999995,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.706999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.439,
      "heapDeltaBytes": -11577648,
      "heapUsedBytes": 56992256,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 9.645999999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2034.507000000076,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.332,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 544.353,
      "heapDeltaBytes": 14204476,
      "heapUsedBytes": 82709752,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 10.389,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1855.1890000000526,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.368,
      "layouts": 14,
      "layoutDurationMs": 4.705,
      "taskDurationMs": 916.2459999999999,
      "heapDeltaBytes": -8309568,
      "heapUsedBytes": 61513772,
      "domNodes": -280,
      "jsHeapTotalBytes": 7856128,
      "scriptDurationMs": 145.293,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1906.6219999999703,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 40.580999999999996,
      "layouts": 14,
      "layoutDurationMs": 5.074999999999999,
      "taskDurationMs": 904.9889999999999,
      "heapDeltaBytes": 8688928,
      "heapUsedBytes": 72034980,
      "domNodes": -285,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 150.608,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.0410000000097,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.12,
      "layouts": 6,
      "layoutDurationMs": 1.1540000000000001,
      "taskDurationMs": 362.58000000000004,
      "heapDeltaBytes": 4370172,
      "heapUsedBytes": 74220828,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.796999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1741.2039999999251,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.484,
      "layouts": 6,
      "layoutDurationMs": 1.262,
      "taskDurationMs": 396.82900000000006,
      "heapDeltaBytes": 4385216,
      "heapUsedBytes": 73731648,
      "domNodes": 78,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 13.235000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 682.974999999999,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.39,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.33299999999997,
      "heapDeltaBytes": 18441252,
      "heapUsedBytes": 87929660,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 152.596,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 702.7659999999969,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.875,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.382,
      "heapDeltaBytes": 18134340,
      "heapUsedBytes": 87720188,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 154.447,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2062.2990000000527,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.124999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 612.589,
      "heapDeltaBytes": -12927032,
      "heapUsedBytes": 86950116,
      "domNodes": -271,
      "jsHeapTotalBytes": -1347584,
      "scriptDurationMs": 31.923999999999992,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.6820000000516,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.163999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 693.639,
      "heapDeltaBytes": 11340380,
      "heapUsedBytes": 87094568,
      "domNodes": -273,
      "jsHeapTotalBytes": -1908736,
      "scriptDurationMs": 35.475,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2155.892999999992,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.118,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1528.75,
      "heapDeltaBytes": 19027304,
      "heapUsedBytes": 84258364,
      "domNodes": -271,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 745.327,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2228.876000000014,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 14.888000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1608.2160000000001,
      "heapDeltaBytes": 23163620,
      "heapUsedBytes": 88813220,
      "domNodes": -271,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 759.247,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3545.4310000000078,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.796,
      "layouts": 60,
      "layoutDurationMs": 12.956,
      "taskDurationMs": 1668.044,
      "heapDeltaBytes": 9140752,
      "heapUsedBytes": 76201912,
      "domNodes": -279,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 742.774,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3568.4309999999186,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.086000000000002,
      "layouts": 60,
      "layoutDurationMs": 13.766,
      "taskDurationMs": 1753.1919999999998,
      "heapDeltaBytes": 8467956,
      "heapUsedBytes": 75750060,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 775.9430000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3094.0120000000206,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.6539999999999955,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1912.0750000000003,
      "heapDeltaBytes": 22021304,
      "heapUsedBytes": 88764768,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 928.8839999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3152.0799999999554,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.370000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1992.081,
      "heapDeltaBytes": 24098468,
      "heapUsedBytes": 91494404,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 986.118,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2007.265000000018,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.173999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.5230000000001,
      "heapDeltaBytes": 21893660,
      "heapUsedBytes": 87528560,
      "domNodes": -268,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.37800000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.0050000000783,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.0299999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 667.7790000000001,
      "heapDeltaBytes": -13770508,
      "heapUsedBytes": 87010404,
      "domNodes": -269,
      "jsHeapTotalBytes": -823296,
      "scriptDurationMs": 39.128,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.4030000000139,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.464,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.23299999999995,
      "heapDeltaBytes": 14355348,
      "heapUsedBytes": 86024772,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 138.799,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.8919999999689,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.302000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.192,
      "heapDeltaBytes": 13933224,
      "heapUsedBytes": 85600392,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.63799999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.5579999999663,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.480999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.047,
      "heapDeltaBytes": 2116220,
      "heapUsedBytes": 74089716,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.701,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2049.9209999999266,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 11.150999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.85100000000006,
      "heapDeltaBytes": -7701056,
      "heapUsedBytes": 63906928,
      "domNodes": -295,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.753,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1732.65200000003,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 35.173,
      "layouts": 18,
      "layoutDurationMs": 4.890000000000001,
      "taskDurationMs": 811.714,
      "heapDeltaBytes": -12212832,
      "heapUsedBytes": 59481060,
      "domNodes": -298,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 100.283,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1743.0200000000013,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.278999999999996,
      "layouts": 18,
      "layoutDurationMs": 5.666,
      "taskDurationMs": 845.609,
      "heapDeltaBytes": -13247252,
      "heapUsedBytes": 58136684,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 109.25900000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.4640000000327,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.944,
      "layouts": 15,
      "layoutDurationMs": 15.122,
      "taskDurationMs": 1019.002,
      "heapDeltaBytes": -9253300,
      "heapUsedBytes": 86182812,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 30.819000000000006,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8386.789000000022,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 37.795,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5762.696999999999,
      "heapDeltaBytes": -10903168,
      "heapUsedBytes": 89389368,
      "domNodes": -272,
      "jsHeapTotalBytes": -860160,
      "scriptDurationMs": 2607.2629999999995,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8506.14399999995,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 40.36599999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5977.294000000001,
      "heapDeltaBytes": -11419172,
      "heapUsedBytes": 88806224,
      "domNodes": -270,
      "jsHeapTotalBytes": -1908736,
      "scriptDurationMs": 2615.323,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18094.443999999952,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17485.147,
      "heapDeltaBytes": -33157524,
      "heapUsedBytes": 176462144,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3002368,
      "scriptDurationMs": 287.125,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18211.417000000096,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17884.691000000003,
      "heapDeltaBytes": -39946160,
      "heapUsedBytes": 175756200,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3874816,
      "scriptDurationMs": 311.536,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22050.910999999986,
      "styleRecalcs": 164,
      "styleRecalcDurationMs": 21.833999999999964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21774.505,
      "heapDeltaBytes": -25075612,
      "heapUsedBytes": 184558236,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5435392,
      "scriptDurationMs": 925.504,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 234,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22201.21800000004,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 21.50599999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21877.076,
      "heapDeltaBytes": -21931404,
      "heapUsedBytes": 180580908,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2551808,
      "scriptDurationMs": 938.8240000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 188,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6413.603000000023,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.164,
      "layouts": 20,
      "layoutDurationMs": 24.39300000000001,
      "taskDurationMs": 6335.79,
      "heapDeltaBytes": -9467004,
      "heapUsedBytes": 195350912,
      "domNodes": -6552,
      "jsHeapTotalBytes": 11677696,
      "scriptDurationMs": 118.04599999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 400,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6478.783000000021,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.44100000000005,
      "layouts": 20,
      "layoutDurationMs": 43.73100000000001,
      "taskDurationMs": 6377.023999999999,
      "heapDeltaBytes": -28654884,
      "heapUsedBytes": 174269524,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10428416,
      "scriptDurationMs": 115.208,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 588,
      "frameDurationMs": 18.33333333333327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 125.56500000005144,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.697,
      "layouts": 2,
      "layoutDurationMs": 1.348,
      "taskDurationMs": 93.177,
      "heapDeltaBytes": 3155564,
      "heapUsedBytes": 70582872,
      "domNodes": 130,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.72,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 100.94100000003436,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.066,
      "layouts": 2,
      "layoutDurationMs": 1.383,
      "taskDurationMs": 80.119,
      "heapDeltaBytes": 3093588,
      "heapUsedBytes": 70337920,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.019000000000002,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@christian-byrne
christian-byrne marked this pull request as draft August 30, 2026 10:18
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 30, 2026
@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.44444% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...gent/composables/agent/useAgentTargetNavigation.ts 35.29% 11 Missing ⚠️
...agent/services/agent/targetAwareAgentNavigation.ts 90.90% 3 Missing ⚠️
@@                    Coverage Diff                     @@
##           christian-byrne/slice-15   #16290    +/-   ##
==========================================================
  Coverage                     83.28%   83.29%            
==========================================================
  Files                          2022     2024     +2     
  Lines                        117037   117101    +64     
  Branches                      33047    32480   -567     
==========================================================
+ Hits                          97480    97540    +60     
- Misses                        19204    19208     +4     
  Partials                        353      353            
Flag Coverage Δ
e2e 66.65% <ø> (+<0.01%) ⬆️
unit 76.50% <84.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 92.67% <ø> (ø)
...ns/agent/components/agent/message/AgentMessage.vue 89.79% <ø> (ø)
...ons/agent/components/agent/message/TabLinkCard.vue 100.00% <100.00%> (ø)
...ions/agent/composables/agent/useCanvasSelection.ts 100.00% <100.00%> (ø)
...rkbench/extensions/agent/schemas/agentApiSchema.ts 100.00% <ø> (ø)
...nsions/agent/services/agent/agentEventTransport.ts 100.00% <ø> (ø)
...tensions/agent/services/agent/agentMessageParts.ts 100.00% <ø> (ø)
...agent/services/agent/targetAwareAgentNavigation.ts 90.90% <90.90%> (ø)
...gent/composables/agent/useAgentTargetNavigation.ts 35.29% <35.29%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded — closing per Christian's direction.

Full context for agent readers

Program pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
ryan-di pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Sep 2, 2026
…6340)

## Summary

- Keeps the novel panel-activity gating and agent CSS ownership from
Comfy-Org#16283.
- Keeps target-aware workflow/node references, explicit-click
navigation, and stable node-locator propagation from Comfy-Org#16290.
- Drops inherited slice-stack changes already present on `main`; this PR
is based directly on `origin/main` at `f954e479a37b`.

Gate 10: requires Christian TDD-gate review — touches existing systems.

<details>
<summary>Full context and validation</summary>

## Changes

- **What**: Feature-gated workflow-tab activity watchers; scoped
animation ownership; explicit `{ workflowId, locatorId }` references;
pure target resolver with typed recoverable failures; main-adapted
navigation through the workflow binding/store APIs; selection watcher
gating.
- **Breaking**: None.
- **Dependencies**: None.

## Salvage provenance

- Slice-14 source: Comfy-Org#16283 (`59d19dbae8f06837623edba29595ce2adfcc14ba`;
authored range starts at `445931d16853ca34f4b5bb7f66878405b83031f9`).
- Slice-16 source: Comfy-Org#16290 (`e36ea79acbd0b5c5cb345bc2061c2a40c4af119e`;
base `fb0493305abe3fc21154125aaa05cec2bcf637ac`).
- Salvage base: `f954e479a37b168a9596aa05a1ce1dec1e9a93b4`.
- Main has no reusable GraphDocument registry seam; the slice-16
stand-in comment was removed and the adapter uses the existing workflow
binding/store abstractions.

## Review Focus

Please verify target isolation when duplicate locator IDs exist across
workflows, feature-disable cleanup for tab activity and selection
watchers, and the main-specific gate adaptation through
`agentPanelStore.enabled`.

## Validation

- `pnpm test:unit` on 8 relevant files: 82 passed.
- `pnpm typecheck`: passed.
- `pnpm lint`: passed with 187 existing warnings and zero errors.
- Commit hooks: format, lint, typecheck, and `knip` passed.

No browser E2E was added or run in this salvage lane.

</details>

<!-- authored-by:agent worker-3 -->

---------

Co-authored-by: Pipeline Agent <agent@pipeline.local>
Co-authored-by: benjcooley <benjcooley@gmail.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants