Repository navigation
[slice-16] add target-aware graph references and navigation - #16290
christian-byrne wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1887 passed, 1 failed❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-30T10:30:44.681Z",
"gitSha": "05d5601c3a1bdd47340f50fd6baa2bbdda6ff0b3",
"branch": "christian-byrne/slice-16",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2100.100999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.706999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.439,
"heapDeltaBytes": -11577648,
"heapUsedBytes": 56992256,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.645999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2034.507000000076,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.332,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.353,
"heapDeltaBytes": 14204476,
"heapUsedBytes": 82709752,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.389,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.1890000000526,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.368,
"layouts": 14,
"layoutDurationMs": 4.705,
"taskDurationMs": 916.2459999999999,
"heapDeltaBytes": -8309568,
"heapUsedBytes": 61513772,
"domNodes": -280,
"jsHeapTotalBytes": 7856128,
"scriptDurationMs": 145.293,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.6219999999703,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.580999999999996,
"layouts": 14,
"layoutDurationMs": 5.074999999999999,
"taskDurationMs": 904.9889999999999,
"heapDeltaBytes": 8688928,
"heapUsedBytes": 72034980,
"domNodes": -285,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 150.608,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.0410000000097,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.12,
"layouts": 6,
"layoutDurationMs": 1.1540000000000001,
"taskDurationMs": 362.58000000000004,
"heapDeltaBytes": 4370172,
"heapUsedBytes": 74220828,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.796999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.2039999999251,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.484,
"layouts": 6,
"layoutDurationMs": 1.262,
"taskDurationMs": 396.82900000000006,
"heapDeltaBytes": 4385216,
"heapUsedBytes": 73731648,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.235000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 682.974999999999,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.39,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.33299999999997,
"heapDeltaBytes": 18441252,
"heapUsedBytes": 87929660,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 152.596,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 702.7659999999969,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.875,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.382,
"heapDeltaBytes": 18134340,
"heapUsedBytes": 87720188,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 154.447,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2062.2990000000527,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.124999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.589,
"heapDeltaBytes": -12927032,
"heapUsedBytes": 86950116,
"domNodes": -271,
"jsHeapTotalBytes": -1347584,
"scriptDurationMs": 31.923999999999992,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2050.6820000000516,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.163999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.639,
"heapDeltaBytes": 11340380,
"heapUsedBytes": 87094568,
"domNodes": -273,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 35.475,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2155.892999999992,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.118,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1528.75,
"heapDeltaBytes": 19027304,
"heapUsedBytes": 84258364,
"domNodes": -271,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 745.327,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2228.876000000014,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.888000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1608.2160000000001,
"heapDeltaBytes": 23163620,
"heapUsedBytes": 88813220,
"domNodes": -271,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 759.247,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3545.4310000000078,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.796,
"layouts": 60,
"layoutDurationMs": 12.956,
"taskDurationMs": 1668.044,
"heapDeltaBytes": 9140752,
"heapUsedBytes": 76201912,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 742.774,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3568.4309999999186,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.086000000000002,
"layouts": 60,
"layoutDurationMs": 13.766,
"taskDurationMs": 1753.1919999999998,
"heapDeltaBytes": 8467956,
"heapUsedBytes": 75750060,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 775.9430000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3094.0120000000206,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.6539999999999955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1912.0750000000003,
"heapDeltaBytes": 22021304,
"heapUsedBytes": 88764768,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 928.8839999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3152.0799999999554,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.370000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1992.081,
"heapDeltaBytes": 24098468,
"heapUsedBytes": 91494404,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 986.118,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.265000000018,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.173999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.5230000000001,
"heapDeltaBytes": 21893660,
"heapUsedBytes": 87528560,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.37800000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2025.0050000000783,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.0299999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.7790000000001,
"heapDeltaBytes": -13770508,
"heapUsedBytes": 87010404,
"domNodes": -269,
"jsHeapTotalBytes": -823296,
"scriptDurationMs": 39.128,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.4030000000139,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.464,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.23299999999995,
"heapDeltaBytes": 14355348,
"heapUsedBytes": 86024772,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 138.799,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.8919999999689,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.302000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.192,
"heapDeltaBytes": 13933224,
"heapUsedBytes": 85600392,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.63799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.5579999999663,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.480999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.047,
"heapDeltaBytes": 2116220,
"heapUsedBytes": 74089716,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.701,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2049.9209999999266,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.150999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.85100000000006,
"heapDeltaBytes": -7701056,
"heapUsedBytes": 63906928,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.753,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.65200000003,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.173,
"layouts": 18,
"layoutDurationMs": 4.890000000000001,
"taskDurationMs": 811.714,
"heapDeltaBytes": -12212832,
"heapUsedBytes": 59481060,
"domNodes": -298,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 100.283,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.0200000000013,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.278999999999996,
"layouts": 18,
"layoutDurationMs": 5.666,
"taskDurationMs": 845.609,
"heapDeltaBytes": -13247252,
"heapUsedBytes": 58136684,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 109.25900000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.4640000000327,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.944,
"layouts": 15,
"layoutDurationMs": 15.122,
"taskDurationMs": 1019.002,
"heapDeltaBytes": -9253300,
"heapUsedBytes": 86182812,
"domNodes": 13671,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 30.819000000000006,
"eventListeners": 2381,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8386.789000000022,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.795,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5762.696999999999,
"heapDeltaBytes": -10903168,
"heapUsedBytes": 89389368,
"domNodes": -272,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 2607.2629999999995,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8506.14399999995,
"styleRecalcs": 246,
"styleRecalcDurationMs": 40.36599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5977.294000000001,
"heapDeltaBytes": -11419172,
"heapUsedBytes": 88806224,
"domNodes": -270,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 2615.323,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18094.443999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17485.147,
"heapDeltaBytes": -33157524,
"heapUsedBytes": 176462144,
"domNodes": -6548,
"jsHeapTotalBytes": -3002368,
"scriptDurationMs": 287.125,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18211.417000000096,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17884.691000000003,
"heapDeltaBytes": -39946160,
"heapUsedBytes": 175756200,
"domNodes": -6548,
"jsHeapTotalBytes": 3874816,
"scriptDurationMs": 311.536,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22050.910999999986,
"styleRecalcs": 164,
"styleRecalcDurationMs": 21.833999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21774.505,
"heapDeltaBytes": -25075612,
"heapUsedBytes": 184558236,
"domNodes": -6548,
"jsHeapTotalBytes": -5435392,
"scriptDurationMs": 925.504,
"eventListeners": -7467,
"totalBlockingTimeMs": 234,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22201.21800000004,
"styleRecalcs": 167,
"styleRecalcDurationMs": 21.50599999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21877.076,
"heapDeltaBytes": -21931404,
"heapUsedBytes": 180580908,
"domNodes": -6548,
"jsHeapTotalBytes": 2551808,
"scriptDurationMs": 938.8240000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 188,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6413.603000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.164,
"layouts": 20,
"layoutDurationMs": 24.39300000000001,
"taskDurationMs": 6335.79,
"heapDeltaBytes": -9467004,
"heapUsedBytes": 195350912,
"domNodes": -6552,
"jsHeapTotalBytes": 11677696,
"scriptDurationMs": 118.04599999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 400,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6478.783000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.44100000000005,
"layouts": 20,
"layoutDurationMs": 43.73100000000001,
"taskDurationMs": 6377.023999999999,
"heapDeltaBytes": -28654884,
"heapUsedBytes": 174269524,
"domNodes": -6548,
"jsHeapTotalBytes": 10428416,
"scriptDurationMs": 115.208,
"eventListeners": -7471,
"totalBlockingTimeMs": 588,
"frameDurationMs": 18.33333333333327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 125.56500000005144,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.697,
"layouts": 2,
"layoutDurationMs": 1.348,
"taskDurationMs": 93.177,
"heapDeltaBytes": 3155564,
"heapUsedBytes": 70582872,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.72,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 100.94100000003436,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.066,
"layouts": 2,
"layoutDurationMs": 1.383,
"taskDurationMs": 80.119,
"heapDeltaBytes": 3093588,
"heapUsedBytes": 70337920,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.019000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## christian-byrne/slice-15 #16290 +/- ##
==========================================================
Coverage 83.28% 83.29%
==========================================================
Files 2022 2024 +2
Lines 117037 117101 +64
Branches 33047 32480 -567
==========================================================
+ Hits 97480 97540 +60
- Misses 19204 19208 +4
Partials 353 353
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Superseded — closing per Christian's direction.
Full context for agent readersProgram pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs. |
…6340) ## Summary - Keeps the novel panel-activity gating and agent CSS ownership from Comfy-Org#16283. - Keeps target-aware workflow/node references, explicit-click navigation, and stable node-locator propagation from Comfy-Org#16290. - Drops inherited slice-stack changes already present on `main`; this PR is based directly on `origin/main` at `f954e479a37b`. Gate 10: requires Christian TDD-gate review — touches existing systems. <details> <summary>Full context and validation</summary> ## Changes - **What**: Feature-gated workflow-tab activity watchers; scoped animation ownership; explicit `{ workflowId, locatorId }` references; pure target resolver with typed recoverable failures; main-adapted navigation through the workflow binding/store APIs; selection watcher gating. - **Breaking**: None. - **Dependencies**: None. ## Salvage provenance - Slice-14 source: Comfy-Org#16283 (`59d19dbae8f06837623edba29595ce2adfcc14ba`; authored range starts at `445931d16853ca34f4b5bb7f66878405b83031f9`). - Slice-16 source: Comfy-Org#16290 (`e36ea79acbd0b5c5cb345bc2061c2a40c4af119e`; base `fb0493305abe3fc21154125aaa05cec2bcf637ac`). - Salvage base: `f954e479a37b168a9596aa05a1ce1dec1e9a93b4`. - Main has no reusable GraphDocument registry seam; the slice-16 stand-in comment was removed and the adapter uses the existing workflow binding/store abstractions. ## Review Focus Please verify target isolation when duplicate locator IDs exist across workflows, feature-disable cleanup for tab activity and selection watchers, and the main-specific gate adaptation through `agentPanelStore.enabled`. ## Validation - `pnpm test:unit` on 8 relevant files: 82 passed. - `pnpm typecheck`: passed. - `pnpm lint`: passed with 187 existing warnings and zero errors. - Commit hooks: format, lint, typecheck, and `knip` passed. No browser E2E was added or run in this salvage lane. </details> <!-- authored-by:agent worker-3 --> --------- Co-authored-by: Pipeline Agent <agent@pipeline.local> Co-authored-by: benjcooley <benjcooley@gmail.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
TL;DR
workflowIdplus stablenode_locator_id; never resolves against the active canvas by fallback.AGENT_IN_APP_EXPERIENCE.Full context for agent readers
Contract
This is chain slice 16, stacked on
christian-byrne/slice-15atfb0493305abe3fc21154125aaa05cec2bcf637ac. It introduces a typed target resolver with recoverablemissing_target,closed_target,activation_failed, andmissing_nodeoutcomes.TabLinkCardcarries the stable locator fromagent_active_taband delegates explicit node clicks to the resolver. Plain workflow links retain their existing behavior.Target identity flow:
G1 scorecard
fb0493305abe3fc21154125aaa05cec2bcf637acTabLinkCardrenders no action;useCanvasSelectiondoes not install its selection watcher until enabledSlice-15 integration
useAgentTargetNavigation.tscontains one markedSTAND-IN(slice-15)over the shipped workflow/tab binding store because slice 15 does not yet expose a separate GraphDocument registry. Replace that adapter on rebase when the registry lands; the pure resolver contract and tests remain unchanged.Scope / invariants
No semantic op application, queue, awareness, presence, automatic focus, or slice-17 activation surface is added. Follower behavior and CRDT reset/resync code are unchanged; the complete existing follower suite remains green.
Glossary