Skip to content

slice 15: lifetime adapter (FE-1930) - #16284

Closed
christian-byrne wants to merge 303 commits into
mainfrom
christian-byrne/slice-15
Closed

christian-byrne wants to merge 303 commits into
mainfrom
christian-byrne/slice-15

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor
  • Adds one explicit workflow/tab/document/thread/user/teardown adapter.
  • Prevents cross-target follower state and pre-ack sends.
  • Required type, lint, and unit gates are green.
Full context for agent readers

FE-1930 scope

Implements Slice 15's approved workflow, tab, and lifetime adapter contract. AgentTarget exposes workflowId, tabPath, and graphId explicitly so Slice 16 can navigate to the selected graph before the follower attaches.

Six-lifetime ownership and transitions

Lifetime Source of truth Adapter action
Workflow Stable backend workflow ID Retargets thread and document intent together.
Tab Core workflow store tab path Observes switches; prunes closed bindings; closes only the selected target.
Document Per-workflow follower state Attaches only when target graph equals current graph; unsubscribes before handoff.
Agent thread Agent session Retargets with workflow; aborts and clears on close, sign-out, or flag-off.
Authenticated user Resolved auth subject ID Namespaces persisted bindings; clears the departing subject on sign-out.
Teardown Component and flag lifecycle Stops operational watchers, destroys all follower docs, disposes thread transport once.

Flag-off proof

Surface Flag false behavior
Panel entry Server flag is read fail-closed before agent store/tracker creation.
Watchers Runtime operational target/graph/tab watchers are stopped on true→false; cold false performs no adapter work.
Bindings/storage Active user bindings are reset and the subject is detached; core workflow/tab state is untouched.
Socket/subscriptions The shared app socket remains owned by core; every agent document target is detached/unsubscribed.
Turns/threads Active turn is aborted and thread state is cleared.
Re-enable Operational watchers are recreated and the current explicit target is selected again.

Isolation

LayoutFollowerBridge keeps follower document, sequence, schema, and acknowledgement state per workflow. A→B→A restores A's own state vector; B never inherits it. Human operations remain blocked until doc_subscribed acknowledges the active target. Ordinary retargeting never wipes follower documents or rewrites operation IDs.

Verification

  • pnpm typecheck: passed.
  • pnpm lint: passed; existing repository warnings only.
  • pnpm test:unit: 1,437 files passed; 19,272 tests passed; 7 skipped.
  • Pre-commit additionally passed pnpm typecheck:browser.
  • Slice 15 browser test typechecks and covers five A→B→A races plus close, reload, and sign-out. Local execution was attempted, but the required backend was unavailable: GET http://localhost:8188/api/users ended with a socket hang-up before the test body.

No spec deviations.

Tags send bare node_ids again; they resolve against the full graph the
same POST already uploads (workflow.content) once the server seeds the
draft from it. No client-side stopgap.
Rename the WorkflowUpload fields so the wire contract reads plainly:
content -> graph (the prompt is already the top-level content field), and
base_version -> last_seen_version (the draft version the client last
received; draft_version would have collided with the existing WS event
type of that name).
… action bar

Draft applies now re-baseline the bound tab's change tracker to the canvas
as loaded and clear isModified, on both the in-place and minted-new-tab
paths. A minted tab's stored baseline carries an ensureWorkflowId id the
canvas never adopts, so the first capture flipped isModified and every
following draft_patch raised the conflict dialog with zero user edits.
Manual edits still re-arm the dialog.

The thumbs up/down + copy row under a completed agent message no longer
hides until hover (V0: always display).
Adds the V0 FE metric set through the existing telemetry layer (typed
events, optional provider methods, cloud PostHog provider):

- app:agent_panel_opened / app:agent_panel_closed with source
  (topbar_button | close_button | flag_disabled) and open_duration_ms,
  so open-vs-closed share per session is computable
- app:agent_entry_button_clicked (resulting_state) and
  app:agent_close_button_clicked for the raw clicks
- app:agent_message_sent (attachment_count, node_tag_count),
  app:agent_node_tagged (mention_picker), app:agent_attach_button_clicked
- app:agent_workflow_applied (workflow_id, new_tab | existing_tab) for
  agent-created vs agent-edited workflow attribution
- app:agent_message_feedback now carries workflow_id (PM-98)

The panel store owns open/close state, so it emits the state events with
an idempotency guard (the flag gate re-syncs close on every evaluation).
The entry/close click events are kept alongside the state events
deliberately: the V0 metrics checklist names them as PM-queryable
trackers, though the state events' sources make them derivable.

Also hardens autosaveAppliedDraft: the tracker re-baselines with the RAW
canvas serialization. A schema-validated baseline would diff against raw
captures under strict graphEqual and re-raise the conflict dialog on an
unedited canvas; a test pins validateComfyWorkflow to its single
loadDraft call so the baseline can never route through the schema.
Adds the V0 FE metric set through the existing telemetry layer (typed
events, optional provider methods, cloud PostHog provider):

- app:agent_panel_opened / app:agent_panel_closed with source
  (topbar_button | close_button | flag_disabled) and open_duration_ms,
  so open-vs-closed share per session is computable
- app:agent_entry_button_clicked (resulting_state) and
  app:agent_close_button_clicked for the raw clicks
- app:agent_message_sent (attachment_count, node_tag_count),
  app:agent_node_tagged (mention_picker), app:agent_attach_button_clicked
- app:agent_workflow_applied (workflow_id, new_tab | existing_tab) for
  agent-created vs agent-edited workflow attribution
- app:agent_message_feedback now carries workflow_id (PM-98)

The panel store owns open/close state, so it emits the state events with
an idempotency guard (the flag gate re-syncs close on every evaluation).
…t regressions

- MarkdownStream renders through the shared markdownRendererUtil; the
  agent copy (and its module-load DOMPurify hook that gave every host
  anchor target=_blank) is deleted.
- The agent event source is now a thin adapter over the api singleton's
  typed custom-event dispatch: no second socket follower, no re-parse of
  every /ws frame, no "Unknown message type" throw noise. Zod payload
  validation and the malformed-event notice stay.
- AgentPanelRoot loads via defineAsyncComponent, keeping the flag-gated
  subtree out of the GraphCanvas chunk.
- Prompt-error cards show details only for the agent's own error types;
  host cards restored to pre-PR behavior, both pinned by tests.
- The agent REST client rides api.fetchApi (Firebase init-wait, auth
  headers, 401 remint, Comfy-User) instead of a hand-rolled fetch with
  workspace-token-only auth; zod parsing and AgentApiError stay.
- Agent-local Button/Textarea forks replaced by the shared UI kit with
  variant mappings verified pixel-equivalent through tailwind-merge;
  dialogs inline reka primitives (the shared kit's entrance animations
  and sizing cannot be neutralized). ScrollArea/CollapsibleContent
  wrappers inlined per the sibling idiom.
- WorkflowTabs CTA uses the shared Button.
- agentTheme.css no longer redefines tw-animate-css collapsible
  keyframes (they globally retargeted three sharing-dialog consumers).
- CodeBlock keeps the framed header + copy but renders plain monospace;
  the shiki dependency and catalog entry are removed. MarkdownStream
  tokenizes fences via marked.lexer, fixing the 4-backtick gap.
- Safety UI that nothing drives (ApprovalCard, LockBanner, RevertButton
  and their AgentPanel plumbing); ConflictDialog stays.
- Dead message-part clusters: file/asset rendering and reasoning
  disclosure that no transport path constructs; the parts union and
  AgentMessage grouping shrink to text/tool/notice.
- Unwired composer pieces (AssetTray, SelectionActionChips,
  useCloudAssets) with zero non-test importers.
- Dead exports (createThread, history.upsert, useAgentFeatureGate fn,
  hasDraft, onboarding multi-step machinery) - each re-verified for
  zero production consumers on the current head; parseAgentWsEvent /
  isAgentEvent kept, they are live imports since the event rework.
- Write-only token pipeline, info/warning notice machinery, and the
  transport's no-op finalize loop removed; finalize/abort merged into
  one settle().
- 17 locale keys with zero usages removed from en (other locales are
  lobe-i18n generated and never carried them); error-catalog and
  design-locked keys kept.
- useAttachment strings go through i18n; the 20MB label derives from
  the named constant (max_upload_size flag exists but has no production
  consumer, so the constant stays).
- A failed thread-list fetch now raises the shared error modal instead
  of silently showing empty history, with a regression test.
The trim deleted the collapsible keyframes as duplicates of
tw-animate-css, but that package defines no collapsible-* keys, so the
tool-disclosure animation silently no-opd. Restored under agent-*
names: the globally-imported sheet can no longer retarget the host's
animate-collapsible-* utilities (undefined on main) in sharing dialogs.
Adds the three review-flagged test gaps: indented code stays prose,
bare fences label as text, and the oversize-attachment message pins
its i18n interpolation.
- ToolCallGroup: streaming auto-open, same-name merge, failure reopen,
  and the AgentMessage adjacent-merge branch with pluralized header.
- WorkflowTabs: the Ask Comfy Agent CTA renders when enabled and
  toggles the panel (mock rewired ref-backed for storeToRefs).
- useAgentSession: non-object and foreign host frames drop silently
  mid-turn.
- MarkdownStream: fence label picks the first info-string word.
The client hardcoded person_profiles: 'identified_only' AFTER the
posthog_config spread, silently overriding the server's explicit
'always' (live on /api/features). Under identified_only every event
captured before identify() resolves is a person-less anonymous event
that never attaches to the user, so early-session events (entry click,
panel opened, first message) vanish from person-scoped PostHog views.
The hardcode is now a default the server can override; before_send
stays locked (PII stripping). Reverses the person_profiles half of the
pin added in #12479, test updated accordingly.

Also retries the posthog-js dynamic import once: a stale deploy can
404 the chunk, which previously disabled telemetry for the entire
session after a single console.error.
The module map caches a failed module resolution, so re-importing the
same specifier rejects from cache without refetching; the retry could
never succeed. Stale-chunk failures are already handled app-wide by the
vite:preloadError listener in App.vue.
The 2MB cap guarded a server limit that does not exist yet and silently
skipped uploads for large graphs, which are normal on a video/image
platform. The server owns its own limits.
The backend now seeds the thread's draft from the graph the client
sends each turn. Align to its shape and rules:
- The turn POST carries draft: { content: <serialize() save format>,
  version: <last seen draft version | null> } (was the inert
  workflow/graph/last_seen_version shape).
- Snapshots gate on canvas-non-empty, not workflow_id, so templates,
  unsaved tabs, and new tabs seed correctly; skipping an unchanged
  canvas stays as the server-blessed optimization.
- A 409 {error, version} means the agent's draft advanced: adopt the
  returned version and retry the send once.
- autosaveAppliedDraft only reset the change tracker and isModified,
  but the tab dot renders whenever a workflow is not persisted, so
  agent-applied drafts always showed unsaved and lived only in memory
- save through workflowService instead: temporary tabs use a silent
  saveWorkflowAs with a collision-safe filename (no prompt or
  overwrite dialog), persisted tabs re-save silently
- rebind workflow_id to the tab current path in finally so service
  renames (collision bump, app extension mismatch) and failed saves
  never strand the binding on a dead path
- known limit: host saveWorkflow drift handling can rarely toast or
  confirm on persisted tabs; reusing the canonical save path there
  is intentional
- tests: failure isolation keeps the applied draft and surfaces no
  error, an app-mode collision bumps the filename and rebinds, a
  save that fails after rename still rebinds; binding tests now
  stub a valid empty threads page
Per the per-file consolidation audit (temp/plans/pr13472-file-consolidation-audit.md):
safetyTypes -> ConflictDialog (SFC type export, ActiveTabStrip pattern),
agentTranscript + useDraftCanvasApply -> AgentPanelRoot, ThinkingStatus ->
AgentMessage, SuggestedPromptChip -> EmptyState, SelectionTagChip -> Composer,
SessionBar -> AgentPanel. All moves byte-identical; net -9 files.

agentTranscript's test is replaced by a stronger end-to-end copy test
asserting the exact clipboard markdown. useDraftCanvasApply's tests were
retired as redundant rather than merged: patch-to-canvas firing is covered
end-to-end by the draft binding suite, rejection semantics are owned by
agentDraftStore.test.ts, and the stop handle was unused API removed by the
fold.
…JECT_TOKEN

Deployed builds keep reading the token from the backend-injected __CONFIG__
(precedence unchanged); the env fallback only enables event verification from
local dev servers, which otherwise have no key and silently queue forever.
- loadThread and newChat fired a server-side cancel for the in-flight
  turn; the backend recorded it and the reply was lost ("Stopped
  streaming..."). Panel unmount did the same. All implicit cancels are
  removed; the explicit Stop button is the only cancel left
- switching away parks the live turn (message + event transport) in a
  per-thread registry; events keep accumulating silently and cannot
  bleed into the displayed chat; switching back re-attaches the turn
  live with no lost text, or renders the finished reply from history
- a done landing during the return fetch keeps the parked entry so the
  full reply still renders; overlapping or double-clicked history loads
  are generation-gated; socket death and panel close settle parked
  turns; remount refreshes a surviving thread from history
- draft patches from a backgrounded thread no longer drive the
  displayed canvas (thread guard; version heartbeat unchanged)
- transport ignores events after settle; chat history date buckets
  follow a reactive clock across midnight; onboarding coach gains
  dialog semantics and Escape to dismiss; dead approval-flow fixtures
  removed
Move the cascading rules (keyframes, .agent-shimmer-text, scoped reset)
from globally imported agentTheme.css into agentPanel.css, loaded only
by the lazy AgentPanelRoot chunk; agentTheme.css keeps the @theme blocks.
Handle agent_active_tab (activate the bound tab or mint, open, and
autosave a named temporary tab; concurrent focus events serialize
latest-wins), send the open_tabs and current_tab snapshot with each
message, persist workflow-tab bindings, and resolve every open saved
tab to its Cloud Ingest workflow id (paginated name index refreshed per
send, binding fallback, never guesses on ambiguity). Reverse resolution
activates existing tabs on switch_tab. Bound tabs send their bound id,
unbound tabs adopt via the draft upload - no speculative ids. Draft
uploads that 5xx degrade to plain chat and re-arm. Friendly labels for
the tab and memory tools.
Extract the docked panel chrome (width container, resize handle, async
panel root card) from the splitter overlay and GraphCanvas into
DockedAgentPanel, and host it in both GraphCanvas and LinearView. Gate
the graph-mode host on !linearMode so exactly one live panel root
exists across mode switches; the splitter overlay is agent-agnostic
again.

FE-1298
Distinguishes the feedback affordance from agent chat next to the Ask
Comfy Agent entry, on both the integrated tab bar and the legacy
topbar button.

FE-1283
Swap the back arrow to a left chevron and rename the tooltip key to
backToPreviousChat per the dev-ready design.

FE-1291
Persist the open state in localStorage and stop the PostHog flag gate
from force-closing on sync, so a slow or transient flag read cannot
wipe the stored preference. A rehydrated panel emits an opened event
with source restored only once it actually docks, so flag-off users
with stale state never produce phantom opens; the now-unused
flag_disabled close source is dropped.

FE-1284
Take the horizontal edge from the graph splitter panel so toasts no
longer sit behind the docked agent panel, while the vertical offset
keeps reading the canvas container so nothing shifts for flag-off
users. Re-anchor on panel open and resize and on every toast shown,
and skip hidden zero-size anchors so app mode keeps the last good
position instead of pushing toasts off screen.

FE-1287
Add a once-per-browser dismissible banner above the composer telling
users the agent modifies the graph but only they can run it, and
replace the caption under the composer with the AI-mistakes
disclaimer, both with the design's exact copy. No auto-mode state is
introduced; running from chat remains a separate open decision.

FE-1307
The empty-state chip row spanned the full panel width and overflowed
the 640px content column on a maximized panel; constrain it to the
same column as the composer.

FE-1288
christian-byrne and others added 20 commits August 29, 2026 18:41
Collapse duplicate agent entry points and panel mounts, reconcile stale test expectations, and remove lint failures exposed by the integrated branch.
PR #16205 intentionally enabled autoplay and looping but left the click-to-play unit assertion unchanged.
Fixes QA rows **T-06** (Fit View corrupts the viewport transform) and
**X-01** (Maximize panel throws) — one root cause, two symptoms. Triage:
`reports/qa/pm630-fail-triage-5956524.md` (in-app-agent workspace),
reproduced live against dev1 @`5956524`.

1. **Two modules called `defineStore('agentPanel')`.** Pinia keys stores
by id, so the first setup to run won and every later
`useAgentPanelStore()` got that instance regardless of which module it
imported. The dock mount imported the gate-only one and runs first, so
the panel resolved a store with no `width` and no `toggleMaximize`.
2. **Fix:** point `useAgentDockMount` at `stores/agent/agentPanelStore`
and delete the gate-only module (plus the unreachable duplicate
`AgentPanelRoot.vue` that was its only other consumer). Its
`writeDefaults: false` behaviour moves onto the surviving store so no
storage key is planted for flag-off users.
3. **Regression pin:** `agentPanelStoreId.test.ts` instantiates through
the dock mount first to reproduce the losing registration order. All
three cases fail against the pre-fix tree (verified), including the
`NaN` viewport that is T-06 itself.

Do not merge on my account — operator merges after review.

<details>
<summary>Full context</summary>

| module | shape |
|---|---|
| `src/workbench/extensions/agent/stores/agentPanelStore.ts` (deleted) |
`{enabled, isOpen, gateSettled, close, toggle}` |
| `src/workbench/extensions/agent/stores/agent/agentPanelStore.ts`
(kept) | `{enabled, isOpen, gateSettled, width, isMaximized,
dismissedSelectionSignature, toggle, close, setWidth, toggleMaximize}` |

Measured in-page on dev1:

```
pinia.state.value.agentPanel keys = ["enabled","isOpen","gateSettled"]
agentPanel.width = undefined
```

**T-06.** The Fit View button dispatches `Comfy.Canvas.FitView` →
`fitViewToSelectionAnimated({viewport:
visibleCanvasViewport(app.canvas)})`. `visibleCanvasViewport` computes
`Math.max(width - panel.width, 0)`; with `panel.width` undefined that is
`Math.max(1600 - undefined, 0)` = `NaN`. One click:

| | before Fit View | after Fit View |
|---|---|---|
| `canvas.ds.scale` | `0.9` | `NaN` |
| `canvas.ds.offset` | `[416, 110]` | `[NaN, NaN]` |
| rightmost node edge | 1796.4 px | 1796.4 px (unmoved) |

Fit View is a silent no-op that also poisons the viewport transform —
which is why the register run left 8 of 10 nodes under the panel and why
later screenshots show the zoom readout as `NaN%`. The panel-aware path
itself is correct; it was being fed `undefined`.

**X-01.** `AgentPanelRoot.vue` emits
`@toggle-size="agentPanelStore.toggleMaximize()"`. The gate-only store
has no such function:

```
pageerror TypeError: $setup.agentPanelStore.toggleMaximize is not a function
```

Width does not change (820.94 px → 820.94 px in repro).

Renaming the gate-only store's id to something like `agentPanelGate` was
the smaller mechanical diff, but it is wrong:
`extensions/core/agentPanel.ts` writes `enabled` and `gateSettled` on
the *panel* store, while `useAgentDockMount` reads them to decide
whether to dock. Splitting the ids would put the writer and the reader
on two different instances and the panel would never dock at all. The
shapes had to collapse onto the panel store, which is what the triage
recommended.

- `composables/useAgentDockMount.ts` — import repointed to
`stores/agent/agentPanelStore`.
- `stores/agentPanelStore.ts` + its test — deleted.
- `components/agent/AgentPanelRoot.vue` + its test — deleted. This was a
34-line stub duplicating the name of the real 983-line
`AgentPanelRoot.vue`; nothing imported it (`DockedAgentPanel.vue`
async-loads the real one), and it was the gate-only store's only other
consumer. Two components with the same name is the same ambiguity that
produced this bug.
- `stores/agent/agentPanelStore.ts` — added `writeDefaults: false` to
the `useLocalStorage` call, carried over from the deleted module so a
flag-off session still plants no `Comfy.AgentPanel.open` key. Its guard
test came across too.
- `extensions/core/agentPanelGateDependencyFailure.test.ts` — dropped
the now-dead second `vi.mock` of the deleted path (it already mocked
both paths onto the same object, so behaviour is unchanged).
- `stores/agent/agentPanelStoreId.test.ts` — new regression pin.

- Full unit suite: **1436 files / 19217 passed, 7 skipped**.
- `npm run typecheck`: clean.
- `oxfmt --check`, `oxlint`, `eslint` on changed files: clean. `knip`
pre-push: clean.
- Pre-fix verification: restored the deleted module and the old import,
ran `agentPanelStoreId.test.ts` → **3/3 failed**, including `expected
false to be true` on the finite-viewport assertion (the T-06 `NaN`).
Restored the fix afterwards.

Not covered here: T-18 and X-03 from the same triage are harness state
leaks, tracked separately.
</details>

---------
Resolve the rebase's ADR number collision in favor of newer main: main retains ADR 0016 and the older agent follower ADR moves to 0025. Align the browser contract with the newer trailing tool-group behavior, and keep the hover-only message actions in the hit-test tree.
| snapshot | status | changed pixels |
| --- | --- | --- |
| `tests/canvasSettings.spec.ts-snapshots/canvas-info-hud-off-chromium-linux.png` | modified | 2507B -> 2474B |
| `tests/canvasSettings.spec.ts-snapshots/canvas-info-hud-on-chromium-linux.png` | modified | 4407B -> 4405B |
| `tests/collapsedNodeLinks.spec.ts-snapshots/subgraph-entry-collapsed-node-links-chromium-linux.png` | modified | 76301B -> 75178B |
| `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-2xl-chromium-linux.png` | modified | 54930B -> 54375B |
| `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-lg-chromium-linux.png` | modified | 53243B -> 52752B |
| `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-md-chromium-linux.png` | modified | 41022B -> 40525B |
| `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-mobile-chromium-linux.png` | modified | 33878B -> 33746B |
| `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-sm-chromium-linux.png` | modified | 39280B -> 38945B |
| `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-wide-chromium-linux.png` | modified | 57830B -> 57327B |
| `tests/dialogs/publishDialog.spec.ts-snapshots/publish-dialog-xl-chromium-linux.png` | modified | 52656B -> 52259B |
| `tests/execution.spec.ts-snapshots/execution-error-unconnected-slot-chromium-linux.png` | modified | 103275B -> 102679B |
| `tests/groupColorPicker.spec.ts-snapshots/group-color-right-click-matches-toolbar-swatch-chromium-linux.png` | modified | 64708B -> 63801B |
| `tests/groupTitleContrast.spec.ts-snapshots/group-title-contrast-black-chromium-linux.png` | modified | 38007B -> 36684B |
| `tests/imageCompare.spec.ts-snapshots/image-compare-default-50-chromium-linux.png` | modified | 12186B -> 11902B |
| `tests/imageCompare.spec.ts-snapshots/image-compare-slider-25-chromium-linux.png` | modified | 12652B -> 12408B |
| `tests/imageCompare.spec.ts-snapshots/image-compare-slider-75-chromium-linux.png` | modified | 12773B -> 12528B |
| `tests/load3d/load3d.spec.ts-snapshots/load3d-empty-node-chromium-linux.png` | modified | 45211B -> 44640B |
| `tests/maskEditor.spec.ts-snapshots/mask-editor-dialog-from-context-menu-chromium-linux.png` | modified | 333102B -> 333535B |
| `tests/mobileBaseline.spec.ts-snapshots/mobile-default-workflow-mobile-chrome-linux.png` | modified | 31392B -> 30982B |
| `tests/mobileBaseline.spec.ts-snapshots/mobile-empty-canvas-mobile-chrome-linux.png` | modified | 19071B -> 18555B |
| `tests/mobileBaseline.spec.ts-snapshots/mobile-graph-canvas-toolbar-mobile-chrome-linux.png` | modified | 33748B -> 33309B |
| `tests/mobileBaseline.spec.ts-snapshots/mobile-settings-dialog-mobile-chrome-linux.png` | modified | 21161B -> 21190B |
| `tests/nodeBadge.spec.ts-snapshots/node-badge-unknown-color-palette-chromium-linux.png` | modified | 102038B -> 101241B |
| `tests/painter.spec.ts-snapshots/painter-after-resize-chromium-linux.png` | modified | 27588B -> 27323B |
| `tests/painter.spec.ts-snapshots/painter-after-stroke-chromium-linux.png` | modified | 23975B -> 23709B |
| `tests/painter.spec.ts-snapshots/painter-default-state-chromium-linux.png` | modified | 22974B -> 22699B |
| `tests/propertiesPanel/infoTab.spec.ts-snapshots/info-tab-dynamic-combo-advanced-input-chromium-linux.png` | modified | 11711B -> 11790B |
| `tests/saveImageAndWebp.spec.ts-snapshots/save-image-and-webm-preview-chromium-linux.png` | modified | 95882B -> 95185B |
| `tests/viewport.spec.ts-snapshots/viewport-fits-when-saved-offscreen-chromium-linux.png` | modified | 104511B -> 103614B |
| `tests/vueNodes/groups/groups.spec.ts-snapshots/vue-groups-fit-to-contents-chromium-linux.png` | modified | 54981B -> 54461B |
| `tests/vueNodes/interactions/canvas/pan.spec.ts-snapshots/vue-nodes-paned-with-touch-mobile-chrome-linux.png` | modified | 26726B -> 26264B |
| `tests/vueNodes/interactions/canvas/zoom.spec.ts-snapshots/zoomed-in-ctrl-shift-chromium-linux.png` | modified | 30338B -> 29560B |
| `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-dragging-link-chromium-linux.png` | modified | 61912B -> 60832B |
| `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-ctrl-alt-chromium-linux.png` | modified | 61969B -> 60969B |
| `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-input-drag-reuses-origin-chromium-linux.png` | modified | 61428B -> 60409B |
| `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-input-drag-chromium-linux.png` | modified | 63840B -> 62831B |
| `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-reroute-output-shift-drag-chromium-linux.png` | modified | 63561B -> 62438B |
| `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-shift-output-multi-link-chromium-linux.png` | modified | 62821B -> 61615B |
| `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-node-chromium-linux.png` | modified | 60319B -> 59244B |
| `tests/vueNodes/interactions/links/linkInteraction.spec.ts-snapshots/vue-node-snap-to-slot-chromium-linux.png` | modified | 59629B -> 58638B |
| `tests/vueNodes/interactions/node/imagePreview.spec.ts-snapshots/vue-node-multiple-promoted-previews-chromium-linux.png` | modified | 91897B -> 91012B |
| `tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png` | modified | 104336B -> 103606B |
| `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-color-blue-chromium-linux.png` | modified | 105666B -> 104899B |
| `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-dark-all-colors-chromium-linux.png` | modified | 137901B -> 137427B |
| `tests/vueNodes/nodeStates/colors.spec.ts-snapshots/vue-node-custom-colors-light-all-colors-chromium-linux.png` | modified | 145842B -> 139597B |
| `tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png` | modified | 104137B -> 103422B |
| `tests/vueNodes/rerouteNodeSize.spec.ts-snapshots/vue-reroute-node-compact-chromium-linux.png` | modified | 53036B -> 52024B |
| `tests/vueNodes/widgets/text/lockedWidgetHoverColor.spec.ts-snapshots/editable-widget-hover-color-chromium-linux.png` | modified | 6128B -> 6067B |

Screenshot capture is not bit-deterministic; small pixel
deltas are usually text rasterization noise. Confirm each
rewrite corresponds to a test expected to change.
@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 56902e7c-60ec-4281-bb26-2c6b4eb925c6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/30/2026, 09:21:20 AM UTC

Links

🎭 Playwright: ❌ 1885 passed, 2 failed

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1864 / ❌ 2 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 132ms TBT · 94.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.3 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 45ms TBT · 179.4 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 468ms TBT · 171.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 534ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.6 MB
canvas-idle: DOM nodes -283
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 37ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 916ms
canvas-mouse-sweep: script duration 158ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.3 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -154
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 360ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.5 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 452ms
dom-widget-clipping: script duration 161ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.7 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 648ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.4 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -169
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1622ms
large-graph-pan: script duration 794ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.5 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -89
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1710ms
large-graph-zoom: script duration 766ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.7 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1923ms
legacy-node-drag: script duration 933ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.1 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 620ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.1 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 410ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.4 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 478ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.4 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 830ms
subgraph-mouse-sweep: script duration 108ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 56.5 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 913ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 132ms
subgraph-transition-enter: heap used 94.6 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5871ms
viewport-pan-sweep: script duration 2679ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.0 MB
viewport-pan-sweep: DOM nodes -256
viewport-pan-sweep: event listeners -168
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16831ms
vue-large-graph-idle: script duration 296ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.3 MB
vue-large-graph-idle: DOM nodes -6552
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 170
vue-large-graph-pan: task duration 20403ms
vue-large-graph-pan: script duration 882ms
vue-large-graph-pan: TBT 45ms
vue-large-graph-pan: heap used 179.4 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6058ms
vue-node-resize-workload: script duration 110ms
vue-node-resize-workload: TBT 468ms
vue-node-resize-workload: heap used 171.9 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 96ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.0 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-08-30T09:33:31.392Z",
  "gitSha": "3fd2c5718584a3f4297a6d908a7876bee1b4c851",
  "branch": "christian-byrne/slice-15",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2038.5119999999688,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.011000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 576.659,
      "heapDeltaBytes": 6825340,
      "heapUsedBytes": 70162372,
      "domNodes": -286,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 13.711999999999998,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.8599999999706,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.363000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.622,
      "heapDeltaBytes": -12210824,
      "heapUsedBytes": 56934680,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.5729999999999995,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1968.01099999999,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 39.745,
      "layouts": 14,
      "layoutDurationMs": 4.256,
      "taskDurationMs": 949.606,
      "heapDeltaBytes": -8395408,
      "heapUsedBytes": 61158920,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 160.439,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1839.01800000001,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.21,
      "layouts": 14,
      "layoutDurationMs": 3.908,
      "taskDurationMs": 882.549,
      "heapDeltaBytes": -8484412,
      "heapUsedBytes": 61133688,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 155.695,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1664.6240000000034,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 16.619,
      "layouts": 6,
      "layoutDurationMs": 1.0309999999999997,
      "taskDurationMs": 352.67099999999994,
      "heapDeltaBytes": 4365100,
      "heapUsedBytes": 73722864,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.56,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.6780000000736,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.591,
      "layouts": 6,
      "layoutDurationMs": 1.1570000000000003,
      "taskDurationMs": 368.12999999999994,
      "heapDeltaBytes": 4453700,
      "heapUsedBytes": 74028392,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.15,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 625.7490000000416,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.74,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.496,
      "heapDeltaBytes": 18776456,
      "heapUsedBytes": 87521252,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 159.971,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 675.0490000000582,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.334999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.13100000000003,
      "heapDeltaBytes": 18535780,
      "heapUsedBytes": 87940384,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 161.637,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.873999999998,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.776,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 596.208,
      "heapDeltaBytes": -13002824,
      "heapUsedBytes": 86850004,
      "domNodes": -268,
      "jsHeapTotalBytes": -1085440,
      "scriptDurationMs": 30.841999999999995,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999975,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2059.44199999999,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.827000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 700.7800000000001,
      "heapDeltaBytes": 10856256,
      "heapUsedBytes": 85865088,
      "domNodes": -270,
      "jsHeapTotalBytes": -860160,
      "scriptDurationMs": 41.761,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2286.7449999999963,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.029999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1644.0800000000002,
      "heapDeltaBytes": 8395448,
      "heapUsedBytes": 84614216,
      "domNodes": -272,
      "jsHeapTotalBytes": -634880,
      "scriptDurationMs": 800.0360000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2229.7709999999142,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.272000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1599.725,
      "heapDeltaBytes": 22594144,
      "heapUsedBytes": 88388892,
      "domNodes": -276,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 787.52,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3457.132999999999,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.130999999999997,
      "layouts": 60,
      "layoutDurationMs": 11.313000000000002,
      "taskDurationMs": 1634.332,
      "heapDeltaBytes": 8184204,
      "heapUsedBytes": 75425884,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 749.414,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3784.8410000000285,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.478000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.540000000000003,
      "taskDurationMs": 1786.3120000000001,
      "heapDeltaBytes": 8016456,
      "heapUsedBytes": 74958188,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 783.329,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3059.568000000013,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.895999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1909.9959999999999,
      "heapDeltaBytes": 18193572,
      "heapUsedBytes": 84665612,
      "domNodes": -283,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 935.6940000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3098.622999999975,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.783000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1936.483,
      "heapDeltaBytes": 17859132,
      "heapUsedBytes": 85375380,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 930.085,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.383000000029,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.6049999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.038,
      "heapDeltaBytes": -14874168,
      "heapUsedBytes": 87063464,
      "domNodes": -275,
      "jsHeapTotalBytes": -823296,
      "scriptDurationMs": 34.285999999999994,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2044.2879999999377,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.8950000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.062,
      "heapDeltaBytes": -14786476,
      "heapUsedBytes": 87218528,
      "domNodes": -269,
      "jsHeapTotalBytes": -1347584,
      "scriptDurationMs": 37.441,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 571.2190000000419,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.631000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.17,
      "heapDeltaBytes": 14720760,
      "heapUsedBytes": 86349140,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 140.01,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.8200000000606,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.447999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.49199999999996,
      "heapDeltaBytes": 14536720,
      "heapUsedBytes": 86420376,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 143.965,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.933999999993,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.715999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.468,
      "heapDeltaBytes": -9463292,
      "heapUsedBytes": 61864292,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.168000000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.6919999999773,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.338,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.304,
      "heapDeltaBytes": -12826412,
      "heapUsedBytes": 58506872,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.665999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1732.3059999999941,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 34.63,
      "layouts": 18,
      "layoutDurationMs": 4.2989999999999995,
      "taskDurationMs": 800.164,
      "heapDeltaBytes": -11696520,
      "heapUsedBytes": 59777656,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 104.602,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1789.8979999999938,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 41.86,
      "layouts": 18,
      "layoutDurationMs": 6.312999999999999,
      "taskDurationMs": 860.1189999999999,
      "heapDeltaBytes": -12838084,
      "heapUsedBytes": 58627180,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 110.78,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.4860000000008,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.986,
      "layouts": 14,
      "layoutDurationMs": 15.497,
      "taskDurationMs": 912.8729999999998,
      "heapDeltaBytes": 2010764,
      "heapUsedBytes": 99224432,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.185999999999996,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8303.10899999995,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 33.064,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5641.6849999999995,
      "heapDeltaBytes": 13114936,
      "heapUsedBytes": 88826040,
      "domNodes": -269,
      "jsHeapTotalBytes": -110592,
      "scriptDurationMs": 2589.707,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9113.009000000035,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.87799999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6100.977000000001,
      "heapDeltaBytes": -8799172,
      "heapUsedBytes": 85282148,
      "domNodes": -242,
      "jsHeapTotalBytes": 4612096,
      "scriptDurationMs": 2767.77,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17309.099000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16754.948,
      "heapDeltaBytes": -37467504,
      "heapUsedBytes": 175495372,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8830976,
      "scriptDurationMs": 275.025,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17689.62900000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16906.194,
      "heapDeltaBytes": -29494468,
      "heapUsedBytes": 179641376,
      "domNodes": -6556,
      "jsHeapTotalBytes": 1658880,
      "scriptDurationMs": 317.303,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20956.749000000003,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 18.02999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20593.566,
      "heapDeltaBytes": -21547696,
      "heapUsedBytes": 186129020,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2129920,
      "scriptDurationMs": 890.535,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 61,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20662.837999999967,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 16.67200000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20212.445,
      "heapDeltaBytes": -13682068,
      "heapUsedBytes": 190139304,
      "domNodes": -6548,
      "jsHeapTotalBytes": -12288,
      "scriptDurationMs": 873.1099999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 29,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6310.3419999999915,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.83799999999997,
      "layouts": 20,
      "layoutDurationMs": 24.42899999999999,
      "taskDurationMs": 6179.104999999999,
      "heapDeltaBytes": -33137840,
      "heapUsedBytes": 180124020,
      "domNodes": -6548,
      "jsHeapTotalBytes": 8900608,
      "scriptDurationMs": 114.57600000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 505,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6052.819999999997,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.80399999999999,
      "layouts": 20,
      "layoutDurationMs": 22.339000000000013,
      "taskDurationMs": 5936.677000000001,
      "heapDeltaBytes": -28477940,
      "heapUsedBytes": 180412108,
      "domNodes": -6548,
      "jsHeapTotalBytes": 7688192,
      "scriptDurationMs": 104.913,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 431,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 109.26200000005792,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.566000000000003,
      "layouts": 2,
      "layoutDurationMs": 0.7949999999999999,
      "taskDurationMs": 76.57700000000001,
      "heapDeltaBytes": 3155312,
      "heapUsedBytes": 70667752,
      "domNodes": 110,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.240999999999999,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 482.75599999999486,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 20.993000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.3849999999999998,
      "taskDurationMs": 114.86099999999999,
      "heapDeltaBytes": 5190488,
      "heapUsedBytes": 72019752,
      "domNodes": 142,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.876,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 30, 2026
@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.10744% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 80.00% 7 Missing ⚠️
@@                             Coverage Diff                              @@
##           christian-byrne/integration-candidate-v2   #16284      +/-   ##
============================================================================
+ Coverage                                     81.25%   83.28%   +2.03%     
============================================================================
  Files                                          2402     2022     -380     
  Lines                                        123372   117037    -6335     
  Branches                                      33894    33047     -847     
============================================================================
- Hits                                         100246    97480    -2766     
+ Misses                                        22527    19204    -3323     
+ Partials                                        599      353     -246     
Flag Coverage Δ
e2e 66.64% <73.68%> (-0.02%) ⬇️
unit 76.49% <97.10%> (+0.03%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/useFeatureFlags.ts 88.07% <100.00%> (+0.11%) ⬆️
src/extensions/core/agentPanel.ts 100.00% <100.00%> (ø)
...ons/agent/composables/agent/useAgentFeatureGate.ts 100.00% <100.00%> (ø)
...agent/composables/agent/useAgentLifetimeAdapter.ts 100.00% <100.00%> (ø)
...ensions/agent/composables/agent/useAgentSession.ts 96.24% <100.00%> (+0.05%) ⬆️
...ench/extensions/agent/crdt/layoutFollowerBridge.ts 97.69% <100.00%> (+4.69%) ⬆️
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 95.51% <100.00%> (+1.04%) ⬆️
...agent/stores/agent/agentWorkflowTabBindingStore.ts 100.00% <100.00%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 92.67% <80.00%> (-1.08%) ⬇️

... and 386 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

akumaburn pushed a commit to akumaburn/ComfyUI_frontend that referenced this pull request Aug 30, 2026
…resolves (Comfy-Org#14965)

## Summary

Part of FE-1540 / PAY-004. Six Pylon tickets (Comfy-Org#16322, Comfy-Org#16286, Comfy-Org#16285,
Comfy-Org#16284, Comfy-Org#16280, Comfy-Org#16274), one customer threatening a formal payment
dispute.

`canRunWorkflows` is `false` from the very first render —
`isInitialized` starts `false`, `subscription` is `null`, and
`canAccessSubscriptionFeatures` is `statusData.value?.is_active ??
false` (`useWorkspaceBilling.ts:127-129`). Neither
`CloudRunButtonWrapper.vue` nor `LinearControls.vue` read
`isInitialized`, `isLoading`, or `error`, so **the locked "Subscribe to
run" button was the default render**, asserted on no data at all.

A paying subscriber whose status fetch is slow, failing, or scoped to
the wrong workspace saw a paywall over Run, with no recovery path —
`CloudRunButtonWrapper`'s focus refetch is gated behind
`refreshBillingOnFocus`, which is only set inside the payment-recovery
dialog, so it never fires for a plain status desync.

Worth stating because it contradicts an assumption made during triage:
`canAccessSubscriptionFeatures` does not mean "this user has a paid
subscription", it means "the last status response said `is_active:
true`". Those differ during a desync, which is the incident.

## Change

Adds `showsSubscribeToRunPrompt` to the billing context — it only claims
the user needs to subscribe once billing status has resolved:

```ts
const showsSubscribeToRunPrompt = computed(
  () => isInitialized.value && !canRunWorkflows.value
)
```

Consumed at the three render sites (`CloudRunButtonWrapper.vue:3`,
`LinearControls.vue:182,246`) instead of each re-deriving the rule.

During the unresolved window the normal Run button renders. Entitlement
is still enforced by the backend on execution, and
`useAccountPreconditionDialog` already handles that rejection, so
failing open for that window is the safer direction — a subscriber who
cannot run is a dispute, a non-subscriber who clicks Run gets a clear
server-driven prompt.

## Scope

Deliberately the low-risk half of FE-1540. **Not** included, because
they change Run-button behaviour for all cloud users and want a human
call during an active incident:

- an unsolicited focus/visibility refetch on the Run path (what Robin
asked for in-thread)
- hardening `useWorkspaceBilling.ts:244` so a successful-but-stale
response cannot silently downgrade a previously-active subscription

Also not addressed here: `getBillingStatus()` sends no workspace
parameter (`workspaceApi.ts:430-441`), so a subscription on a team
workspace while Personal is active reads the wrong billing entirely.
Tracked on FE-1540.

## Tests

New case `keeps the run button while billing status is still resolving`,
verified red against the old gate:

```
× keeps the run button while billing status is still resolving
  Tests  1 failed | 11 passed (12)
```

275 tests pass across the 19 affected suites. `pnpm typecheck` exit 0,
`pnpm knip` exit 0.

- Part of FE-1540

Co-authored-by: Connor Byrne <c.byrne@comfy.org>
Base automatically changed from christian-byrne/integration-candidate-v2 to main August 30, 2026 21:43
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded — closing per Christian's direction.

Full context for agent readers

Program pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants