Repository navigation
[slice-14] gate panel activity effects and animation ownership - #16283
christian-byrne wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1885 passed, 1 failed · 1 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-30T10:07:11.586Z",
"gitSha": "95279205004d27cdbb72287408fd5342e58e0f80",
"branch": "christian-byrne/slice-14",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2088.3719999999926,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.684999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.841,
"heapDeltaBytes": 12353396,
"heapUsedBytes": 81000248,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.9590000000000005,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2038.1340000000137,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.388,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.281,
"heapDeltaBytes": 12252216,
"heapUsedBytes": 80846560,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.648000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.3029999999922,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.8,
"layouts": 14,
"layoutDurationMs": 4.035,
"taskDurationMs": 846.511,
"heapDeltaBytes": -9309484,
"heapUsedBytes": 60169336,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 150.524,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.4870000000392,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.37899999999999,
"layouts": 14,
"layoutDurationMs": 3.9939999999999993,
"taskDurationMs": 849.576,
"heapDeltaBytes": 2323164,
"heapUsedBytes": 71999592,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 151.46099999999998,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1678.147000000024,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.262,
"layouts": 6,
"layoutDurationMs": 1.0320000000000003,
"taskDurationMs": 337.884,
"heapDeltaBytes": 4480012,
"heapUsedBytes": 73835168,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.492,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.2000000000335,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.349999999999998,
"layouts": 6,
"layoutDurationMs": 1.284,
"taskDurationMs": 340.791,
"heapDeltaBytes": 4406240,
"heapUsedBytes": 74210484,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 9.953999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 665.9630000000334,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.366999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.531,
"heapDeltaBytes": 18823636,
"heapUsedBytes": 87943404,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 170.852,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 630.800000000022,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.403,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.249,
"heapDeltaBytes": 18419708,
"heapUsedBytes": 87629484,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 154.08100000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2014.3939999999816,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.0069999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.616,
"heapDeltaBytes": 22213392,
"heapUsedBytes": 86911620,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.28900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.0830000000524,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.239000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.3580000000001,
"heapDeltaBytes": -12983496,
"heapUsedBytes": 86165712,
"domNodes": -270,
"jsHeapTotalBytes": -1085440,
"scriptDurationMs": 31.294999999999998,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2133.4299999999757,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.701999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1528.298,
"heapDeltaBytes": 18129964,
"heapUsedBytes": 83953312,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 762.899,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2228.9639999999054,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.682000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1539.747,
"heapDeltaBytes": 17715592,
"heapUsedBytes": 83682916,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 772.892,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3406.505999999979,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.114,
"layouts": 60,
"layoutDurationMs": 11.037,
"taskDurationMs": 1632.869,
"heapDeltaBytes": 8676856,
"heapUsedBytes": 75876104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 749.49,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3509.79099999995,
"styleRecalcs": 60,
"styleRecalcDurationMs": 8.989,
"layouts": 60,
"layoutDurationMs": 11.165999999999999,
"taskDurationMs": 1631.9079999999997,
"heapDeltaBytes": 7747816,
"heapUsedBytes": 74962548,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 739.9559999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3003.7169999999946,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.744999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1848.3440000000003,
"heapDeltaBytes": 17776884,
"heapUsedBytes": 84709824,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 916.952,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2952.079000000026,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.310000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1826.9309999999998,
"heapDeltaBytes": 17373224,
"heapUsedBytes": 84700872,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 899.6080000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.8649999999966,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.293,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.864,
"heapDeltaBytes": -14359296,
"heapUsedBytes": 86977256,
"domNodes": -266,
"jsHeapTotalBytes": -1085440,
"scriptDurationMs": 29.245999999999995,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.9139999999434,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.9750000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.7400000000001,
"heapDeltaBytes": 11102948,
"heapUsedBytes": 86897020,
"domNodes": -272,
"jsHeapTotalBytes": -1646592,
"scriptDurationMs": 29.452999999999992,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.8230000000144,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.488000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.43000000000006,
"heapDeltaBytes": 13992996,
"heapUsedBytes": 85651596,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 137.44,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.0150000000313,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.086000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.92499999999995,
"heapDeltaBytes": 14115468,
"heapUsedBytes": 79061120,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.916,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2017.4229999999511,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.231999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.276,
"heapDeltaBytes": 958628,
"heapUsedBytes": 72379936,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.849999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.2290000000094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.995999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.451,
"heapDeltaBytes": -11580584,
"heapUsedBytes": 59796692,
"domNodes": -297,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.5489999999999995,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.8000000000065,
"styleRecalcs": 80,
"styleRecalcDurationMs": 35.87799999999999,
"layouts": 18,
"layoutDurationMs": 4.986,
"taskDurationMs": 805.048,
"heapDeltaBytes": 3129704,
"heapUsedBytes": 68088304,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 105.643,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.1019999999553,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.839,
"layouts": 18,
"layoutDurationMs": 5.287,
"taskDurationMs": 787.2470000000001,
"heapDeltaBytes": -12539208,
"heapUsedBytes": 59002004,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 105.30300000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.8650000000298,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.543,
"layouts": 14,
"layoutDurationMs": 15.549,
"taskDurationMs": 917,
"heapDeltaBytes": 21892208,
"heapUsedBytes": 105315396,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.522000000000002,
"eventListeners": 2381,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8635.911000000022,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.44,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5744.514,
"heapDeltaBytes": 11419856,
"heapUsedBytes": 86542448,
"domNodes": -266,
"jsHeapTotalBytes": 413696,
"scriptDurationMs": 2669.866,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8383.609999999975,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.464,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5654.483,
"heapDeltaBytes": 5741204,
"heapUsedBytes": 80738344,
"domNodes": -268,
"jsHeapTotalBytes": 1200128,
"scriptDurationMs": 2596.7480000000005,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16656.954999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15793.234999999999,
"heapDeltaBytes": -23591760,
"heapUsedBytes": 179138612,
"domNodes": -6548,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 249.32699999999997,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16594.84599999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15895.037,
"heapDeltaBytes": -24893372,
"heapUsedBytes": 179062664,
"domNodes": -6548,
"jsHeapTotalBytes": -6410240,
"scriptDurationMs": 251.13600000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20818.891000000007,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.533999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20438.368000000002,
"heapDeltaBytes": -25448796,
"heapUsedBytes": 173098000,
"domNodes": -6548,
"jsHeapTotalBytes": -385024,
"scriptDurationMs": 937.84,
"eventListeners": -7465,
"totalBlockingTimeMs": 103,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20211.76200000002,
"styleRecalcs": 174,
"styleRecalcDurationMs": 16.521000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19820.255,
"heapDeltaBytes": -36740516,
"heapUsedBytes": 166141604,
"domNodes": -6548,
"jsHeapTotalBytes": 1601536,
"scriptDurationMs": 883.5849999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5963.353999999981,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.11600000000001,
"layouts": 20,
"layoutDurationMs": 21.232,
"taskDurationMs": 5871.379999999999,
"heapDeltaBytes": -35958376,
"heapUsedBytes": 174265620,
"domNodes": -6548,
"jsHeapTotalBytes": 4001792,
"scriptDurationMs": 102.738,
"eventListeners": -7471,
"totalBlockingTimeMs": 369,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6039.755000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.14700000000002,
"layouts": 20,
"layoutDurationMs": 22.549,
"taskDurationMs": 5907.277000000001,
"heapDeltaBytes": -48037004,
"heapUsedBytes": 160314292,
"domNodes": -6548,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 128.26100000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 263,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 102.37700000004679,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.32,
"layouts": 2,
"layoutDurationMs": 1.038,
"taskDurationMs": 74.549,
"heapDeltaBytes": 3147360,
"heapUsedBytes": 70384760,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.037,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 462.0620000000599,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.196,
"layouts": 3,
"layoutDurationMs": 1.213,
"taskDurationMs": 103.36200000000001,
"heapDeltaBytes": 5184128,
"heapUsedBytes": 72704068,
"domNodes": 146,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.014999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## christian-byrne/slice-13 #16283 +/- ##
============================================================
+ Coverage 83.24% 83.26% +0.01%
============================================================
Files 2024 2024
Lines 116932 116946 +14
Branches 32426 33011 +585
============================================================
+ Hits 97344 97370 +26
+ Misses 19235 19223 -12
Partials 353 353
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
314a1f5 to
8662319
Compare
|
Superseded — closing per Christian's direction.
Full context for agent readersProgram pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs. |
…6340) ## Summary - Keeps the novel panel-activity gating and agent CSS ownership from Comfy-Org#16283. - Keeps target-aware workflow/node references, explicit-click navigation, and stable node-locator propagation from Comfy-Org#16290. - Drops inherited slice-stack changes already present on `main`; this PR is based directly on `origin/main` at `f954e479a37b`. Gate 10: requires Christian TDD-gate review — touches existing systems. <details> <summary>Full context and validation</summary> ## Changes - **What**: Feature-gated workflow-tab activity watchers; scoped animation ownership; explicit `{ workflowId, locatorId }` references; pure target resolver with typed recoverable failures; main-adapted navigation through the workflow binding/store APIs; selection watcher gating. - **Breaking**: None. - **Dependencies**: None. ## Salvage provenance - Slice-14 source: Comfy-Org#16283 (`59d19dbae8f06837623edba29595ce2adfcc14ba`; authored range starts at `445931d16853ca34f4b5bb7f66878405b83031f9`). - Slice-16 source: Comfy-Org#16290 (`e36ea79acbd0b5c5cb345bc2061c2a40c4af119e`; base `fb0493305abe3fc21154125aaa05cec2bcf637ac`). - Salvage base: `f954e479a37b168a9596aa05a1ce1dec1e9a93b4`. - Main has no reusable GraphDocument registry seam; the slice-16 stand-in comment was removed and the adapter uses the existing workflow binding/store abstractions. ## Review Focus Please verify target isolation when duplicate locator IDs exist across workflows, feature-disable cleanup for tab activity and selection watchers, and the main-specific gate adaptation through `agentPanelStore.enabled`. ## Validation - `pnpm test:unit` on 8 relevant files: 82 passed. - `pnpm typecheck`: passed. - `pnpm lint`: passed with 187 existing warnings and zero errors. - Commit hooks: format, lint, typecheck, and `knip` passed. No browser E2E was added or run in this salvage lane. </details> <!-- authored-by:agent worker-3 --> --------- Co-authored-by: Pipeline Agent <agent@pipeline.local> Co-authored-by: benjcooley <benjcooley@gmail.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
TL;DR
agent-in-app-experienceserver flag.Full context for agent readers
Implements the approved slice-14 panel/effects contract on the reconciled candidate while slice 13 is not yet published. The shared
useAgentFeatureGatefiles are temporary exact-contract stand-ins and must yield to slice 13 during the required rebase. Effects remain presentation-only and do not write semantic or layout Yjs state.State-to-effect: enabled normalized activity registers target-tab watchers; activation clears the target indicator; tab close prunes state; flag disable stops watchers and clears all agent-owned activity. CSS ownership: animation tokens and their
agent-*keyframes now ship together inagentTheme.css; panel selectors remain agent-root/namespace scoped.G1 evidence: base
3a0897bf75e618e8fa017ce8b29e6b331961f5b0; focused unit/component suites 36/36 green; tracker/style suites 7/7 green;pnpm typecheckgreen; commit hooks (format, stylelint, oxlint, ESLint, typecheck) green; pre-push knip green. Full repository ESLint was stopped after stylelint/oxlint because of runtime, with touched-file ESLint green. No dedicated Linear ticket exists per approved spec.Flag-off proof: the gate defaults false; panel store remains disabled; the tracker creates no inner watchers; disable clears unseen/editing/creating state. No effect telemetry or graph mutation was added.
Follow-up: rebase onto
origin/christian-byrne/slice-13as soon as desktop publishes it and prefer its shared flag/runtime implementation.