Repository navigation
test(assets): cover 3D filter remount - #16281
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1893 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.66 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BBundles that do not match a named category Status: 294 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T07:43:47.352Z",
"gitSha": "83c6f83f0a716c3da5346e175f4e30543bb39a5a",
"branch": "test/assets-3d-filter-remount",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.3329999999842,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.292000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.236,
"heapDeltaBytes": -11886440,
"heapUsedBytes": 56454564,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.568999999999998,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2020.1220000000149,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.59,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.94,
"heapDeltaBytes": 1438328,
"heapUsedBytes": 71314044,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.932999999999998,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1755.117999999925,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.979000000000003,
"layouts": 14,
"layoutDurationMs": 2.8960000000000004,
"taskDurationMs": 646.674,
"heapDeltaBytes": 3275292,
"heapUsedBytes": 72249384,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 88.70800000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 15,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1696.903999999904,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.619,
"layouts": 14,
"layoutDurationMs": 2.787,
"taskDurationMs": 585.007,
"heapDeltaBytes": 3592688,
"heapUsedBytes": 73041956,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 85.384,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.3189999999495,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.383000000000001,
"layouts": 6,
"layoutDurationMs": 0.9610000000000001,
"taskDurationMs": 244.695,
"heapDeltaBytes": 4458140,
"heapUsedBytes": 74207664,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.926000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.9519999999757,
"styleRecalcs": 29,
"styleRecalcDurationMs": 11.024,
"layouts": 6,
"layoutDurationMs": 1.121,
"taskDurationMs": 250.597,
"heapDeltaBytes": 4430136,
"heapUsedBytes": 74714124,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.685,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 986.1039999999548,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.6619999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 778.0160000000001,
"heapDeltaBytes": 18473100,
"heapUsedBytes": 87540780,
"domNodes": 8,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 103.072,
"eventListeners": 2,
"totalBlockingTimeMs": 398,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 498.1880000000274,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.48400000000004,
"heapDeltaBytes": 18517788,
"heapUsedBytes": 82303572,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 101.687,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2018.4449999999288,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.8200000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.195,
"heapDeltaBytes": 11248892,
"heapUsedBytes": 86713676,
"domNodes": -266,
"jsHeapTotalBytes": -2179072,
"scriptDurationMs": 29.831999999999997,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.420000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.056999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.782,
"heapDeltaBytes": -12881096,
"heapUsedBytes": 87094788,
"domNodes": -262,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 34.195,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2069.902999999954,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.722999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1071.969,
"heapDeltaBytes": 20683412,
"heapUsedBytes": 86556892,
"domNodes": 8,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 513.688,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2080.859999999916,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.097000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1098.0020000000002,
"heapDeltaBytes": 22942252,
"heapUsedBytes": 88422352,
"domNodes": -276,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 527.308,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3092.883000000029,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.508999999999999,
"layouts": 60,
"layoutDurationMs": 10.248,
"taskDurationMs": 1180.593,
"heapDeltaBytes": -1152372,
"heapUsedBytes": 75355892,
"domNodes": -274,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 482.36500000000007,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3040.1359999999613,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.875,
"layouts": 60,
"layoutDurationMs": 10.068000000000001,
"taskDurationMs": 1133.792,
"heapDeltaBytes": 9172664,
"heapUsedBytes": 75902576,
"domNodes": -270,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 479.84400000000005,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2127.200000000016,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.231,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1205.311,
"heapDeltaBytes": 14636596,
"heapUsedBytes": 83992544,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 559.6179999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2154.6840000000884,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.397000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1265.9530000000002,
"heapDeltaBytes": 13287900,
"heapUsedBytes": 80446868,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 590.4169999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.7680000000037,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.691,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.65100000000007,
"heapDeltaBytes": -14511820,
"heapUsedBytes": 86947916,
"domNodes": -266,
"jsHeapTotalBytes": -2142208,
"scriptDurationMs": 24.767999999999997,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.119999999958,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.9770000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.35900000000004,
"heapDeltaBytes": 21845800,
"heapUsedBytes": 87084296,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.009999999999998,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.2399999999734,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.2170000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 254.65000000000003,
"heapDeltaBytes": 14776628,
"heapUsedBytes": 86985456,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 78.89099999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.65299999999115,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.569,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 261.94300000000004,
"heapDeltaBytes": 14864856,
"heapUsedBytes": 87017696,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 81.532,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1993.4370000000854,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.9350000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.846,
"heapDeltaBytes": 2036584,
"heapUsedBytes": 74131440,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.393,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.35700000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.723,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.166,
"heapDeltaBytes": 3602876,
"heapUsedBytes": 75661016,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.619,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.8859999999968,
"styleRecalcs": 78,
"styleRecalcDurationMs": 22.701,
"layouts": 18,
"layoutDurationMs": 3.259000000000001,
"taskDurationMs": 584.8960000000001,
"heapDeltaBytes": 2654516,
"heapUsedBytes": 74995968,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 67.229,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.5700000000224,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.474999999999998,
"layouts": 18,
"layoutDurationMs": 3.4070000000000005,
"taskDurationMs": 574.1350000000001,
"heapDeltaBytes": 5794436,
"heapUsedBytes": 71257504,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 64.83000000000001,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.3089999999638,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.551999999999996,
"layouts": 16,
"layoutDurationMs": 9.545,
"taskDurationMs": 607.974,
"heapDeltaBytes": 19975752,
"heapUsedBytes": 103115044,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 20.561999999999998,
"eventListeners": 2381,
"totalBlockingTimeMs": 90,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8146.84299999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 24.868000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3943.657,
"heapDeltaBytes": 235804,
"heapUsedBytes": 100719784,
"domNodes": -265,
"jsHeapTotalBytes": 8306688,
"scriptDurationMs": 1808.087,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8099.778000000015,
"styleRecalcs": 247,
"styleRecalcDurationMs": 27.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3759.6879999999996,
"heapDeltaBytes": 22720540,
"heapUsedBytes": 87889928,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 1654.731,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11338.404999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10457.444000000001,
"heapDeltaBytes": -22409776,
"heapUsedBytes": 178365000,
"domNodes": -6548,
"jsHeapTotalBytes": 3104768,
"scriptDurationMs": 155.827,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11948.558000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11088.86,
"heapDeltaBytes": -34006016,
"heapUsedBytes": 175600484,
"domNodes": -6548,
"jsHeapTotalBytes": -6942720,
"scriptDurationMs": 160.456,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14276.959000000033,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.47899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13631.909000000001,
"heapDeltaBytes": -35913660,
"heapUsedBytes": 174616988,
"domNodes": -6548,
"jsHeapTotalBytes": -12214272,
"scriptDurationMs": 687.375,
"eventListeners": -7473,
"totalBlockingTimeMs": 39,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13814.055000000053,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.183,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13203.279999999999,
"heapDeltaBytes": -43716740,
"heapUsedBytes": 162419380,
"domNodes": -6548,
"jsHeapTotalBytes": -5484544,
"scriptDurationMs": 657.416,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3968.5400000000755,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.238000000000014,
"layouts": 20,
"layoutDurationMs": 21.923,
"taskDurationMs": 3824.8190000000004,
"heapDeltaBytes": -22641300,
"heapUsedBytes": 180942368,
"domNodes": -6548,
"jsHeapTotalBytes": 20652032,
"scriptDurationMs": 71.749,
"eventListeners": -7473,
"totalBlockingTimeMs": 49,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 3816.882000000078,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.730000000000025,
"layouts": 20,
"layoutDurationMs": 20.203,
"taskDurationMs": 3660.1069999999995,
"heapDeltaBytes": -5748964,
"heapUsedBytes": 181722672,
"domNodes": -6548,
"jsHeapTotalBytes": 15736832,
"scriptDurationMs": 58.732000000000006,
"eventListeners": -7473,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 95.98499999992782,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.413,
"layouts": 2,
"layoutDurationMs": 1.47,
"taskDurationMs": 71.99300000000001,
"heapDeltaBytes": 3199508,
"heapUsedBytes": 70677164,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.129999999999999,
"eventListeners": 27,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 81.35399999991932,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.740999999999998,
"layouts": 2,
"layoutDurationMs": 1.2510000000000001,
"taskDurationMs": 55.48900000000001,
"heapDeltaBytes": 3122024,
"heapUsedBytes": 71225352,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.646000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-16281.vercel.app This commit: https://website-frontend-42re1k0n7-comfyui.vercel.app Last updated: 2026-09-01T07:32:55Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16281 +/- ##
==========================================
+ Coverage 81.33% 83.26% +1.92%
==========================================
Files 2413 2023 -390
Lines 123730 116960 -6770
Branches 34571 33030 -1541
==========================================
- Hits 100635 97381 -3254
+ Misses 22490 19224 -3266
+ Partials 605 355 -250
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
|
c7d2233 to
711068b
Compare
070ff3f to
82aeb1b
Compare
|
@coderabbitai review |
|
|
Fully contained in #16293; our review is posted there. |
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks for adding a 3D detector for #11635. One blocking point: marking the whole existing test test.fail removes the guard on image, video, and audio restoration that this test gives today. Details are inline.
CI note: the failing checks (playwright-tests, custom_nodes_e2e, ecosystem matrix) are from 2026-09-01 and look like infrastructure problems, not this spec. A rebase on current main would give a clean signal.
| test('Unchecking the active filter restores every hidden preview', async ({ | ||
| comfyPage | ||
| }) => { | ||
| test.fail( |
There was a problem hiding this comment.
issue: test.fail(true, …) passes the test when it fails anywhere, not only at the 3D assertion. If a regression stops the image, video, or audio card from coming back after the filter is cleared, this test still goes green as an "expected failure". On main, this test catches that regression today, so the change weakens existing coverage. When #11635 is fixed, the test does flip to "unexpectedly passed", but until then the other three media types have no guard.
Could you keep the existing passing test as it is and add a separate test.fail (or test.fixme) case that asserts only the 3D card and its 3D Model placeholder? That keeps the current guard and still records the known bug.
Summary
Adds the missing 3D filter-remount detector. Current regression is recorded as an expected failure. Extends the Cloud Assets filter journey so clearing the Image filter must restore the hidden 3D card and initialize exactly one 3D preview placeholder. This covers the 3D filter-remount case, tracked internally as TC-VIEW-08, and replaces the assertion omission associated with issue #11635.
Review Focus
The expectation is marked with
test.failbecause the 3D virtual item currently remains unmounted after filtering. The same test first proves image, video, and audio restoration, while the other five tests in the file provide passing fixture controls.Verification
Verification:
/api/users; CI is the execution gate