Skip to content

test: align fdct hero test with autoplay hero video - #16267

Closed
DrJKL wants to merge 2 commits into
mainfrom
fix/fdct-hero-autoplay-test
Closed

DrJKL wants to merge 2 commits into
mainfrom
fix/fdct-hero-autoplay-test

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

#16205 made the fdct hero video autoplay but left the HeroSection unit test asserting the old click-to-play design, so website-unit fails whenever it runs (it is path-filtered and skipped on most PRs, which hid the breakage).

Updates the test to assert the intended behavior: autoplay attribute present, muted (required for browser autoplay), poster fallback retained. Removes the overlay play-button assertion tied to the removed click-to-play affordance.

@DrJKL
DrJKL requested a review from a team August 30, 2026 01:07
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 30, 2026
@github-actions

github-actions Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-16267.vercel.app

This commit: https://website-frontend-6k8tkmwx3-comfyui.vercel.app

Last updated: 2026-08-30T17:34:42Z for d27d186

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c9c1a5a5-fdfc-4f15-9aff-b99fa5c1e0d6

📥 Commits

Reviewing files that changed from the base of the PR and between 937e4c3 and dbbf684.

📒 Files selected for processing (1)
  • apps/website/src/templates/fdct/HeroSection.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The HeroSection test now expects muted autoplay video, retains the poster fallback check, and removes the click-to-play overlay assertion.

Changes

Hero video behavior

Layer / File(s) Summary
Update hero video assertions
apps/website/src/templates/fdct/HeroSection.test.ts
The test verifies autoplay, muted playback, and the poster fallback. It no longer checks for non-autoplay behavior or an overlay play button.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to dbbf6

This localized test-only change updates assertions for autoplay, muted playback, and poster fallback while removing an obsolete play-button expectation; no actionable merge-blocking risk remains.


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The review context does not provide the PR title or commit subjects. The custom check requires those fields to evaluate the bug-fix signal, and it requires INCONCLUSIVE when commit subjects are unavai… Provide the PR title and all commit subjects, plus the authoritative base-to-head changed-file list, then rerun the check.
Website End-To-End Regression Coverage ❓ Inconclusive The review context identifies one changed file, apps/website/src/templates/fdct/HeroSection.test.ts, but it does not provide the PR title, commit subjects, or the actual diff content. The custom che… Provide the PR title, commit subjects, complete base...head changed-file list, and diff content. Then verify whether a website runtime behavior changed and whether a matching Playwright assertion exists under `apps/website/e2e/**/*.spec.t…
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating the FDCT HeroSection test to match autoplay hero video behavior.
Description check ✅ Passed The description explains why the test changed and identifies the autoplay, muted, poster fallback, and removed overlay button assertions. It omits the template headings and explicit review focus or sc…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains only apps/website/src/templates/fdct/HeroSection.test.ts. It does not modify src/lib/litegraph/, src/ecs/, or files related to graph entities. The custom check is …
Full details: Description check

Explanation

The description explains why the test changed and identifies the autoplay, muted, poster fallback, and removed overlay button assertions. It omits the template headings and explicit review focus or screenshots, but the required change information is complete.

Full details: End-To-End Regression Coverage For Fixes

Explanation

The review context does not provide the PR title or commit subjects. The custom check requires those fields to evaluate the bug-fix signal, and it requires INCONCLUSIVE when commit subjects are unavailable. The context does identify one changed file under apps/website, but this does not resolve the missing required metadata.

Full details: Website End-To-End Regression Coverage

Explanation

The review context identifies one changed file, apps/website/src/templates/fdct/HeroSection.test.ts, but it does not provide the PR title, commit subjects, or the actual diff content. The custom check requires an inconclusive result when commit subjects or the changed-file list is unavailable. The available summary is not sufficient to verify the required behavior change and coverage conditions from the diff.

Resolution

Provide the PR title, commit subjects, complete base...head changed-file list, and diff content. Then verify whether a website runtime behavior changed and whether a matching Playwright assertion exists under apps/website/e2e/**/*.spec.ts, or whether the description explains why such coverage is not practical.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The changed-file list contains only apps/website/src/templates/fdct/HeroSection.test.ts. It does not modify src/lib/litegraph/, src/ecs/, or files related to graph entities. The custom check is therefore not applicable.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fdct-hero-autoplay-test

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #16267      +/-   ##
==========================================
- Coverage   82.79%   80.74%   -2.06%     
==========================================
  Files        1953     2333     +380     
  Lines      112630   119133    +6503     
  Branches    31230    32711    +1481     
==========================================
+ Hits        93256    96193    +2937     
- Misses      19035    22348    +3313     
- Partials      339      592     +253     
Flag Coverage Δ
website-unit 45.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 396 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 30, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

This fix and frontend PR 16215 address the same broken test; landing either one unblocks the 1.53.5 release train (frontend PR 16207), which currently fails only on this.

Full context for agent readers
  • Root cause: the autoplay FDCT hero video change (frontend PR 16205, merged 2026-08-29) updated HeroSection.vue and the e2e spec but not the unit test, so apps/website/src/templates/fdct/HeroSection.test.ts ("renders the split hero with a click-to-play video behind its poster") now fails on every branch containing that commit.
  • Confirmed deterministic: failed at release-train head before and after updating that branch with latest main (fresh run 2026-08-30T11:36Z).
  • Duplicate fixes: this PR (16267) and frontend PR 16215 (robinjhuang) — both green and mergeable, neither approved. Suggest approving/landing one and closing the other.
  • robinjhuang requested as reviewer here since he authored the equivalent fix.

@DrJKL DrJKL closed this Aug 30, 2026
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants