Repository navigation
test(assets): partial bulk insertion - #16252
Conversation
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe tests configure ChangesMedia asset action tests
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2070 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle: 9.96 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.88 MB (baseline 3.88 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 302 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-21T23:21:38.165Z",
"gitSha": "8ac7e5f364a82e89de8f4092278f8c67f0a8186c",
"branch": "test/assets-delete-cache-refetch",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.2510000000061,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.742999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.642,
"heapDeltaBytes": -6560216,
"heapUsedBytes": 55768080,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.362999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.2799999998997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.163999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.1049999999999,
"heapDeltaBytes": 14651756,
"heapUsedBytes": 76848372,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.889000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.533999999976,
"styleRecalcs": 73,
"styleRecalcDurationMs": 20.097000000000005,
"layouts": 14,
"layoutDurationMs": 3.488,
"taskDurationMs": 639.192,
"heapDeltaBytes": 1727992,
"heapUsedBytes": 63892540,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 114.93299999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.5200000000268,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.189000000000004,
"layouts": 14,
"layoutDurationMs": 3.816,
"taskDurationMs": 756.5280000000001,
"heapDeltaBytes": 2834528,
"heapUsedBytes": 64931380,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 128.822,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.0879999999756,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.618,
"layouts": 6,
"layoutDurationMs": 0.9029999999999999,
"taskDurationMs": 265.154,
"heapDeltaBytes": 3167916,
"heapUsedBytes": 70507324,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.384000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.900999999969,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.019000000000002,
"layouts": 6,
"layoutDurationMs": 1.1239999999999999,
"taskDurationMs": 326.792,
"heapDeltaBytes": 2239500,
"heapUsedBytes": 64498572,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 13.674000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 561.2760000000208,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.956999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.796,
"heapDeltaBytes": 18610772,
"heapUsedBytes": 80939712,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 133.265,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 526.9099999999298,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.452000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.536,
"heapDeltaBytes": 17924356,
"heapUsedBytes": 80065628,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 133.31300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1031.3200000000506,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.11,
"heapDeltaBytes": -13439636,
"heapUsedBytes": 72526228,
"domNodes": -296,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 49.297000000000004,
"eventListeners": -217,
"totalBlockingTimeMs": 391,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1059.4320000000153,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.316,
"heapDeltaBytes": 34405188,
"heapUsedBytes": 102444752,
"domNodes": 0,
"jsHeapTotalBytes": 17985536,
"scriptDurationMs": 52.36599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 444,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.5380000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.74500000000023,
"heapDeltaBytes": 14311240,
"heapUsedBytes": 90574652,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.09699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 154,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.6100000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.53200000000044,
"heapDeltaBytes": 15814384,
"heapUsedBytes": 92339744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.689,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7538.228000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6709.353,
"heapDeltaBytes": -7818464,
"heapUsedBytes": 73981720,
"domNodes": -16,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 5440.695,
"eventListeners": 0,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7259.405000000015,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8230000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6378.225,
"heapDeltaBytes": 12894280,
"heapUsedBytes": 89846452,
"domNodes": -267,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5058.658,
"eventListeners": -170,
"totalBlockingTimeMs": 26,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6920.153999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6204.162,
"heapDeltaBytes": -897984,
"heapUsedBytes": 81679504,
"domNodes": -18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4954.817999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 71,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7677.302999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6781.541000000001,
"heapDeltaBytes": 726084,
"heapUsedBytes": 83059156,
"domNodes": -16,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 5603.7660000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2008.1230000000119,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.198999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.30899999999997,
"heapDeltaBytes": -1921392,
"heapUsedBytes": 79769784,
"domNodes": -247,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 27.397,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2016.5130000000318,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.5139999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.3939999999999,
"heapDeltaBytes": 2061280,
"heapUsedBytes": 83505768,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.821999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2120.902000000001,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.334000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1232.4969999999998,
"heapDeltaBytes": 19796064,
"heapUsedBytes": 84244556,
"domNodes": -248,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 630.2690000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2152.9749999999694,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.408999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1384.292,
"heapDeltaBytes": 19405852,
"heapUsedBytes": 83686200,
"domNodes": -254,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 688.4390000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3153.6800000000085,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.871000000000002,
"layouts": 60,
"layoutDurationMs": 11.717000000000002,
"taskDurationMs": 1293.9879999999998,
"heapDeltaBytes": 9102736,
"heapUsedBytes": 74102208,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 606.21,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3289.050999999972,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.939000000000004,
"layouts": 60,
"layoutDurationMs": 13.236,
"taskDurationMs": 1508.226,
"heapDeltaBytes": 8036344,
"heapUsedBytes": 74224420,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 690.151,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2279.7690000000443,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.3180000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1498.2699999999998,
"heapDeltaBytes": 16921572,
"heapUsedBytes": 83113880,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 775.468,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2564.760999999976,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.926000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1668.6820000000002,
"heapDeltaBytes": 18368832,
"heapUsedBytes": 82876148,
"domNodes": -255,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 830.43,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.6159999999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.004000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.57399999999996,
"heapDeltaBytes": -6250616,
"heapUsedBytes": 82682600,
"domNodes": -244,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 27.443999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.8650000000016,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.995999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.27,
"heapDeltaBytes": -9313140,
"heapUsedBytes": 80057920,
"domNodes": -257,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 33.41000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 481.47900000003574,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.922999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 307.043,
"heapDeltaBytes": 13742584,
"heapUsedBytes": 83390700,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 115.11099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.363000000084,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.393,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.603,
"heapDeltaBytes": 12867212,
"heapUsedBytes": 76367332,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 117.132,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.715999999969,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.783999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.9340000000001,
"heapDeltaBytes": -9068072,
"heapUsedBytes": 54426540,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.837,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.294000000039,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.5340000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.40900000000005,
"heapDeltaBytes": 17906700,
"heapUsedBytes": 81440336,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.051,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.4930000000227,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.078,
"layouts": 18,
"layoutDurationMs": 3.9389999999999996,
"taskDurationMs": 593.4150000000001,
"heapDeltaBytes": 1053348,
"heapUsedBytes": 64778676,
"domNodes": -276,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 79.765,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.430999999995,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.895000000000003,
"layouts": 18,
"layoutDurationMs": 5.159000000000001,
"taskDurationMs": 701.729,
"heapDeltaBytes": 6328976,
"heapUsedBytes": 75790448,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 95.68199999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.5969999999934,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.802999999999997,
"layouts": 5,
"layoutDurationMs": 9.322000000000001,
"taskDurationMs": 674.163,
"heapDeltaBytes": -8140644,
"heapUsedBytes": 81493940,
"domNodes": 13667,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 20.259000000000007,
"eventListeners": 2383,
"totalBlockingTimeMs": 86,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8166.110000000003,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.265,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4378.706,
"heapDeltaBytes": 12694064,
"heapUsedBytes": 76364628,
"domNodes": -243,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 2103.499,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8244.315000000028,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4878.562000000001,
"heapDeltaBytes": -1218912,
"heapUsedBytes": 80029388,
"domNodes": -244,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2228.561,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14023.579000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13400.638,
"heapDeltaBytes": -32743632,
"heapUsedBytes": 188209792,
"domNodes": -8061,
"jsHeapTotalBytes": -15667200,
"scriptDurationMs": 189.81800000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14642.68299999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14533.765,
"heapDeltaBytes": -50992092,
"heapUsedBytes": 188229488,
"domNodes": -8061,
"jsHeapTotalBytes": -12238848,
"scriptDurationMs": 211.779,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16694.398999999976,
"styleRecalcs": 122,
"styleRecalcDurationMs": 13.397999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16286.791999999998,
"heapDeltaBytes": -45876608,
"heapUsedBytes": 171426720,
"domNodes": -8061,
"jsHeapTotalBytes": -9478144,
"scriptDurationMs": 695.597,
"eventListeners": -14928,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17409.754000000023,
"styleRecalcs": 122,
"styleRecalcDurationMs": 16.537999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17311.61,
"heapDeltaBytes": -53931008,
"heapUsedBytes": 168500612,
"domNodes": -8061,
"jsHeapTotalBytes": -11517952,
"scriptDurationMs": 738.349,
"eventListeners": -14928,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5045.119999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.27499999999999,
"layouts": 20,
"layoutDurationMs": 21.042000000000005,
"taskDurationMs": 4987.825,
"heapDeltaBytes": -12377668,
"heapUsedBytes": 197319888,
"domNodes": -8061,
"jsHeapTotalBytes": 15126528,
"scriptDurationMs": 80.067,
"eventListeners": -14928,
"totalBlockingTimeMs": 168,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5454.732000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.97500000000004,
"layouts": 20,
"layoutDurationMs": 26.657,
"taskDurationMs": 5438.242,
"heapDeltaBytes": -36540348,
"heapUsedBytes": 195002512,
"domNodes": -8061,
"jsHeapTotalBytes": 17506304,
"scriptDurationMs": 96.87,
"eventListeners": -14928,
"totalBlockingTimeMs": 259,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7084.716000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6992.181999999998,
"heapDeltaBytes": 10048388,
"heapUsedBytes": 197866300,
"domNodes": 0,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 97.72399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7296.5410000000475,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7235.746000000001,
"heapDeltaBytes": 9345436,
"heapUsedBytes": 178156080,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 105.00300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 460.3349999999864,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.286,
"layouts": 5,
"layoutDurationMs": 1.8190000000000002,
"taskDurationMs": 112.759,
"heapDeltaBytes": 5282696,
"heapUsedBytes": 67169148,
"domNodes": 154,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.886,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 456.0320000000502,
"styleRecalcs": 21,
"styleRecalcDurationMs": 21.19,
"layouts": 5,
"layoutDurationMs": 1.919,
"taskDurationMs": 103.767,
"heapDeltaBytes": 4896908,
"heapUsedBytes": 66688944,
"domNodes": 146,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.979,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1afcc614e8157904349382e05daee93fe1e711b4
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16252 +/- ##
==========================================
+ Coverage 83.25% 84.22% +0.97%
==========================================
Files 2972 2278 -694
Lines 146279 129267 -17012
Branches 39639 33042 -6597
==========================================
- Hits 121782 108879 -12903
+ Misses 23221 20092 -3129
+ Partials 1276 296 -980
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
9c51437 to
493a249
Compare
c148db9 to
95b384f
Compare
|
Fully contained in #16293; our review is posted there. |
|
@coderabbitai review |
|
benjcooley
left a comment
There was a problem hiding this comment.
Comprehensive PR Review
Generated by Claude. If any comment looks wrong, say why and I'll re-check.
PR: test(assets): partial bulk insertion (#16252) — 45 additions, 2 deletions, 1 file (test-only)
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 |
| TRIVIAL | 2 |
What I verified
addMultipleToWorkflowon currentmainis byte-identical to the version this test targets:nodeIndexonly advances on success,failed++on!nodeType || !widgetName, and the warn toast carries{ succeeded, failed }. The assertions on contiguous positions ([100,100],[150,150]) and the exact2/1counts are real behaviour, not restated mock config.- Widget values:
isCloud === falseandgetAssetType → 'input', socreateAssetWidgetPathyields the barefirst.png/third.pngwith no annotation. The expectation is correct. - No duplicate coverage —
addMultipleToWorkflowhad only the cloud annotation test before this; the partial path was untested. - Test isolation is fine:
mockReset: trueclears the sharedtoast.addandtspies between tests, sotoHaveBeenCalledWithhere is scoped to this test.
SHOULD FIX
1. Branch is stale — merges with a conflict. A trial merge against current main conflicts in the import block: main has since replaced the importOriginal-spread mock of ../utils/outputAssetUtil with vi.mock('../utils/outputAssetUtil') + vi.mocked(...), and the shared beforeEach now also seeds api.getServerFeature and mockInputAssets.items. Everything else auto-merges. Rebase and keep main's outputAssetUtil mock form; only the new import type * as loaderNodeUtilModule line needs to be added on top.
2. The Verification block does not describe this change. It claims 51 passed, 1 expected failure; this file has 44 tests on main today and is fully green, so the new test makes 45 green — there is no expected failure here. It also says "Stacked on #16248", but #16248 is still open on a different branch and this PR's diff against main is a single independent commit. The branch name (test/assets-delete-cache-refetch) is unrelated to bulk insertion. None of this affects the code, but a verification block that reports numbers from some other run is worth correcting before merge.
Optional
addMultipleToWorkflow still has no coverage for the two remaining failure branches — the all-unsupported case (error toast, succeeded === 0) and the missing-nodeDef / null-node case. The all-unsupported case is one more it given the mock you just introduced.
Positives
Good use of vi.hoisted with vi.fn<typeof detectNodeTypeFromFilename> so the mock stays contract-checked against the real signature. The position assertion is the valuable part — it pins the invariant that a failed asset does not consume a slot in the layout, which a counts-only test would have missed.
| mockDetectNodeTypeFromFilename.mockReturnValue({ | ||
| nodeType: 'LoadImage', | ||
| widgetName: 'image' | ||
| }) |
There was a problem hiding this comment.
TRIVIAL — dead setup. mockReset: true is on in vite.config.mts, and in Vitest 4 mockReset() restores the implementation originally passed to vi.fn(impl). The hoisted mock already returns { nodeType: 'LoadImage', widgetName: 'image' } and is restored to that before every test, so this block never changes behaviour (verified against vitest 4.1.10). The new test's mockImplementation is likewise cleaned up automatically. Safe to drop the four lines.
There was a problem hiding this comment.
Addressed in 46ec7f2: removed the redundant default mock reset.
There was a problem hiding this comment.
This removal is no longer safe after the rebase. My earlier comment assumed the original vi.fn(implementation) factory; f120ec7 replaced it with vi.mock(import('@/utils/loaderNodeUtil')), which has no default implementation. Removing the beforeEach return value in 46ec7f2 therefore leaves the detector returning undefined in every test except the new partial-insertion test.
The CI test job for this head confirms five failures in this file: four addWorkflow tests and the existing bulk cloud annotation test all throw while destructuring nodeType.
Please restore the default return value in beforeEach, or restore a factory with a reset-persistent implementation, and rerun the whole file. Keeping this thread open until the existing tests pass.
There was a problem hiding this comment.
Remote CI disproved the original Vitest reset assumption: after removing this setup, every addWorkflow case received undefined from detectNodeTypeFromFilename. Restored the explicit default in 8af4273.
benjcooley
left a comment
There was a problem hiding this comment.
Approving — no blockers. Test is correct and covers a genuinely untested branch (partial-failure accounting + the layout-slot invariant), verified against addMultipleToWorkflow on current main.
Two non-blocking items from my earlier review still worth doing before merge: rebase (the branch conflicts with main in the import block), and fix the Verification block in the description — it reports 51 passed, 1 expected failure, but this file is 44 green on main and 45 green with this change. Inline nits (dead beforeEach seeding, unmount() after assertions) are optional.
|
Rebased onto current |
95b384f to
f120ec7
Compare
Addresses review feedback: #16252 (comment)
benjcooley
left a comment
There was a problem hiding this comment.
Request changes on 46ec7f2. Scoped re-review of the updates since 95b384f, including the rebased test harness.
Blocking: removing the detector default now breaks five existing tests. The rebased version uses an automock rather than the original vi.fn(implementation), so mockReset cannot restore the old LoadImage result. Restore that default (in setup or a reset-persistent mock factory) and rerun the full useMediaAssetActions.test.ts file. Confirmed in the current head's CI log: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35583828582/job/106282521225. Replied on the original thread.
Resolved the cleanup thread: mounted apps are registered and unmounted by afterEach even if assertions fail. The rebase also removes the previous merge conflict; the partial-result assertion now uses real i18n.
The non-blocking verification-note issue remains: the body still reports 51 passed / 1 expected failure and a single stacked commit, while current CI reports 54 tests in this file with 5 failures and the PR has two commits. Please refresh it after the fix.
Validation: read-only comparison and current-head CI logs; no local checkout, edits, or test execution.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
I confirmed one pre-merge defect:
- [P1] The bare
detectNodeTypeFromFilenameautomock has no supported-file default. The exact-head file run reports 49 passed and 5 failed because the four existing single-asset tests and the existing cloud bulk test destructureundefined. Restore a reset-persistent default, keep the mixed-case override local to its test, and rerun the full file.
Existing findings confirmed or contested
- Confirmed [P1]: The detector-default finding reproduces locally at
46ec7f292c: 5 failures and 49 passes, all from the undefined automock result. - Contested [P3]: The earlier cleanup-leak finding no longer describes the current harness.
mountMediaActionsregisters each app, and the file-levelafterEachunmounts remaining apps after failed assertions. I left a separate inline nit because the new test still duplicates that cleanup owner. - Confirmed [P3]: The verification-note finding remains. The body says 51 passed with 1 expected failure, while the exact-head result is 49 passed and 5 failed.
- Confirmed [P3]: The same review notes that the description no longer matches the commit range. The PR has two commits,
f120ec7and46ec7f2, not one. - Confirmed [P3]: The earlier stack finding remains. #16248 and this PR share base
d8ba393, but #16248 is not an ancestor of this head. - Contested [P2]: The claim that #16293 contains this PR does not match the current diffs. #16293 is closed unmerged and changes a Playwright assets spec for runtime flag fallback. This PR changes a Vitest composable test for bulk insertion.
Checked and cleared
- The old merge-conflict report is resolved. The live PR API reports this head mergeable.
- Missing all-unsupported and missing-node-definition coverage predates this PR. This PR claims only the mixed partial-result case, so I am not treating adjacent branch coverage as introduced work.
- I did not require attached logs for every command listed in the PR body. The remote lint-and-format check is green; the directly contradicted unit result is called out above.
- The mutation-proof statement is supported by the code path: removing the unsupported-item
failed++selects the success toast instead of the warning asserted by the new test. - The internal QA plan is explicitly internal, so its absence from the public PR is not a documentation defect.
Coverage
Depth: standard. I reviewed the full one-file diff with correctness, maintainability, idiomaticity, tests, and documentation lanes. Standard specialist checks covered blast radius, regression history, boundary and lifecycle behavior, deletion-first maintainability, TypeScript/Vitest idioms, mock quality, setup ownership, and verification claims. Playwright guidance was not applicable because no browser_tests file changed. CI Fallow reports no new findings; a local Fallow rerun could not start because the borrowed worktree dependencies triggered pnpm's non-TTY install guard.
Local exact-head check: vitest run src/platform/assets/composables/useMediaAssetActions.test.ts with the required Node local-storage option, 49 passed, 5 failed. Current check runs: 79 successful, 1 failed (test), 20 skipped.
| }) | ||
| }) | ||
|
|
||
| it('adds supported assets and reports an exact partial result', async () => { |
There was a problem hiding this comment.
Nit: [P3] This case exercises addMultipleToWorkflow, but it is nested under describe('addWorkflow') while the owning bulk-operation describe starts just below. Please move this test there so Vitest's test path and source organization name the API under test.
| }), | ||
| life: 3000 | ||
| }) | ||
| unmount() |
There was a problem hiding this comment.
Nit: [P3] The file-level afterEach already unmounts every app left in apps, including after an assertion fails. Using useMediaAssetActions() here and deleting this second cleanup path leaves one lifecycle owner.
This comment has been minimized.
This comment has been minimized.
Remote CI shows Vitest 4 resets this hoisted mock to undefined in this suite. Addresses review feedback: #16252 (comment)
Summary
Supported assets still insert when one selection is unsupported. Partial outcome reports exact 2/1 counts. Covers the mixed supported/unsupported bulk-insertion case from the internal assets QA plan.
Changes
Verification
pnpm test:unit src/platform/assets/composables/useMediaAssetActions.test.ts(51 passed, 1 expected failure)pnpm typecheckpnpm exec eslint src/platform/assets/composables/useMediaAssetActions.test.tspnpm exec oxlint --type-aware src/platform/assets/composables/useMediaAssetActions.test.tspnpm exec oxfmt --check src/platform/assets/composables/useMediaAssetActions.test.tspnpm knipStacked on #16248; review this PR’s single commit.