Repository navigation
test(assets): ordered graph cleanup - #16244
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1891 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.66 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BBundles that do not match a named category Status: 294 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T08:12:15.556Z",
"gitSha": "67660eaabf454d8de77c7db3a501c4f6b33c6bfc",
"branch": "test/assets-delete-graph-cleanup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2075.5009999999743,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.106,
"heapDeltaBytes": -238324,
"heapUsedBytes": 68783456,
"domNodes": -280,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 9.190000000000003,
"eventListeners": -189,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2035.3790000000345,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.767,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.961,
"heapDeltaBytes": -9825160,
"heapUsedBytes": 59684692,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.379000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1934.5749999999953,
"styleRecalcs": 81,
"styleRecalcDurationMs": 42.456,
"layouts": 14,
"layoutDurationMs": 4.646,
"taskDurationMs": 921.282,
"heapDeltaBytes": 13943464,
"heapUsedBytes": 77780236,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 162.79399999999998,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1881.5690000000131,
"styleRecalcs": 79,
"styleRecalcDurationMs": 44.665,
"layouts": 14,
"layoutDurationMs": 4.8389999999999995,
"taskDurationMs": 925.707,
"heapDeltaBytes": -7892808,
"heapUsedBytes": 61872948,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 166.84700000000004,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.0769999999852,
"styleRecalcs": 33,
"styleRecalcDurationMs": 19.114,
"layouts": 6,
"layoutDurationMs": 1.339,
"taskDurationMs": 409.509,
"heapDeltaBytes": 4390736,
"heapUsedBytes": 74280500,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.702000000000002,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.3440000000783,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.852999999999994,
"layouts": 6,
"layoutDurationMs": 1.2630000000000001,
"taskDurationMs": 405.86899999999997,
"heapDeltaBytes": 4643736,
"heapUsedBytes": 74532984,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.885,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.8099999999849,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.350000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.889,
"heapDeltaBytes": 18173864,
"heapUsedBytes": 88016072,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 165.827,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 728.9220000000114,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.633999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.90899999999993,
"heapDeltaBytes": 18142652,
"heapUsedBytes": 88016380,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 168.336,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.3849999999911,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.969000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.0100000000001,
"heapDeltaBytes": -12945708,
"heapUsedBytes": 86669892,
"domNodes": -270,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 36.692,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.3410000000167,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.291000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.7749999999999,
"heapDeltaBytes": -13470128,
"heapUsedBytes": 86750748,
"domNodes": -271,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 38.594,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2455.865000000017,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.208000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1706.611,
"heapDeltaBytes": 26146252,
"heapUsedBytes": 91466692,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 838.605,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2582.0320000000265,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.989999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1706.2740000000001,
"heapDeltaBytes": 21984168,
"heapUsedBytes": 87398364,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 843.0279999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3625.6030000000123,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.296000000000003,
"layouts": 60,
"layoutDurationMs": 12.485,
"taskDurationMs": 1779.7,
"heapDeltaBytes": 8366808,
"heapUsedBytes": 75671016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 804.956,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3634.302000000048,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.549000000000003,
"layouts": 60,
"layoutDurationMs": 12.826999999999998,
"taskDurationMs": 1771.225,
"heapDeltaBytes": 11727772,
"heapUsedBytes": 79491016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 811.1160000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3171.7179999999985,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.241000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2017.748,
"heapDeltaBytes": 17702224,
"heapUsedBytes": 84557840,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1013.1840000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3235.5289999999286,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.178999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2053.5040000000004,
"heapDeltaBytes": 20206708,
"heapUsedBytes": 86877168,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1033.925,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2034.4600000000241,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9169999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.322,
"heapDeltaBytes": -14537444,
"heapUsedBytes": 86796688,
"domNodes": -274,
"jsHeapTotalBytes": -2142208,
"scriptDurationMs": 34.287,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.618000000014,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9970000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.6979999999999,
"heapDeltaBytes": -15006444,
"heapUsedBytes": 87191624,
"domNodes": -273,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 35.49099999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.9210000000517,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.353,
"heapDeltaBytes": 14278956,
"heapUsedBytes": 86223936,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 143.844,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 618.8379999999825,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.062,
"heapDeltaBytes": 13687536,
"heapUsedBytes": 79087156,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 148.02400000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2037.7280000000155,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.758999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.114,
"heapDeltaBytes": -9840936,
"heapUsedBytes": 61851672,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.070000000000002,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.4260000000195,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.324000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.029,
"heapDeltaBytes": 4165276,
"heapUsedBytes": 76230632,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.735,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1731.870000000015,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.071000000000005,
"layouts": 18,
"layoutDurationMs": 5.518,
"taskDurationMs": 885.2339999999999,
"heapDeltaBytes": -10123160,
"heapUsedBytes": 61811840,
"domNodes": -297,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 116.803,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1822.1250000000282,
"styleRecalcs": 78,
"styleRecalcDurationMs": 44.592000000000006,
"layouts": 18,
"layoutDurationMs": 6.200999999999999,
"taskDurationMs": 935.382,
"heapDeltaBytes": 2699140,
"heapUsedBytes": 74740744,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 122.10199999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.814999999966,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.24400000000001,
"layouts": 14,
"layoutDurationMs": 15.536999999999999,
"taskDurationMs": 983.333,
"heapDeltaBytes": 24602044,
"heapUsedBytes": 97353900,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 33.617,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9348.360000000013,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.061,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6280.407999999999,
"heapDeltaBytes": -7120768,
"heapUsedBytes": 92901800,
"domNodes": -268,
"jsHeapTotalBytes": -1163264,
"scriptDurationMs": 2827.7539999999995,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9801.191000000017,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.355,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6374.01,
"heapDeltaBytes": -10059096,
"heapUsedBytes": 90262264,
"domNodes": -270,
"jsHeapTotalBytes": -901120,
"scriptDurationMs": 2933.6310000000003,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18094.202999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17209.475,
"heapDeltaBytes": -33460536,
"heapUsedBytes": 176155264,
"domNodes": -6548,
"jsHeapTotalBytes": -5107712,
"scriptDurationMs": 316.885,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18309.1179999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17595.746000000003,
"heapDeltaBytes": -33316340,
"heapUsedBytes": 175979804,
"domNodes": -6548,
"jsHeapTotalBytes": -3010560,
"scriptDurationMs": 312.48900000000003,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22111.30000000003,
"styleRecalcs": 171,
"styleRecalcDurationMs": 21.677000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21777.243000000002,
"heapDeltaBytes": -37042460,
"heapUsedBytes": 176090864,
"domNodes": -6548,
"jsHeapTotalBytes": -10506240,
"scriptDurationMs": 989.428,
"eventListeners": -7467,
"totalBlockingTimeMs": 186,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22838.60100000004,
"styleRecalcs": 173,
"styleRecalcDurationMs": 22.184999999999956,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22452.534999999996,
"heapDeltaBytes": -24340256,
"heapUsedBytes": 179859140,
"domNodes": -6548,
"jsHeapTotalBytes": 991232,
"scriptDurationMs": 1045.985,
"eventListeners": -7469,
"totalBlockingTimeMs": 26,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6549.926999999969,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.78300000000006,
"layouts": 20,
"layoutDurationMs": 25.437000000000015,
"taskDurationMs": 6446.307,
"heapDeltaBytes": -31601552,
"heapUsedBytes": 181369620,
"domNodes": -6548,
"jsHeapTotalBytes": 8892416,
"scriptDurationMs": 117.14099999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 495,
"frameDurationMs": 18.33666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6431.381999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.42099999999996,
"layouts": 20,
"layoutDurationMs": 24.968000000000004,
"taskDurationMs": 6328.964999999999,
"heapDeltaBytes": -22457224,
"heapUsedBytes": 174874240,
"domNodes": -6548,
"jsHeapTotalBytes": 11526144,
"scriptDurationMs": 137.18000000000004,
"eventListeners": -7471,
"totalBlockingTimeMs": 429,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 482.87200000004304,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.107,
"layouts": 3,
"layoutDurationMs": 1.3960000000000001,
"taskDurationMs": 129.162,
"heapDeltaBytes": 5283600,
"heapUsedBytes": 72926120,
"domNodes": 153,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.185,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 460.4190000000017,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.634999999999998,
"layouts": 3,
"layoutDurationMs": 0.8180000000000001,
"taskDurationMs": 102.52799999999999,
"heapDeltaBytes": 5053348,
"heapUsedBytes": 73079700,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.764000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16244 +/- ##
==========================================
+ Coverage 81.33% 83.25% +1.92%
==========================================
Files 2413 2023 -390
Lines 123730 116960 -6770
Branches 34571 33030 -1541
==========================================
- Hits 100635 97375 -3260
+ Misses 22490 19230 -3260
+ Partials 605 355 -250
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
edbeadc to
e47466b
Compare
abed95c to
650f082
Compare
|
@coderabbitai review |
|
|
Fully contained in #16293; our review is posted there. |
Partial failure cleans successful references only. Failed asset graph state remains retryable. Covers the partial graph-cleanup case from the internal assets QA plan. <details><summary>Full context for agent readers</summary> ## Summary - Adds integration coverage for two graph nodes sharing a successfully deleted asset reference. - Verifies partial bulk deletion clears every successful reference while preserving the failed asset's preview, widget value, and callback state. - Verifies missing-media receives successful variants only and workflow state is captured once after widget cleanup. ## Test plan - `pnpm test:unit src/platform/assets/composables/useMediaAssetActions.test.ts` (50 passed, 1 expected failure) - `pnpm typecheck` - `pnpm exec eslint src/platform/assets/composables/useMediaAssetActions.test.ts` - `pnpm exec oxlint --type-aware src/platform/assets/composables/useMediaAssetActions.test.ts` - `pnpm exec oxfmt --check src/platform/assets/composables/useMediaAssetActions.test.ts` - `pnpm knip:no-cache` - Mutation proof: removing the fulfilled-result filter fails the new test because failed asset variants enter cleanup. Stacked on #16244; review this PR's single commit. </details>
Summary
deleteAssetsTest plan
pnpm test:unit src/platform/assets/composables/useMediaAssetActions.test.ts(49 passed, 1 expected failure)pnpm typecheckpnpm exec eslint src/platform/assets/composables/useMediaAssetActions.test.tspnpm exec oxlint --type-aware src/platform/assets/composables/useMediaAssetActions.test.tspnpm exec oxfmt --check src/platform/assets/composables/useMediaAssetActions.test.tspnpm knipStacked on #16236 so the graph cleanup guard follows the deletion lifecycle coverage chain.