Repository navigation
test(assets): cover successful deletion lifecycle - #16234
Conversation
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1902 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T12:16:12.423Z",
"gitSha": "772ef0201ce0bbadd6bc5506fe4b9d768035863e",
"branch": "test/assets-delete-success",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2084.2139999999745,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.99,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.48,
"heapDeltaBytes": 6999236,
"heapUsedBytes": 76918864,
"domNodes": -279,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.706,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2058.616000000029,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.075,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.20699999999994,
"heapDeltaBytes": 9498452,
"heapUsedBytes": 79847116,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.569000000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.059000000032,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.633000000000003,
"layouts": 14,
"layoutDurationMs": 3.6470000000000002,
"taskDurationMs": 757.7890000000001,
"heapDeltaBytes": -8856280,
"heapUsedBytes": 61789288,
"domNodes": -279,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 122.52499999999999,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1717.4560000000838,
"styleRecalcs": 73,
"styleRecalcDurationMs": 26.921,
"layouts": 14,
"layoutDurationMs": 3.314,
"taskDurationMs": 739.3530000000001,
"heapDeltaBytes": 3691300,
"heapUsedBytes": 74599232,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 116.93400000000001,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.9060000000163,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.35,
"layouts": 6,
"layoutDurationMs": 0.9680000000000001,
"taskDurationMs": 332.79900000000004,
"heapDeltaBytes": 5004384,
"heapUsedBytes": 75813244,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.833000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.9939999998842,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.950000000000003,
"layouts": 6,
"layoutDurationMs": 0.9629999999999999,
"taskDurationMs": 319.21,
"heapDeltaBytes": 5032140,
"heapUsedBytes": 75777612,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.360999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 581.5540000000965,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.404999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.96200000000005,
"heapDeltaBytes": -8203132,
"heapUsedBytes": 62559872,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 131.909,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 584.9279999999908,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.381000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.95099999999996,
"heapDeltaBytes": -8194800,
"heapUsedBytes": 62494472,
"domNodes": 20,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 130.445,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2023.225000000025,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.3429999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.1049999999998,
"heapDeltaBytes": -13436864,
"heapUsedBytes": 87223372,
"domNodes": -267,
"jsHeapTotalBytes": -1363968,
"scriptDurationMs": 29.572000000000006,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2035.6490000001486,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.42,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.6990000000001,
"heapDeltaBytes": 11899368,
"heapUsedBytes": 87351244,
"domNodes": -265,
"jsHeapTotalBytes": -2187264,
"scriptDurationMs": 28.118000000000006,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2148.0040000000145,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.582999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1344.4129999999998,
"heapDeltaBytes": 8209180,
"heapUsedBytes": 85074312,
"domNodes": -272,
"jsHeapTotalBytes": -651264,
"scriptDurationMs": 630.6129999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2101.897000000008,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.328999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1285.1849999999997,
"heapDeltaBytes": 22306572,
"heapUsedBytes": 88267548,
"domNodes": -267,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 600.329,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3127.520000000004,
"styleRecalcs": 61,
"styleRecalcDurationMs": 7.897999999999999,
"layouts": 60,
"layoutDurationMs": 9.212000000000002,
"taskDurationMs": 1367.2,
"heapDeltaBytes": 12050776,
"heapUsedBytes": 79638628,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 584.3770000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3172.616000000062,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.284999999999998,
"layouts": 60,
"layoutDurationMs": 10.245000000000001,
"taskDurationMs": 1372.3449999999998,
"heapDeltaBytes": 8486344,
"heapUsedBytes": 75890248,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 583.112,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2314.1669999999976,
"styleRecalcs": 40,
"styleRecalcDurationMs": 3.3000000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1511.8910000000003,
"heapDeltaBytes": 18155824,
"heapUsedBytes": 85604020,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 716.3470000000001,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2356.027999999924,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.857000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1522.5819999999999,
"heapDeltaBytes": 17755668,
"heapUsedBytes": 85203680,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 722.693,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2004.2929999999615,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.1059999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.2209999999999,
"heapDeltaBytes": 21775800,
"heapUsedBytes": 87669908,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.88099999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 1999.1749999999229,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.1130000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.812,
"heapDeltaBytes": 21929404,
"heapUsedBytes": 87697476,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.870000000000008,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.5580000000418,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.892999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.769,
"heapDeltaBytes": 15172360,
"heapUsedBytes": 86951016,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 115.96000000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 568.9099999999598,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.281000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.345,
"heapDeltaBytes": 14367080,
"heapUsedBytes": 86459240,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 113.08200000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.1159999999727,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.343,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.7100000000001,
"heapDeltaBytes": -8041844,
"heapUsedBytes": 64736148,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.979999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.5080000000435,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.549999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.74199999999996,
"heapDeltaBytes": -13181368,
"heapUsedBytes": 59311968,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.127000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1736.4999999999782,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.955999999999996,
"layouts": 18,
"layoutDurationMs": 3.858,
"taskDurationMs": 713.6410000000001,
"heapDeltaBytes": -10358652,
"heapUsedBytes": 62453824,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 79.716,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.7839999998996,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.724000000000004,
"layouts": 18,
"layoutDurationMs": 3.837,
"taskDurationMs": 705.0730000000001,
"heapDeltaBytes": 2522352,
"heapUsedBytes": 75411720,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 78.63600000000001,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1032.0420000000468,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.125999999999998,
"layouts": 16,
"layoutDurationMs": 11.458999999999996,
"taskDurationMs": 795.0919999999996,
"heapDeltaBytes": 19959644,
"heapUsedBytes": 103592448,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 24.931999999999995,
"eventListeners": 2381,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8261.635999999953,
"styleRecalcs": 248,
"styleRecalcDurationMs": 26.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4937.661,
"heapDeltaBytes": -11791912,
"heapUsedBytes": 89388620,
"domNodes": -268,
"jsHeapTotalBytes": -1662976,
"scriptDurationMs": 2148.7219999999998,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8202.416999999969,
"styleRecalcs": 248,
"styleRecalcDurationMs": 25.822,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4780.958,
"heapDeltaBytes": -11736624,
"heapUsedBytes": 89413628,
"domNodes": -266,
"jsHeapTotalBytes": -1662976,
"scriptDurationMs": 2070.415,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14401.893000000087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13309.012,
"heapDeltaBytes": -8069392,
"heapUsedBytes": 180275648,
"domNodes": -6548,
"jsHeapTotalBytes": 8114176,
"scriptDurationMs": 226.46,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13376.711000000114,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12669.807999999999,
"heapDeltaBytes": -30823364,
"heapUsedBytes": 177707440,
"domNodes": -6548,
"jsHeapTotalBytes": -2117632,
"scriptDurationMs": 203.237,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17674.769000000084,
"styleRecalcs": 161,
"styleRecalcDurationMs": 19.473000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17255.888,
"heapDeltaBytes": -12064936,
"heapUsedBytes": 189924484,
"domNodes": -6548,
"jsHeapTotalBytes": -606208,
"scriptDurationMs": 907.65,
"eventListeners": -7469,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17372.30700000009,
"styleRecalcs": 143,
"styleRecalcDurationMs": 17.897999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16896.068,
"heapDeltaBytes": -16151100,
"heapUsedBytes": 186247528,
"domNodes": -6548,
"jsHeapTotalBytes": 3325952,
"scriptDurationMs": 856.4040000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 15,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4961.699999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.711,
"layouts": 20,
"layoutDurationMs": 22.42699999999999,
"taskDurationMs": 4769.995,
"heapDeltaBytes": -26382880,
"heapUsedBytes": 178998000,
"domNodes": -6548,
"jsHeapTotalBytes": 11931648,
"scriptDurationMs": 93.41099999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 218,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4695.204000000103,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.784,
"layouts": 20,
"layoutDurationMs": 22.17100000000001,
"taskDurationMs": 4534.030000000001,
"heapDeltaBytes": -30267132,
"heapUsedBytes": 179874228,
"domNodes": -6548,
"jsHeapTotalBytes": 10309632,
"scriptDurationMs": 80.94500000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 172,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 90.87399999998524,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.353000000000002,
"layouts": 2,
"layoutDurationMs": 1.0299999999999998,
"taskDurationMs": 57.61400000000001,
"heapDeltaBytes": 3069060,
"heapUsedBytes": 71503868,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.596,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 459.1630000002169,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.027,
"layouts": 3,
"layoutDurationMs": 1.4569999999999999,
"taskDurationMs": 96.498,
"heapDeltaBytes": 4905336,
"heapUsedBytes": 73109408,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.755000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-16234.vercel.app This commit: https://website-frontend-88m1ht3vk-comfyui.vercel.app Last updated: 2026-09-01T08:03:12Z for |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16234 +/- ##
==========================================
+ Coverage 80.75% 82.35% +1.60%
==========================================
Files 2440 2031 -409
Lines 124479 117254 -7225
Branches 31124 31276 +152
==========================================
- Hits 100525 96568 -3957
+ Misses 23452 20508 -2944
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
a272794 to
c74e247
Compare
|
@coderabbitai review |
|
|
Cross-reference with one important exception: most of this PR's added content is contained in #16293, but three lines are NOT - and they are a genuine ordering contract the aggregate lacks: expect(mockUpdateInputs).toHaveBeenCalledOnce()
expect(mockSetAssetDeleting.mock.invocationCallOrder[0]).toBeLessThan(mockDeleteAsset.mock.invocationCallOrder[0])
expect(mockUpdateInputs.mock.invocationCallOrder[0]).toBeLessThan(mockSetAssetDeleting.mock.invocationCallOrder[1])This pins the deletion flow's ordering: the deleting flag is set before the network delete fires, and inputs refresh before the flag clears. Reordering either produces a stale-state flash or an early-clearing spinner, and nothing else in the suite catches it. (Cross-mock So: please do NOT close this as a duplicate. Either fold these three lines into #16293 before it lands, or land this PR after #16293 carrying only this remainder. |
DrJKL
left a comment
There was a problem hiding this comment.
The test covers the confirmed deletion lifecycle and the meaningful ordering contract around loading state, deletion, input refresh, and cleanup. Focused Vitest passes 47/47; typecheck, scoped ESLint, and format checks pass. The lone failing trailer check is using an unrelated stale commit range and is not caused by this PR.
c74e247 to
d928be4
Compare
d928be4 to
50b2fa0
Compare
|
@coderabbitai review |
|
There was a problem hiding this comment.
It's a little bit "testing specific implementation details"
Full context for agent readers
Summary
Adds one orchestration test for successful deletion of a real input Asset record.
Changes
assetService.deleteAssetonce.Review Focus
This closes the frontend orchestration portion of that case. Endpoint construction remains covered by
assetService.test.ts; backend lifecycle semantics remain separate contract cases.Validation:
useMediaAssetActions.test.ts: 48/48 passedpnpm typecheck: passedpnpm knip: passed