Skip to content

test(agent): reserve workspace-inset coverage for slice 05 - #16227

Closed
christian-byrne wants to merge 89 commits into
nathaniel/agent-v1/05-shared-ui-mediafrom
christian-byrne/reserve-qa-slice05
Closed

christian-byrne wants to merge 89 commits into
nathaniel/agent-v1/05-shared-ui-mediafrom
christian-byrne/reserve-qa-slice05

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Active workspace-inset E2E coverage reserved for slice 05 exact head 9f3023cfac1a54a1c0d33f2e02694f92033ce3b1.

Full context for agent readers

Splits the slice-05 Load3D case from QA draft #16217 and activates it on the branch that owns the shared media/dialog behavior. It verifies the full-screen viewer remains inside the visible workspace inset.

Validation: git diff --check passed. Browser execution was not available in this dependency-free reservation clone.

CodeJuggernaut and others added 30 commits August 26, 2026 18:18
Lands the agent shell dark behind the existing PostHog flag
agent-in-app-experience: the gate wiring (extension setup syncing the
flag into the panel store), the Ask Comfy Agent topbar entry button,
a stub docked panel mounted in graph and linear views, and the
flag-off E2E proving no agent surface renders while the flag is off.

The stub intentionally omits what later slices own: engagement
telemetry and detection, panel resize and maximize, the workspace
inset, selection-driven chrome hiding, and the full panel content.
File paths match the feature branch so later slices replace stub
content in place.
Rapid or overlapping workflow opens, closes, and subgraph hash
navigations could interleave: a slower earlier load could overwrite a
newer selection, closing a workflow could re-activate it, and stale
hash navigations could move the canvas after a newer one. Workflow
loads now run through a serialized queue with per-path pending
tracking and re-entrant close accounting; hash/graph synchronization
carries navigation intent ids so only the newest intent can write the
route or move the canvas.

Test-led split from the agent feature branch: the added service and
navigation-store tests pin the contract - 13 of them fail against the
previous implementation - and only non-agent hunks are extracted (the
new extension load hooks stay on the feature branch with their
consumer).
The full-suite baseline caught main's navigateToHash suite failing
against the extracted intent-id signature: the feature branch had
extended that suite (+557) plus app.test.ts's intent-forwarding case,
and the initial extraction missed both. Both are taken now; the
app.test.ts case covering the excluded extension load hooks stays on
the feature branch with its subject.
Eight-hat review round on the shell PR; the convergent findings:

- Register the gate extension in the cloud block, where the PostHog
  flag actually exists and the SDK is initialized - the misplaced
  !isCloud registration made the panel unreachable in every shipped
  build, failed the cloud E2E job, and leaked posthog-js into the
  OSS dist scan.
- Force-enable dev builds BEFORE the SDK import so a blocked chunk
  cannot take local development down, and add a bounded retry that
  re-takes the flag subscription when extension setup wins the race
  against posthog initialization (pre-init subscriptions are dead).
  The gate marks a body dataset when settled so the flag-off E2E
  asserts after gating actually ran, anchored by the tab-bar
  container being visible.
- Restructure LinearView like the canvas overlay (row root + column
  wrapper) so the docked panel is a right-hand sibling instead of
  stacking below the workspace; pinned by a placement test.
- Replace the entry chip's fixed ink-700 fill with a semantic
  surface token (the fixed hex under a theme-flipping foreground
  computed 1.11:1 in light themes) and add aria-pressed.
- Rebuild the E2E boot mocks on the shared mockCloudBoot helper
  instead of a hand-rolled route fork.
- Trim agentTheme.css to the four consumed tokens (the trimmed rest
  returns with its consumers and keyframes in later slices), drop
  the width ref and dead guards from the store, drop the dead shell
  testid and alias click handler, and merge the async component into
  the setup block with a complementary landmark role.
- New gate composition tests (flag on/off/flip, init race, blocked
  SDK), a close-button test for the panel root, a legacy-tab-bar
  gating case, and a real enable/disable transition in the store
  persistence test.
The cloud E2E run proved the registration fix end to end (the flag-on
test passed against the production build) but the flag-off spec timed
out awaiting the settle marker: posthog drops false-valued bootstrap
flags, so isFeatureEnabled legitimately stays undefined forever when
the flag is off and settle only arrived at retry exhaustion (~30s).
The retry budget only needs to cover telemetry's init window, so it
shrinks to ~5s worst case, exhaustion being the settled fail-closed
state, and the spec awaits settle with an explicit window.
Round-2 panel residuals on the gate: readiness now settles on an
observed flags delivery OR a definite flag read, the resolved path no
longer stacks a second subscription, and the exhausted path re-takes
the subscription against the by-now live instance before settling -
so a flag that first appears mid-session still propagates instead of
waiting for a reload. The unit mock now models the off state the way
the real SDK reports it (undefined, never false) and pins the
exhausted-then-arrives path. Also: the close button reuses g.close
instead of minting a duplicate key, and the store drops the
consumer-less open().
…delivery

Round-2 panels caught the rework's own regression with the SDK source
as receipt: uninitialized posthog invokes the onFeatureFlags callback
synchronously with errorsLoading and registers nothing, so the
delivered signal fired against a dead subscription and pinned the
panel off for the session - the exact race the retry defends. The
flag source now filters error-context callbacks before they reach the
listener, the unit double models the real pre-init contract (fires
once, registers nothing, undefined flags) and the race test asserts a
live subscription exists after recovery. The retry constants are
exported so tests pace off the real values, the settle window fits
inside the cloud project's test timeout with actual headroom, and the
E2E mocks drop a hand-rolled auth-token route that shadowed the
shared workspace mint.
Eight-hat review round; the convergent findings:

- Pass suppressWorkflowReset=false at the two import call sites
  (importA1111, loadApiJson) - they reset to root with no later
  workflow-load hash republish, so the armed suppression left the URL
  on a destroyed subgraph id; pinned by new app tests covering both
  branches of the clean flag.
- Capture the closing workflow's path once at closeWorkflow entry: a
  rename mid-close mutates workflow.path in place, and the live
  re-read in the finally would strand a phantom closingWorkflowCounts
  entry that silently no-ops every future open of that path.
- Restore main's last-workflow fallback for an inactive close: the
  sole open workflow closing while inactive now still creates the
  default workflow.
- Log queued-load failures inside the serialization chain: attaching
  the internal handler marks the caller's promise handled, which had
  silenced fire-and-forget failures.
- Test hardening: a module-state reset hook with per-test leak
  assertions, the active-workflow no-op guard pinned from both sides,
  a reopen-after-close-settles case, the misleadingly named
  clean-flag test renamed, and a shadowed parameter renamed.
Tree-shaking: the cloud extension block now gates on the literal
__DISTRIBUTION__ comparison - the cross-module isCloud const does not
dead-code-eliminate, so the gate's posthog-js import was shipping into
OSS and desktop bundles (measured +289KB; the localhost build now
scans clean and the vendor chunk returns to baseline). The gate's
retry/re-take machinery is deleted: the shipped posthog bundle
constructs its featureFlags extension in the constructor, so a
pre-init subscription registers and survives init() (probe-verified);
what remains is the errorsLoading filter, a settle timeout for the
no-token path, and a dev force-enable that now honours the ff:
localStorage override in both directions. The gate's settle signal
moved off document.body onto a store ref bound as a data attribute on
the tab-bar actions container, and its constants moved out of
extensions/core so nothing new lands on the window.comfyAPI surface.

Layout and a11y: the dock width is a proportional cap
(min(420px, 33%)) so narrow viewports and the linear arrange panels
can no longer be clipped dead; the panel title is a real heading the
landmark references via aria-labelledby; borders unify on
interface-stroke and the four-token alias theme file is deleted in
favour of design-system tokens.

Structure: the extension tree flattens to the manager exemplar's
shape (stores/, utils/, components/agent/), and the E2E fixture moves
to fixtures/ and drives a raw page like the cloud siblings - with the
assets mock typed against ListAssetsResponse and the posthog ingest
host routed so CI emits no live third-party traffic.

Tests: real-contract gate coverage replaces the mock-manufactured
race tests, dev force-enable and blocked-import paths are pinned,
aria-pressed and the settle attribute are asserted, the graph-side
mount invariants are pinned, and the hollow store case is replaced
with a writeDefaults pin.
- key the closing-workflow registry by raw workflow object identity
- queue default/blank/duplicate loads through the same load queue
- bound the close-drain and skip it when no workflow is open
- release a failed workflow-load navigation intent and restore the hash
- move the workflow-load hash publish into loadGraphData's finally
- pin the close-race orderings and the intent release in unit tests
- new-surface mutation battery left this guard undiscriminated: the
  existing replacement test's interleaving empties the closing window
  before the shift loop runs
- hold the neighbor's close inside the store call so it is still open
  AND registered at decision time, then assert the fallback lands on
  the survivor and never the closing neighbor
- a blocked posthog import only reached console.error; it now also
  calls reportError with the stable agent_flag_gate_load_failure
  type, so the failure is queryable in Sentry and RUM
- fail-closed settling and the dev force-enable are unchanged and
  both paths pin the report in the gate tests
- swap the store test onto createTestingPinia({stubActions:false})
  per the repo's testing-pinia convention
- pin that disabling the flag mid-session never wipes the stored
  open preference
- give the async panel root a Suspense fallback so the dock frame
  never flashes empty chrome
…w nits

- the nav recovery catch and the queued-load catch now also call
  reportError with stable types (workflow_navigation_failure,
  workflow_load_failure), keeping each site's redirect and
  queue-continue behavior
- pin that a stale workflow-load publish reapplies the latest graph
  intent and clears the pending reset suppression (the finally
  publish is what prevents the suppression leak on a failed load)
- detect the default load by its payload, not a missing argument
The Aug-12 review's one Request-Changes gap, still live: closeWorkflow
deleted the draft at the top of the try, so a replacement load that
fails (which now rethrows) left the tab open with its draft already
gone. The draft is removed only after the store close is real, and the
regression pin asserts a failed replacement keeps both the tab and the
draft.
… source

Two comment anchors naming which coordination primitives the ECS
per-document milestone deletes and which survive, so the supersession
is greppable from the code as well as the decision log and PR body.
Same treatment the crdt files got: every multi-line justification
block drops to the one invariant the code cannot show.
A real configure failure is caught inside loadGraphData (dialog, then
resolve), so the close path never saw it and deleted the draft of a
tab that stayed open over a never-painted graph. loadGraphData now
returns an explicit outcome; openWorkflow and loadDefaultWorkflow
thread it; closeWorkflow aborts on an explicit failure report through
its existing not-closed contract, releasing the load's navigation
intent and skipping warnings for a graph that never painted. The
regression tests drive the real failure shape: rootGraph.configure
throwing, not a mocked rejection.
The docked panel's complementary landmark lost its accessible name while
the async panel body loaded; the Suspense fallback now carries a
visually-hidden agent-panel-title heading with the same translated
string, covered in loading and resolved states. The dock-siblinghood
test now mounts the splitter overlay and asserts the rendered structure
instead of pinning source text; the linear-mode guard stays a source pin
because GraphCanvas cannot mount in the unit environment. The dock width
moves from an arbitrary min() to w-1/3 max-w-[420px].
A rejected AgentPanelRoot load left the Suspense fallback up forever
with nothing reported. The dock now acts as an error boundary: the
failure reaches reportError under agent_panel_load_failure and the
panel renders a localized error state that keeps the landmark named.
Also drops a non-null assertion in the mount test for optional
chaining.
OSS builds now emit no agent chunk and carry no agent code: the dock
mounts and tab-bar button sit behind the distribution literal (new
useAgentDockMount seam), and the flag gate follows the initTelemetry
idiom - the guard lives inside the retained function with every agent
module imported dynamically past it, so the dead remainder and its
import edges fold away, taking posthog-js with them. Cloud builds
inline the gate into the core graph instead of fetching a separate
extension chunk, and the panel body chunks load only once the gate
enables and the panel opens. Verified by dist scans of both
distributions.
The follower doc, wire schema and frame client, mint ports, litegraph
mutator and semantic projector, layout follower bridge, op envelope and
sender, schema guard, and the dev panel - all flag-gated and inert with
no consumer in this slice (activation arrives with the agent stack).
Carries the beforeLoadGraph/afterLoadGraph extension hooks, the
layoutStore withActor scope, graph traversal support, the four
transport prompt-error registrations with their locale entries, the
comfy-multi-player dependency with its license-scan exclusion, ADR-0020
and the follower boundary check. Transitional knip entries mark the
tree until slices 07+ import it.
…heet

- rename ADR 0020 -> 0024 (main already carries 0020-0023), fix its H1,
  update all references, add the missing README index row
- correct the license-exclusion comment: the pinned package declares
  GPL-3.0-only and ships a LICENSE file
- genericize RUN-CLOUD-E2E.md (no internal hosts or names) and note the
  follower has no mount site until the agent-panel slice
- install __agentCrdtPoc only under import.meta.env.DEV
- update stale PoC comments; document both load hooks in
  docs/extensions/core.md including the configure-failure asymmetry
- port the child's graph-load hook test and pin once-each-in-order
- pin afterLoadGraph skipped when graph configure fails
- cover the four agent prompt-error types in the resolver suite
- document beforeLoadGraph/afterLoadGraph pairing on ComfyExtension
- dedupe findSubgraphPathById/findSubgraphNodePathById via a shared walk
- reject async callbacks in layoutStore.withActor, with a pinning test
- exercise the traversal walker's malformed-subgraph guard
- remove the comfy-multi-player license-scan exclusion: the pinned
  package declares GPL-3.0-only (allowlisted), and keeping the check
  live guards future pin bumps of a git-ref dependency
- render CrdtDevPanel only in dev builds; knip tracks it via ignore
  instead of entry so unused-export reporting stays live for the tree
- reword the ADR and boundary-check lines that asserted an env gate
  that does not exist on this branch
- correct the afterLoadGraph JSDoc: neither after-hook fires on a
  configure failure; brackets reset at the next beforeLoadGraph and
  close on afterConfigureGraph (superset of this hook's cases)
- pin the full four-hook load order in the app suite
- widen withActor's guard to thenables, report through the assert
  seam, neutralize the orphaned rejection, and pin actor restoration
- dev panel: init open state and start the poll interval only in dev
  builds (the render gate alone left prod lifecycle effects running)
- symmetric DEV gate on the console-helper teardown delete
- ADR: drop the dev-rendered claim, name the stopgap product-flag-gated,
  future-tense the mount statement
- run sheet: point Verify at the dev panel's real testid
…ooks

- the guard asserts, not throws: DEV throws, production reports and
  returns the thenable - say so on the method
- the configure-fail test now pins that afterConfigureGraph is also
  skipped, completing the documented two-hook promise
@github-actions

github-actions Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1883 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1862 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 110ms TBT · 101.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.0 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 25ms TBT · 170.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 429ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.0 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -171
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 26ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 675ms
canvas-mouse-sweep: script duration 102ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.4 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -170
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 289ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.3 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 326ms
dom-widget-clipping: script duration 112ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 80.9 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 479ms
large-graph-idle: script duration 25ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 84.5 MB
large-graph-idle: DOM nodes -265
large-graph-idle: event listeners -151
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 7ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1206ms
large-graph-pan: script duration 592ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.4 MB
large-graph-pan: DOM nodes -130
large-graph-pan: event listeners -73
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 9ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1288ms
large-graph-zoom: script duration 579ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.6 MB
large-graph-zoom: DOM nodes 6
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 4ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1383ms
legacy-node-drag: script duration 673ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.1 MB
legacy-node-drag: DOM nodes 4
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 465ms
minimap-idle: script duration 26ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.7 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -88
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 327ms
subgraph-dom-widget-clipping: script duration 104ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.1 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 415ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.4 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -232
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 24ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 613ms
subgraph-mouse-sweep: script duration 68ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.4 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 712ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 110ms
subgraph-transition-enter: heap used 101.2 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 21ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4449ms
viewport-pan-sweep: script duration 2036ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 75.9 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -152
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10851ms
vue-large-graph-idle: script duration 155ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.0 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7476
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 10ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 68
vue-large-graph-pan: task duration 13401ms
vue-large-graph-pan: script duration 690ms
vue-large-graph-pan: TBT 25ms
vue-large-graph-pan: heap used 170.1 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7472
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 4
workflow-execution: style recalc count 13
workflow-execution: task duration 79ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.1 MB
workflow-execution: DOM nodes 171
workflow-execution: event listeners 88
Raw data
{
  "timestamp": "2026-08-29T10:02:29.805Z",
  "gitSha": "75a2cf76b78f43a04854342d867c30bdfeca235b",
  "branch": "christian-byrne/reserve-qa-slice05",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2041.8540000000007,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.814999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.409,
      "heapDeltaBytes": 2379660,
      "heapUsedBytes": 66113096,
      "domNodes": -280,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 9.357000000000001,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.024000000035,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.248,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.598,
      "heapDeltaBytes": -11364016,
      "heapUsedBytes": 57675984,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 6.066999999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1710.4199999999992,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 25.977,
      "layouts": 14,
      "layoutDurationMs": 3.4419999999999997,
      "taskDurationMs": 690.6,
      "heapDeltaBytes": -7167900,
      "heapUsedBytes": 61849404,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 99.382,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1710.3510000000028,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.703999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.5789999999999997,
      "taskDurationMs": 659.2059999999999,
      "heapDeltaBytes": -2811292,
      "heapUsedBytes": 60698000,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 103.83,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1670.7309999999893,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 12.677999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.0559999999999998,
      "taskDurationMs": 291.497,
      "heapDeltaBytes": 3789332,
      "heapUsedBytes": 67722016,
      "domNodes": 78,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 7.964,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1658.1100000000788,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 11.790000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.8800000000000001,
      "taskDurationMs": 285.94,
      "heapDeltaBytes": 4417152,
      "heapUsedBytes": 73388024,
      "domNodes": 78,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 7.723000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 524.3350000000078,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.115000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 330.584,
      "heapDeltaBytes": 18056472,
      "heapUsedBytes": 81897580,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 114.344,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 512.593000000038,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.731,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 321.425,
      "heapDeltaBytes": 19406992,
      "heapUsedBytes": 87679960,
      "domNodes": 20,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 108.81,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2001.2669999999844,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.342000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.56999999999994,
      "heapDeltaBytes": 24070052,
      "heapUsedBytes": 88752028,
      "domNodes": -265,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 26.250999999999998,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2014.6220000000312,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.801000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.065,
      "heapDeltaBytes": -12112836,
      "heapUsedBytes": 88476956,
      "domNodes": -264,
      "jsHeapTotalBytes": -2105344,
      "scriptDurationMs": 24.48,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2082.195000000013,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 6.254,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1189.27,
      "heapDeltaBytes": 19832260,
      "heapUsedBytes": 84937560,
      "domNodes": 8,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 581.674,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2115.5780000000277,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 7.574999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1221.8229999999999,
      "heapDeltaBytes": 20714760,
      "heapUsedBytes": 85685776,
      "domNodes": -267,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 601.798,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3147.418000000016,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 7.908999999999999,
      "layouts": 60,
      "layoutDurationMs": 8.848,
      "taskDurationMs": 1313.65,
      "heapDeltaBytes": 10929752,
      "heapUsedBytes": 77400100,
      "domNodes": 6,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 605.097,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3092.2950000000355,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.217999999999998,
      "layouts": 60,
      "layoutDurationMs": 8.671999999999999,
      "taskDurationMs": 1262.127,
      "heapDeltaBytes": 10253920,
      "heapUsedBytes": 76862404,
      "domNodes": 6,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 553.3480000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2144.2599999999743,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 3.615999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1365.6209999999999,
      "heapDeltaBytes": 17769024,
      "heapUsedBytes": 85238252,
      "domNodes": 4,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 660.125,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2264.4639999999754,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 3.603000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1400.9080000000001,
      "heapDeltaBytes": 17410780,
      "heapUsedBytes": 84878836,
      "domNodes": 4,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 686.8689999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2000.0840000000153,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.2900000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.45099999999996,
      "heapDeltaBytes": 23740656,
      "heapUsedBytes": 88579800,
      "domNodes": -270,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 25.120000000000005,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2011.288000000036,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.9700000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.9599999999999,
      "heapDeltaBytes": 23869032,
      "heapUsedBytes": 89097824,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 27.069000000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 524.2370000000278,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 8.023000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 310.809,
      "heapDeltaBytes": 14775732,
      "heapUsedBytes": 80046076,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 95.44599999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 546.0000000000491,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.868999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 343.346,
      "heapDeltaBytes": 14808740,
      "heapUsedBytes": 85901648,
      "domNodes": 20,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 113.247,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.4399999999782,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.648999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.65399999999994,
      "heapDeltaBytes": 845632,
      "heapUsedBytes": 72044708,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 5.963000000000001,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.752999999956,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.6160000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.77200000000005,
      "heapDeltaBytes": 2235924,
      "heapUsedBytes": 73474964,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.255999999999999,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1695.0499999999806,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 23.880000000000003,
      "layouts": 18,
      "layoutDurationMs": 3.649,
      "taskDurationMs": 620.9520000000001,
      "heapDeltaBytes": 3217532,
      "heapUsedBytes": 74451892,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 67.54,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1689.436999999998,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 23.318,
      "layouts": 18,
      "layoutDurationMs": 3.706,
      "taskDurationMs": 604.4730000000001,
      "heapDeltaBytes": -12250624,
      "heapUsedBytes": 58509572,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 67.628,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 916.3340000000062,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.780999999999995,
      "layouts": 16,
      "layoutDurationMs": 10.933,
      "taskDurationMs": 712.281,
      "heapDeltaBytes": 23714920,
      "heapUsedBytes": 106144264,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 20.836000000000002,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 110,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8195.812999999987,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 21.114,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4569.231000000001,
      "heapDeltaBytes": 17190596,
      "heapUsedBytes": 92437188,
      "domNodes": -270,
      "jsHeapTotalBytes": 180224,
      "scriptDurationMs": 2108.1119999999996,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8137.736000000018,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 20.952,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4328.0599999999995,
      "heapDeltaBytes": -29163144,
      "heapUsedBytes": 66657712,
      "domNodes": -267,
      "jsHeapTotalBytes": -794624,
      "scriptDurationMs": 1964.4920000000002,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11958.945000000029,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10889.353,
      "heapDeltaBytes": -26902664,
      "heapUsedBytes": 175047772,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4513792,
      "scriptDurationMs": 155.601,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11833.970000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10812.181,
      "heapDeltaBytes": -36053136,
      "heapUsedBytes": 175215840,
      "domNodes": -6548,
      "jsHeapTotalBytes": 479232,
      "scriptDurationMs": 153.65,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14013.658999999961,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 10.478999999999989,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13394.765000000001,
      "heapDeltaBytes": -30454092,
      "heapUsedBytes": 176029056,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1720320,
      "scriptDurationMs": 679.3710000000001,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14049.033000000009,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 10.182000000000023,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13406.632000000001,
      "heapDeltaBytes": -41204152,
      "heapUsedBytes": 180641108,
      "domNodes": -6548,
      "jsHeapTotalBytes": -9183232,
      "scriptDurationMs": 700.634,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 49,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.1870000000422,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 16.639,
      "layouts": 3,
      "layoutDurationMs": 1.2529999999999997,
      "taskDurationMs": 91.20500000000001,
      "heapDeltaBytes": 5318544,
      "heapUsedBytes": 72053404,
      "domNodes": 150,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.507000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 82.21499999990556,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 12.301,
      "layouts": 4,
      "layoutDurationMs": 1.2850000000000001,
      "taskDurationMs": 65.974,
      "heapDeltaBytes": 3668128,
      "heapUsedBytes": 70773400,
      "domNodes": 191,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.612999999999999,
      "eventListeners": 79,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 29, 2026
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                            Coverage Diff                            @@
##           nathaniel/agent-v1/05-shared-ui-media   #16227      +/-   ##
=========================================================================
+ Coverage                                  80.77%   82.80%   +2.03%     
=========================================================================
  Files                                       2344     1972     -372     
  Lines                                     120199   113898    -6301     
  Branches                                   34779    33339    -1440     
=========================================================================
- Hits                                       97093    94316    -2777     
+ Misses                                     22544    19243    -3301     
+ Partials                                     562      339     -223     
Flag Coverage Δ
e2e 66.65% <ø> (+0.01%) ⬆️
unit 75.71% <ø> (ø)
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 378 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Aug 30, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 7 finding(s).

Severity Count
🟡 Medium 3
🟢 Low 3
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

await load3d.openViewerButton.click()
await viewer.waitForOpen()

const dialogBox = await viewer.dialog.boundingBox()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — waitForOpen() only awaits visibility, which is satisfied on the first frame of the dialog's zoom-in-95/fade-in enter animation, and boundingBox() neither retries nor waits for stability. A mid-animation read returns a box that is scaled down and more centered than the settled layout, biasing every upper-bound assertion below toward passing even when the settled dialog overflows the inset. Wrap the measurement in expect.poll(() => viewer.dialog.boundingBox()) (as comboWidget.spec.ts does) or disable animations first. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).

const viewport = comfyPage.page.viewportSize()
expect(dialogBox).not.toBeNull()
expect(viewport).not.toBeNull()
expect(dialogBox!.x).toBeGreaterThanOrEqual(0)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — All four assertions are one-sided (>= 0 and <= upper bound), so a degenerate box at the origin satisfies every one of them and the test passes vacuously. A regression that over-subtracts in the max-w calc and collapses the dialog to a few pixels would be reported green, since toBeVisible() only requires a non-empty rect. Add lower bounds on dialogBox.width/height like the sibling smoke test at lines 34-36. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

}
)

test('keeps the full-screen viewer inside the visible workspace inset', async ({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — The title claims coverage of the "full-screen viewer", but only the initial non-maximized state is measured — and that is the one state that is already inset-aware via left-[calc(50%-var(--workspace-inset-right,0px)/2)]. The viewer is opened with maximizable: true, and the maximized: true variant (inset-2 ... max-w-none sm:max-w-none) drops every inset-aware cap, so the actually-broken path stays uncovered behind a reassuring test name. Either click Maximize and assert containment there, or rename the test to match what it checks. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

viewer
}) => {
await comfyPage.page.evaluate(() => {
document.documentElement.style.setProperty(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — --workspace-inset-right is hand-written onto document.documentElement, but that property is owned by useWorkspaceInsetRight, which sets it in a watchEffect and removes it in onScopeDispose. It survives today only because nothing in src/ calls the composable yet; once a docked surface adopts it, the app can overwrite or remove the value between this evaluate and the measurement while the assertions still use the hardcoded 420. Read the effective value back from the DOM, or drive the inset through the composable. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

expect(dialogBox!.x).toBeGreaterThanOrEqual(0)
expect(dialogBox!.y).toBeGreaterThanOrEqual(0)
expect(dialogBox!.x + dialogBox!.width).toBeLessThanOrEqual(
viewport!.width - 420 + 1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This bound is ~9px looser than the behavior it guards: the width cap subtracts 1rem, so the settled right edge sits about 8px inside viewport.width - 420, and the extra + 1 also literally permits a 1px overflow past the workspace edge. Dropping the -1rem term from the viewer's class — exactly the regression this test targets — would still pass. Assert against the expected edge with a small tolerance, and hoist the duplicated 420 into a named constant shared with the injection at line 63 so the two cannot drift apart silently. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

await viewer.waitForOpen()

const dialogBox = await viewer.dialog.boundingBox()
const viewport = comfyPage.page.viewportSize()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Bounds are derived from the runtime viewport while the inset is hardcoded at 420px, so the test silently depends on the chromium project's 1280x720 default. On a narrow viewport the two constraints become unsatisfiable (x >= 0 plus x + width <= width - 419 is impossible below ~420px), and the cap under test is sm:-scoped so it does not even apply there. Pin the viewport with test.use({ viewport: ... }) to make the assumption explicit. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

expect(dialogBox!.x + dialogBox!.width).toBeLessThanOrEqual(
viewport!.width - 420 + 1
)
expect(dialogBox!.y + dialogBox!.height).toBeLessThanOrEqual(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — The vertical assertion cannot fail: the viewer is h-[80vh] capped at max-h-[85vh] and vertically centered, so y + height is always well inside the viewport height. It reads as vertical-containment coverage while being unfalsifiable — drop it, or assert the intended geometry instead. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/05-shared-ui-media branch from 9f3023c to 1c6e239 Compare August 30, 2026 12:03
@christian-byrne
christian-byrne requested review from a team and jtydhr88 as code owners August 30, 2026 12:03
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/05-shared-ui-media branch 4 times, most recently from 87d6f57 to c7b1402 Compare August 30, 2026 16:57
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded — closing per Christian's direction.

Full context for agent readers

Program pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components and removed agent Comfy Agent product, integration, tests or product documentation agent-test-unit Touches Agent-related unit/component tests or their support agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-ui Agent panel, composer, transcript or other user-interface components agent-docs Agent product architecture, contracts or documentation labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants