Repository navigation
test(agent): reserve active canvas coverage for slice 03 - #16225
christian-byrne wants to merge 66 commits into
Conversation
Lands the agent shell dark behind the existing PostHog flag agent-in-app-experience: the gate wiring (extension setup syncing the flag into the panel store), the Ask Comfy Agent topbar entry button, a stub docked panel mounted in graph and linear views, and the flag-off E2E proving no agent surface renders while the flag is off. The stub intentionally omits what later slices own: engagement telemetry and detection, panel resize and maximize, the workspace inset, selection-driven chrome hiding, and the full panel content. File paths match the feature branch so later slices replace stub content in place.
Rapid or overlapping workflow opens, closes, and subgraph hash navigations could interleave: a slower earlier load could overwrite a newer selection, closing a workflow could re-activate it, and stale hash navigations could move the canvas after a newer one. Workflow loads now run through a serialized queue with per-path pending tracking and re-entrant close accounting; hash/graph synchronization carries navigation intent ids so only the newest intent can write the route or move the canvas. Test-led split from the agent feature branch: the added service and navigation-store tests pin the contract - 13 of them fail against the previous implementation - and only non-agent hunks are extracted (the new extension load hooks stay on the feature branch with their consumer).
The full-suite baseline caught main's navigateToHash suite failing against the extracted intent-id signature: the feature branch had extended that suite (+557) plus app.test.ts's intent-forwarding case, and the initial extraction missed both. Both are taken now; the app.test.ts case covering the excluded extension load hooks stays on the feature branch with its subject.
Eight-hat review round on the shell PR; the convergent findings: - Register the gate extension in the cloud block, where the PostHog flag actually exists and the SDK is initialized - the misplaced !isCloud registration made the panel unreachable in every shipped build, failed the cloud E2E job, and leaked posthog-js into the OSS dist scan. - Force-enable dev builds BEFORE the SDK import so a blocked chunk cannot take local development down, and add a bounded retry that re-takes the flag subscription when extension setup wins the race against posthog initialization (pre-init subscriptions are dead). The gate marks a body dataset when settled so the flag-off E2E asserts after gating actually ran, anchored by the tab-bar container being visible. - Restructure LinearView like the canvas overlay (row root + column wrapper) so the docked panel is a right-hand sibling instead of stacking below the workspace; pinned by a placement test. - Replace the entry chip's fixed ink-700 fill with a semantic surface token (the fixed hex under a theme-flipping foreground computed 1.11:1 in light themes) and add aria-pressed. - Rebuild the E2E boot mocks on the shared mockCloudBoot helper instead of a hand-rolled route fork. - Trim agentTheme.css to the four consumed tokens (the trimmed rest returns with its consumers and keyframes in later slices), drop the width ref and dead guards from the store, drop the dead shell testid and alias click handler, and merge the async component into the setup block with a complementary landmark role. - New gate composition tests (flag on/off/flip, init race, blocked SDK), a close-button test for the panel root, a legacy-tab-bar gating case, and a real enable/disable transition in the store persistence test.
The cloud E2E run proved the registration fix end to end (the flag-on test passed against the production build) but the flag-off spec timed out awaiting the settle marker: posthog drops false-valued bootstrap flags, so isFeatureEnabled legitimately stays undefined forever when the flag is off and settle only arrived at retry exhaustion (~30s). The retry budget only needs to cover telemetry's init window, so it shrinks to ~5s worst case, exhaustion being the settled fail-closed state, and the spec awaits settle with an explicit window.
Round-2 panel residuals on the gate: readiness now settles on an observed flags delivery OR a definite flag read, the resolved path no longer stacks a second subscription, and the exhausted path re-takes the subscription against the by-now live instance before settling - so a flag that first appears mid-session still propagates instead of waiting for a reload. The unit mock now models the off state the way the real SDK reports it (undefined, never false) and pins the exhausted-then-arrives path. Also: the close button reuses g.close instead of minting a duplicate key, and the store drops the consumer-less open().
…delivery Round-2 panels caught the rework's own regression with the SDK source as receipt: uninitialized posthog invokes the onFeatureFlags callback synchronously with errorsLoading and registers nothing, so the delivered signal fired against a dead subscription and pinned the panel off for the session - the exact race the retry defends. The flag source now filters error-context callbacks before they reach the listener, the unit double models the real pre-init contract (fires once, registers nothing, undefined flags) and the race test asserts a live subscription exists after recovery. The retry constants are exported so tests pace off the real values, the settle window fits inside the cloud project's test timeout with actual headroom, and the E2E mocks drop a hand-rolled auth-token route that shadowed the shared workspace mint.
Eight-hat review round; the convergent findings: - Pass suppressWorkflowReset=false at the two import call sites (importA1111, loadApiJson) - they reset to root with no later workflow-load hash republish, so the armed suppression left the URL on a destroyed subgraph id; pinned by new app tests covering both branches of the clean flag. - Capture the closing workflow's path once at closeWorkflow entry: a rename mid-close mutates workflow.path in place, and the live re-read in the finally would strand a phantom closingWorkflowCounts entry that silently no-ops every future open of that path. - Restore main's last-workflow fallback for an inactive close: the sole open workflow closing while inactive now still creates the default workflow. - Log queued-load failures inside the serialization chain: attaching the internal handler marks the caller's promise handled, which had silenced fire-and-forget failures. - Test hardening: a module-state reset hook with per-test leak assertions, the active-workflow no-op guard pinned from both sides, a reopen-after-close-settles case, the misleadingly named clean-flag test renamed, and a shadowed parameter renamed.
Tree-shaking: the cloud extension block now gates on the literal __DISTRIBUTION__ comparison - the cross-module isCloud const does not dead-code-eliminate, so the gate's posthog-js import was shipping into OSS and desktop bundles (measured +289KB; the localhost build now scans clean and the vendor chunk returns to baseline). The gate's retry/re-take machinery is deleted: the shipped posthog bundle constructs its featureFlags extension in the constructor, so a pre-init subscription registers and survives init() (probe-verified); what remains is the errorsLoading filter, a settle timeout for the no-token path, and a dev force-enable that now honours the ff: localStorage override in both directions. The gate's settle signal moved off document.body onto a store ref bound as a data attribute on the tab-bar actions container, and its constants moved out of extensions/core so nothing new lands on the window.comfyAPI surface. Layout and a11y: the dock width is a proportional cap (min(420px, 33%)) so narrow viewports and the linear arrange panels can no longer be clipped dead; the panel title is a real heading the landmark references via aria-labelledby; borders unify on interface-stroke and the four-token alias theme file is deleted in favour of design-system tokens. Structure: the extension tree flattens to the manager exemplar's shape (stores/, utils/, components/agent/), and the E2E fixture moves to fixtures/ and drives a raw page like the cloud siblings - with the assets mock typed against ListAssetsResponse and the posthog ingest host routed so CI emits no live third-party traffic. Tests: real-contract gate coverage replaces the mock-manufactured race tests, dev force-enable and blocked-import paths are pinned, aria-pressed and the settle attribute are asserted, the graph-side mount invariants are pinned, and the hollow store case is replaced with a writeDefaults pin.
- key the closing-workflow registry by raw workflow object identity - queue default/blank/duplicate loads through the same load queue - bound the close-drain and skip it when no workflow is open - release a failed workflow-load navigation intent and restore the hash - move the workflow-load hash publish into loadGraphData's finally - pin the close-race orderings and the intent release in unit tests
- new-surface mutation battery left this guard undiscriminated: the existing replacement test's interleaving empties the closing window before the shift loop runs - hold the neighbor's close inside the store call so it is still open AND registered at decision time, then assert the fallback lands on the survivor and never the closing neighbor
- a blocked posthog import only reached console.error; it now also calls reportError with the stable agent_flag_gate_load_failure type, so the failure is queryable in Sentry and RUM - fail-closed settling and the dev force-enable are unchanged and both paths pin the report in the gate tests
- swap the store test onto createTestingPinia({stubActions:false})
per the repo's testing-pinia convention
- pin that disabling the flag mid-session never wipes the stored
open preference
- give the async panel root a Suspense fallback so the dock frame
never flashes empty chrome
…w nits - the nav recovery catch and the queued-load catch now also call reportError with stable types (workflow_navigation_failure, workflow_load_failure), keeping each site's redirect and queue-continue behavior - pin that a stale workflow-load publish reapplies the latest graph intent and clears the pending reset suppression (the finally publish is what prevents the suppression leak on a failed load) - detect the default load by its payload, not a missing argument
The Aug-12 review's one Request-Changes gap, still live: closeWorkflow deleted the draft at the top of the try, so a replacement load that fails (which now rethrows) left the tab open with its draft already gone. The draft is removed only after the store close is real, and the regression pin asserts a failed replacement keeps both the tab and the draft.
… source Two comment anchors naming which coordination primitives the ECS per-document milestone deletes and which survive, so the supersession is greppable from the code as well as the decision log and PR body.
Same treatment the crdt files got: every multi-line justification block drops to the one invariant the code cannot show.
A real configure failure is caught inside loadGraphData (dialog, then resolve), so the close path never saw it and deleted the draft of a tab that stayed open over a never-painted graph. loadGraphData now returns an explicit outcome; openWorkflow and loadDefaultWorkflow thread it; closeWorkflow aborts on an explicit failure report through its existing not-closed contract, releasing the load's navigation intent and skipping warnings for a graph that never painted. The regression tests drive the real failure shape: rootGraph.configure throwing, not a mocked rejection.
The docked panel's complementary landmark lost its accessible name while the async panel body loaded; the Suspense fallback now carries a visually-hidden agent-panel-title heading with the same translated string, covered in loading and resolved states. The dock-siblinghood test now mounts the splitter overlay and asserts the rendered structure instead of pinning source text; the linear-mode guard stays a source pin because GraphCanvas cannot mount in the unit environment. The dock width moves from an arbitrary min() to w-1/3 max-w-[420px].
A rejected AgentPanelRoot load left the Suspense fallback up forever with nothing reported. The dock now acts as an error boundary: the failure reaches reportError under agent_panel_load_failure and the panel renders a localized error state that keeps the landmark named. Also drops a non-null assertion in the mount test for optional chaining.
OSS builds now emit no agent chunk and carry no agent code: the dock mounts and tab-bar button sit behind the distribution literal (new useAgentDockMount seam), and the flag gate follows the initTelemetry idiom - the guard lives inside the retained function with every agent module imported dynamically past it, so the dead remainder and its import edges fold away, taking posthog-js with them. Cloud builds inline the gate into the core graph instead of fetching a separate extension chunk, and the panel body chunks load only once the gate enables and the panel opens. Verified by dist scans of both distributions.
The follower doc, wire schema and frame client, mint ports, litegraph mutator and semantic projector, layout follower bridge, op envelope and sender, schema guard, and the dev panel - all flag-gated and inert with no consumer in this slice (activation arrives with the agent stack). Carries the beforeLoadGraph/afterLoadGraph extension hooks, the layoutStore withActor scope, graph traversal support, the four transport prompt-error registrations with their locale entries, the comfy-multi-player dependency with its license-scan exclusion, ADR-0020 and the follower boundary check. Transitional knip entries mark the tree until slices 07+ import it.
…heet - rename ADR 0020 -> 0024 (main already carries 0020-0023), fix its H1, update all references, add the missing README index row - correct the license-exclusion comment: the pinned package declares GPL-3.0-only and ships a LICENSE file - genericize RUN-CLOUD-E2E.md (no internal hosts or names) and note the follower has no mount site until the agent-panel slice - install __agentCrdtPoc only under import.meta.env.DEV - update stale PoC comments; document both load hooks in docs/extensions/core.md including the configure-failure asymmetry
- port the child's graph-load hook test and pin once-each-in-order - pin afterLoadGraph skipped when graph configure fails - cover the four agent prompt-error types in the resolver suite - document beforeLoadGraph/afterLoadGraph pairing on ComfyExtension - dedupe findSubgraphPathById/findSubgraphNodePathById via a shared walk - reject async callbacks in layoutStore.withActor, with a pinning test - exercise the traversal walker's malformed-subgraph guard
- remove the comfy-multi-player license-scan exclusion: the pinned package declares GPL-3.0-only (allowlisted), and keeping the check live guards future pin bumps of a git-ref dependency - render CrdtDevPanel only in dev builds; knip tracks it via ignore instead of entry so unused-export reporting stays live for the tree - reword the ADR and boundary-check lines that asserted an env gate that does not exist on this branch
- correct the afterLoadGraph JSDoc: neither after-hook fires on a configure failure; brackets reset at the next beforeLoadGraph and close on afterConfigureGraph (superset of this hook's cases) - pin the full four-hook load order in the app suite - widen withActor's guard to thenables, report through the assert seam, neutralize the orphaned rejection, and pin actor restoration
- dev panel: init open state and start the poll interval only in dev builds (the render gate alone left prod lifecycle effects running) - symmetric DEV gate on the console-helper teardown delete - ADR: drop the dev-rendered claim, name the stopgap product-flag-gated, future-tense the mount statement - run sheet: point Verify at the dev panel's real testid
…ooks - the guard asserts, not throws: DEV throws, production reports and returns the thenable - say so on the method - the configure-fail test now pins that afterConfigureGraph is also skipped, completing the documented two-hook promise
# Conflicts: # docs/adr/README.md
# Conflicts: # src/services/litegraphService.test.ts
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ❌ 1886 passed, 1 failed · 1 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-29T10:03:34.954Z",
"gitSha": "68f91b5476bb795ef5a22cfe2f5feca814e1f0c0",
"branch": "christian-byrne/reserve-qa-slice03",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.982999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.464999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.38900000000007,
"heapDeltaBytes": 11105292,
"heapUsedBytes": 79207936,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.585999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2025.4059999999754,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.807999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.55799999999994,
"heapDeltaBytes": 12677524,
"heapUsedBytes": 80823628,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.845,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1732.1590000000242,
"styleRecalcs": 71,
"styleRecalcDurationMs": 37.396,
"layouts": 12,
"layoutDurationMs": 3.2700000000000005,
"taskDurationMs": 769.3829999999999,
"heapDeltaBytes": -7072972,
"heapUsedBytes": 61582808,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 125.084,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.994999999998,
"styleRecalcs": 73,
"styleRecalcDurationMs": 29.025999999999996,
"layouts": 12,
"layoutDurationMs": 2.9920000000000004,
"taskDurationMs": 739.5,
"heapDeltaBytes": 3317396,
"heapUsedBytes": 72463804,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 125.413,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.3900000000076,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.679999999999998,
"layouts": 6,
"layoutDurationMs": 0.536,
"taskDurationMs": 295.948,
"heapDeltaBytes": 4352984,
"heapUsedBytes": 73410260,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.315999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.1330000000444,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.091999999999999,
"layouts": 6,
"layoutDurationMs": 0.659,
"taskDurationMs": 297.5,
"heapDeltaBytes": 3698180,
"heapUsedBytes": 67000308,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.068999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 555.6630000000382,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.424000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.652,
"heapDeltaBytes": 19503168,
"heapUsedBytes": 88297508,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 127.17899999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 548.0039999999917,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.867,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.4920000000001,
"heapDeltaBytes": -6936076,
"heapUsedBytes": 62125360,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 126.51099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.7439999999892,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.460000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.157,
"heapDeltaBytes": 13159432,
"heapUsedBytes": 85841676,
"domNodes": -271,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 32.84,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.127000000055,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.673000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.2349999999999,
"heapDeltaBytes": -12021756,
"heapUsedBytes": 88113960,
"domNodes": -266,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 32.607000000000006,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2166.7249999999854,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.979999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1366.2450000000001,
"heapDeltaBytes": 20239348,
"heapUsedBytes": 85986652,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 692.163,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2112.041999999974,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.540000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1357.109,
"heapDeltaBytes": 19919388,
"heapUsedBytes": 85724780,
"domNodes": -271,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 678.4830000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3231.187000000034,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.025,
"layouts": 60,
"layoutDurationMs": 7.718,
"taskDurationMs": 1501.041,
"heapDeltaBytes": 8509108,
"heapUsedBytes": 76012412,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 681.2909999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3233.7740000000395,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.254999999999997,
"layouts": 60,
"layoutDurationMs": 7.396,
"taskDurationMs": 1432.163,
"heapDeltaBytes": 12645876,
"heapUsedBytes": 80104984,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 662.211,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2450.2620000000093,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.004000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1632.722,
"heapDeltaBytes": 18170636,
"heapUsedBytes": 84702804,
"domNodes": -279,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 811.23,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2394.8190000000977,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.105999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1638.843,
"heapDeltaBytes": 19170952,
"heapUsedBytes": 85975364,
"domNodes": 6,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 819.037,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2000.3900000000385,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.5670000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.64400000000006,
"heapDeltaBytes": 23696252,
"heapUsedBytes": 89414920,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.038,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.5539999999992,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.5320000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.99499999999995,
"heapDeltaBytes": 24109448,
"heapUsedBytes": 89090964,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.062999999999995,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.4980000000228,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.411000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.794,
"heapDeltaBytes": 14754044,
"heapUsedBytes": 79877884,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 113.67099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.5740000000014,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.705999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.44399999999996,
"heapDeltaBytes": 14866756,
"heapUsedBytes": 85927376,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 112.169,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.9179999999847,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.856,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.20799999999997,
"heapDeltaBytes": -7543684,
"heapUsedBytes": 63513524,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.845999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.5189999999457,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.95,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.79300000000006,
"heapDeltaBytes": -6338536,
"heapUsedBytes": 64766044,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.092000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.8579999999874,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.906000000000002,
"layouts": 16,
"layoutDurationMs": 3.9890000000000003,
"taskDurationMs": 736.026,
"heapDeltaBytes": -5062248,
"heapUsedBytes": 59089660,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 94.597,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.32600000007,
"styleRecalcs": 74,
"styleRecalcDurationMs": 31.744999999999994,
"layouts": 16,
"layoutDurationMs": 4.171,
"taskDurationMs": 690.4399999999999,
"heapDeltaBytes": -11642768,
"heapUsedBytes": 59517404,
"domNodes": -299,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 93.333,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1184.7739999999476,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.204000000000008,
"layouts": 15,
"layoutDurationMs": 11.508000000000001,
"taskDurationMs": 791.9549999999997,
"heapDeltaBytes": 26024316,
"heapUsedBytes": 99179364,
"domNodes": 13671,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 26.859,
"eventListeners": 2381,
"totalBlockingTimeMs": 88,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8681.15899999998,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.905,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5540.664000000001,
"heapDeltaBytes": 26546544,
"heapUsedBytes": 102796592,
"domNodes": -269,
"jsHeapTotalBytes": 2539520,
"scriptDurationMs": 2698.575,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8263.954000000012,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.63099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5060.834,
"heapDeltaBytes": -17693492,
"heapUsedBytes": 83213984,
"domNodes": -269,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 2413.672,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 15364.482000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14817.372999999998,
"heapDeltaBytes": -34631172,
"heapUsedBytes": 176551152,
"domNodes": -6548,
"jsHeapTotalBytes": -5033984,
"scriptDurationMs": 265.407,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15401.688999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14898.896999999999,
"heapDeltaBytes": -43154832,
"heapUsedBytes": 173523936,
"domNodes": -6548,
"jsHeapTotalBytes": -4657152,
"scriptDurationMs": 296.724,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17874.52200000001,
"styleRecalcs": 137,
"styleRecalcDurationMs": 15.522999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17552.928,
"heapDeltaBytes": -22618464,
"heapUsedBytes": 182017176,
"domNodes": -6548,
"jsHeapTotalBytes": -7045120,
"scriptDurationMs": 802.9549999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18294.668,
"styleRecalcs": 130,
"styleRecalcDurationMs": 17.722000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18095.049,
"heapDeltaBytes": -32435424,
"heapUsedBytes": 167452476,
"domNodes": -6548,
"jsHeapTotalBytes": 1601536,
"scriptDurationMs": 909.1179999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 438.0859999999984,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.796999999999997,
"layouts": 3,
"layoutDurationMs": 0.5720000000000002,
"taskDurationMs": 89.57,
"heapDeltaBytes": 5084356,
"heapUsedBytes": 71488100,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.758000000000002,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 80.00199999992219,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.231,
"layouts": 1,
"layoutDurationMs": 0.245,
"taskDurationMs": 52.949999999999996,
"heapDeltaBytes": 3189052,
"heapUsedBytes": 69226084,
"domNodes": 107,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.186000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-v1/03-canvas-primitives #16225 +/- ##
===========================================================================
- Coverage 82.77% 82.75% -0.02%
===========================================================================
Files 1970 1970
Lines 113834 113834
Branches 33816 33764 -52
===========================================================================
- Hits 94221 94204 -17
- Misses 19269 19286 +17
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 4 |
| 🟢 Low | 2 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
| await node.centerOnNode() | ||
| await expect | ||
| .poll(() => comfyPage.nodeOps.getSerializedGraph()) | ||
| .toEqual(before) |
There was a problem hiding this comment.
🟠 High — centerOnNode() writes canvas.ds.offset, and graph.serialize() embeds the live viewport as extra.ds = { scale, offset } whenever LiteGraph.saveViewportWithGraph is set — it mirrors Comfy.EnableWorkflowViewRestore, which defaults to true and isn't overridden by the comfyPage fixture. So the serialized graph provably differs from before after centering, and the poll will burn its full timeout before failing. Compare only node/link/group data (or strip extra.ds), and add a positive assertion that the node is actually centered. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
|
|
||
| await fitToViewInstant(comfyPage) | ||
| const offset = await comfyPage.canvasOps.getOffset() | ||
| expect(offset.every(Number.isFinite)).toBe(true) |
There was a problem hiding this comment.
🟡 Medium — This assertion cannot detect a fit-to-view regression: ds.offset is already a finite pair before the call, and fitToViewInstant returns silently on three paths (no app.canvas, no positionable items, non-finite bounds), so a complete no-op still passes. Capture offset/scale before the call and assert the viewport changed, or assert the graph's bounds land inside the visible area. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
|
|
||
| const before = await comfyPage.canvasOps.getNodeGeometry(node.id) | ||
| const position = await node.getPosition() | ||
| await comfyPage.canvasOps.dragAndDrop(position, { |
There was a problem hiding this comment.
🟡 Medium — Coordinate-space mismatch: NodeReference.getPosition() returns canvas-element-relative coordinates (via ds.convertOffsetToCanvas, without the canvas element's client offset), but dragAndDrop forwards its arguments straight to page.mouse.move, which needs page-absolute coordinates. Other call sites (NodeReference.dragBy, mouseClickAt) convert with canvasOps.toAbsolute() first; this only works while the <canvas> sits at page origin. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| if (!node) return | ||
|
|
||
| const before = await comfyPage.nodeOps.getSerializedGraph() | ||
| await node.click('title') |
There was a problem hiding this comment.
🟡 Medium — The test is titled for select-only mode but never enables canvas.state.selectOnly (defaults to false, and neither the spec nor the fixture sets it), so it exercises the ordinary editable click path. It also can't observe selection regressions, since graph.serialize() carries no selection state. Arm selectOnly and assert on selection state, or retitle the test. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
| if (!node) return | ||
|
|
||
| const before = await comfyPage.canvasOps.getNodeGeometry(node.id) | ||
| const position = await node.getPosition() |
There was a problem hiding this comment.
🟡 Medium — The drag starts at the node body's exact top-left corner (getPosition() maps node.pos), which is a boundary pixel and sits near input slot 0's hit region (getConnectionPos places it around pos + [10, 10]). A press there can start a link drag or a canvas rubber-band instead of a node move, so expectSlotsTrackedNode fails intermittently. Use getTitlePosition()/dragBy, which existing node-drag helpers deliberately inset from the corner. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| .poll(() => comfyPage.nodeOps.getSelectedGraphNodesCount()) | ||
| .toBe(1) | ||
| await expect | ||
| .poll(() => comfyPage.nodeOps.getSerializedGraph()) |
There was a problem hiding this comment.
🟢 Low — expect.poll(...).toEqual(before) is the wrong primitive for a "must not change" invariant (same pattern at line 38): poll succeeds on the first matching sample — here the very first one — so a mutation that lands later is never observed, while a genuine mismatch is only reported after the full timeout. Sample once after a deterministic settle point: expect(await comfyPage.nodeOps.getSerializedGraph()).toEqual(before). Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| if (!node) return | ||
| await node.click('title') | ||
|
|
||
| await fitToViewInstant(comfyPage) |
There was a problem hiding this comment.
🟢 Low — fitToViewInstant defaults selectionOnly to false, so the preceding node.click('title') has no bearing on what this call does — the fit covers all positionable items regardless of selection. Either drop the dead selection setup or pass { selectionOnly: true } if selection-aware fitting is the intended coverage. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| expect(offset.every(Number.isFinite)).toBe(true) | ||
| }) | ||
|
|
||
| test('moves one selected node and keeps its connection slots aligned', async ({ |
There was a problem hiding this comment.
⚪ Nit — The title says "moves one selected node" but this test never selects the node before dragging (unlike the first and third tests, which call node.click('title')), so it actually covers dragging an unselected node. Select first, or drop "selected" from the title. Raised by 1 of 8 reviewers (kimi-k3-max edge-case).
| }) => { | ||
| const node = await comfyPage.nodeOps.getFirstNodeRef() | ||
| expect(node).not.toBeNull() | ||
| if (!node) return |
There was a problem hiding this comment.
⚪ Nit — if (!node) return ends the test body with zero assertions run. It is dead today because the preceding expect(node).not.toBeNull() throws first, but the pattern is repeated in all four tests and would turn each into a vacuous pass if that assertion is ever softened; a non-null assertion or a throwing helper states the precondition without the escape hatch. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
73194ad to
e59f370
Compare
|
Superseded — closing per Christian's direction.
Full context for agent readersProgram pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs. |
Active canvas E2E coverage reserved for slice 03 exact head
ebe385c3ab60613bfc84a338d90443b5c7bee29d.Full context for agent readers
Splits the slice-03 cases from QA draft #16217 and activates them on the branch that owns the behavior. Covers select-only graph preservation, focus without graph mutation, finite fit-to-view, and moved-node slot alignment.
Validation:
git diff --checkpassed. Browser execution was not available in this dependency-free reservation clone.