Repository navigation
fix: transfer link presentation through recreation flows - #16219
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe PR preserves link presentation metadata across graph mutations, subgraph conversion, link reconnection, clipboard copy/paste, reroute operations, and topology normalization. It also removes stale presentation data when links or semantic graph owners are cleared. ChangesLink presentation lifecycle
Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: ⚪ Minimal · up to Link hidden-state and label metadata now survives supported graph recreation flows while stale metadata is cleaned up when graphs and links are removed. No current merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant GraphOperation
participant LinkPresentationStore
participant NewLink
GraphOperation->>LinkPresentationStore: read source presentation
GraphOperation->>NewLink: create or recreate link
GraphOperation->>LinkPresentationStore: transfer presentation to new link
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (5 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list is available, and it shows no Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The PR introduces Resolution Refactor link-presentation transfers into a serializable, deterministic, idempotent command or route them through the repository's command layer. Update the link recreation, clipboard, subgraph, reroute, and graph-mutation paths to dispatch that command and retain deletion and ownership semantics. Document the command shape and add focused tests for replay and repeated application. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1921 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.83 MB gzip 🔴 +1.74 kBDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.63 MB (baseline 3.62 MB) • 🔴 +6.71 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-08T18:59:33.322Z",
"gitSha": "ae3792317773b46ba22b1aed0ab7ddb44fa6e3c6",
"branch": "jaeone94/link-presentation-2-transfer",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2128.99699999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.729000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.567,
"heapDeltaBytes": -1476776,
"heapUsedBytes": 69062608,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.0120000000000005,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2041.5109999999004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.7669999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.87999999999994,
"heapDeltaBytes": -11786032,
"heapUsedBytes": 59150464,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.153,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.0410000000384,
"styleRecalcs": 73,
"styleRecalcDurationMs": 27.406999999999996,
"layouts": 14,
"layoutDurationMs": 3.1830000000000003,
"taskDurationMs": 773.963,
"heapDeltaBytes": 2691968,
"heapUsedBytes": 73531256,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 118.979,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.4129999999714,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.899,
"layouts": 14,
"layoutDurationMs": 4.24,
"taskDurationMs": 758.281,
"heapDeltaBytes": 12580596,
"heapUsedBytes": 82854912,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 124.37699999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.1220000000394,
"styleRecalcs": 29,
"styleRecalcDurationMs": 11.712,
"layouts": 6,
"layoutDurationMs": 0.8670000000000001,
"taskDurationMs": 289.74100000000004,
"heapDeltaBytes": 4956272,
"heapUsedBytes": 76085280,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.379999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1676.048000000037,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.326,
"layouts": 6,
"layoutDurationMs": 0.983,
"taskDurationMs": 295.65,
"heapDeltaBytes": 4399116,
"heapUsedBytes": 74703820,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.536999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 530.2810000000022,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.8709999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.294,
"heapDeltaBytes": 18978704,
"heapUsedBytes": 88834188,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 120.886,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 610.2109999999357,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.614999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.188,
"heapDeltaBytes": -7870676,
"heapUsedBytes": 63044492,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 145.433,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2026.6579999999976,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.652000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.8560000000001,
"heapDeltaBytes": 10502176,
"heapUsedBytes": 86475328,
"domNodes": -263,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 25.485,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.481000000037,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.105,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.7679999999999,
"heapDeltaBytes": -15248176,
"heapUsedBytes": 87723668,
"domNodes": -267,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 29.375999999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2119.854000000032,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.076000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1189.212,
"heapDeltaBytes": 26791988,
"heapUsedBytes": 92841668,
"domNodes": 8,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 562.268,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2096.230999999989,
"styleRecalcs": 64,
"styleRecalcDurationMs": 6.308000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1217.147,
"heapDeltaBytes": 20723568,
"heapUsedBytes": 87493072,
"domNodes": 4,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 578.8230000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3158.5190000000125,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.892999999999999,
"layouts": 60,
"layoutDurationMs": 10.046000000000001,
"taskDurationMs": 1304.4319999999998,
"heapDeltaBytes": 8244924,
"heapUsedBytes": 76428928,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 572.63,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3164.715000000001,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.826999999999996,
"layouts": 60,
"layoutDurationMs": 11.013,
"taskDurationMs": 1352.361,
"heapDeltaBytes": 9502684,
"heapUsedBytes": 76591080,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 568.632,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2222.3999999999933,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.777,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1376.175,
"heapDeltaBytes": 14861320,
"heapUsedBytes": 82343336,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 654.026,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2380.6170000000293,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.673,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1528.3349999999998,
"heapDeltaBytes": 18642460,
"heapUsedBytes": 86118332,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 726.4440000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.8370000000095,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.365999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.685,
"heapDeltaBytes": -5382344,
"heapUsedBytes": 72240448,
"domNodes": -283,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 27.572,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2001.7919999999094,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5109999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.0759999999999,
"heapDeltaBytes": 22229124,
"heapUsedBytes": 88535768,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 23.666,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.1670000000104,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.780999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.726,
"heapDeltaBytes": 15476824,
"heapUsedBytes": 87830004,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 99.693,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 508.78099999999904,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.22,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.762,
"heapDeltaBytes": 15204632,
"heapUsedBytes": 87912076,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 99.132,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2001.5200000000277,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.448999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.921,
"heapDeltaBytes": -3367868,
"heapUsedBytes": 69014664,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.827,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2005.3120000000035,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.386000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.275,
"heapDeltaBytes": -2725380,
"heapUsedBytes": 69675828,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.283999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.531999999991,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.091,
"layouts": 18,
"layoutDurationMs": 3.174,
"taskDurationMs": 647.124,
"heapDeltaBytes": -269512,
"heapUsedBytes": 71729620,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 69.963,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.8910000000087,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.948,
"layouts": 18,
"layoutDurationMs": 3.6430000000000002,
"taskDurationMs": 693.2629999999999,
"heapDeltaBytes": -12577988,
"heapUsedBytes": 60431124,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 77.549,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1233.6549999999988,
"styleRecalcs": 21,
"styleRecalcDurationMs": 25.625999999999998,
"layouts": 17,
"layoutDurationMs": 11.062000000000003,
"taskDurationMs": 820.8290000000001,
"heapDeltaBytes": 21564524,
"heapUsedBytes": 105670348,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 26.174999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8199.329999999974,
"styleRecalcs": 247,
"styleRecalcDurationMs": 25.134,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4266.999,
"heapDeltaBytes": 13546772,
"heapUsedBytes": 89410504,
"domNodes": -270,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 1852.5819999999999,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8205.038000000059,
"styleRecalcs": 249,
"styleRecalcDurationMs": 26.971,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4367.035,
"heapDeltaBytes": 14269592,
"heapUsedBytes": 89988076,
"domNodes": -269,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 1893.397,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12311.570000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11267.823999999999,
"heapDeltaBytes": -13187172,
"heapUsedBytes": 176252908,
"domNodes": -6548,
"jsHeapTotalBytes": 2637824,
"scriptDurationMs": 163.709,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 11990.848000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10951.938,
"heapDeltaBytes": -37040100,
"heapUsedBytes": 174850152,
"domNodes": -6552,
"jsHeapTotalBytes": -3727360,
"scriptDurationMs": 188.96600000000004,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15483.42500000001,
"styleRecalcs": 84,
"styleRecalcDurationMs": 13.353000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14956.047000000002,
"heapDeltaBytes": -38854428,
"heapUsedBytes": 162880940,
"domNodes": -6548,
"jsHeapTotalBytes": 512000,
"scriptDurationMs": 738.641,
"eventListeners": -7473,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14313.768999999978,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.021000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13616.999,
"heapDeltaBytes": -13842376,
"heapUsedBytes": 190771124,
"domNodes": -6548,
"jsHeapTotalBytes": 442368,
"scriptDurationMs": 671.322,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5068.914999999947,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.519,
"layouts": 20,
"layoutDurationMs": 23.358000000000004,
"taskDurationMs": 4956.477999999999,
"heapDeltaBytes": -13031968,
"heapUsedBytes": 175939080,
"domNodes": -6548,
"jsHeapTotalBytes": 11837440,
"scriptDurationMs": 90.751,
"eventListeners": -7473,
"totalBlockingTimeMs": 173,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4156.158000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.14699999999998,
"layouts": 20,
"layoutDurationMs": 18.89500000000001,
"taskDurationMs": 4020.707000000001,
"heapDeltaBytes": -33425584,
"heapUsedBytes": 174860508,
"domNodes": -6548,
"jsHeapTotalBytes": 5918720,
"scriptDurationMs": 71.47300000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7303.881999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7005.689,
"heapDeltaBytes": 6541628,
"heapUsedBytes": 175344592,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 120.23700000000004,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6120.296000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5582.419999999999,
"heapDeltaBytes": 7621920,
"heapUsedBytes": 174737320,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 120.49700000000001,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 92.12700000000495,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.312000000000001,
"layouts": 3,
"layoutDurationMs": 0.8160000000000001,
"taskDurationMs": 66.54999999999998,
"heapDeltaBytes": 3143104,
"heapUsedBytes": 72304068,
"domNodes": 110,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.984,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 70.0809999999592,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.248,
"layouts": 2,
"layoutDurationMs": 0.945,
"taskDurationMs": 47.87,
"heapDeltaBytes": 2942184,
"heapUsedBytes": 70013780,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 2.681000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #16219 +/- ##
==========================================
+ Coverage 81.49% 82.97% +1.48%
==========================================
Files 2487 2057 -430
Lines 127523 119938 -7585
Branches 32883 31903 -980
==========================================
- Hits 103921 99521 -4400
+ Misses 23082 20237 -2845
+ Partials 520 180 -340
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 444 files with indirect coverage changes 🚀 New features to boost your workflow:
|
9bfa296 to
c133d9f
Compare
18e900c to
96ff540
Compare
96ff540 to
6c834a3
Compare
6c834a3 to
22077bc
Compare
22077bc to
b49042a
Compare
# Conflicts: # docs/adr/README.md
b49042a to
8595e26
Compare
| } | ||
|
|
||
| const presentation = data.extra?.linkPresentation | ||
| if (presentation) { |
There was a problem hiding this comment.
Maybe flip this to a guard clause?
There was a problem hiding this comment.
agree; that would definitely be more beautiful.
There was a problem hiding this comment.
Done in c98bf3a2bb, with an early return when there's no presentation to remap.
DrJKL
left a comment
There was a problem hiding this comment.
Reviewed the current immediate-base delta. Transfer paths, ownership, typing, and focused tests look good.
| ...(presentation?.[String(id)]?.hidden === true && { hidden: true }), | ||
| ...(typeof presentation?.[String(id)]?.label === 'string' && { | ||
| label: presentation[String(id)].label | ||
| }) |
There was a problem hiding this comment.
Close to the line of too clever. Also odd that id has to be both Stringified and Numberfied here
There was a problem hiding this comment.
Agreed, this takes more effort to read than it should. Our review guidelines
call this out too. I’ll look up the presentation once and use explicit assignments, keeping the runtime checks.There was a problem hiding this comment.
Updated in c98bf3a2bb. It now uses one lookup and explicit assignments, with the same runtime checks. I also removed the redundant String(id) for the object lookup.
I traced the numeric conversion back through the callers too. Workflow insertion can reach this converter without schema validation, so I've kept the existing Number(extensionId) for now to preserve that behavior. String extension IDs aren't part of the schema contract; I'd prefer to tighten the upstream validation and remove that tolerance together in a separate PR. If you think keeping the coercion here still gives the wrong impression about what we support, I'm happy to remove it in this PR.
c98bf3a
## ELI5 Hiding a connection replaces its long curve with a named badge at each end, making a crowded graph easier to follow. Users can rename the badges or restore the connection from their context menu. ## Reviewer context Third slice of the link-presentation stack, based on [Comfy-Org#16219: fix: transfer link presentation through recreation flows](Comfy-Org#16219), including its latest `c98bf3a2bb` changes. This slice supplies Hide, Show, and Rename; [Comfy-Org#16221: feat: hover reveal for hidden links](Comfy-Org#16221) adds temporary reveal from badges and Vue-node slots. Existing connections retain their appearance until hidden. | Slice | PR | Scope | | --- | --- | --- | | 1 | [Comfy-Org#16218: feat: store-backed link presentation state](Comfy-Org#16218) | Store graph-scoped hidden/label state and persist it in workflow JSON. | | 2 | [Comfy-Org#16219: fix: transfer link presentation through recreation flows](Comfy-Org#16219) | Preserve presentation through copy/paste, reconnection, and subgraph conversion/unpacking; clean up deleted links. | | 3 (this PR) | [Comfy-Org#16220: feat: hidden-link badges and context menu](Comfy-Org#16220) | Replace hidden connections with endpoint badges and add Hide, Show, and Rename interactions. | | 4 | [Comfy-Org#16221: feat: hover reveal for hidden links](Comfy-Org#16221) | Temporarily reveal hidden routes when hovering badges or connected Vue-node slots, without changing saved state. | | 5 | [Comfy-Org#17213: fix: order hidden link badges by displayed slot position](Comfy-Org#17213) | Order badges independently at each endpoint by displayed slot position, keeping drawing, hit testing, and revealed routes aligned. | ## Summary - Keep presentation in the graph-scoped store and badge hit areas private to each canvas. Badges paint above links and reroutes; paint-only culling keeps rows stable while panning. - Share the rendered-segment hit query between primary-button interactions and context menus, including DPI handling and stroke-width restoration. Context menus then filter hidden links, including shared reroutes; primary interactions preserve marker, Shift, and Alt behavior. - Order overlapping badges with the existing locale-independent `compareNodeIds`, then output slot and link ID. Double-click renames a badge; dragging pans. - Reuse the hidden-link screenshot for the reload assertion, removing two byte-identical goldens while retaining serialization and reload checks. ## Provenance - **Verified:** 195 selected unit tests across 18 related suites passed with one worker, including parent-PR transfer, clipboard, and converter coverage. After adjusting parameterized tests to repository conventions, the affected 53 tests passed again. Full `pnpm lint` passed (0 errors, 209 ESLint warnings), as did `pnpm adr:check`, formatting, commit-hook `pnpm typecheck` and `pnpm typecheck:browser`, and push-hook `pnpm knip`. - **Deviations:** Browser E2E was not rerun locally. Linux and Darwin reload goldens were verified byte-identical to the retained hidden-link goldens. CI on the new head is still pending. ## Test plan - [ ] Confirm hide → rename → reload → show, overlapping badges, and node/reroute hit-testing in the browser. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
The section claimed all graph-level callers of attachNodeToStores, replaceLink and updateEndpoints had been re-verified, but the table only covered sites inside src/lib/litegraph. Two direct store callers outside it were never looked at: the remote connect applier in graphMutations.ts and replaceNodesInPlace in useNodeReplacement.ts. State the audited population explicitly, name the two routes into the same store functions that remain out of scope, add both missing rows, and refresh the drifted line numbers. The graphMutations.ts site is atomic only by precondition: the store signals rejection with a bare undefined, and nothing at the call site would stop detachLinkSlots from clearing the occupant's endpoint slots. Its guard was added incidentally by #16219 and had no test; pin it with a spec that stubs replaceLink to reject and asserts the occupant keeps its topology and slots. Addresses review feedback: #15721 (comment)
ELI5
Moving or copying a connection should not silently reset whether it is hidden or what it is called. This PR carries those settings to replacement connections and removes them when the connections are deleted.
Motivation
The store-backed presentation foundation is merged, but editing a graph can replace links rather than modify them in place. Local regression tests showed that some replacement paths could lose presentation or leave entries belonging to deleted links. This data-transfer slice closes those gaps before the dependent hiding and hover UI changes, while retaining the current store ownership, workflow formats, and snapshot-based editing model.
Summary
LLink.Stack
The store foundation is merged. This PR now targets
main; the remaining children still target the preceding branch.mainReview focus
mainbase, this PR adds eightimport-x/no-restricted-pathswarnings: six production imports and two test imports oflinkPresentationStorefrom litegraph. These are new dependencies, not pre-existing warnings. Can we accept this bounded coupling for the current store-backed adapter phase and handle dependency inversion separately? This PR deliberately does not add a registration-based bridge, command/replay/undo framework, warning suppressions, or wrappers that only conceal the dependency. Future command handlers could take over mutation orchestration, but would not automatically resolve serialization reads.Provenance
pnpm test:unit <files> --maxWorkers=1; 62 existingLinkConnector.integration.test.tscases passed with-t 'reroute|loopback|move output links' --maxWorkers=1(134 distinct tests total). The three latest lifecycle regressions failed at the intended assertions before the fixes and passed afterward. Fixture consolidation retained the same 45 passing cases and assertions across its three affected suites.pnpm lint,pnpm typecheck,pnpm knip, changed-file formatting, andgit diff --checkpassed. Lint reported 0 errors, 200 ESLint warnings (including the eight above), and two existing oxlint warnings. Commit and push hooks passed without bypasses.Test plan