Repository navigation
refactor(widgets): extract a shared node widget value boundary - #16214
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1888 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.62 MB gzip 🔴 +72 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.39 MB (baseline 1.39 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.57 MB (baseline 3.57 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 556 kB (baseline 556 kB) • 🔴 +299 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.2 MB (baseline 16.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-29T03:21:56.514Z",
"gitSha": "537cc2781dfc7f5f377218e1ed3c7b84f2838ad8",
"branch": "refactor/node-widget-value-helper",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.873999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.532000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.188,
"heapDeltaBytes": -12779272,
"heapUsedBytes": 56222188,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.476,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2054.4830000000047,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.068,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.142,
"heapDeltaBytes": -13293368,
"heapUsedBytes": 55975672,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.991,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1821.8859999999495,
"styleRecalcs": 73,
"styleRecalcDurationMs": 34.445,
"layouts": 12,
"layoutDurationMs": 3.5660000000000003,
"taskDurationMs": 869.0930000000001,
"heapDeltaBytes": -7482348,
"heapUsedBytes": 61533128,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 152.63500000000002,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.4199999999728,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.663000000000004,
"layouts": 12,
"layoutDurationMs": 3.1719999999999997,
"taskDurationMs": 930.107,
"heapDeltaBytes": 1863184,
"heapUsedBytes": 70759324,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 163.946,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.7719999999708,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.515,
"layouts": 6,
"layoutDurationMs": 0.54,
"taskDurationMs": 361.572,
"heapDeltaBytes": 3778256,
"heapUsedBytes": 67933168,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.619,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.1930000000475,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.787,
"layouts": 6,
"layoutDurationMs": 0.6199999999999999,
"taskDurationMs": 420.74999999999994,
"heapDeltaBytes": 4477092,
"heapUsedBytes": 73896968,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.332,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 665.6050000000278,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.527,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.94899999999996,
"heapDeltaBytes": 18820516,
"heapUsedBytes": 87360492,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 156.57999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 741.8760000000475,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.322999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.232,
"heapDeltaBytes": 18825036,
"heapUsedBytes": 87363288,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 175.005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2048.2920000000036,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.786999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.543,
"heapDeltaBytes": -13036148,
"heapUsedBytes": 86592404,
"domNodes": -266,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 31.703999999999997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2048.7660000000005,
"styleRecalcs": 4,
"styleRecalcDurationMs": 7.233,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.7550000000001,
"heapDeltaBytes": 11005828,
"heapUsedBytes": 86712184,
"domNodes": -273,
"jsHeapTotalBytes": -1875968,
"scriptDurationMs": 34.92000000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2336.6790000000037,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.85,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1667.48,
"heapDeltaBytes": 15698896,
"heapUsedBytes": 80509604,
"domNodes": -272,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 832.431,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2454.84799999997,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.018000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1688.4969999999998,
"heapDeltaBytes": 22573248,
"heapUsedBytes": 88463092,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 813.6840000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3576.8600000000106,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.344999999999997,
"layouts": 60,
"layoutDurationMs": 7.7669999999999995,
"taskDurationMs": 1698.516,
"heapDeltaBytes": 9955996,
"heapUsedBytes": 76106812,
"domNodes": -284,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 761.8580000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3872.3959999999806,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.669999999999998,
"layouts": 60,
"layoutDurationMs": 8.098999999999998,
"taskDurationMs": 1877.596,
"heapDeltaBytes": 8713172,
"heapUsedBytes": 76163732,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 833.971,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3031.4219999999636,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.598999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1917.8379999999997,
"heapDeltaBytes": 18206520,
"heapUsedBytes": 84180804,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 935.7110000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3245.853000000011,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.004999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2027.704,
"heapDeltaBytes": 24527396,
"heapUsedBytes": 91700296,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 989.1589999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2074.28299999998,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.3550000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.237,
"heapDeltaBytes": 10496188,
"heapUsedBytes": 86208840,
"domNodes": -274,
"jsHeapTotalBytes": -1875968,
"scriptDurationMs": 39.926,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.2469999999357,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.610999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.1630000000001,
"heapDeltaBytes": 22257912,
"heapUsedBytes": 87411900,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.24899999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.722999999959,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.461,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.285,
"heapDeltaBytes": 14008308,
"heapUsedBytes": 85629308,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 139.914,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.9569999999767,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.424000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.49100000000004,
"heapDeltaBytes": 14722920,
"heapUsedBytes": 85927764,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.482,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.198000000003,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.567000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.01599999999996,
"heapDeltaBytes": 3802264,
"heapUsedBytes": 68258628,
"domNodes": -299,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.692000000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.5009999999966,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.443,
"heapDeltaBytes": 3341840,
"heapUsedBytes": 67781908,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.879000000000003,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.951999999997,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.422000000000004,
"layouts": 16,
"layoutDurationMs": 4.255,
"taskDurationMs": 830.514,
"heapDeltaBytes": 696952,
"heapUsedBytes": 71544164,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.05399999999999,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.2779999999284,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.325,
"layouts": 16,
"layoutDurationMs": 5.177999999999999,
"taskDurationMs": 911.4010000000001,
"heapDeltaBytes": -12996644,
"heapUsedBytes": 58539688,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 119.01400000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1465.8170000000155,
"styleRecalcs": 17,
"styleRecalcDurationMs": 34.04500000000001,
"layouts": 12,
"layoutDurationMs": 15.017999999999997,
"taskDurationMs": 1054.6799999999998,
"heapDeltaBytes": 21862748,
"heapUsedBytes": 105743540,
"domNodes": 13671,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 36.257000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 162,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8588.848999999982,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.053999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5894.742,
"heapDeltaBytes": -16280152,
"heapUsedBytes": 76922684,
"domNodes": -276,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 2670.2439999999997,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9335.008000000016,
"styleRecalcs": 245,
"styleRecalcDurationMs": 35.452999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6222.657,
"heapDeltaBytes": -6491436,
"heapUsedBytes": 93237888,
"domNodes": -272,
"jsHeapTotalBytes": -1122304,
"scriptDurationMs": 2759.94,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16596.07699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15873.671000000002,
"heapDeltaBytes": -31807408,
"heapUsedBytes": 175052196,
"domNodes": -6548,
"jsHeapTotalBytes": -7225344,
"scriptDurationMs": 250.73900000000003,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17735.75900000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17050.632,
"heapDeltaBytes": -17384308,
"heapUsedBytes": 190549400,
"domNodes": -6548,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 319.913,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21145.84500000001,
"styleRecalcs": 173,
"styleRecalcDurationMs": 18.004999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20696.191,
"heapDeltaBytes": -47029688,
"heapUsedBytes": 162451452,
"domNodes": -6548,
"jsHeapTotalBytes": -4022272,
"scriptDurationMs": 898.996,
"eventListeners": -7467,
"totalBlockingTimeMs": 91,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21341.219000000023,
"styleRecalcs": 163,
"styleRecalcDurationMs": 19.774000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20983.143000000004,
"heapDeltaBytes": -33654168,
"heapUsedBytes": 162462160,
"domNodes": -6548,
"jsHeapTotalBytes": -6447104,
"scriptDurationMs": 914.061,
"eventListeners": -7471,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6250.683999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.30700000000002,
"layouts": 20,
"layoutDurationMs": 23.116999999999997,
"taskDurationMs": 6162.395,
"heapDeltaBytes": -25878404,
"heapUsedBytes": 176546112,
"domNodes": -6548,
"jsHeapTotalBytes": 12091392,
"scriptDurationMs": 118.384,
"eventListeners": -7469,
"totalBlockingTimeMs": 529,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6463.336000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.15899999999999,
"layouts": 20,
"layoutDurationMs": 24.608000000000004,
"taskDurationMs": 6332.802000000001,
"heapDeltaBytes": -23666300,
"heapUsedBytes": 178963060,
"domNodes": -6548,
"jsHeapTotalBytes": 13139968,
"scriptDurationMs": 116.86599999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 580,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 115.02199999995355,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.143999999999998,
"layouts": 2,
"layoutDurationMs": 0.6280000000000001,
"taskDurationMs": 81.96600000000001,
"heapDeltaBytes": 3212344,
"heapUsedBytes": 70778888,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.870000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 465.9629999999879,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.297000000000004,
"layouts": 3,
"layoutDurationMs": 0.684,
"taskDurationMs": 114.92900000000003,
"heapDeltaBytes": 5050896,
"heapUsedBytes": 72433844,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.09,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughAdds shared helpers for reading and writing node widget values. The compositor composables now use these helpers, and tests cover store precedence, nullish values, fallbacks, detached nodes, and missing widgets. ChangesNode widget value access
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized refactor centralizes widget-value store access while preserving the documented fallback behavior; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description clearly explains the motivation, implementation, behavior for nullish store values, compositor adoption, and follow-up migrations. It does not use all template headings, but it contains the required substantive information. Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list is available, but the PR title and commit subjects are not available in the review context. The check requires those signals to determine whether bug-fix language is present, so the result cannot be determined without guessing. Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The PR is applicable because it changes graph-widget files. The described diff adds shared widget-value helpers and updates the compositor boundary; it does not add methods or properties to
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #16214 +/- ##
==========================================
+ Coverage 80.72% 82.76% +2.03%
==========================================
Files 2324 1953 -371
Lines 118786 112504 -6282
Branches 32609 31690 -919
==========================================
- Hits 95894 93112 -2782
+ Misses 22324 19056 -3268
+ Partials 568 336 -232
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 383 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Reviewed the code and unit-test changes at ae5b27e. No actionable findings. The nullish store-value precedence is intentional and covered by a focused regression test; existing compositor write behavior and public signatures are preserved.
Checks: targeted Vitest (16 tests), typecheck, changed-file ESLint, formatting, diff check, and fallow audit --base origin/main all passed.
DrJKL
left a comment
There was a problem hiding this comment.
Approved. The behavior and placement look sound. Two non-blocking consolidation suggestions are attached: finish the immediate helper consolidation, and avoid expanding the API with exports or return contracts that have no current production consumer.
fallow audit --base origin/main passes with no changed-file findings.
| import type { WidgetId } from '@/types/widgetId' | ||
| import { widgetId } from '@/types/widgetId' | ||
|
|
||
| export function nodeWidgetId(node: LGraphNode, name: string): WidgetId | null { |
There was a problem hiding this comment.
Non-blocking: can this stay private? No production module imports nodeWidgetId; exporting it only turns an implementation detail into a maintained contract and encourages tests to couple to the derivation rather than the read/write behavior. Keeping only the operations that callers use matches the repository’s minimal-surface guidance.
| node: LGraphNode, | ||
| name: string, | ||
| value: WidgetValue | ||
| ): boolean { |
There was a problem hiding this comment.
Non-blocking: the sole production caller discards this boolean, so please keep the setter void until a real caller needs failure feedback and assert observable state in its tests instead. This extraction should also migrate src/composables/maskeditor/imageWidgetAdapter.ts, which still duplicates the same ID/store/fallback flow; its node.properties.image synchronization can remain around the shared setter. That gives the helper two real consumers and one source of truth now, rather than adding API for planned follow-ups.
…mfy-Org#16475) *PR Created by the Glary-Bot Agent* --- ## Summary Brings Comfy-Org#16381 up to date with `main` (14 commits behind), lands the two test simplifications still outstanding from @DrJKL's review, and fixes a save-path regression the branch was carrying. Supersedes Comfy-Org#16441 — its two changes are included here verbatim. ## Changes - **What**: - Merge current `main` into the branch. No textual conflicts; the merge was verified against `main`'s widget refactors (Comfy-Org#16214, Comfy-Org#16428, Comfy-Org#16454). - `LLink.spreadCopy.test.ts` / `widgetValueStore.test.ts`: apply Comfy-Org#16441 exactly — fold the redundant store-mutation spread test into the single topology test, and drop the registration case that codified an empty-name `WidgetId` (`isWidgetId` rejects it; re-registration is already covered at four other sites in the same file). - `LGraph.ts`: the live-node mismatch guard added by this branch compared stored state against `_nodes.length`. A node held twice in `_nodes` took the fallback and wrote **its id twice into the saved workflow** — `main` serialises it once. Compare against the count of distinct live ids and serialise identity-deduplicated live nodes. - `LGraph.serialise.test.ts`: two regressions — one pinning the store path for a benign duplicate (no fallback, no diagnostic), one forcing the fallback with an unregistered orphan so the dedup itself is exercised. Both fail without the fix. - `litegraphUtil.test.ts`: the widget-identity regressions asserted identity with `toEqual`, so a clone would have passed; `expect(node.widgets).toEqual([first, frozen])` compared the array to its own contents and could not fail. Now `toBe` per entry, with names asserted explicitly. - `LGraph.serialise.test.ts`: give the adapter-only fixture a real node id instead of pinning the diagnostic on `-1`, which `add()` can never produce. - **Breaking**: none. ## Review Focus `LGraph.ts` is the only behaviour change here. Verified against `main`: | `_nodes` | stored | `main` | Comfy-Org#16381 head | this branch | | --- | --- | --- | --- | --- | | `[n, n]` | `{n}` | `[n]` | `[n, n]` — corrupt | `[n]`, no diagnostic | | `[n]` after double-add + remove | `{}` | `[]` — silent data loss | `[n]` | `[n]` | The branch's new guard genuinely fixes the second row, so it should stay — only the fallback needed deduplicating. Two reviewer notes left as-is, deliberately: - The third arm of the diagnostic string (`N stored nodes do not match M live nodes`) is now unreachable, since the guard and the arms use the same key sets. It is error-message text on an error path, so removing it would mean either a non-null assertion or `undefined` in a log line. - `mapLiveWidgetsById`'s synthetic `name#N` ids are not registered in `widgetValueStore`, so no consumer can observe them. That non-registration is intentional (a read helper must not mutate the store), but the JSDoc still describes the pre-Comfy-Org#16381 contract. Separately: Comfy-Org#16381 is titled `test:` but ships runtime changes to `LGraph.ts` and `litegraphUtil.ts`. Both sit on error paths with no healthy-path difference, but the title is worth updating so reviewers know the serialisation path is in play. ## Verification - `pnpm typecheck`, `pnpm lint` (0 errors), `pnpm format:check`, `pnpm knip`, `pnpm build` — all clean. - Full `pnpm test:unit`: 1440/1443 files pass. The failures (`AgentPanelRoot`, `GettingStartedScreen`, `agentPanel`, `presetService`, `useWorkspaceAuth`, `useFirstRunTourController`) reproduce identically on `origin/main` in this sandbox and are unrelated to these files. - The 7 test files this PR touches: 196 tests, all pass. - Manual: ComfyUI backend + dev server, default workflow loaded in Chromium. 10 nodes serialise with unique ids and no `Cannot serialize graph …` diagnostic; save → reload → re-serialise is byte-identical; a prompt edit made in the UI reaches both the workflow JSON and `graphToPrompt`; all 20 live widgets map 1:1 through `mapLiveWidgetsById` and resolve back to themselves via `getWidgetIdForNode`. ## Screenshots Default workflow loaded against a live backend, and the same graph after editing the positive prompt through the UI. ## Screenshots   --------- Co-authored-by: Pipeline Agent <agent@pipeline.local> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Summary
Every rich-widget feature boundary that talks to widgetValueStore has been hand-writing the same three steps: derive the WidgetId from graphId:nodeId:name, read or write the store, and fall back to the live widget object for nodes whose widgets are not registered.
Extract that into core/graph/widgets/nodeWidgetValues and adopt it in the compositor boundary, which keeps its typed CompositorWidgetValue surface and delegates the plumbing.
The read resolves the entity first, store state when registered, the widget object only when the store has no entry, so a registered-but-nullish store value is preserved instead of resurrecting a stale widget object value (same distinction as the maskeditor adapter in #15962, suggested by review on #15964).
Follow-ups migrate the remaining feature boundaries (painter, bbox editor, camera-info, maskeditor) to the same helper.