Repository navigation
[backport cloud/1.52] fix: clarify missing core node version warning - #16181
Conversation
## ELI5 The warning says a workflow was created with a newer ComfyUI version, but the number shown is actually the currently installed backend version. This changes the warning to say that some missing core nodes require a newer ComfyUI version and asks the user to update. ## Motivation MissingNodeCard receives the current ComfyUI version from /system_stats. Describing that value as the workflow creation version is misleading. The new copy matches the actual data source and gives users the appropriate next step. ## Provenance - **Authored by:** interactive session - **Verified:** targeted MissingNodeCard tests, format check, lint, typecheck, knip, and locale check - **Deviations:** none ## Reviewer context - **Type:** bug fix for missing-core-node guidance - **Slots into:** right-side-panel workflow issue reporting - **Not in scope:** core-node metadata detection or workflow serialization ## Summary Clarify that missing core nodes may require a newer ComfyUI version and that the displayed version is the current installation. ## Changes - **What:** Replace the misleading workflow-creation wording with update guidance. - **Localization:** Replace the old keys so the release translation pipeline queues the new copy and prunes the obsolete translations. ## Review Focus Confirm that the warning distinguishes the current installed version from the required versions listed for missing core nodes. ## Test plan - MissingNodeCard unit tests: 21 passed - pnpm format:check - pnpm lint: 0 errors - pnpm typecheck - pnpm knip - pnpm locale:check: new keys queued for translation; 0 protected-token violations ## Screenshots Before <img width="569" height="127" alt="스크린샷 2026-08-28 오후 1 30 32" src="https://github.com/user-attachments/assets/f5d00960-f4f0-4101-92c8-a9206d03539b" /> After <img width="558" height="111" alt="스크린샷 2026-08-28 오후 1 30 42" src="https://github.com/user-attachments/assets/73767250-d76c-4b11-b2ac-5267502d0bd2" />
🎭 Playwright: ✅ 1985 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-28T10:12:50.815Z",
"gitSha": "9bb51ae9b74664542f5bfa8111a91e398beb38c4",
"branch": "backport-16166-to-cloud-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2069.818000000055,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.426999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.539,
"heapDeltaBytes": 15779572,
"heapUsedBytes": 78161904,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.208000000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2039.637999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.627,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.91,
"heapDeltaBytes": 15627684,
"heapUsedBytes": 78024472,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.914,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.5870000000195,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.396,
"layouts": 12,
"layoutDurationMs": 3.5379999999999994,
"taskDurationMs": 849.463,
"heapDeltaBytes": -3996788,
"heapUsedBytes": 58913824,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 110.389,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1836.5840000000162,
"styleRecalcs": 72,
"styleRecalcDurationMs": 34.22899999999999,
"layouts": 12,
"layoutDurationMs": 3.5089999999999995,
"taskDurationMs": 850.955,
"heapDeltaBytes": -5251184,
"heapUsedBytes": 57350880,
"domNodes": -285,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 108.23,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.3399999999465,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.517999999999997,
"layouts": 6,
"layoutDurationMs": 0.6050000000000001,
"taskDurationMs": 359.765,
"heapDeltaBytes": 3328816,
"heapUsedBytes": 65875108,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.719000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.1819999999989,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.869,
"layouts": 6,
"layoutDurationMs": 0.525,
"taskDurationMs": 355.248,
"heapDeltaBytes": 3002684,
"heapUsedBytes": 65752768,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.966,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 588.7269999999489,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.038000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.379,
"heapDeltaBytes": 10899324,
"heapUsedBytes": 73457684,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 53.787,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 596.3289999999688,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.8180000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.738,
"heapDeltaBytes": 10904220,
"heapUsedBytes": 73491600,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 60.455,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.0249999999478,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.050999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.0779999999999,
"heapDeltaBytes": -6051808,
"heapUsedBytes": 71444632,
"domNodes": -281,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 13.907000000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.3379999999906,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.095,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.951,
"heapDeltaBytes": -12507472,
"heapUsedBytes": 64659708,
"domNodes": -280,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 15.319999999999997,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2183.5729999999103,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.976000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1184.471,
"heapDeltaBytes": -14280588,
"heapUsedBytes": 63836984,
"domNodes": -285,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 346.383,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.610999999907,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1184.481,
"heapDeltaBytes": -8338400,
"heapUsedBytes": 69879068,
"domNodes": -279,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 331.433,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3162.7449999999726,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.168999999999997,
"layouts": 60,
"layoutDurationMs": 7.1979999999999995,
"taskDurationMs": 1381.262,
"heapDeltaBytes": -14249944,
"heapUsedBytes": 65271640,
"domNodes": -291,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 380.769,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3198.3619999999746,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.576000000000002,
"layouts": 60,
"layoutDurationMs": 7.377000000000001,
"taskDurationMs": 1378.4399999999998,
"heapDeltaBytes": -12924556,
"heapUsedBytes": 66651024,
"domNodes": -288,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 383.616,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2258.1440000000157,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.900999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1423.6449999999998,
"heapDeltaBytes": -17248064,
"heapUsedBytes": 70213556,
"domNodes": 14,
"jsHeapTotalBytes": 8687616,
"scriptDurationMs": 452.13100000000003,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2222.405999999978,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.655999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1394.838,
"heapDeltaBytes": -17274952,
"heapUsedBytes": 69953860,
"domNodes": 14,
"jsHeapTotalBytes": 8949760,
"scriptDurationMs": 449.13599999999997,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2045.906000000059,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.640999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.825,
"heapDeltaBytes": -12151732,
"heapUsedBytes": 73088712,
"domNodes": -281,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 12.847000000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2045.372000000043,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.513999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.649,
"heapDeltaBytes": -12015412,
"heapUsedBytes": 71318132,
"domNodes": -278,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 16.187,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.3419999999833,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.813999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.42599999999993,
"heapDeltaBytes": 11433424,
"heapUsedBytes": 74642148,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 115.38000000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.081000000031,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.075000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.69100000000003,
"heapDeltaBytes": 11538248,
"heapUsedBytes": 74553924,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 114.83100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.742000000031,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.74300000000005,
"heapDeltaBytes": -7034308,
"heapUsedBytes": 55929360,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.214999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.6730000000016,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.322999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.912,
"heapDeltaBytes": -6771452,
"heapUsedBytes": 56031856,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.128,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.8709999999783,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.823,
"layouts": 16,
"layoutDurationMs": 4.457,
"taskDurationMs": 780.1120000000001,
"heapDeltaBytes": 19399812,
"heapUsedBytes": 82412116,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 85.236,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.5319999999638,
"styleRecalcs": 74,
"styleRecalcDurationMs": 33.897,
"layouts": 16,
"layoutDurationMs": 4.155000000000001,
"taskDurationMs": 790.628,
"heapDeltaBytes": 14813896,
"heapUsedBytes": 77870700,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 84.33200000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.262000000027,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.38500000000001,
"layouts": 14,
"layoutDurationMs": 14.411999999999999,
"taskDurationMs": 912.8929999999999,
"heapDeltaBytes": 22133752,
"heapUsedBytes": 105031556,
"domNodes": 13673,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 15.575999999999993,
"eventListeners": 2373,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8348.94200000008,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.283,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4302.278,
"heapDeltaBytes": -2322556,
"heapUsedBytes": 74308472,
"domNodes": -281,
"jsHeapTotalBytes": 5459968,
"scriptDurationMs": 1157.508,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8280.038999999988,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.591,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4188.95,
"heapDeltaBytes": -259416,
"heapUsedBytes": 77256344,
"domNodes": -284,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 1054.193,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16920.63500000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16323.218999999997,
"heapDeltaBytes": -49146948,
"heapUsedBytes": 176292704,
"domNodes": -8312,
"jsHeapTotalBytes": -18128896,
"scriptDurationMs": 104.987,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17011.92100000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16441.742,
"heapDeltaBytes": -38545836,
"heapUsedBytes": 177611928,
"domNodes": -8312,
"jsHeapTotalBytes": -21782528,
"scriptDurationMs": 100.21,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19843.42300000003,
"styleRecalcs": 164,
"styleRecalcDurationMs": 15.23399999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19313.284,
"heapDeltaBytes": -19111620,
"heapUsedBytes": 193241264,
"domNodes": -8312,
"jsHeapTotalBytes": -16932864,
"scriptDurationMs": 383.173,
"eventListeners": -16387,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 19761.720999999965,
"styleRecalcs": 159,
"styleRecalcDurationMs": 15.652,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19231.923,
"heapDeltaBytes": -37184068,
"heapUsedBytes": 194451420,
"domNodes": -8312,
"jsHeapTotalBytes": -23601152,
"scriptDurationMs": 384.727,
"eventListeners": -16387,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 471.2129999999206,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.915,
"layouts": 5,
"layoutDurationMs": 1.788,
"taskDurationMs": 128.526,
"heapDeltaBytes": 5347196,
"heapUsedBytes": 67937824,
"domNodes": 150,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.775999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 449.3130000000747,
"styleRecalcs": 11,
"styleRecalcDurationMs": 15.778,
"layouts": 2,
"layoutDurationMs": 0.402,
"taskDurationMs": 92.69800000000001,
"heapDeltaBytes": 4990052,
"heapUsedBytes": 67758104,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.736000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.52 #16181 +/- ##
==============================================
+ Coverage 79.66% 82.03% +2.36%
==============================================
Files 2242 1912 -330
Lines 115219 110217 -5002
Branches 33457 32267 -1190
==============================================
- Hits 91791 90418 -1373
+ Misses 22949 19451 -3498
+ Partials 479 348 -131
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 344 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #16166 to
cloud/1.52Automatically created by backport workflow.