Repository navigation
[backport core/1.52] fix: clarify missing core node version warning - #16180
Conversation
## ELI5 The warning says a workflow was created with a newer ComfyUI version, but the number shown is actually the currently installed backend version. This changes the warning to say that some missing core nodes require a newer ComfyUI version and asks the user to update. ## Motivation MissingNodeCard receives the current ComfyUI version from /system_stats. Describing that value as the workflow creation version is misleading. The new copy matches the actual data source and gives users the appropriate next step. ## Provenance - **Authored by:** interactive session - **Verified:** targeted MissingNodeCard tests, format check, lint, typecheck, knip, and locale check - **Deviations:** none ## Reviewer context - **Type:** bug fix for missing-core-node guidance - **Slots into:** right-side-panel workflow issue reporting - **Not in scope:** core-node metadata detection or workflow serialization ## Summary Clarify that missing core nodes may require a newer ComfyUI version and that the displayed version is the current installation. ## Changes - **What:** Replace the misleading workflow-creation wording with update guidance. - **Localization:** Replace the old keys so the release translation pipeline queues the new copy and prunes the obsolete translations. ## Review Focus Confirm that the warning distinguishes the current installed version from the required versions listed for missing core nodes. ## Test plan - MissingNodeCard unit tests: 21 passed - pnpm format:check - pnpm lint: 0 errors - pnpm typecheck - pnpm knip - pnpm locale:check: new keys queued for translation; 0 protected-token violations ## Screenshots Before <img width="569" height="127" alt="스크린샷 2026-08-28 오후 1 30 32" src="https://github.com/user-attachments/assets/f5d00960-f4f0-4101-92c8-a9206d03539b" /> After <img width="558" height="111" alt="스크린샷 2026-08-28 오후 1 30 42" src="https://github.com/user-attachments/assets/73767250-d76c-4b11-b2ac-5267502d0bd2" />
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1982 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-28T10:12:58.564Z",
"gitSha": "aa38f3f1957dceb85764eb0bcd9d8a5c7b8d4edd",
"branch": "backport-16166-to-core-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.7160000000085,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.975999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.583,
"heapDeltaBytes": 18580196,
"heapUsedBytes": 80628816,
"domNodes": -284,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.345,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2042.9929999999104,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.133,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.9,
"heapDeltaBytes": -6128732,
"heapUsedBytes": 55186960,
"domNodes": -283,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 7.039,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2029.8680000000218,
"styleRecalcs": 79,
"styleRecalcDurationMs": 48.905,
"layouts": 12,
"layoutDurationMs": 3.8510000000000004,
"taskDurationMs": 1010.3009999999999,
"heapDeltaBytes": 6829564,
"heapUsedBytes": 69084348,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 122.873,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1869.0740000000687,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.914,
"layouts": 12,
"layoutDurationMs": 3.555,
"taskDurationMs": 858.939,
"heapDeltaBytes": -4720272,
"heapUsedBytes": 57790756,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 109.457,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.0449999999892,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.599999999999998,
"layouts": 6,
"layoutDurationMs": 0.6280000000000001,
"taskDurationMs": 354.751,
"heapDeltaBytes": 3374484,
"heapUsedBytes": 64933512,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.255,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.4380000000347,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.200999999999997,
"layouts": 6,
"layoutDurationMs": 0.672,
"taskDurationMs": 357.973,
"heapDeltaBytes": 3396124,
"heapUsedBytes": 65287604,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.477,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 546.2749999999801,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.473000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.271,
"heapDeltaBytes": 10962564,
"heapUsedBytes": 73557952,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 53.752,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 582.997999999975,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.462000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.615,
"heapDeltaBytes": 10827448,
"heapUsedBytes": 73781428,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 54.623,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2053.346999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.3029999999999,
"heapDeltaBytes": -938060,
"heapUsedBytes": 75885252,
"domNodes": -269,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 15.195999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2020.9539999999606,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.429000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.663,
"heapDeltaBytes": 13590904,
"heapUsedBytes": 89730524,
"domNodes": -282,
"jsHeapTotalBytes": 4452352,
"scriptDurationMs": 15.115,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2198.5559999999964,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.210999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1220.029,
"heapDeltaBytes": -7305084,
"heapUsedBytes": 70521720,
"domNodes": -281,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 337.152,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2147.0220000001063,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.520999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1225.406,
"heapDeltaBytes": -7828364,
"heapUsedBytes": 70125092,
"domNodes": -282,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 342.526,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3196.466999999984,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.714,
"layouts": 60,
"layoutDurationMs": 6.824,
"taskDurationMs": 1369.44,
"heapDeltaBytes": 16095076,
"heapUsedBytes": 78874052,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 407.634,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3127.4680000000217,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.891,
"layouts": 60,
"layoutDurationMs": 6.971,
"taskDurationMs": 1370.3539999999998,
"heapDeltaBytes": -1525836,
"heapUsedBytes": 77507168,
"domNodes": -278,
"jsHeapTotalBytes": -2101248,
"scriptDurationMs": 380.219,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2234.671999999989,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.138999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1400.581,
"heapDeltaBytes": -17306948,
"heapUsedBytes": 69916500,
"domNodes": 10,
"jsHeapTotalBytes": 8163328,
"scriptDurationMs": 446.02599999999995,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2425.194000000033,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.280000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1513.946,
"heapDeltaBytes": -22766020,
"heapUsedBytes": 64315696,
"domNodes": -248,
"jsHeapTotalBytes": 4976640,
"scriptDurationMs": 479.33400000000006,
"eventListeners": 29,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.199999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.993999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.153,
"heapDeltaBytes": -13153536,
"heapUsedBytes": 64915420,
"domNodes": -283,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 14.886000000000003,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2045.6530000000157,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.352000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.614,
"heapDeltaBytes": -12219992,
"heapUsedBytes": 71325164,
"domNodes": -282,
"jsHeapTotalBytes": 4452352,
"scriptDurationMs": 14.014000000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.3350000000064,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.423,
"heapDeltaBytes": 11913044,
"heapUsedBytes": 74204868,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 126.75,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.6640000000561,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.159,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.7,
"heapDeltaBytes": 11827480,
"heapUsedBytes": 74374744,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 118.95299999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.9909999999809,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.819000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.113,
"heapDeltaBytes": -7349324,
"heapUsedBytes": 55686128,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.0539999999999985,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.4649999999683,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.498,
"heapDeltaBytes": -5062664,
"heapUsedBytes": 57427956,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.801,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.8020000000101,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.02799999999999,
"layouts": 16,
"layoutDurationMs": 4.071,
"taskDurationMs": 781.5269999999999,
"heapDeltaBytes": -4617148,
"heapUsedBytes": 57991404,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 82.981,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.0320000000174,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.241,
"layouts": 16,
"layoutDurationMs": 4.53,
"taskDurationMs": 822.988,
"heapDeltaBytes": -5257164,
"heapUsedBytes": 57100876,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 89.159,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.7590000000173,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.372999999999998,
"layouts": 14,
"layoutDurationMs": 14.520000000000001,
"taskDurationMs": 910.9939999999999,
"heapDeltaBytes": -4105412,
"heapUsedBytes": 84014392,
"domNodes": 13673,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 16.240999999999993,
"eventListeners": 2373,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8780.54800000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.263000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4440.192000000001,
"heapDeltaBytes": 6460228,
"heapUsedBytes": 83331928,
"domNodes": -244,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 1111.991,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8245.173000000023,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.865,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4222.906,
"heapDeltaBytes": 495452,
"heapUsedBytes": 77899504,
"domNodes": -279,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 1051.597,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16998.355000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16431.697,
"heapDeltaBytes": -38360024,
"heapUsedBytes": 177476712,
"domNodes": -8312,
"jsHeapTotalBytes": -20242432,
"scriptDurationMs": 112.371,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17486.505999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16779.082,
"heapDeltaBytes": -40088080,
"heapUsedBytes": 180713228,
"domNodes": -8312,
"jsHeapTotalBytes": -24514560,
"scriptDurationMs": 113.21300000000001,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20607.092999999964,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.020000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19959.394,
"heapDeltaBytes": -18984160,
"heapUsedBytes": 193043068,
"domNodes": -8312,
"jsHeapTotalBytes": -16101376,
"scriptDurationMs": 400.329,
"eventListeners": -16387,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21099.72000000005,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.689999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20542.543999999998,
"heapDeltaBytes": -25995804,
"heapUsedBytes": 186559004,
"domNodes": -8312,
"jsHeapTotalBytes": -16363520,
"scriptDurationMs": 467.399,
"eventListeners": -16381,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 449.00799999993524,
"styleRecalcs": 11,
"styleRecalcDurationMs": 16.087999999999997,
"layouts": 2,
"layoutDurationMs": 0.3109999999999999,
"taskDurationMs": 97.158,
"heapDeltaBytes": 5010020,
"heapUsedBytes": 67641596,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.0360000000000005,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 125.88799999991807,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.637,
"layouts": 3,
"layoutDurationMs": 1.09,
"taskDurationMs": 82.656,
"heapDeltaBytes": 2996676,
"heapUsedBytes": 64904924,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.043000000000001,
"eventListeners": 27,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.52 #16180 +/- ##
==========================================
Coverage 82.03% 82.03%
==========================================
Files 1907 1907
Lines 109043 109043
Branches 29761 29761
==========================================
Hits 89448 89448
+ Misses 19258 19257 -1
- Partials 337 338 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #16166 to
core/1.52Automatically created by backport workflow.