Repository navigation
[backport core/1.51] fix: clarify missing core node version warning - #16178
Conversation
## ELI5 The warning says a workflow was created with a newer ComfyUI version, but the number shown is actually the currently installed backend version. This changes the warning to say that some missing core nodes require a newer ComfyUI version and asks the user to update. ## Motivation MissingNodeCard receives the current ComfyUI version from /system_stats. Describing that value as the workflow creation version is misleading. The new copy matches the actual data source and gives users the appropriate next step. ## Provenance - **Authored by:** interactive session - **Verified:** targeted MissingNodeCard tests, format check, lint, typecheck, knip, and locale check - **Deviations:** none ## Reviewer context - **Type:** bug fix for missing-core-node guidance - **Slots into:** right-side-panel workflow issue reporting - **Not in scope:** core-node metadata detection or workflow serialization ## Summary Clarify that missing core nodes may require a newer ComfyUI version and that the displayed version is the current installation. ## Changes - **What:** Replace the misleading workflow-creation wording with update guidance. - **Localization:** Replace the old keys so the release translation pipeline queues the new copy and prunes the obsolete translations. ## Review Focus Confirm that the warning distinguishes the current installed version from the required versions listed for missing core nodes. ## Test plan - MissingNodeCard unit tests: 21 passed - pnpm format:check - pnpm lint: 0 errors - pnpm typecheck - pnpm knip - pnpm locale:check: new keys queued for translation; 0 protected-token violations ## Screenshots Before <img width="569" height="127" alt="스크린샷 2026-08-28 오후 1 30 32" src="https://github.com/user-attachments/assets/f5d00960-f4f0-4101-92c8-a9206d03539b" /> After <img width="558" height="111" alt="스크린샷 2026-08-28 오후 1 30 42" src="https://github.com/user-attachments/assets/73767250-d76c-4b11-b2ac-5267502d0bd2" />
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1830 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-28T10:12:12.260Z",
"gitSha": "82c745f0ac81243ec076642127fe1c428792dc53",
"branch": "backport-16166-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2036.736000000019,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.701,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.466,
"heapDeltaBytes": 5166768,
"heapUsedBytes": 70520912,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 9.724,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2032.944999999927,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.428,
"heapDeltaBytes": 5081356,
"heapUsedBytes": 70666008,
"domNodes": 16,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 8.573,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1965.101999999888,
"styleRecalcs": 77,
"styleRecalcDurationMs": 46.328,
"layouts": 12,
"layoutDurationMs": 3.8600000000000003,
"taskDurationMs": 984.3920000000002,
"heapDeltaBytes": -187572,
"heapUsedBytes": 65124252,
"domNodes": 60,
"jsHeapTotalBytes": 25432064,
"scriptDurationMs": 128.36299999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1917.316000000028,
"styleRecalcs": 75,
"styleRecalcDurationMs": 41.481,
"layouts": 12,
"layoutDurationMs": 4.071,
"taskDurationMs": 946.703,
"heapDeltaBytes": -16706952,
"heapUsedBytes": 48818924,
"domNodes": -283,
"jsHeapTotalBytes": 22908928,
"scriptDurationMs": 123.02,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.375,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.976,
"layouts": 6,
"layoutDurationMs": 0.5720000000000001,
"taskDurationMs": 386.7269999999999,
"heapDeltaBytes": 7926168,
"heapUsedBytes": 73183180,
"domNodes": 75,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 10.286999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.4780000001338,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.083000000000002,
"layouts": 6,
"layoutDurationMs": 0.591,
"taskDurationMs": 434.035,
"heapDeltaBytes": 8220920,
"heapUsedBytes": 73587248,
"domNodes": 75,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 12.818999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 645.4909999999927,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.393,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.597,
"heapDeltaBytes": -11588320,
"heapUsedBytes": 53754084,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 62.035000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 610.1949999999761,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.383,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.97499999999997,
"heapDeltaBytes": -10674764,
"heapUsedBytes": 54838844,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 60.144000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.0889999999708,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.609000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.4990000000001,
"heapDeltaBytes": 8187688,
"heapUsedBytes": 68340708,
"domNodes": -282,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 16.863,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2011.8720000000394,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.7929999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 720.4920000000001,
"heapDeltaBytes": 12424784,
"heapUsedBytes": 72338568,
"domNodes": -282,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 19.456,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2254.139000000123,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.459000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1280.548,
"heapDeltaBytes": 8034032,
"heapUsedBytes": 68750776,
"domNodes": -282,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 368.35200000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2233.932999999979,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.396999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1264.8029999999999,
"heapDeltaBytes": 7549388,
"heapUsedBytes": 69001536,
"domNodes": -286,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 348.36,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3181.3280000001214,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.634,
"layouts": 60,
"layoutDurationMs": 7.4559999999999995,
"taskDurationMs": 1349.5220000000002,
"heapDeltaBytes": 16945004,
"heapUsedBytes": 79710124,
"domNodes": 12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 390.85900000000004,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3378.2719999999244,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.803999999999998,
"layouts": 60,
"layoutDurationMs": 8.203999999999999,
"taskDurationMs": 1490.9360000000001,
"heapDeltaBytes": 3325456,
"heapUsedBytes": 65611536,
"domNodes": -287,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 417.583,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.7299999999432,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.535999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.9069999999999,
"heapDeltaBytes": 12843208,
"heapUsedBytes": 73807592,
"domNodes": -285,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 15.134000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2012.958000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.640999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.6790000000001,
"heapDeltaBytes": 10399392,
"heapUsedBytes": 71465544,
"domNodes": -284,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 17.017999999999997,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.8900000000449,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.93,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.05899999999997,
"heapDeltaBytes": -11070676,
"heapUsedBytes": 54371120,
"domNodes": 18,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 118.483,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.5009999999911,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.585,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.60600000000005,
"heapDeltaBytes": -9843704,
"heapUsedBytes": 55660940,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 126.69999999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2024.1080000000693,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.71599999999995,
"heapDeltaBytes": 5547208,
"heapUsedBytes": 71116752,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 7.994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.3289999998706,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.331000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.70899999999995,
"heapDeltaBytes": 5370464,
"heapUsedBytes": 70919296,
"domNodes": 20,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 8.655999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.7160000000094,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.389,
"layouts": 16,
"layoutDurationMs": 4.635999999999999,
"taskDurationMs": 808.4780000000001,
"heapDeltaBytes": -3615292,
"heapUsedBytes": 61907708,
"domNodes": 61,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 91.31700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.618999999966,
"styleRecalcs": 76,
"styleRecalcDurationMs": 40.692,
"layouts": 16,
"layoutDurationMs": 4.917,
"taskDurationMs": 833.611,
"heapDeltaBytes": -3858236,
"heapUsedBytes": 61931648,
"domNodes": 61,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 92.442,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.6390000000083,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.825999999999993,
"layouts": 14,
"layoutDurationMs": 12.839999999999998,
"taskDurationMs": 988.5659999999998,
"heapDeltaBytes": -5927452,
"heapUsedBytes": 77228312,
"domNodes": 13673,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 18.843,
"eventListeners": 2375,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8574.19200000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4353.3189999999995,
"heapDeltaBytes": 13112232,
"heapUsedBytes": 73633076,
"domNodes": -282,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 1056.933,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8677.753000000166,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.699999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4575.906,
"heapDeltaBytes": 14087736,
"heapUsedBytes": 74772060,
"domNodes": -281,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 1129.047,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17573.439999999893,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16797.483,
"heapDeltaBytes": -52651024,
"heapUsedBytes": 171685212,
"domNodes": -8312,
"jsHeapTotalBytes": -6496256,
"scriptDurationMs": 118.263,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17993.709000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17100.452,
"heapDeltaBytes": -56992456,
"heapUsedBytes": 171408896,
"domNodes": -8312,
"jsHeapTotalBytes": -10428416,
"scriptDurationMs": 127.281,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21357.964999999924,
"styleRecalcs": 178,
"styleRecalcDurationMs": 20.127000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20791.367000000002,
"heapDeltaBytes": -26579624,
"heapUsedBytes": 172198452,
"domNodes": -8312,
"jsHeapTotalBytes": -14692352,
"scriptDurationMs": 439.96100000000007,
"eventListeners": -16383,
"totalBlockingTimeMs": 68,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21423.763000000006,
"styleRecalcs": 175,
"styleRecalcDurationMs": 20.751999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20741.926,
"heapDeltaBytes": -36472512,
"heapUsedBytes": 176408932,
"domNodes": -8312,
"jsHeapTotalBytes": -13381632,
"scriptDurationMs": 421.96500000000003,
"eventListeners": -16381,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.15600000014456,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.626000000000005,
"layouts": 3,
"layoutDurationMs": 0.6429999999999999,
"taskDurationMs": 108.407,
"heapDeltaBytes": 4980948,
"heapUsedBytes": 69633380,
"domNodes": 124,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.55,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 487.002000000075,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.298999999999996,
"layouts": 3,
"layoutDurationMs": 1.1540000000000001,
"taskDurationMs": 133.12400000000002,
"heapDeltaBytes": 5080844,
"heapUsedBytes": 69632208,
"domNodes": 147,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.929000000000002,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🎭 Playwright: ⏳ Running... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.51 #16178 +/- ##
===========================================
Coverage 81.70% 81.70%
===========================================
Files 1885 1885
Lines 107291 107291
Branches 29622 30090 +468
===========================================
Hits 87659 87659
+ Misses 19297 19288 -9
- Partials 335 344 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #16166 to
core/1.51Automatically created by backport workflow.