Skip to content

test: consolidate repeated asset mocks - #16162

Closed
DrJKL wants to merge 2 commits into
amp/pr-15381-review-proposalsfrom
amp/pr-16131-more-vitest-automocks
Closed

DrJKL wants to merge 2 commits into
amp/pr-15381-review-proposalsfrom
amp/pr-16131-more-vitest-automocks

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Already incorporated into main by #15381, merged September 2, 2026. This historical proposal still targets amp/pr-15381-review-proposals; it does not need another merge.

Changes

  • The adjacent api and outputAssetUtil manual mocks are identical on main. Their adopters now use typed, factory-free vi.mock(import(...)) calls.
  • resolveOutputAssetItems already uses a constructor-supplied async default that survives mock resets.
  • Further cleanup belongs to FE-2343, following the conventions in #17714.

Review Focus

The shared API mock still uses fromPartial<typeof RealApi>, and makeResolvedOutput in useWidgetSelectItems.test.ts uses partial asset fixtures. These do not meet the current effort's complete-fixture standard. Address them against current main, preserving scenario results and rejection behavior; do not broaden the partial API mock to consolidate additional consumers.

Keep real imports with vi.mocked, constructor-supplied defaults, and scenario-local overrides. Prefer the real collaborator when a mock is unnecessary. Do not merge this stale proposal branch to reintroduce changes already on main.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 13de6606-5f19-4071-ac9b-8de6f361b84c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/28/2026, 03:56:42 AM UTC

Links

🎭 Playwright: ✅ 2014 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1993 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 3ms TBT · 81.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 139ms TBT · 81.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.8 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.6 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 58ms TBT · 183.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 522ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.8 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -185
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 41ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 1235ms
canvas-mouse-sweep: script duration 158ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.8 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 384ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.2 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 671ms
dom-widget-clipping: script duration 143ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 74.9 MB
dom-widget-clipping: DOM nodes 13
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 557ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 70.6 MB
large-graph-idle: DOM nodes -275
large-graph-idle: event listeners -183
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 2467ms
large-graph-pan: script duration 882ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 86.0 MB
large-graph-pan: DOM nodes -134
large-graph-pan: event listeners -72
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 2404ms
large-graph-zoom: script duration 805ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.1 MB
large-graph-zoom: DOM nodes -118
large-graph-zoom: event listeners -84
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 3520ms
legacy-node-drag: script duration 981ms
legacy-node-drag: TBT 3ms
legacy-node-drag: heap used 81.3 MB
legacy-node-drag: DOM nodes -141
legacy-node-drag: event listeners 98
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 0ms
minimap-idle: layout count 0
minimap-idle: style recalc count 0
minimap-idle: task duration 481ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 74.3 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 4
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 509ms
subgraph-dom-widget-clipping: script duration 137ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 61.9 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 527ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.0 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 1160ms
subgraph-mouse-sweep: script duration 114ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 74.8 MB
subgraph-mouse-sweep: DOM nodes -299
subgraph-mouse-sweep: event listeners -231
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 13
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 933ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 139ms
subgraph-transition-enter: heap used 81.4 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 245
viewport-pan-sweep: task duration 8743ms
viewport-pan-sweep: script duration 3034ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.8 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -129
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16839ms
vue-large-graph-idle: script duration 309ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.6 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 175
vue-large-graph-pan: task duration 21025ms
vue-large-graph-pan: script duration 905ms
vue-large-graph-pan: TBT 58ms
vue-large-graph-pan: heap used 183.3 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 120ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.5 MB
workflow-execution: DOM nodes 130
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-08-28T04:16:59.949Z",
  "gitSha": "dfe98b42b756365fcbcde9c238f89955463f0de5",
  "branch": "amp/pr-16131-more-vitest-automocks",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2059.707000000003,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.489999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 535.373,
      "heapDeltaBytes": -6960784,
      "heapUsedBytes": 63607300,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.814,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.1239999999489,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.442,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.6900000000001,
      "heapDeltaBytes": -433436,
      "heapUsedBytes": 70225444,
      "domNodes": -279,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.366999999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2303.457999999978,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 43.316,
      "layouts": 12,
      "layoutDurationMs": 3.528,
      "taskDurationMs": 1303.512,
      "heapDeltaBytes": 3254940,
      "heapUsedBytes": 75392744,
      "domNodes": -283,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 166.374,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2155.885000000012,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.585,
      "layouts": 12,
      "layoutDurationMs": 3.6670000000000003,
      "taskDurationMs": 1165.67,
      "heapDeltaBytes": 3018232,
      "heapUsedBytes": 75159032,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 149.705,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.1629999999818,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.088000000000005,
      "layouts": 6,
      "layoutDurationMs": 0.58,
      "taskDurationMs": 368.471,
      "heapDeltaBytes": 4551528,
      "heapUsedBytes": 76762260,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.68,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.0460000000303,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.813000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.603,
      "taskDurationMs": 398.80299999999994,
      "heapDeltaBytes": 4522384,
      "heapUsedBytes": 76700960,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 12.796000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 911.8229999999699,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.939999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 676.2139999999999,
      "heapDeltaBytes": 6469980,
      "heapUsedBytes": 78805144,
      "domNodes": 12,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 143.149,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 927.8380000000652,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.403,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 666.2669999999999,
      "heapDeltaBytes": 7012144,
      "heapUsedBytes": 78332608,
      "domNodes": 14,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 142.407,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.3639999999727,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.9190000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 546.076,
      "heapDeltaBytes": -2202636,
      "heapUsedBytes": 76975568,
      "domNodes": -274,
      "jsHeapTotalBytes": -1884160,
      "scriptDurationMs": 35.187000000000005,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2053.8609999999835,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.795,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 567.8930000000001,
      "heapDeltaBytes": -7014884,
      "heapUsedBytes": 71187864,
      "domNodes": -275,
      "jsHeapTotalBytes": -835584,
      "scriptDurationMs": 41.99499999999999,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3184.763999999973,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.141,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2463.517,
      "heapDeltaBytes": 28639488,
      "heapUsedBytes": 93740672,
      "domNodes": 4,
      "jsHeapTotalBytes": 3371008,
      "scriptDurationMs": 890.664,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3268.63000000003,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.365000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2470.457,
      "heapDeltaBytes": 6758760,
      "heapUsedBytes": 86679184,
      "domNodes": -271,
      "jsHeapTotalBytes": 2011136,
      "scriptDurationMs": 873.413,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4271.994000000006,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.092,
      "layouts": 60,
      "layoutDurationMs": 7.220000000000001,
      "taskDurationMs": 2393.3169999999996,
      "heapDeltaBytes": -3949012,
      "heapUsedBytes": 66752312,
      "domNodes": 24,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 803.608,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4279.269999999997,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.204999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.007999999999999,
      "taskDurationMs": 2413.801,
      "heapDeltaBytes": 4930292,
      "heapUsedBytes": 88638840,
      "domNodes": -260,
      "jsHeapTotalBytes": -835584,
      "scriptDurationMs": 806.812,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4765.028000000029,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.101000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3511.235,
      "heapDeltaBytes": 22901740,
      "heapUsedBytes": 90017532,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 981.624,
      "eventListeners": 192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4802.819999999997,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 4.952999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3528.999,
      "heapDeltaBytes": -6055120,
      "heapUsedBytes": 80547696,
      "domNodes": -282,
      "jsHeapTotalBytes": 892928,
      "scriptDurationMs": 981.013,
      "eventListeners": 3,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1995.2110000000403,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.42899999999986,
      "heapDeltaBytes": 12390692,
      "heapUsedBytes": 77841996,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.602000000000004,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.6159999999654,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.634,
      "heapDeltaBytes": 12632176,
      "heapUsedBytes": 77874936,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.553000000000004,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 694.9010000000158,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.191,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 513.908,
      "heapDeltaBytes": -8260304,
      "heapUsedBytes": 64612980,
      "domNodes": 16,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 136.784,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 726.0890000000018,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.773999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.93700000000007,
      "heapDeltaBytes": -7637504,
      "heapUsedBytes": 65127104,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 137.629,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2039.1440000000216,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.803,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 564.8649999999999,
      "heapDeltaBytes": -13089384,
      "heapUsedBytes": 59817756,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.421000000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.7120000000032,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.021,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.46,
      "heapDeltaBytes": -3674548,
      "heapUsedBytes": 68134204,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.224000000000001,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1874.0510000000086,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 40.762,
      "layouts": 16,
      "layoutDurationMs": 4.4990000000000006,
      "taskDurationMs": 1175.677,
      "heapDeltaBytes": 4298024,
      "heapUsedBytes": 76304644,
      "domNodes": -299,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 115.80600000000003,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1924.8440000000073,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 39.059,
      "layouts": 16,
      "layoutDurationMs": 4.353,
      "taskDurationMs": 1144.739,
      "heapDeltaBytes": 7735904,
      "heapUsedBytes": 80562680,
      "domNodes": -298,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 113.058,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1398.9939999999024,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.341,
      "layouts": 13,
      "layoutDurationMs": 14.292,
      "taskDurationMs": 933.15,
      "heapDeltaBytes": -7392236,
      "heapUsedBytes": 85350300,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.73100000000001,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 139,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12262.856,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 37.267999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8545.484,
      "heapDeltaBytes": 8717480,
      "heapUsedBytes": 87619796,
      "domNodes": -272,
      "jsHeapTotalBytes": 1978368,
      "scriptDurationMs": 2905.27,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12505.819000000087,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 33.526,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8940.352,
      "heapDeltaBytes": -3462608,
      "heapUsedBytes": 75501776,
      "domNodes": -272,
      "jsHeapTotalBytes": 2572288,
      "scriptDurationMs": 3162.07,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17509.191999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16949.862,
      "heapDeltaBytes": -42575176,
      "heapUsedBytes": 181592652,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1560576,
      "scriptDurationMs": 306.338,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17197.200000000066,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16729.124,
      "heapDeltaBytes": -45918664,
      "heapUsedBytes": 178333908,
      "domNodes": -6548,
      "jsHeapTotalBytes": -872448,
      "scriptDurationMs": 311.43,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21404.079000000023,
      "styleRecalcs": 177,
      "styleRecalcDurationMs": 17.762999999999973,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21035.628,
      "heapDeltaBytes": -16277580,
      "heapUsedBytes": 190431596,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1265664,
      "scriptDurationMs": 901.2070000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 37,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21292.162000000077,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 18.45599999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21014.646,
      "heapDeltaBytes": -12653996,
      "heapUsedBytes": 194052204,
      "domNodes": -6548,
      "jsHeapTotalBytes": -569344,
      "scriptDurationMs": 908.053,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 78,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 140.01600000005965,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 18.496,
      "layouts": 2,
      "layoutDurationMs": 0.8260000000000001,
      "taskDurationMs": 104.67099999999999,
      "heapDeltaBytes": 3735796,
      "heapUsedBytes": 71837700,
      "domNodes": 137,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.058,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 468.4310000000096,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 25.991,
      "layouts": 4,
      "layoutDurationMs": 1.3610000000000002,
      "taskDurationMs": 135.717,
      "heapDeltaBytes": 5838108,
      "heapUsedBytes": 73839580,
      "domNodes": 123,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.489999999999998,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@DrJKL
DrJKL force-pushed the amp/pr-16131-more-vitest-automocks branch from 20792b2 to 9687a9c Compare August 28, 2026 03:53
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...platform/assets/utils/__mocks__/outputAssetUtil.ts 50.00% 1 Missing ⚠️
src/scripts/__mocks__/api.ts 50.00% 1 Missing ⚠️
@@                        Coverage Diff                        @@
##           amp/pr-15381-review-proposals   #16162      +/-   ##
=================================================================
- Coverage                          82.58%   82.57%   -0.01%     
=================================================================
  Files                               1942     1944       +2     
  Lines                             111826   111829       +3     
  Branches                           32800    32802       +2     
=================================================================
- Hits                               92354    92346       -8     
- Misses                             19117    19131      +14     
+ Partials                             355      352       -3     
Flag Coverage Δ
e2e 66.82% <ø> (+<0.01%) ⬆️
unit 74.85% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...platform/assets/utils/__mocks__/outputAssetUtil.ts 50.00% <50.00%> (ø)
src/scripts/__mocks__/api.ts 50.00% <50.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@DrJKL DrJKL closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants