Skip to content

test: share asset mapper automock - #16149

Closed
DrJKL wants to merge 3 commits into
amp/pr-15381-review-proposalsfrom
amp/pr-16131-asset-mapper-automock
Closed

DrJKL wants to merge 3 commits into
amp/pr-15381-review-proposalsfrom
amp/pr-16131-asset-mapper-automock

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Already incorporated into main by #15381, merged September 2, 2026. This historical proposal still targets amp/pr-15381-review-proposals; it does not need another merge.

Changes

  • The adjacent assetMappers manual mock is identical on main, and all eleven adopters now use typed, factory-free vi.mock(import(...)) calls.
  • Further mock cleanup belongs to FE-2343, following the conventions in #17714.

Review Focus

Preserve tests that configure mapper results through real imports and vi.mocked. Prefer removing a mock when the real collaborator works, as in #17722. Do not merge this stale proposal branch to reintroduce changes already on main.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: a090aa50-721c-4797-aca4-afc2c7ae9e17

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2016 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1995 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/28/2026, 12:40:42 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 541775173aad79b522cabccb1e582034bac2247d

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                        Coverage Diff                        @@
##           amp/pr-15381-review-proposals   #16149      +/-   ##
=================================================================
- Coverage                          82.58%   82.57%   -0.02%     
=================================================================
  Files                               1942     1943       +1     
  Lines                             111826   111827       +1     
  Branches                           32800    32802       +2     
=================================================================
- Hits                               92354    92339      -15     
- Misses                             19117    19136      +19     
+ Partials                             355      352       -3     
Flag Coverage Δ
e2e 66.79% <ø> (-0.03%) ⬇️
unit 74.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...assets/composables/media/__mocks__/assetMappers.ts 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL assigned AustinMroz and unassigned DrJKL Aug 28, 2026
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@DrJKL DrJKL closed this Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants