Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2016 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 541775173aad79b522cabccb1e582034bac2247d
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## amp/pr-15381-review-proposals #16149 +/- ##
=================================================================
- Coverage 82.58% 82.57% -0.02%
=================================================================
Files 1942 1943 +1
Lines 111826 111827 +1
Branches 32800 32802 +2
=================================================================
- Hits 92354 92339 -15
- Misses 19117 19136 +19
+ Partials 355 352 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Already incorporated into
mainby #15381, merged September 2, 2026. This historical proposal still targetsamp/pr-15381-review-proposals; it does not need another merge.Changes
assetMappersmanual mock is identical onmain, and all eleven adopters now use typed, factory-freevi.mock(import(...))calls.Review Focus
Preserve tests that configure mapper results through real imports and
vi.mocked. Prefer removing a mock when the real collaborator works, as in #17722. Do not merge this stale proposal branch to reintroduce changes already onmain.