Skip to content

[backport cloud/1.52] fix(billing): harden sales-managed rendering against unreadable capabilities - #16148

Merged
comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16100-to-cloud-1.52
Aug 28, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-16100-to-cloud-1.52

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Backport of #16100 to cloud/1.52.

The automated backport cleaned up its successful Cloud branch after the parallel core/1.52 target conflicted. This recreates the Cloud backport from the merged target branch.

Verification

  • 6 affected unit suites: 215 tests passed
  • git diff --check passed

…ilities (#16100)

Follow-up to #16067. Five defects found while writing regression
coverage for the sales-managed tier surface it introduced.

- Fixes FE-1662 follow-up

## Root cause

**1. A sales-managed plan gets a Run button that does nothing.**
`CloudRunButtonWrapper.vue` renders the real `ComfyQueueButton` whenever
`isSalesManagedPlan`, even when `showsSubscribeToRunPrompt` is true.
`ComfyQueueButton` only self-disables on `paymentRecoveryLock`, so the
button is enabled. Clicking it reaches `blockRunWithoutSubscription()`,
which returns `true` and deliberately skips the dialog for sales-managed
tiers. Result: an ended Enterprise workspace shows an enabled Run button
that produces no dialog, no toast, no explanation. Before #16067 the
same user saw "Subscribe to run" — the wrong offer, but at least
legible.

**2. The whole pricing surface fails closed on an unreadable capability
snapshot.**
`canOpenPricingSurface` resolves to
`capabilities?.can_subscribe_self_serve ?? false`. That field is one of
three listed in `BillingCapabilityRolloutDefaults`, documented as
"capability values currently using safe rollout defaults instead of
deterministic policy results". #16067 moved three entry points — profile
menu, settings link, `?pricing=` deep link — onto it. During a
capabilities outage every self-serve owner loses all three, and the boot
window makes "Plans & pricing" pop in late on every load. `canTopUp`
already has an owner fallback for exactly this; `canSubscribeSelfServe`
has none.

**3. The inactive-credits zero-state is coupled to a rollout-defaulted
capability.**
`showsInactivePlanState = inactivePlan && !canTopUp`. `can_top_up` is
also rollout-defaulted, and `canTopUp` returns **true** for an owner
when the read is `unavailable` — so during an outage a lapsed self-serve
team drops out of the reactivate-to-use-credits treatment and sees its
real balance plus Add credits.

**4. The transition preview crashes on three real tiers.**

```ts
function tierMonthlyCredits(tier: string): number {
  return getTierCredits(tier.toLowerCase() as PersonalTierKey) ?? 0
}
```

`TIER_PRICING` holds only `standard | creator | pro`; `getTierCredits`
early-returns for `free` and `founder`. The cast is unchecked, so
`TIER_PRICING[key].credits` throws:

| tier | key | result |
|---|---|---|
| `FOUNDERS_EDITION` | `founders_edition` | **TypeError** (≠ `founder`)
|
| `ENTERPRISE` | `enterprise` | **TypeError** |
| unrecognized | — | **TypeError** |

`?? 0` cannot help — the throw happens inside the callee. `TEAM` is
spared only because the `teamPlan` prop short-circuits the call. This is
pre-existing, not introduced by #16067, but it contradicts that PR's
story 6 ("an unrecognized tier … no crash") and an Enterprise
scheduled-change preview walks straight into it.

**5.** `SOME_FUTURE_TIER` rendered as `Some_future_tier` (CodeRabbit on
#16067).

## How

1. `blockRunWithoutSubscription()` raises a warn toast naming the state
and routing to sales, instead of returning silently.
2. `useBillingCapabilities` derives `snapshotAuthoritative` directly
from its discriminated read state (`resolved` and `denied` are
authoritative for the current scope). `canOpenPricingSurface` uses that
policy result and otherwise falls back to membership. Opening the
catalog is navigation, not a billing write, and every checkout endpoint
enforces its own policy, so failing open here cannot authorize anything.
Mirrors `canTopUp`.
3. `showsInactivePlanState` keys off
`isSalesManagedTier(subscription.tier)`, matching #16067's own "tier
drives rendering only" principle and the `creditPoolTotalCredits`
computed directly above it.
4. `tierMonthlyCredits` routes through the validated `toTierKey`, and
`getTierCredits` becomes total (`TIER_PRICING[tierKey]?.credits ??
null`) so the existing `?? 0` does what it claims.
5. Split the raw tier on `[_-]+`, capitalize, join.

## Trade-off worth a reviewer's attention

Change 2 means that during a capabilities outage an Enterprise owner
could reach the pricing table. They cannot buy — the checkout endpoints
reject independently, per the contract's own "these values do not
authorize billing writes". Weighed against every self-serve owner losing
the upgrade path during the same outage, failing open on navigation is
the better default. Push back if you disagree.

## Tests

- Unit: **93 files, 1760 tests, 0 failures** across
`src/platform/workspace`, `src/platform/cloud/subscription`,
`src/composables/useCoreCommands.test.ts`, `src/components/actionbar`.
- New coverage: pricing-surface fallback for unresolved / unavailable
snapshots and a non-owner closed case; inactive-team zero-state held
while top-up reads open; sales-managed run emits a toast and no dialog;
`FOUNDERS_EDITION` refill renders; unknown tier renders as readable
words.
- Both transition-preview tests fail on `main` without this change — the
`SOME_FUTURE_TIER` one is what surfaced defect 4.
- E2E: ended Enterprise Run explains the blocked state; pricing deep
links remain available during capability 503s; inactive credits remain
disabled during the same outage.

## AS IS / TO BE

Screenshots from the real app to follow in an edit: ended-Enterprise Run
click (silent → explained), Plans & pricing during a capabilities outage
(missing → present), Enterprise scheduled-change preview (crash →
renders).

---------

Co-authored-by: Amp <amp@ampcode.com>
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3974e53d-c4e8-4838-b576-05d0e2fa497c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@dante01yoon dante01yoon added backport Backporting a PR onto a release candidate and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 27, 2026
@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1985 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1964 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/27/2026, 11:52:50 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 118ms TBT · 84.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.2 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 14ms TBT · 184.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 453ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 71.1 MB
canvas-idle: DOM nodes -277
canvas-idle: event listeners -167
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 27ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 763ms
canvas-mouse-sweep: script duration 84ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.3 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -167
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 324ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 63.2 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 298ms
dom-widget-clipping: script duration 41ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 69.6 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 536ms
large-graph-idle: script duration 16ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 66.4 MB
large-graph-idle: DOM nodes -281
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1012ms
large-graph-pan: script duration 269ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 86.3 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -162
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1211ms
large-graph-zoom: script duration 313ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 62.4 MB
large-graph-zoom: DOM nodes -290
large-graph-zoom: event listeners -168
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1200ms
legacy-node-drag: script duration 372ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 92.1 MB
legacy-node-drag: DOM nodes 14
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 10ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 558ms
minimap-idle: script duration 13ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.2 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -147
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 327ms
subgraph-dom-widget-clipping: script duration 96ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 71.0 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 431ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.1 MB
subgraph-idle: DOM nodes -282
subgraph-idle: event listeners -151
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 658ms
subgraph-mouse-sweep: script duration 63ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.9 MB
subgraph-mouse-sweep: DOM nodes -280
subgraph-mouse-sweep: event listeners -168
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 763ms
subgraph-transition-enter: script duration 13ms
subgraph-transition-enter: TBT 118ms
subgraph-transition-enter: heap used 84.5 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 3611ms
viewport-pan-sweep: script duration 856ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.4 MB
viewport-pan-sweep: DOM nodes -281
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13795ms
vue-large-graph-idle: script duration 106ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.2 MB
vue-large-graph-idle: DOM nodes -8314
vue-large-graph-idle: event listeners -16393
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 143
vue-large-graph-pan: task duration 16660ms
vue-large-graph-pan: script duration 404ms
vue-large-graph-pan: TBT 14ms
vue-large-graph-pan: heap used 184.0 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16390
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 68ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.7 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 37
Raw data
{
  "timestamp": "2026-08-28T00:03:33.755Z",
  "gitSha": "3f239610cb67a86cba9e4dccbc513ba67b8db9bf",
  "branch": "backport-16100-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2023.493999999971,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.2410000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.47100000000006,
      "heapDeltaBytes": 18348788,
      "heapUsedBytes": 81183084,
      "domNodes": -274,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 6.6640000000000015,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2003.8589999999203,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.219000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.95000000000005,
      "heapDeltaBytes": 5346000,
      "heapUsedBytes": 67846960,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.4529999999999985,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1775.8379999999647,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 27.351000000000003,
      "layouts": 12,
      "layoutDurationMs": 2.9720000000000004,
      "taskDurationMs": 810.692,
      "heapDeltaBytes": -4760020,
      "heapUsedBytes": 57816424,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 84.813,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1760.8149999999796,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 27.012999999999995,
      "layouts": 12,
      "layoutDurationMs": 3.0219999999999994,
      "taskDurationMs": 714.9689999999999,
      "heapDeltaBytes": 3303552,
      "heapUsedBytes": 66477468,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 82.28099999999999,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.394999999996,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 13.57,
      "layouts": 6,
      "layoutDurationMs": 0.5690000000000001,
      "taskDurationMs": 327.09900000000005,
      "heapDeltaBytes": 3287956,
      "heapUsedBytes": 66151220,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.148,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.3940000000748,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.785000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.5630000000000002,
      "taskDurationMs": 321.7,
      "heapDeltaBytes": 3303320,
      "heapUsedBytes": 66326940,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 9.331000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 509.0230000000133,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.774999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 304.60900000000004,
      "heapDeltaBytes": 9751476,
      "heapUsedBytes": 72293812,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 41.408,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 508.69599999998627,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.558000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 290.999,
      "heapDeltaBytes": 10830184,
      "heapUsedBytes": 73740920,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 40.217999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.95900000003,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.502,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.125,
      "heapDeltaBytes": -2303368,
      "heapUsedBytes": 74819800,
      "domNodes": -279,
      "jsHeapTotalBytes": -794624,
      "scriptDurationMs": 15.595999999999998,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.4560000000101,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.953000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.609,
      "heapDeltaBytes": -11819416,
      "heapUsedBytes": 64523908,
      "domNodes": -282,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 15.719999999999997,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2144.303999999977,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.137,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1005.4540000000001,
      "heapDeltaBytes": 11718388,
      "heapUsedBytes": 89019276,
      "domNodes": -283,
      "jsHeapTotalBytes": 4935680,
      "scriptDurationMs": 267.78599999999994,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2091.5410000000065,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.774000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1018.993,
      "heapDeltaBytes": 13518276,
      "heapUsedBytes": 91879360,
      "domNodes": -282,
      "jsHeapTotalBytes": -307200,
      "scriptDurationMs": 270.987,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3126.72299999997,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.780000000000001,
      "layouts": 60,
      "layoutDurationMs": 8.192,
      "taskDurationMs": 1201.707,
      "heapDeltaBytes": -16079044,
      "heapUsedBytes": 63318864,
      "domNodes": -290,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 312.75,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3182.154999999966,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.418000000000005,
      "layouts": 60,
      "layoutDurationMs": 8.124,
      "taskDurationMs": 1220.9260000000002,
      "heapDeltaBytes": -11167572,
      "heapUsedBytes": 67449084,
      "domNodes": -290,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 313.916,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2075.1489999999535,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.766,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1206.188,
      "heapDeltaBytes": 11093916,
      "heapUsedBytes": 96526080,
      "domNodes": 14,
      "jsHeapTotalBytes": 7794688,
      "scriptDurationMs": 373.54200000000003,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2116.692999999941,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.404,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1194.068,
      "heapDeltaBytes": 11033384,
      "heapUsedBytes": 96549980,
      "domNodes": 14,
      "jsHeapTotalBytes": 7794688,
      "scriptDurationMs": 370.31,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.2959999999603,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.663000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 561.08,
      "heapDeltaBytes": -12106280,
      "heapUsedBytes": 73417860,
      "domNodes": -276,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 12.028999999999998,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.96899999999,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.412999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.824,
      "heapDeltaBytes": -11595096,
      "heapUsedBytes": 73820304,
      "domNodes": -276,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 13.906000000000002,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 530.5009999999584,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 7.860999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 320.092,
      "heapDeltaBytes": 11538284,
      "heapUsedBytes": 74459988,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 93.863,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 536.5950000000339,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 7.8610000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 334.225,
      "heapDeltaBytes": 11865052,
      "heapUsedBytes": 74420224,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 98.312,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.901000000018,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.265000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.654,
      "heapDeltaBytes": -6542712,
      "heapUsedBytes": 56389664,
      "domNodes": -283,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 6.1209999999999996,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1995.3580000000102,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.625,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 433.366,
      "heapDeltaBytes": 20161388,
      "heapUsedBytes": 82230508,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 6.105000000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.3570000000154,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.698000000000004,
      "layouts": 16,
      "layoutDurationMs": 3.0689999999999995,
      "taskDurationMs": 648.574,
      "heapDeltaBytes": 3169252,
      "heapUsedBytes": 66317484,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 63.402,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1698.2719999999745,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 28.095000000000002,
      "layouts": 16,
      "layoutDurationMs": 3.86,
      "taskDurationMs": 666.5790000000001,
      "heapDeltaBytes": 15564532,
      "heapUsedBytes": 78140720,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 62.27199999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 999.1209999999455,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 27.121,
      "layouts": 16,
      "layoutDurationMs": 10.596,
      "taskDurationMs": 763.2760000000003,
      "heapDeltaBytes": -6188944,
      "heapUsedBytes": 88603636,
      "domNodes": 13673,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 12.645999999999997,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 118,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8123.401000000002,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.473000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3548.4230000000002,
      "heapDeltaBytes": -6430240,
      "heapUsedBytes": 69956000,
      "domNodes": -282,
      "jsHeapTotalBytes": 5722112,
      "scriptDurationMs": 846.413,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8121.003999999971,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.474000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3673.218,
      "heapDeltaBytes": -1565392,
      "heapUsedBytes": 75649020,
      "domNodes": -280,
      "jsHeapTotalBytes": -307200,
      "scriptDurationMs": 866.3629999999999,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14642.897000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13635.552999999998,
      "heapDeltaBytes": -32801292,
      "heapUsedBytes": 182983760,
      "domNodes": -8316,
      "jsHeapTotalBytes": -13918208,
      "scriptDurationMs": 108.83100000000002,
      "eventListeners": -16392,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14744.202000000087,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13953.477,
      "heapDeltaBytes": -36129496,
      "heapUsedBytes": 176061972,
      "domNodes": -8312,
      "jsHeapTotalBytes": -16556032,
      "scriptDurationMs": 103.61,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17137.34599999998,
      "styleRecalcs": 140,
      "styleRecalcDurationMs": 18.174999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16527.577,
      "heapDeltaBytes": -33172352,
      "heapUsedBytes": 192921468,
      "domNodes": -8312,
      "jsHeapTotalBytes": -16629760,
      "scriptDurationMs": 402.948,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17374.172000000042,
      "styleRecalcs": 146,
      "styleRecalcDurationMs": 19.209000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16793.185999999998,
      "heapDeltaBytes": -32374536,
      "heapUsedBytes": 193005228,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15577088,
      "scriptDurationMs": 406.023,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 24,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 102.3450000000139,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.429,
      "layouts": 2,
      "layoutDurationMs": 1.299,
      "taskDurationMs": 75.18799999999999,
      "heapDeltaBytes": 3160024,
      "heapUsedBytes": 65942228,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.166000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 92.21999999999753,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 10.718000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.639,
      "taskDurationMs": 60.04699999999999,
      "heapDeltaBytes": 3088088,
      "heapUsedBytes": 65639276,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 3.535999999999999,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

@github-actions
github-actions Bot requested a review from thedatalife August 27, 2026 23:52
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.52   #16148   +/-   ##
=============================================
  Coverage              ?   82.02%           
=============================================
  Files                 ?     1911           
  Lines                 ?   110041           
  Branches              ?    30249           
=============================================
  Hits                  ?    90266           
  Misses                ?    19433           
  Partials              ?      342           
Flag Coverage Δ
e2e 66.11% <50.00%> (?)
unit 74.04% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/useCoreCommands.ts 63.44% <100.00%> (ø)
...form/cloud/subscription/components/CreditsTile.vue 98.98% <100.00%> (ø)
...atform/cloud/subscription/constants/tierPricing.ts 89.47% <100.00%> (ø)
...e/components/SubscriptionPanelContentWorkspace.vue 96.64% <100.00%> (ø)
...ponents/SubscriptionTransitionPreviewWorkspace.vue 91.23% <100.00%> (ø)
...rm/workspace/composables/useBillingCapabilities.ts 96.78% <100.00%> (ø)
...c/platform/workspace/composables/useWorkspaceUI.ts 98.61% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot added this pull request to the merge queue Aug 28, 2026
Merged via the queue into cloud/1.52 with commit 10d7b57 Aug 28, 2026
103 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-16100-to-cloud-1.52 branch August 28, 2026 04:49
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants