Repository navigation
[backport cloud/1.52] fix(billing): harden sales-managed rendering against unreadable capabilities - #16148
Conversation
…ilities (#16100) Follow-up to #16067. Five defects found while writing regression coverage for the sales-managed tier surface it introduced. - Fixes FE-1662 follow-up ## Root cause **1. A sales-managed plan gets a Run button that does nothing.** `CloudRunButtonWrapper.vue` renders the real `ComfyQueueButton` whenever `isSalesManagedPlan`, even when `showsSubscribeToRunPrompt` is true. `ComfyQueueButton` only self-disables on `paymentRecoveryLock`, so the button is enabled. Clicking it reaches `blockRunWithoutSubscription()`, which returns `true` and deliberately skips the dialog for sales-managed tiers. Result: an ended Enterprise workspace shows an enabled Run button that produces no dialog, no toast, no explanation. Before #16067 the same user saw "Subscribe to run" — the wrong offer, but at least legible. **2. The whole pricing surface fails closed on an unreadable capability snapshot.** `canOpenPricingSurface` resolves to `capabilities?.can_subscribe_self_serve ?? false`. That field is one of three listed in `BillingCapabilityRolloutDefaults`, documented as "capability values currently using safe rollout defaults instead of deterministic policy results". #16067 moved three entry points — profile menu, settings link, `?pricing=` deep link — onto it. During a capabilities outage every self-serve owner loses all three, and the boot window makes "Plans & pricing" pop in late on every load. `canTopUp` already has an owner fallback for exactly this; `canSubscribeSelfServe` has none. **3. The inactive-credits zero-state is coupled to a rollout-defaulted capability.** `showsInactivePlanState = inactivePlan && !canTopUp`. `can_top_up` is also rollout-defaulted, and `canTopUp` returns **true** for an owner when the read is `unavailable` — so during an outage a lapsed self-serve team drops out of the reactivate-to-use-credits treatment and sees its real balance plus Add credits. **4. The transition preview crashes on three real tiers.** ```ts function tierMonthlyCredits(tier: string): number { return getTierCredits(tier.toLowerCase() as PersonalTierKey) ?? 0 } ``` `TIER_PRICING` holds only `standard | creator | pro`; `getTierCredits` early-returns for `free` and `founder`. The cast is unchecked, so `TIER_PRICING[key].credits` throws: | tier | key | result | |---|---|---| | `FOUNDERS_EDITION` | `founders_edition` | **TypeError** (≠ `founder`) | | `ENTERPRISE` | `enterprise` | **TypeError** | | unrecognized | — | **TypeError** | `?? 0` cannot help — the throw happens inside the callee. `TEAM` is spared only because the `teamPlan` prop short-circuits the call. This is pre-existing, not introduced by #16067, but it contradicts that PR's story 6 ("an unrecognized tier … no crash") and an Enterprise scheduled-change preview walks straight into it. **5.** `SOME_FUTURE_TIER` rendered as `Some_future_tier` (CodeRabbit on #16067). ## How 1. `blockRunWithoutSubscription()` raises a warn toast naming the state and routing to sales, instead of returning silently. 2. `useBillingCapabilities` derives `snapshotAuthoritative` directly from its discriminated read state (`resolved` and `denied` are authoritative for the current scope). `canOpenPricingSurface` uses that policy result and otherwise falls back to membership. Opening the catalog is navigation, not a billing write, and every checkout endpoint enforces its own policy, so failing open here cannot authorize anything. Mirrors `canTopUp`. 3. `showsInactivePlanState` keys off `isSalesManagedTier(subscription.tier)`, matching #16067's own "tier drives rendering only" principle and the `creditPoolTotalCredits` computed directly above it. 4. `tierMonthlyCredits` routes through the validated `toTierKey`, and `getTierCredits` becomes total (`TIER_PRICING[tierKey]?.credits ?? null`) so the existing `?? 0` does what it claims. 5. Split the raw tier on `[_-]+`, capitalize, join. ## Trade-off worth a reviewer's attention Change 2 means that during a capabilities outage an Enterprise owner could reach the pricing table. They cannot buy — the checkout endpoints reject independently, per the contract's own "these values do not authorize billing writes". Weighed against every self-serve owner losing the upgrade path during the same outage, failing open on navigation is the better default. Push back if you disagree. ## Tests - Unit: **93 files, 1760 tests, 0 failures** across `src/platform/workspace`, `src/platform/cloud/subscription`, `src/composables/useCoreCommands.test.ts`, `src/components/actionbar`. - New coverage: pricing-surface fallback for unresolved / unavailable snapshots and a non-owner closed case; inactive-team zero-state held while top-up reads open; sales-managed run emits a toast and no dialog; `FOUNDERS_EDITION` refill renders; unknown tier renders as readable words. - Both transition-preview tests fail on `main` without this change — the `SOME_FUTURE_TIER` one is what surfaced defect 4. - E2E: ended Enterprise Run explains the blocked state; pricing deep links remain available during capability 503s; inactive credits remain disabled during the same outage. ## AS IS / TO BE Screenshots from the real app to follow in an edit: ended-Enterprise Run click (silent → explained), Plans & pricing during a capabilities outage (missing → present), Enterprise scheduled-change preview (crash → renders). --------- Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1985 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-28T00:03:33.755Z",
"gitSha": "3f239610cb67a86cba9e4dccbc513ba67b8db9bf",
"branch": "backport-16100-to-cloud-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.493999999971,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.2410000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.47100000000006,
"heapDeltaBytes": 18348788,
"heapUsedBytes": 81183084,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.6640000000000015,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2003.8589999999203,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.219000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.95000000000005,
"heapDeltaBytes": 5346000,
"heapUsedBytes": 67846960,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.4529999999999985,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.8379999999647,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.351000000000003,
"layouts": 12,
"layoutDurationMs": 2.9720000000000004,
"taskDurationMs": 810.692,
"heapDeltaBytes": -4760020,
"heapUsedBytes": 57816424,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 84.813,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.8149999999796,
"styleRecalcs": 73,
"styleRecalcDurationMs": 27.012999999999995,
"layouts": 12,
"layoutDurationMs": 3.0219999999999994,
"taskDurationMs": 714.9689999999999,
"heapDeltaBytes": 3303552,
"heapUsedBytes": 66477468,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 82.28099999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.394999999996,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.57,
"layouts": 6,
"layoutDurationMs": 0.5690000000000001,
"taskDurationMs": 327.09900000000005,
"heapDeltaBytes": 3287956,
"heapUsedBytes": 66151220,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.148,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.3940000000748,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.785000000000002,
"layouts": 6,
"layoutDurationMs": 0.5630000000000002,
"taskDurationMs": 321.7,
"heapDeltaBytes": 3303320,
"heapUsedBytes": 66326940,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.331000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 509.0230000000133,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.774999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 304.60900000000004,
"heapDeltaBytes": 9751476,
"heapUsedBytes": 72293812,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 41.408,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 508.69599999998627,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.558000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.999,
"heapDeltaBytes": 10830184,
"heapUsedBytes": 73740920,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 40.217999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2055.95900000003,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.502,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.125,
"heapDeltaBytes": -2303368,
"heapUsedBytes": 74819800,
"domNodes": -279,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 15.595999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.4560000000101,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.953000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.609,
"heapDeltaBytes": -11819416,
"heapUsedBytes": 64523908,
"domNodes": -282,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 15.719999999999997,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2144.303999999977,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1005.4540000000001,
"heapDeltaBytes": 11718388,
"heapUsedBytes": 89019276,
"domNodes": -283,
"jsHeapTotalBytes": 4935680,
"scriptDurationMs": 267.78599999999994,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2091.5410000000065,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.774000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1018.993,
"heapDeltaBytes": 13518276,
"heapUsedBytes": 91879360,
"domNodes": -282,
"jsHeapTotalBytes": -307200,
"scriptDurationMs": 270.987,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3126.72299999997,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.780000000000001,
"layouts": 60,
"layoutDurationMs": 8.192,
"taskDurationMs": 1201.707,
"heapDeltaBytes": -16079044,
"heapUsedBytes": 63318864,
"domNodes": -290,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 312.75,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3182.154999999966,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.418000000000005,
"layouts": 60,
"layoutDurationMs": 8.124,
"taskDurationMs": 1220.9260000000002,
"heapDeltaBytes": -11167572,
"heapUsedBytes": 67449084,
"domNodes": -290,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 313.916,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2075.1489999999535,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.766,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1206.188,
"heapDeltaBytes": 11093916,
"heapUsedBytes": 96526080,
"domNodes": 14,
"jsHeapTotalBytes": 7794688,
"scriptDurationMs": 373.54200000000003,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2116.692999999941,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.404,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1194.068,
"heapDeltaBytes": 11033384,
"heapUsedBytes": 96549980,
"domNodes": 14,
"jsHeapTotalBytes": 7794688,
"scriptDurationMs": 370.31,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.2959999999603,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.663000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.08,
"heapDeltaBytes": -12106280,
"heapUsedBytes": 73417860,
"domNodes": -276,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 12.028999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.96899999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.412999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.824,
"heapDeltaBytes": -11595096,
"heapUsedBytes": 73820304,
"domNodes": -276,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 13.906000000000002,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.5009999999584,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.860999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.092,
"heapDeltaBytes": 11538284,
"heapUsedBytes": 74459988,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 93.863,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 536.5950000000339,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.8610000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.225,
"heapDeltaBytes": 11865052,
"heapUsedBytes": 74420224,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 98.312,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.901000000018,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.265000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.654,
"heapDeltaBytes": -6542712,
"heapUsedBytes": 56389664,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.1209999999999996,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.3580000000102,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.625,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.366,
"heapDeltaBytes": 20161388,
"heapUsedBytes": 82230508,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.105000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.3570000000154,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.698000000000004,
"layouts": 16,
"layoutDurationMs": 3.0689999999999995,
"taskDurationMs": 648.574,
"heapDeltaBytes": 3169252,
"heapUsedBytes": 66317484,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 63.402,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1698.2719999999745,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.095000000000002,
"layouts": 16,
"layoutDurationMs": 3.86,
"taskDurationMs": 666.5790000000001,
"heapDeltaBytes": 15564532,
"heapUsedBytes": 78140720,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 62.27199999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 999.1209999999455,
"styleRecalcs": 21,
"styleRecalcDurationMs": 27.121,
"layouts": 16,
"layoutDurationMs": 10.596,
"taskDurationMs": 763.2760000000003,
"heapDeltaBytes": -6188944,
"heapUsedBytes": 88603636,
"domNodes": 13673,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 12.645999999999997,
"eventListeners": 2373,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8123.401000000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.473000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3548.4230000000002,
"heapDeltaBytes": -6430240,
"heapUsedBytes": 69956000,
"domNodes": -282,
"jsHeapTotalBytes": 5722112,
"scriptDurationMs": 846.413,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8121.003999999971,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.474000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3673.218,
"heapDeltaBytes": -1565392,
"heapUsedBytes": 75649020,
"domNodes": -280,
"jsHeapTotalBytes": -307200,
"scriptDurationMs": 866.3629999999999,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14642.897000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13635.552999999998,
"heapDeltaBytes": -32801292,
"heapUsedBytes": 182983760,
"domNodes": -8316,
"jsHeapTotalBytes": -13918208,
"scriptDurationMs": 108.83100000000002,
"eventListeners": -16392,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14744.202000000087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13953.477,
"heapDeltaBytes": -36129496,
"heapUsedBytes": 176061972,
"domNodes": -8312,
"jsHeapTotalBytes": -16556032,
"scriptDurationMs": 103.61,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17137.34599999998,
"styleRecalcs": 140,
"styleRecalcDurationMs": 18.174999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16527.577,
"heapDeltaBytes": -33172352,
"heapUsedBytes": 192921468,
"domNodes": -8312,
"jsHeapTotalBytes": -16629760,
"scriptDurationMs": 402.948,
"eventListeners": -16389,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17374.172000000042,
"styleRecalcs": 146,
"styleRecalcDurationMs": 19.209000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16793.185999999998,
"heapDeltaBytes": -32374536,
"heapUsedBytes": 193005228,
"domNodes": -8312,
"jsHeapTotalBytes": -15577088,
"scriptDurationMs": 406.023,
"eventListeners": -16391,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 102.3450000000139,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.429,
"layouts": 2,
"layoutDurationMs": 1.299,
"taskDurationMs": 75.18799999999999,
"heapDeltaBytes": 3160024,
"heapUsedBytes": 65942228,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.166000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 92.21999999999753,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.718000000000002,
"layouts": 2,
"layoutDurationMs": 0.639,
"taskDurationMs": 60.04699999999999,
"heapDeltaBytes": 3088088,
"heapUsedBytes": 65639276,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.535999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.52 #16148 +/- ##
=============================================
Coverage ? 82.02%
=============================================
Files ? 1911
Lines ? 110041
Branches ? 30249
=============================================
Hits ? 90266
Misses ? 19433
Partials ? 342
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #16100 to
cloud/1.52.The automated backport cleaned up its successful Cloud branch after the parallel
core/1.52target conflicted. This recreates the Cloud backport from the merged target branch.Verification
git diff --checkpassed