Repository navigation
test: cover post-first-run continuation handoff - #16136
benceruleanlu wants to merge 6 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe PR centralizes first-run suggestion definitions, adds shared onboarding fixtures, refactors Getting Started tests, and adds browser coverage for post-first-run continuation loading and image output. ChangesFirst-run tour and continuation flow
Estimated code review effort: 3 (Moderate) | ~30 minutes Merge Risk: ⚪ Minimal · up to This test-focused change adds coverage for the post-first-run continuation handoff without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant PostFirstRunHelper
participant OnboardingCoachmarks
participant ComfyPage
participant WebSocket
participant FirstRunNudge
PostFirstRunHelper->>ComfyPage: Open getting-started template
PostFirstRunHelper->>OnboardingCoachmarks: Walk to run step
PostFirstRunHelper->>ComfyPage: Click run button
WebSocket->>ComfyPage: Send execution events
PostFirstRunHelper->>FirstRunNudge: Complete tour
FirstRunNudge->>ComfyPage: Select continuation
ComfyPage-->>PostFirstRunHelper: Load image input and output
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description clearly explains the post-first-run continuation handoff coverage, implementation scope, shared fixtures, test design, and validation results. It does not use the template's exact Changes or Review Focus headings, but it provides the required information in detailed alternative sections. Full details: Title checkExplanation The title, "test: cover post-first-run continuation handoff," clearly and concisely identifies the pull request's main change: adding frontend test coverage for the post-first-run continuation handoff. Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list and PR description are available, and the PR changes both Full details: Adr Compliance For Entity/Litegraph ChangesExplanation PASS. The changed-file list contains no files under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 1883 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.61 MB gzip 🔴 +116 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • 🔴 +282 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.55 MB (baseline 3.55 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.2 MB (baseline 16.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-28T00:17:21.666Z",
"gitSha": "399e5c8a1bc62665de7809982dcfdfbd952dccd2",
"branch": "bl/fe-1355-post-nux-discovery-e2e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.2899999999568,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.753999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.18600000000004,
"heapDeltaBytes": 17629992,
"heapUsedBytes": 80611236,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.198999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2012.6399999999194,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.451,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.144,
"heapDeltaBytes": 1850720,
"heapUsedBytes": 65010532,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.956999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.3210000000072,
"styleRecalcs": 74,
"styleRecalcDurationMs": 32.40800000000001,
"layouts": 12,
"layoutDurationMs": 3.476,
"taskDurationMs": 837.4430000000001,
"heapDeltaBytes": -9614652,
"heapUsedBytes": 58534304,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 137.04,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1843.097000000057,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.135,
"layouts": 12,
"layoutDurationMs": 3.549,
"taskDurationMs": 837.98,
"heapDeltaBytes": -3189132,
"heapUsedBytes": 59601900,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 139.962,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.2040000000238,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.129000000000001,
"layouts": 6,
"layoutDurationMs": 0.649,
"taskDurationMs": 338.60799999999995,
"heapDeltaBytes": 4387648,
"heapUsedBytes": 72336448,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.120000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.3809999999512,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.261000000000001,
"layouts": 6,
"layoutDurationMs": 0.5650000000000002,
"taskDurationMs": 343.472,
"heapDeltaBytes": 3755988,
"heapUsedBytes": 67563264,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.362999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 652.6700000000005,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.468,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.56800000000004,
"heapDeltaBytes": 18955980,
"heapUsedBytes": 82259140,
"domNodes": 12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 160.61199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 674.8420000000124,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.882999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.3640000000001,
"heapDeltaBytes": 19289120,
"heapUsedBytes": 87837292,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 151.959,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2044.128999999998,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.674000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.1640000000001,
"heapDeltaBytes": 12053740,
"heapUsedBytes": 87110816,
"domNodes": -268,
"jsHeapTotalBytes": -1880064,
"scriptDurationMs": 37.69499999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2044.0159999999423,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.4290000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.1639999999999,
"heapDeltaBytes": -4763492,
"heapUsedBytes": 87957224,
"domNodes": -275,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 35.842999999999996,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2264.130000000023,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.808999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1655.64,
"heapDeltaBytes": -7699276,
"heapUsedBytes": 86312116,
"domNodes": -270,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 846.2909999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2210.687000000007,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.442999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1591.219,
"heapDeltaBytes": 19992276,
"heapUsedBytes": 85623884,
"domNodes": 4,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 834.3649999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3576.54100000002,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.206999999999997,
"layouts": 60,
"layoutDurationMs": 7.562,
"taskDurationMs": 1717.8490000000002,
"heapDeltaBytes": 13625052,
"heapUsedBytes": 80657644,
"domNodes": -278,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 840.545,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3515.623000000005,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.372999999999998,
"layouts": 60,
"layoutDurationMs": 7.417999999999999,
"taskDurationMs": 1655.119,
"heapDeltaBytes": 8541980,
"heapUsedBytes": 75783176,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 789.943,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3112.508000000048,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.635999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1891.759,
"heapDeltaBytes": 19865168,
"heapUsedBytes": 86106100,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 964.879,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3109.0070000000196,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.993999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1862.929,
"heapDeltaBytes": 19528932,
"heapUsedBytes": 86355700,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 946.935,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.9829999999724,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.629,
"heapDeltaBytes": 23290932,
"heapUsedBytes": 87787008,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.067,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1994.6969999999737,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.7910000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.1329999999998,
"heapDeltaBytes": 23541264,
"heapUsedBytes": 88799192,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.631,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.0539999999664,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.235999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.583,
"heapDeltaBytes": 15009452,
"heapUsedBytes": 85604492,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.39100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.5260000000208,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.328,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.451,
"heapDeltaBytes": 14170560,
"heapUsedBytes": 78662236,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 139.18900000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.2179999999466,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.338999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.648,
"heapDeltaBytes": -4691456,
"heapUsedBytes": 59820456,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.2490000000000006,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.5380000000678,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.566000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.04900000000004,
"heapDeltaBytes": 6613600,
"heapUsedBytes": 70691752,
"domNodes": -297,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.235999999999998,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.4559999999933,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.349999999999994,
"layouts": 16,
"layoutDurationMs": 3.993,
"taskDurationMs": 770.406,
"heapDeltaBytes": -12007592,
"heapUsedBytes": 58840284,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 97.904,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.6369999999815,
"styleRecalcs": 75,
"styleRecalcDurationMs": 31.769000000000005,
"layouts": 16,
"layoutDurationMs": 3.881,
"taskDurationMs": 764.3679999999999,
"heapDeltaBytes": -12145796,
"heapUsedBytes": 58307416,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 94.708,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.5079999999825,
"styleRecalcs": 20,
"styleRecalcDurationMs": 29.285999999999998,
"layouts": 15,
"layoutDurationMs": 12.756,
"taskDurationMs": 919.9519999999999,
"heapDeltaBytes": 142248,
"heapUsedBytes": 97004384,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.097,
"eventListeners": 2383,
"totalBlockingTimeMs": 119,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8371.043999999983,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.71099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5748.632,
"heapDeltaBytes": -6001704,
"heapUsedBytes": 86822792,
"domNodes": -277,
"jsHeapTotalBytes": 4149248,
"scriptDurationMs": 2742.104,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8296.621000000072,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.592,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5684.597999999999,
"heapDeltaBytes": -7571956,
"heapUsedBytes": 85187676,
"domNodes": -269,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 2675.7329999999997,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17826.29800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16889.529,
"heapDeltaBytes": -42205540,
"heapUsedBytes": 174752704,
"domNodes": -6548,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 338.17600000000004,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17704.49199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16907.105000000003,
"heapDeltaBytes": -39490044,
"heapUsedBytes": 175007180,
"domNodes": -6548,
"jsHeapTotalBytes": 3686400,
"scriptDurationMs": 319.673,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21714.844000000026,
"styleRecalcs": 178,
"styleRecalcDurationMs": 19.762,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21377.587,
"heapDeltaBytes": -16842388,
"heapUsedBytes": 191217748,
"domNodes": -6548,
"jsHeapTotalBytes": -2891776,
"scriptDurationMs": 989.541,
"eventListeners": -7469,
"totalBlockingTimeMs": 95,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21816.051000000014,
"styleRecalcs": 170,
"styleRecalcDurationMs": 19.961000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21449.477000000003,
"heapDeltaBytes": -21442156,
"heapUsedBytes": 191004512,
"domNodes": -6548,
"jsHeapTotalBytes": -4640768,
"scriptDurationMs": 999.7100000000002,
"eventListeners": -7467,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 92.13599999998223,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.080999999999998,
"layouts": 2,
"layoutDurationMs": 0.5830000000000001,
"taskDurationMs": 66.222,
"heapDeltaBytes": 3150072,
"heapUsedBytes": 66063396,
"domNodes": 107,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.236,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 442.26500000002034,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.112,
"layouts": 2,
"layoutDurationMs": 0.3349999999999999,
"taskDurationMs": 94.77000000000001,
"heapDeltaBytes": 5055596,
"heapUsedBytes": 71647496,
"domNodes": 123,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.390999999999998,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎨 Storybook: ✅ Built — View Storybook |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16136 +/- ##
==========================================
+ Coverage 80.69% 82.66% +1.97%
==========================================
Files 2298 1944 -354
Lines 118226 112140 -6086
Branches 33722 32337 -1385
==========================================
- Hits 95399 92700 -2699
+ Misses 22264 19095 -3169
+ Partials 563 345 -218
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 360 files with indirect coverage changes 🚀 New features to boost your workflow:
|
d718e25 to
d74d9a0
Compare
Shares the billing, remote-config, asset and queued-prompt mocks the two first-run suites had each declared, sources nudge copy from the locale the card renders from, and walks to the Run step instead of pinning a step count.
The card's suggestion table lived inside the SFC, so every suite covering it retyped the ids and template ids. Moving it beside the component lets the unit test parametrise over the real table and lets the e2e fixtures read the ids the card actually renders.
- one walk instead of three: the per-action id-to-template mapping is already covered in FirstRunTourNudge.test.ts, so re-proving it through a full tour per action bought nothing for 3x the cloud budget - read the suggestion ids off the shared table rather than retyping them - name the test from the id, not from translatable copy - share the step walk with the sibling suite via OnboardingCoachmarks - drop the unused /internal/files/output mock - read the seeded LoadImage widget by name
01181ea to
de4ea4b
Compare
Parametrising the nudge suite over FIRST_RUN_SUGGESTIONS had left it asserting the component's table against itself: both the expected templateId and the mock catalog were read off the table, so repointing an action at another template passed. The expected ids are spelled out again and typed against FirstRunSuggestionId, so a new action fails to compile until its template is declared. Both onboarding suites had also copied the same three route mocks; they now share mockFirstRunTourBackend. The initialFeatureFlags seed goes with them: it writes an ff: override that getDevOverride only reads under import.meta.env.DEV, so it was inert against the production dist CI runs, and the /api/features route already carries the flag in either build.
## Summary Adds the DES-550 post-first-output discovery card and continues the generated image into three dedicated continuation workflows. ## Changes - Shows the card after every first-run tour ending, and adds Animate, 4× Upscale, Nano Banana restyle, and Browse all templates actions. - Seeds the captured output through each template's declared `io.inputs` metadata and fails closed if catalog/workflow metadata is incomplete or drifts. - Filters the three actions against the served catalog, so an install on an older template package hides an action instead of failing it on click. - Falls back to the template browser when nothing is seedable — an install serving none of the three, or a run that produced no image. Suppressing the card there would take the way forward from the users who most need it (Comfy-Org#14144). - Correlates output to the newly accepted first-run job across every media key, including WebSocket output arriving before HTTP job metadata, and outliving the tour so walking to the end during a long generation does not discard the result. - Prefers a saved result over a preview on both the direct and the buffered path, but seeds a preview's `temp` file when nothing saved one — a `PreviewImage` sink is the whole result and the backend still serves it. - Holds the card open while a continuation loads, so dismissing it cannot leave a graph swap or an error toast behind. - Waits for the served catalog before rendering, so the card cannot paint the fallback and then rewrite itself into the continuations under the user. Capped at 3s, because a stalled fetch must not withhold the card from the user it is for (Comfy-Org#14144). - Preserves delayed display, dialog deferral, close/Escape behavior, no-auto-run, and loading/error feedback. ## Template dependency Workflow templates: [Comfy-Org/workflow_templates#1184](Comfy-Org/workflow_templates#1184) (merged). Static mappings: - `video_minimax_h3_i2v_continuation` - `utility_seedvr2_7b_int8_upscale_image` (existing template; 4× multiplier) - `api_google_nano_banana2_image_edit_continuation` The paid action continues to rely on the existing execution-time auth and billing guard. Installs pin `comfyui_workflow_templates` independently of the frontend, so the catalog filter above is what keeps an older package from producing dead buttons. Linear: [FE-1355](https://linear.app/comfyorg/issue/FE-1355/e-22-fe-post-nux-discovery-everything-you-can-do-free-paid) ## Telemetry `tour_completed` is dropped from `nudge_shown` and `explore_templates_clicked`. `nudge_suggestion_clicked` is added, carrying the chosen action and whether its template opened. All three nudge events now carry `suggestion_count` — this is a schema change for anyone querying them. Zero means the card fell back to the template browser, which is the only signal distinguishing template-package skew from a nudge that never appeared. The count reported is always the one rendered: the card and the event share a single catalog gate, so neither can describe a state the other never showed. Each tour reports its own impression — a second first-run tour is a second nudge, not a repeat of the first. ## Testing - Focused unit/component tests across four suites, including catalog skew, a catalog that lands late and one that stalls, per-tour impression reporting, missing `io` metadata, the temp/saved output preference on both the direct and the buffered path, video output, late output after the tour ends, and the missing-filename path. - `pnpm test:unit`, clean-install `vue-tsc --noEmit`, ESLint, type-aware Oxlint, formatting, and `knip --cache`. ## Screenshots (if applicable) [Figma reference](https://www.figma.com/design/SSo9GcILgQhAV3uoa4r1xJ/Onboarding?node-id=2602-18740) ## Native GitHub stack This is the bottom product layer. The E2E contract layer is Comfy-Org#16136. Supersedes Comfy-Org#15319, which was closed so this replacement can participate in GitHub's first-party stacked pull request feature.
## Summary Reverts Comfy-Org#16143 while the post-first-run discovery flow is reworked to satisfy the agreed correctness, observability, and end-to-end coverage requirements. ## Changes - **What**: Restores the previous first-run nudge, template loading, and tour-controller behavior. - **Dependencies**: None. ## Review Focus This is the exact inverse of the squash commit from Comfy-Org#16143. Follow-up work will restore the product feature in a reviewable stack; the existing E2E work in Comfy-Org#16136 should not merge ahead of that stack.
## Summary Adds the DES-550 post-first-output discovery card and continues the generated image into three dedicated continuation workflows. ## Changes - Shows the card after every first-run tour ending, and adds Animate, 4× Upscale, Nano Banana restyle, and Browse all templates actions. - Seeds the captured output through each template's declared `io.inputs` metadata and fails closed if catalog/workflow metadata is incomplete or drifts. - Filters the three actions against the served catalog, so an install on an older template package hides an action instead of failing it on click. - Falls back to the template browser when nothing is seedable — an install serving none of the three, or a run that produced no image. Suppressing the card there would take the way forward from the users who most need it (#14144). - Correlates output to the newly accepted first-run job across every media key, including WebSocket output arriving before HTTP job metadata, and outliving the tour so walking to the end during a long generation does not discard the result. - Prefers a saved result over a preview on both the direct and the buffered path, but seeds a preview's `temp` file when nothing saved one — a `PreviewImage` sink is the whole result and the backend still serves it. - Holds the card open while a continuation loads, so dismissing it cannot leave a graph swap or an error toast behind. - Waits for the served catalog before rendering, so the card cannot paint the fallback and then rewrite itself into the continuations under the user. Capped at 3s, because a stalled fetch must not withhold the card from the user it is for (#14144). - Preserves delayed display, dialog deferral, close/Escape behavior, no-auto-run, and loading/error feedback. ## Template dependency Workflow templates: [Comfy-Org/workflow_templates#1184](Comfy-Org/workflow_templates#1184) (merged). Static mappings: - `video_minimax_h3_i2v_continuation` - `utility_seedvr2_7b_int8_upscale_image` (existing template; 4× multiplier) - `api_google_nano_banana2_image_edit_continuation` The paid action continues to rely on the existing execution-time auth and billing guard. Installs pin `comfyui_workflow_templates` independently of the frontend, so the catalog filter above is what keeps an older package from producing dead buttons. Linear: [FE-1355](https://linear.app/comfyorg/issue/FE-1355/e-22-fe-post-nux-discovery-everything-you-can-do-free-paid) ## Telemetry `tour_completed` is dropped from `nudge_shown` and `explore_templates_clicked`. `nudge_suggestion_clicked` is added, carrying the chosen action and whether its template opened. All three nudge events now carry `suggestion_count` — this is a schema change for anyone querying them. Zero means the card fell back to the template browser, which is the only signal distinguishing template-package skew from a nudge that never appeared. The count reported is always the one rendered: the card and the event share a single catalog gate, so neither can describe a state the other never showed. Each tour reports its own impression — a second first-run tour is a second nudge, not a repeat of the first. ## Testing - Focused unit/component tests across four suites, including catalog skew, a catalog that lands late and one that stalls, per-tour impression reporting, missing `io` metadata, the temp/saved output preference on both the direct and the buffered path, video output, late output after the tour ends, and the missing-filename path. - `pnpm test:unit`, clean-install `vue-tsc --noEmit`, ESLint, type-aware Oxlint, formatting, and `knip --cache`. ## Screenshots (if applicable) [Figma reference](https://www.figma.com/design/SSo9GcILgQhAV3uoa4r1xJ/Onboarding?node-id=2602-18740) ## Native GitHub stack This is the bottom product layer. The E2E contract layer is #16136. Supersedes #15319, which was closed so this replacement can participate in GitHub's first-party stacked pull request feature.
## Summary Reverts #16143 while the post-first-run discovery flow is reworked to satisfy the agreed correctness, observability, and end-to-end coverage requirements. ## Changes - **What**: Restores the previous first-run nudge, template loading, and tour-controller behavior. - **Dependencies**: None. ## Review Focus This is the exact inverse of the squash commit from #16143. Follow-up work will restore the product feature in a reviewable stack; the existing E2E work in #16136 should not merge ahead of that stack.
Summary
Scope
This is a frontend handoff contract test. It intentionally does not copy or claim to validate the currently published continuation workflows. Served catalog availability, published workflow contents, model availability, and real Cloud execution remain separate runtime gates.
Coverage split
The suite walks the tour once, not once per action. Which continuation it clicks does not matter:
FirstRunTourNudge.test.tsalready asserts per action that clicking it callsloadWorkflowTemplate(templateId, 'default', { input }), andtemplateWorkflowTransforms.test.tsalready covers the seeding transform. What neither owns is the wiring — a fetched graph replacing the tour workflow with the first output seeded into its declared input, resolving to something the node can show — and that needs proving once. Re-proving the mapping through three full 120s cloud walks bought nothing.That per-action claim has to stay true, so the expected template ids are spelled out in the unit test rather than read off
FIRST_RUN_SUGGESTIONS. Parametrising over the real table is what makes a new action covered for free; asserting the table against itself is what would make repointing an action at another template pass silently. The expectation map is typedRecord<FirstRunSuggestionId, string>, so a new action fails to compile until its template is declared.Shared suggestion table
SUGGESTIONSlived insideFirstRunTourNudge.vue, so both suites covering the card retyped its ids and template ids. It now sits beside the component infirstRunNudgeSuggestions.ts: the unit test parametrises over the real table, and the e2e fixtures read the ids the card actually renders. Renaming a continuation template is now a compile-or-one-place change instead of a misleadingtoHaveCountred.Shared fixtures
gettingStartedTour.spec.tshad already declared the billing status, remote config, empty asset response and queued-prompt payload this suite needs, so both now read one copy:ACTIVE_PERSONAL_BILLING_STATUSandONBOARDING_TOUR_REMOTE_CONFIGsit besideLEGACY_PERSONAL_BILLING_STATUSindata/cloudWorkspace.ts,EMPTY_ASSET_RESPONSEindata/assetFixtures.ts, andqueuedPrompt()plus the tour's template id indata/firstRunTour.ts. The routes consuming them are shared too, asmockFirstRunTourBackend(), rather than copied into each suite'sbeforeEach. Both specs are colocated undertests/onboarding/, and the step walk itself —stepCount()andwalkToStep()— moves ontoOnboardingCoachmarksso the two suites share one loop.The start template is typed
SupportedTemplateId, the sink the run reports against is read fromTOUR_ROLE_PINS, the test name comes from the suggestion id rather than translatable copy, and the walk steps to Run instead of pinning a step count — so a copy tweak, a renumbered pin or an added tour step cannot red this suite for a reason it does not cover.getNodeLocatorreplaces the one-locator page object, the seeded LoadImage widget is read by name, and the budget is stated once as a 120s describe timeout instead oftest.slow()on top of the project default.The
initialFeatureFlagsseed is gone from both suites. It writes anff:localStorage override that onlygetDevOverridereads, and that returnsundefinedunlessimport.meta.env.DEV— so it was inert against the productiondistthe cloud CI job runs, and the/api/featuresroute already carries the flag in either build.Validation
pnpm typecheck,pnpm typecheck:browser, oxlint, oxfmt,knip --cachepnpm vitest run src/renderer/extensions/firstRunTour/: 254 passedanimateat the upscale template reds two unit tests, and passed silently before--project=cloud, which is where it first executes