Repository navigation
fix: keep non-widget input sockets out of custom widgets - #16122
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2013 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.61 MB gzip 🔴 +27 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.39 MB (baseline 1.39 MB) • 🔴 +72 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.55 MB (baseline 3.55 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.2 MB (baseline 16.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-27T18:20:44.636Z",
"gitSha": "7516dbedef20e311d6a21639ded851532e65428d",
"branch": "benjcooley/widget-slot-ownership-fix",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.685000000002,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.082,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.895,
"heapDeltaBytes": -2886788,
"heapUsedBytes": 65689016,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.135000000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2038.4319999999434,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.689000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.81500000000005,
"heapDeltaBytes": -7216624,
"heapUsedBytes": 56173632,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.609000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1976.9739999999842,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.91100000000001,
"layouts": 12,
"layoutDurationMs": 3.962,
"taskDurationMs": 974.7920000000001,
"heapDeltaBytes": -439160,
"heapUsedBytes": 63317452,
"domNodes": -284,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 166.72,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.9590000000353,
"styleRecalcs": 71,
"styleRecalcDurationMs": 35.442,
"layouts": 12,
"layoutDurationMs": 3.504,
"taskDurationMs": 870.029,
"heapDeltaBytes": 10953440,
"heapUsedBytes": 74196848,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 153.844,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.796999999971,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.494,
"layouts": 6,
"layoutDurationMs": 0.589,
"taskDurationMs": 346.175,
"heapDeltaBytes": 3884072,
"heapUsedBytes": 67612924,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.572000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.7410000000045,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.657,
"layouts": 6,
"layoutDurationMs": 0.6119999999999999,
"taskDurationMs": 405.469,
"heapDeltaBytes": 3749348,
"heapUsedBytes": 66353628,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.812,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 690.922999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.628000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.212,
"heapDeltaBytes": 19339080,
"heapUsedBytes": 82273964,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 160.855,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 669.3480000000136,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.917000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.704,
"heapDeltaBytes": 19177636,
"heapUsedBytes": 82450108,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 167.691,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2038.6540000000082,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.719000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.79,
"heapDeltaBytes": -6095684,
"heapUsedBytes": 87218832,
"domNodes": -271,
"jsHeapTotalBytes": -1585152,
"scriptDurationMs": 40.77,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.095999999996,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.087999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.0169999999999,
"heapDeltaBytes": -5366344,
"heapUsedBytes": 87401768,
"domNodes": -271,
"jsHeapTotalBytes": -2109440,
"scriptDurationMs": 40.27199999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2356.398000000013,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.203999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1722.5609999999997,
"heapDeltaBytes": 10000308,
"heapUsedBytes": 82061108,
"domNodes": -245,
"jsHeapTotalBytes": 438272,
"scriptDurationMs": 871.34,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2553.8740000000644,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.664000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1746.422,
"heapDeltaBytes": 14914292,
"heapUsedBytes": 80564596,
"domNodes": -276,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 895.4110000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3569.54300000001,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.62,
"layouts": 60,
"layoutDurationMs": 7.1469999999999985,
"taskDurationMs": 1726.5459999999998,
"heapDeltaBytes": 8889868,
"heapUsedBytes": 76320652,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 819.6239999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3666.729000000032,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.700999999999997,
"layouts": 60,
"layoutDurationMs": 7.271,
"taskDurationMs": 1802.876,
"heapDeltaBytes": 1600940,
"heapUsedBytes": 75101144,
"domNodes": -285,
"jsHeapTotalBytes": -1884160,
"scriptDurationMs": 826.538,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3049.6619999999552,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.490999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1918.224,
"heapDeltaBytes": 19080528,
"heapUsedBytes": 85808832,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 965.98,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3167.822000000001,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.079000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2049.134,
"heapDeltaBytes": 19301264,
"heapUsedBytes": 86129692,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1041.827,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.3719999999762,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.602000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.1370000000001,
"heapDeltaBytes": 12379120,
"heapUsedBytes": 87837588,
"domNodes": -271,
"jsHeapTotalBytes": -1884160,
"scriptDurationMs": 37.903000000000006,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2039.0739999999141,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.526999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.5150000000001,
"heapDeltaBytes": 12328364,
"heapUsedBytes": 88192384,
"domNodes": -272,
"jsHeapTotalBytes": -2408448,
"scriptDurationMs": 40.683000000000014,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.8249999999816,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.628,
"heapDeltaBytes": 14324232,
"heapUsedBytes": 78707912,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 139.7,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 722.9110000000674,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.346,
"heapDeltaBytes": 14022040,
"heapUsedBytes": 78740288,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 147.191,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.6089999999608,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.286,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.7049999999999,
"heapDeltaBytes": -5455852,
"heapUsedBytes": 59116696,
"domNodes": -296,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.458999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.9759999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.991999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.355,
"heapDeltaBytes": -4834440,
"heapUsedBytes": 59885720,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.360000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1768.9900000000307,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.06999999999999,
"layouts": 16,
"layoutDurationMs": 4.567,
"taskDurationMs": 899.6540000000002,
"heapDeltaBytes": 8360892,
"heapUsedBytes": 73323532,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 124.65499999999999,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.4260000000859,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.118,
"layouts": 16,
"layoutDurationMs": 6.819999999999999,
"taskDurationMs": 830.533,
"heapDeltaBytes": -3130352,
"heapUsedBytes": 61420840,
"domNodes": -298,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 113.26899999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.556999999898,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.730000000000008,
"layouts": 15,
"layoutDurationMs": 14.270000000000001,
"taskDurationMs": 921.5439999999999,
"heapDeltaBytes": 218196,
"heapUsedBytes": 97089440,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.753999999999998,
"eventListeners": 2381,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8537.431000000026,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.921,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6039.032999999999,
"heapDeltaBytes": -7364436,
"heapUsedBytes": 85642644,
"domNodes": -268,
"jsHeapTotalBytes": -49152,
"scriptDurationMs": 2849.6440000000002,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10096.014000000083,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.597,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6682.195,
"heapDeltaBytes": -24189972,
"heapUsedBytes": 68636508,
"domNodes": -268,
"jsHeapTotalBytes": -274432,
"scriptDurationMs": 3208.472,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17634.15900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16826.418,
"heapDeltaBytes": -34561772,
"heapUsedBytes": 174735372,
"domNodes": -6548,
"jsHeapTotalBytes": 3919872,
"scriptDurationMs": 321.30800000000005,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17645.02500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16975.476,
"heapDeltaBytes": -25323184,
"heapUsedBytes": 183856344,
"domNodes": -6548,
"jsHeapTotalBytes": -3571712,
"scriptDurationMs": 338.28000000000003,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21153.68700000005,
"styleRecalcs": 172,
"styleRecalcDurationMs": 19.160999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20885.113999999998,
"heapDeltaBytes": -28835636,
"heapUsedBytes": 164287060,
"domNodes": -6548,
"jsHeapTotalBytes": 1769472,
"scriptDurationMs": 1063.9099999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 109,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21661.327000000027,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.74999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21374.412,
"heapDeltaBytes": -31756992,
"heapUsedBytes": 177577488,
"domNodes": -6548,
"jsHeapTotalBytes": -5144576,
"scriptDurationMs": 1029.191,
"eventListeners": -7469,
"totalBlockingTimeMs": 56,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 109.4349999999622,
"styleRecalcs": 6,
"styleRecalcDurationMs": 15.642,
"layouts": 6,
"layoutDurationMs": 2.069,
"taskDurationMs": 77.80899999999998,
"heapDeltaBytes": 3151384,
"heapUsedBytes": 66129416,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.988999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 455.475999999976,
"styleRecalcs": 11,
"styleRecalcDurationMs": 16.86,
"layouts": 3,
"layoutDurationMs": 0.691,
"taskDurationMs": 105.327,
"heapDeltaBytes": 5050296,
"heapUsedBytes": 67972980,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.923000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe change updates slot metadata assignment so widget names take precedence and adds a test for a same-named non-widget input. ChangesWidget slot ownership
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change prevents custom widgets from claiming same-named ordinary input sockets. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list and commit subject are available. The commit subject, “Preserves custom widget slot ownership,” does not use the specified bug-fix language. The PR changes Full details: Website End-To-End Regression CoverageExplanation The PR changes only Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The PR changes widget slot metadata selection and adds a focused test. The available change summary shows no entity-state mutation commands, new methods or properties on Full details: Description checkExplanation The description explains the fix, identifies the related issue, documents red-green verification, and provides a test plan. It does not use the template's Changes, Review Focus, or Screenshots headings, but it contains the key technical and validation information. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@huang47 @christian-byrne This is the focused two-commit dependency blocking #15590. The test-only commit failed solely on the observed duplicate socket, the source-only commit is locally green, and CodeRabbit has approved the current head with no threads. Please review when you can; after it lands I will merge main into #15590 and rerun both required gates repeatedly. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16122 +/- ##
==========================================
+ Coverage 80.61% 82.63% +2.02%
==========================================
Files 2291 1941 -350
Lines 117992 111918 -6074
Branches 34106 32244 -1862
==========================================
- Hits 95116 92484 -2632
+ Misses 22333 19092 -3241
+ Partials 543 342 -201
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 361 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@huang47 @christian-byrne re-ping on the exact green head. The test-only commit is proven red in run 33100566398; the source-only fix has all 75 PR checks green, and the combined custom-node gate passed 184/184 with zero failures, skips, flakes, or retries in two consecutive runs (33102039974 and 33103461842). #15590 is intentionally waiting for this focused product fix so its final diff remains gate-only. |
huang47
left a comment
There was a problem hiding this comment.
approve to unblock, leave comments which can be a follow up
| it('does not assign a non-widget input socket to a same-named custom widget', () => { | ||
| const { graph, node } = createGraphWithNode([]) | ||
| node.addInput('model', 'MODEL') | ||
| node.addWidget('custom', 'model', null, () => {}) | ||
|
|
||
| const [processedWidget] = computeProcessedWidgets({ | ||
| nodeData: node._state, | ||
| widgetIds: undefined, | ||
| graphId: GRAPH_ID, | ||
| showAdvanced: false, | ||
| isGraphReady: true, | ||
| rootGraph: graph, | ||
| ui: noopUi | ||
| }) | ||
|
|
||
| expect(processedWidget.slotMetadata).toBeUndefined() |
There was a problem hiding this comment.
we need more test cases to cover widgetId / linked paths added in this PR
## Summary Prevent a custom widget from claiming a same-named non-widget input socket in Nodes 2.0. This fixes the duplicate slot detected by custom-node S2 in #15590. ## Red-green verification - Test-only `a0a1b3fbf8`: [unit CI failed only on the new assertion](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33100566398) on all three attempts; current main was green. - Source-only `5eb7c2abba`: preserves explicit/promoted/linked widget slots while excluding an unlinked ordinary input from a same-named custom widget. ## Test plan - 91 focused widget, slot, and subgraph tests pass. - Typecheck, lint, Knip, and format pass. - Full PR CI must pass on the source-fix commit.
…g#17579) ## Summary Keep unrelated same-name widgets usable after linking in both renderers. **Human owner:** DrJKL. Christian Byrne owns CI repair until exact-head checks are green. <details><summary>Full context for agent readers</summary> ## Changes - Require explicit `input.widget` or promoted `widgetId` ownership before applying linked-slot state to a widget. A matching socket name and a link alone do not establish ownership. - Cover unowned, `input.widget`-owned, and `widgetId`-only linked sockets in the unit ownership matrix. - Verify the same unrelated-name button remains rendered and usable before and after linking in both the legacy canvas and Vue node renderers. - Keep legitimate linked widget inputs disabled and preserve existing visibility behavior. ## Review Focus The unlinked guard in [the earlier ownership fix](Comfy-Org#16122) left a linked-socket fallback. That fallback attached slot metadata to an unrelated custom widget and disabled it. [The subgraph boundary presentation PR](Comfy-Org#17128) consumes linked metadata but does not repair this ownership decision. This is a generic custom-widget mechanism test, not certification of an installed third-party pack. No serialization, link topology, or widget value behavior changes. ## Testing The surrounding composable suite passed 101 tests across 10 files. The focused browser test passed for both legacy and Vue renderers. ### E2E Verification Steps 1. Run the scenario once with legacy nodes and once with Vue nodes. 2. Construct a node with an unbound `model` input socket plus a separate `model` button widget. 3. Assert the button is rendered and usable before linking. 4. Link the producer output to the unrelated same-name input. 5. Assert the button remains rendered and usable after linking. ### Verification Evidence ```text $ node node_modules/vitest/vitest.mjs run src/renderer/extensions/vueNodes/composables Test Files 10 passed (10) Tests 101 passed (101) $ PLAYWRIGHT_TEST_URL=http://127.0.0.1:5233 PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:8293 node node_modules/@playwright/test/cli.js test sameNameSocketWidget.spec.ts --project=chromium --workers=1 --reporter=line 2 passed (13.1s) Mutation: remove the widgetId ownership fallback 1 failed, 36 passed; the intended widgetId-only ownership assertion failed. Mutation: suppress the legacy production label draw 1 failed; expected one rendered label, received zero. ``` The browser run used the candidate checkout's Vite server on port 5233 with a dedicated test backend on port 8293. The full browser suite and release builds were not run locally. Exact-head CI is pending. ## Checklist - [x] Root cause reproduced in unit and browser tests. - [x] Unowned linked widgets remain enabled. - [x] `input.widget` and `widgetId` ownership remain linked and disabled. - [x] Both legacy and Vue renderers retain the unrelated control. - [x] Causal production mutations fail the intended assertions. - [ ] Exact-head CI and human review complete. Glossary: CI means automated pull-request checks; ownership metadata associates an input socket with its widget; legacy renderer means the canvas-drawn node UI; Vue renderer means the DOM-based node UI. </details>
Summary
Prevent a custom widget from claiming a same-named non-widget input socket in Nodes 2.0. This fixes the duplicate slot detected by custom-node S2 in #15590.
Red-green verification
a0a1b3fbf8: unit CI failed only on the new assertion on all three attempts; current main was green.5eb7c2abba: preserves explicit/promoted/linked widget slots while excluding an unlinked ordinary input from a same-named custom widget.Test plan