Skip to content

fix: keep non-widget input sockets out of custom widgets - #16122

Merged
benjcooley merged 2 commits into
mainfrom
benjcooley/widget-slot-ownership-fix
Aug 27, 2026
Merged

benjcooley merged 2 commits into
mainfrom
benjcooley/widget-slot-ownership-fix

Conversation

@benjcooley

@benjcooley benjcooley commented Aug 27, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Prevent a custom widget from claiming a same-named non-widget input socket in Nodes 2.0. This fixes the duplicate slot detected by custom-node S2 in #15590.

Red-green verification

  • Test-only a0a1b3fbf8: unit CI failed only on the new assertion on all three attempts; current main was green.
  • Source-only 5eb7c2abba: preserves explicit/promoted/linked widget slots while excluding an unlinked ordinary input from a same-named custom widget.

Test plan

  • 91 focused widget, slot, and subgraph tests pass.
  • Typecheck, lint, Knip, and format pass.
  • Full PR CI must pass on the source-fix commit.

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/27/2026, 06:09:13 PM UTC

Links

🎭 Playwright: ✅ 2013 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1992 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 9.61 MB gzip 🔴 +27 B

Details

Summary

  • Raw size: 40.8 MB baseline 40.8 MB — 🔴 +72 B
  • Gzip: 9.61 MB baseline 9.61 MB — 🔴 +27 B
  • Brotli: 6.76 MB baseline 6.76 MB — 🟢 -85 B
  • Bundles: 451 current • 451 baseline • 3 added / 3 removed

Category Glance
Graph Workspace 🔴 +72 B (1.39 MB) · Vendor & Third-Party ⚪ 0 B (18.1 MB) · Other ⚪ 0 B (16.2 MB) · Data & Services ⚪ 0 B (3.55 MB) · Panels & Settings ⚪ 0 B (622 kB) · Utilities & Hooks ⚪ 0 B (555 kB) · + 5 more

App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-CalS3-MT.js (removed) 3.78 kB — 🟢 -3.78 kB 🟢 -1.9 kB 🟢 -1.65 kB
assets/index-DZ1SR3sy.js (new) — 3.78 kB 🔴 +3.78 kB 🔴 +1.9 kB 🔴 +1.61 kB

Status: 1 added / 1 removed

Graph Workspace — 1.39 MB (baseline 1.39 MB) • 🔴 +72 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-nh2cWx4b.js (new) — 1.38 MB 🔴 +1.38 MB 🔴 +302 kB 🔴 +227 kB
assets/GraphView-D_9ZMmRq.js (removed) 1.38 MB — 🟢 -1.38 MB 🟢 -302 kB 🟢 -227 kB

Status: 1 added / 1 removed / 2 unchanged

Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 17 unchanged

Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 28 unchanged

User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 11 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 8 unchanged

UI Components — 115 kB (baseline 115 kB) • ⚪ 0 B

Reusable component library chunks

Status: 15 unchanged

Data & Services — 3.55 MB (baseline 3.55 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 37 unchanged

Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 16.2 MB (baseline 16.2 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-DY2gVVuW.js (new) — 41.6 kB 🔴 +41.6 kB 🔴 +12.2 kB 🔴 +10.6 kB
assets/main-W4o62HUT.js (removed) 41.6 kB — 🟢 -41.6 kB 🟢 -12.2 kB 🟢 -10.6 kB

Status: 1 added / 1 removed / 295 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 128ms TBT · 92.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.0 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 83ms TBT · 163.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap

⚠️ 14 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 506ms 512ms +1% ⚠️ z=3.8
canvas-mouse-sweep: script duration 167ms 160ms -4% ⚠️ z=3.8
canvas-zoom-sweep: task duration 381ms 376ms -1% ⚠️ z=2.1
dom-widget-clipping: task duration 479ms 445ms -7% ⚠️ z=4.9
dom-widget-clipping: script duration 167ms 164ms -2% ⚠️ z=29.7
large-graph-pan: task duration 1793ms 1734ms -3% ⚠️ z=15.2
large-graph-pan: script duration 916ms 883ms -4% ⚠️ z=24.0
minimap-idle: task duration 598ms 646ms +8% ⚠️ z=2.5
subgraph-dom-widget-clipping: task duration 428ms 430ms +0% ⚠️ z=2.8
subgraph-dom-widget-clipping: script duration 146ms 143ms -1% ⚠️ z=2.4
subgraph-idle: task duration 546ms 485ms -11% ⚠️ z=3.7
subgraph-mouse-sweep: layout duration 4ms 6ms +37% ⚠️ z=3.1
subgraph-mouse-sweep: script duration 117ms 119ms +2% ⚠️ z=2.8
workflow-execution: event listeners 97 61 -37% ⚠️ z=2.1
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 8ms 6ms -21% z=-5.0
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 8 8 -6% z=-6.5
canvas-idle: task duration 506ms 512ms +1% ⚠️ z=3.8
canvas-idle: script duration 10ms 9ms -8% z=-7.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 75.6 MB 58.1 MB -23% —
canvas-idle: DOM nodes -283 -281 -1% z=-238.0
canvas-idle: event listeners -155 -170 +10% z=-38.4
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms -1% —
canvas-mouse-sweep: layout duration 4ms 4ms -3% z=0.6
canvas-mouse-sweep: style recalc duration 40ms 40ms +0% z=-0.9
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 74 75 +1% z=-1.8
canvas-mouse-sweep: task duration 941ms 922ms -2% z=1.0
canvas-mouse-sweep: script duration 167ms 160ms -4% ⚠️ z=3.8
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 57.1 MB 65.6 MB +15% —
canvas-mouse-sweep: DOM nodes -282 -284 +1% z=-133.7
canvas-mouse-sweep: event listeners -157 -172 +10% z=-43.3
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms -0% —
canvas-zoom-sweep: layout duration 1ms 1ms -12% z=-0.9
canvas-zoom-sweep: style recalc duration 18ms 17ms -7% z=-1.3
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 31 +0% z=-0.6
canvas-zoom-sweep: task duration 381ms 376ms -1% ⚠️ z=2.1
canvas-zoom-sweep: script duration 12ms 13ms +3% z=-4.8
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 64.3 MB 63.9 MB -1% —
canvas-zoom-sweep: DOM nodes 77 76 -1% z=-4.1
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.6
dom-widget-clipping: p95 frame time 17ms 17ms +1% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 6ms 7ms +7% z=-3.9
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 9 10 +6% z=-7.2
dom-widget-clipping: task duration 479ms 445ms -7% ⚠️ z=4.9
dom-widget-clipping: script duration 167ms 164ms -2% ⚠️ z=29.7
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 78.3 MB 78.5 MB +0% —
dom-widget-clipping: DOM nodes 14 15 +7% z=-5.0
dom-widget-clipping: event listeners 2 1 -50% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=0.2
large-graph-idle: p95 frame time 17ms 17ms +1% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 5ms 5ms -4% z=-7.0
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 5 5 +0% z=-21.0
large-graph-idle: task duration 697ms 647ms -7% z=1.9
large-graph-idle: script duration 41ms 41ms -0% z=-5.9
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 82.9 MB 83.3 MB +0% —
large-graph-idle: DOM nodes -271 -271 +0% z=-327.1
large-graph-idle: event listeners -183 -154 -16% z=-29.5
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 9ms 10ms +15% z=-8.6
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 63 66 +4% z=-6.4
large-graph-pan: task duration 1793ms 1734ms -3% ⚠️ z=15.2
large-graph-pan: script duration 916ms 883ms -4% ⚠️ z=24.0
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 80.8 MB 77.5 MB -4% —
large-graph-pan: DOM nodes -275 -261 -5% z=-169.4
large-graph-pan: event listeners 6 -89 -1575% z=-112.8
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 7ms 7ms -4% —
large-graph-zoom: style recalc duration 11ms 11ms -5% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 62 61 -2% —
large-graph-zoom: task duration 1852ms 1765ms -5% —
large-graph-zoom: script duration 852ms 823ms -3% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 72.7 MB 72.2 MB -1% —
large-graph-zoom: DOM nodes -278 -143 -49% —
large-graph-zoom: event listeners 8 -86 -1169% —
legacy-node-drag: avg frame time 17ms 17ms -0% —
legacy-node-drag: p95 frame time 17ms 17ms +0% —
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 5ms 5ms -3% —
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 40 40 +0% —
legacy-node-drag: task duration 2029ms 1984ms -2% —
legacy-node-drag: script duration 1016ms 1004ms -1% —
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 82.7 MB 82.0 MB -1% —
legacy-node-drag: DOM nodes 0 0 +0% —
legacy-node-drag: event listeners 188 188 +0% —
minimap-idle: avg frame time 17ms 17ms -0% z=-0.4
minimap-idle: p95 frame time 17ms 17ms +1% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 2ms 4ms +128% z=-6.7
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 2 5 +125% z=-7.4
minimap-idle: task duration 598ms 646ms +8% ⚠️ z=2.5
minimap-idle: script duration 39ms 39ms +1% z=-5.9
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 83.8 MB 83.9 MB +0% —
minimap-idle: DOM nodes -275 -272 -1% z=-212.5
minimap-idle: event listeners -153 -183 +20% z=-284.1
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.4
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 12ms 11ms -6% z=-2.0
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 46 46 +0% z=-3.3
subgraph-dom-widget-clipping: task duration 428ms 430ms +0% ⚠️ z=2.8
subgraph-dom-widget-clipping: script duration 146ms 143ms -1% ⚠️ z=2.4
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 75.3 MB 75.1 MB -0% —
subgraph-dom-widget-clipping: DOM nodes 18 18 +0% z=-3.7
subgraph-dom-widget-clipping: event listeners 6 8 +33% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 8ms -6% z=-2.9
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 9 +0% z=-2.9
subgraph-idle: task duration 546ms 485ms -11% ⚠️ z=3.7
subgraph-idle: script duration 10ms 8ms -21% z=-4.6
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 68.1 MB 56.7 MB -17% —
subgraph-idle: DOM nodes -297 -296 -0% z=-212.6
subgraph-idle: event listeners -231 -201 -13% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms -1% —
subgraph-mouse-sweep: layout duration 4ms 6ms +37% ⚠️ z=3.1
subgraph-mouse-sweep: style recalc duration 35ms 39ms +9% z=-1.2
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 75 75 +0% z=-2.7
subgraph-mouse-sweep: task duration 861ms 865ms +0% z=1.4
subgraph-mouse-sweep: script duration 117ms 119ms +2% ⚠️ z=2.8
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 58.0 MB 64.3 MB +11% —
subgraph-mouse-sweep: DOM nodes -296 -298 +1% z=-163.1
subgraph-mouse-sweep: event listeners -201 -216 +7% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms -0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 15ms 14ms -4% —
subgraph-transition-enter: style recalc duration 32ms 32ms -2% —
subgraph-transition-enter: layout count 14 15 +7% —
subgraph-transition-enter: style recalc count 19 20 +5% —
subgraph-transition-enter: task duration 1025ms 922ms -10% —
subgraph-transition-enter: script duration 35ms 32ms -10% —
subgraph-transition-enter: TBT 148ms 128ms -14% —
subgraph-transition-enter: heap used 100.3 MB 92.6 MB -8% —
subgraph-transition-enter: DOM nodes 13671 13671 +0% —
subgraph-transition-enter: event listeners 2381 2381 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms -1% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 35ms 37ms +5% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 248 248 +0% —
viewport-pan-sweep: task duration 6445ms 6361ms -1% —
viewport-pan-sweep: script duration 3029ms 3029ms +0% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 82.8 MB 73.6 MB -11% —
viewport-pan-sweep: DOM nodes -269 -268 -0% —
viewport-pan-sweep: event listeners -137 -136 -1% —
vue-large-graph-idle: avg frame time 18ms 18ms -0% —
vue-large-graph-idle: p95 frame time 17ms 17ms -0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 17134ms 16901ms -1% —
vue-large-graph-idle: script duration 343ms 330ms -4% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 168.3 MB 171.0 MB +2% —
vue-large-graph-idle: DOM nodes -6548 -6548 +0% —
vue-large-graph-idle: event listeners -7473 -7474 +0% —
vue-large-graph-pan: avg frame time 18ms 18ms -3% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 20ms 20ms +1% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 173 172 -1% —
vue-large-graph-pan: task duration 21226ms 21130ms -0% —
vue-large-graph-pan: script duration 1031ms 1047ms +2% —
vue-large-graph-pan: TBT 61ms 83ms +35% —
vue-large-graph-pan: heap used 167.8 MB 163.0 MB -3% —
vue-large-graph-pan: DOM nodes -6548 -6548 +0% —
vue-large-graph-pan: event listeners -7469 -7470 +0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 1ms 1ms +87% z=-1.2
workflow-execution: style recalc duration 18ms 16ms -10% z=-3.6
workflow-execution: layout count 3 5 +50% z=-0.8
workflow-execution: style recalc count 12 9 -29% z=-4.5
workflow-execution: task duration 102ms 92ms -10% z=-2.9
workflow-execution: script duration 8ms 7ms -12% z=-7.3
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 65.2 MB 63.9 MB -2% —
workflow-execution: DOM nodes 121 125 +3% z=-5.0
workflow-execution: event listeners 97 61 -37% ⚠️ z=2.1
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-08-27T18:20:44.636Z",
  "gitSha": "7516dbedef20e311d6a21639ded851532e65428d",
  "branch": "benjcooley/widget-slot-ownership-fix",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2071.685000000002,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.082,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.895,
      "heapDeltaBytes": -2886788,
      "heapUsedBytes": 65689016,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.135000000000002,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.4319999999434,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.689000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.81500000000005,
      "heapDeltaBytes": -7216624,
      "heapUsedBytes": 56173632,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.609000000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1976.9739999999842,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 43.91100000000001,
      "layouts": 12,
      "layoutDurationMs": 3.962,
      "taskDurationMs": 974.7920000000001,
      "heapDeltaBytes": -439160,
      "heapUsedBytes": 63317452,
      "domNodes": -284,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 166.72,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1824.9590000000353,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 35.442,
      "layouts": 12,
      "layoutDurationMs": 3.504,
      "taskDurationMs": 870.029,
      "heapDeltaBytes": 10953440,
      "heapUsedBytes": 74196848,
      "domNodes": -283,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 153.844,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.796999999971,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.494,
      "layouts": 6,
      "layoutDurationMs": 0.589,
      "taskDurationMs": 346.175,
      "heapDeltaBytes": 3884072,
      "heapUsedBytes": 67612924,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.572000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.7410000000045,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.657,
      "layouts": 6,
      "layoutDurationMs": 0.6119999999999999,
      "taskDurationMs": 405.469,
      "heapDeltaBytes": 3749348,
      "heapUsedBytes": 66353628,
      "domNodes": 76,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 14.812,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 690.922999999998,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.628000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 440.212,
      "heapDeltaBytes": 19339080,
      "heapUsedBytes": 82273964,
      "domNodes": 14,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 160.855,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 669.3480000000136,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.917000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.704,
      "heapDeltaBytes": 19177636,
      "heapUsedBytes": 82450108,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 167.691,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.6540000000082,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.719000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 635.79,
      "heapDeltaBytes": -6095684,
      "heapUsedBytes": 87218832,
      "domNodes": -271,
      "jsHeapTotalBytes": -1585152,
      "scriptDurationMs": 40.77,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.095999999996,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.087999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 659.0169999999999,
      "heapDeltaBytes": -5366344,
      "heapUsedBytes": 87401768,
      "domNodes": -271,
      "jsHeapTotalBytes": -2109440,
      "scriptDurationMs": 40.27199999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2356.398000000013,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.203999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1722.5609999999997,
      "heapDeltaBytes": 10000308,
      "heapUsedBytes": 82061108,
      "domNodes": -245,
      "jsHeapTotalBytes": 438272,
      "scriptDurationMs": 871.34,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2553.8740000000644,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.664000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1746.422,
      "heapDeltaBytes": 14914292,
      "heapUsedBytes": 80564596,
      "domNodes": -276,
      "jsHeapTotalBytes": 1011712,
      "scriptDurationMs": 895.4110000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3569.54300000001,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.62,
      "layouts": 60,
      "layoutDurationMs": 7.1469999999999985,
      "taskDurationMs": 1726.5459999999998,
      "heapDeltaBytes": 8889868,
      "heapUsedBytes": 76320652,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 819.6239999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3666.729000000032,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.700999999999997,
      "layouts": 60,
      "layoutDurationMs": 7.271,
      "taskDurationMs": 1802.876,
      "heapDeltaBytes": 1600940,
      "heapUsedBytes": 75101144,
      "domNodes": -285,
      "jsHeapTotalBytes": -1884160,
      "scriptDurationMs": 826.538,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3049.6619999999552,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.490999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1918.224,
      "heapDeltaBytes": 19080528,
      "heapUsedBytes": 85808832,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 965.98,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3167.822000000001,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.079000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2049.134,
      "heapDeltaBytes": 19301264,
      "heapUsedBytes": 86129692,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1041.827,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.3719999999762,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.602000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 626.1370000000001,
      "heapDeltaBytes": 12379120,
      "heapUsedBytes": 87837588,
      "domNodes": -271,
      "jsHeapTotalBytes": -1884160,
      "scriptDurationMs": 37.903000000000006,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2039.0739999999141,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.526999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 665.5150000000001,
      "heapDeltaBytes": 12328364,
      "heapUsedBytes": 88192384,
      "domNodes": -272,
      "jsHeapTotalBytes": -2408448,
      "scriptDurationMs": 40.683000000000014,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 605.8249999999816,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.628,
      "heapDeltaBytes": 14324232,
      "heapUsedBytes": 78707912,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 139.7,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 722.9110000000674,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.594,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.346,
      "heapDeltaBytes": 14022040,
      "heapUsedBytes": 78740288,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 147.191,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.6089999999608,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.286,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.7049999999999,
      "heapDeltaBytes": -5455852,
      "heapUsedBytes": 59116696,
      "domNodes": -296,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.458999999999998,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1997.9759999999942,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.991999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.355,
      "heapDeltaBytes": -4834440,
      "heapUsedBytes": 59885720,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.360000000000002,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1768.9900000000307,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 40.06999999999999,
      "layouts": 16,
      "layoutDurationMs": 4.567,
      "taskDurationMs": 899.6540000000002,
      "heapDeltaBytes": 8360892,
      "heapUsedBytes": 73323532,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 124.65499999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1773.4260000000859,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 37.118,
      "layouts": 16,
      "layoutDurationMs": 6.819999999999999,
      "taskDurationMs": 830.533,
      "heapDeltaBytes": -3130352,
      "heapUsedBytes": 61420840,
      "domNodes": -298,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 113.26899999999999,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1416.556999999898,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.730000000000008,
      "layouts": 15,
      "layoutDurationMs": 14.270000000000001,
      "taskDurationMs": 921.5439999999999,
      "heapDeltaBytes": 218196,
      "heapUsedBytes": 97089440,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 31.753999999999998,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8537.431000000026,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 34.921,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6039.032999999999,
      "heapDeltaBytes": -7364436,
      "heapUsedBytes": 85642644,
      "domNodes": -268,
      "jsHeapTotalBytes": -49152,
      "scriptDurationMs": 2849.6440000000002,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10096.014000000083,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 38.597,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6682.195,
      "heapDeltaBytes": -24189972,
      "heapUsedBytes": 68636508,
      "domNodes": -268,
      "jsHeapTotalBytes": -274432,
      "scriptDurationMs": 3208.472,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17634.15900000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16826.418,
      "heapDeltaBytes": -34561772,
      "heapUsedBytes": 174735372,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3919872,
      "scriptDurationMs": 321.30800000000005,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17645.02500000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16975.476,
      "heapDeltaBytes": -25323184,
      "heapUsedBytes": 183856344,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3571712,
      "scriptDurationMs": 338.28000000000003,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21153.68700000005,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 19.160999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20885.113999999998,
      "heapDeltaBytes": -28835636,
      "heapUsedBytes": 164287060,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1769472,
      "scriptDurationMs": 1063.9099999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 109,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21661.327000000027,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 20.74999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21374.412,
      "heapDeltaBytes": -31756992,
      "heapUsedBytes": 177577488,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5144576,
      "scriptDurationMs": 1029.191,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 109.4349999999622,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 15.642,
      "layouts": 6,
      "layoutDurationMs": 2.069,
      "taskDurationMs": 77.80899999999998,
      "heapDeltaBytes": 3151384,
      "heapUsedBytes": 66129416,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.988999999999999,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 455.475999999976,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 16.86,
      "layouts": 3,
      "layoutDurationMs": 0.691,
      "taskDurationMs": 105.327,
      "heapDeltaBytes": 5050296,
      "heapUsedBytes": 67972980,
      "domNodes": 121,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.923000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c7ac508d-7319-43b2-9f6b-de7509346c40

📥 Commits

Reviewing files that changed from the base of the PR and between a0a1b3f and 5eb7c2a.

📒 Files selected for processing (1)
  • src/renderer/extensions/vueNodes/composables/processedWidgetRenderModel.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The change updates slot metadata assignment so widget names take precedence and adds a test for a same-named non-widget input.

Changes

Widget slot ownership

Layer / File(s) Summary
Slot metadata assignment
src/renderer/extensions/vueNodes/composables/processedWidgetRenderModel.ts
buildSlotMetadata records one key per input. It uses the widget name first and uses the input name only for widget-backed or linked inputs.
Non-widget slot ownership validation
src/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.ts
Adds a test that verifies a MODEL input does not receive slotMetadata from a same-named custom widget.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 5eb7c

This change prevents custom widgets from claiming same-named ordinary input sockets. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: drjkl

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed The changed-file list and commit subject are available. The commit subject, “Preserves custom widget slot ownership,” does not use the specified bug-fix language. The PR changes src/ files and no `b…
Website End-To-End Regression Coverage ✅ Passed The PR changes only src/renderer/extensions/vueNodes/composables/... files. It does not change files under apps/website/src/ or apps/website/public/. The website end-to-end regression coverage c…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The PR changes widget slot metadata selection and adds a focused test. The available change summary shows no entity-state mutation commands, new methods or properties on LGraphNode, LGraphCanvas, …
Title check ✅ Passed The title clearly summarizes the main change: preventing custom widgets from claiming same-named non-widget input sockets.
Description check ✅ Passed The description explains the fix, identifies the related issue, documents red-green verification, and provides a test plan. It does not use the template's Changes, Review Focus, or Screenshots heading…
Full details: End-To-End Regression Coverage For Fixes

Explanation

The changed-file list and commit subject are available. The commit subject, “Preserves custom widget slot ownership,” does not use the specified bug-fix language. The PR changes src/ files and no browser_tests/ file, but the required bug-fix signal is absent. The check therefore passes.

Full details: Website End-To-End Regression Coverage

Explanation

The PR changes only src/renderer/extensions/vueNodes/composables/... files. It does not change files under apps/website/src/ or apps/website/public/. The website end-to-end regression coverage check does not apply.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The PR changes widget slot metadata selection and adds a focused test. The available change summary shows no entity-state mutation commands, new methods or properties on LGraphNode, LGraphCanvas, LGraph, or Subgraph, ECS component behavior, or extension-facing callback changes. No listed ADR 0003 or ADR 0008 pattern is present.

Full details: Description check

Explanation

The description explains the fix, identifies the related issue, documents red-green verification, and provides a test plan. It does not use the template's Changes, Review Focus, or Screenshots headings, but it contains the key technical and validation information.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch benjcooley/widget-slot-ownership-fix

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 27, 2026
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 27, 2026
@benjcooley
benjcooley marked this pull request as ready for review August 27, 2026 18:07
@benjcooley
benjcooley requested review from a team, DrJKL, christian-byrne and huang47 August 27, 2026 18:07
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 27, 2026
@benjcooley

Copy link
Copy Markdown
Collaborator Author

@huang47 @christian-byrne This is the focused two-commit dependency blocking #15590. The test-only commit failed solely on the observed duplicate socket, the source-only commit is locally green, and CodeRabbit has approved the current head with no threads. Please review when you can; after it lands I will merge main into #15590 and rerun both required gates repeatedly.

@huang47 huang47 self-assigned this Aug 27, 2026
@codecov

codecov Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #16122      +/-   ##
==========================================
+ Coverage   80.61%   82.63%   +2.02%     
==========================================
  Files        2291     1941     -350     
  Lines      117992   111918    -6074     
  Branches    34106    32244    -1862     
==========================================
- Hits        95116    92484    -2632     
+ Misses      22333    19092    -3241     
+ Partials      543      342     -201     
Flag Coverage Δ
e2e 66.71% <100.00%> (-0.01%) ⬇️
unit 75.09% <100.00%> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vueNodes/composables/processedWidgetRenderModel.ts 97.14% <100.00%> (+0.03%) ⬆️

... and 361 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjcooley

Copy link
Copy Markdown
Collaborator Author

@huang47 @christian-byrne re-ping on the exact green head. The test-only commit is proven red in run 33100566398; the source-only fix has all 75 PR checks green, and the combined custom-node gate passed 184/184 with zero failures, skips, flakes, or retries in two consecutive runs (33102039974 and 33103461842). #15590 is intentionally waiting for this focused product fix so its final diff remains gate-only.

@benjcooley
benjcooley enabled auto-merge August 27, 2026 18:49

@huang47 huang47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve to unblock, leave comments which can be a follow up

Comment on lines +153 to +168
it('does not assign a non-widget input socket to a same-named custom widget', () => {
const { graph, node } = createGraphWithNode([])
node.addInput('model', 'MODEL')
node.addWidget('custom', 'model', null, () => {})

const [processedWidget] = computeProcessedWidgets({
nodeData: node._state,
widgetIds: undefined,
graphId: GRAPH_ID,
showAdvanced: false,
isGraphReady: true,
rootGraph: graph,
ui: noopUi
})

expect(processedWidget.slotMetadata).toBeUndefined()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need more test cases to cover widgetId / linked paths added in this PR

@huang47 huang47 removed their assignment Aug 27, 2026
@benjcooley
benjcooley added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 92efbae Aug 27, 2026
102 of 103 checks passed
@benjcooley
benjcooley deleted the benjcooley/widget-slot-ownership-fix branch August 27, 2026 19:32
mattmillerai pushed a commit that referenced this pull request Aug 29, 2026
## Summary

Prevent a custom widget from claiming a same-named non-widget input
socket in Nodes 2.0. This fixes the duplicate slot detected by
custom-node S2 in #15590.

## Red-green verification

- Test-only `a0a1b3fbf8`: [unit CI failed only on the new
assertion](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/33100566398)
on all three attempts; current main was green.
- Source-only `5eb7c2abba`: preserves explicit/promoted/linked widget
slots while excluding an unlinked ordinary input from a same-named
custom widget.

## Test plan

- 91 focused widget, slot, and subgraph tests pass.
- Typecheck, lint, Knip, and format pass.
- Full PR CI must pass on the source-fix commit.
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 13, 2026
…g#17579)

## Summary

Keep unrelated same-name widgets usable after linking in both renderers.

**Human owner:** DrJKL. Christian Byrne owns CI repair until exact-head
checks are green.

<details><summary>Full context for agent readers</summary>

## Changes

- Require explicit `input.widget` or promoted `widgetId` ownership
before applying linked-slot state to a widget. A matching socket name
and a link alone do not establish ownership.
- Cover unowned, `input.widget`-owned, and `widgetId`-only linked
sockets in the unit ownership matrix.
- Verify the same unrelated-name button remains rendered and usable
before and after linking in both the legacy canvas and Vue node
renderers.
- Keep legitimate linked widget inputs disabled and preserve existing
visibility behavior.

## Review Focus

The unlinked guard in [the earlier ownership
fix](Comfy-Org#16122) left a
linked-socket fallback. That fallback attached slot metadata to an
unrelated custom widget and disabled it. [The subgraph boundary
presentation
PR](Comfy-Org#17128) consumes
linked metadata but does not repair this ownership decision.

This is a generic custom-widget mechanism test, not certification of an
installed third-party pack. No serialization, link topology, or widget
value behavior changes.

## Testing

The surrounding composable suite passed 101 tests across 10 files. The
focused browser test passed for both legacy and Vue renderers.

### E2E Verification Steps

1. Run the scenario once with legacy nodes and once with Vue nodes.
2. Construct a node with an unbound `model` input socket plus a separate
`model` button widget.
3. Assert the button is rendered and usable before linking.
4. Link the producer output to the unrelated same-name input.
5. Assert the button remains rendered and usable after linking.

### Verification Evidence

```text
$ node node_modules/vitest/vitest.mjs run src/renderer/extensions/vueNodes/composables
Test Files 10 passed (10)
Tests 101 passed (101)

$ PLAYWRIGHT_TEST_URL=http://127.0.0.1:5233 PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:8293 node node_modules/@playwright/test/cli.js test sameNameSocketWidget.spec.ts --project=chromium --workers=1 --reporter=line
2 passed (13.1s)

Mutation: remove the widgetId ownership fallback
1 failed, 36 passed; the intended widgetId-only ownership assertion failed.

Mutation: suppress the legacy production label draw
1 failed; expected one rendered label, received zero.
```

The browser run used the candidate checkout's Vite server on port 5233
with a dedicated test backend on port 8293. The full browser suite and
release builds were not run locally. Exact-head CI is pending.

## Checklist

- [x] Root cause reproduced in unit and browser tests.
- [x] Unowned linked widgets remain enabled.
- [x] `input.widget` and `widgetId` ownership remain linked and
disabled.
- [x] Both legacy and Vue renderers retain the unrelated control.
- [x] Causal production mutations fail the intended assertions.
- [ ] Exact-head CI and human review complete.

Glossary: CI means automated pull-request checks; ownership metadata
associates an input socket with its widget; legacy renderer means the
canvas-drawn node UI; Vue renderer means the DOM-based node UI.

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants