Repository navigation
[backport core/1.52] fix(billing): open Plan & Credits and refresh the balance for rail-less sessions - #16116
Conversation
…ss sessions (#15892) ## Why this is needed A session with no workspace context — an API-key sign-in, or a pre-workspace bootstrap — still reaches billing through the legacy rail, and two of its entry points were never migrated to the V1 layout: - The profile menu **Credits** action opens the legacy combined Credits + Activity screen instead of the tabbed **Plan & Credits** panel. That legacy panel is hidden from the settings menu and is only reachable by key, so the user lands somewhere they cannot navigate back to. - After a Stripe credit top-up, returning to the app shows the **pre-purchase balance until a manual reload**, and drops the user on that same hidden screen. Reported in [Slack](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1787651927438829?thread_ts=1787034725.224329&cid=C0932CGKT5K). ## Root cause **Destination.** #15793 routed the workspace-aware call sites to `workspace`, and deliberately left `CurrentUserPopoverLegacy` alone. But `CurrentUserButton` falls back to that legacy popover whenever `teamWorkspaceStore.initState !== 'ready'`, which is exactly the state an API-key session stays in — workspace discovery never runs for it. Two call sites still decide from the billing rail: ```ts // CurrentUserPopoverLegacy.vue — always the hidden panel settingsDialog.show('credits') // TopUpCreditsDialogContentLegacy.vue — hidden panel whenever no rail is active const settingsPanel = shouldUseWorkspaceBilling.value || isSubscriptionEnabled() ? 'workspace' : 'credits' ``` The rail is the wrong question. What decides whether `workspace` is reachable is panel availability, and `useSettingUI` registers Plan & Credits for every signed-in user (`shouldShowWorkspacePanel = isLoggedIn`). The panel also renders correctly on the legacy rail — its credits tile reads the same `/customers/balance` the legacy screen did. **Stale balance.** The workspace rail has a completion path for top-ups (`billingOperationStore` polls, refreshes the balance, and opens Plan & Credits). The legacy rail has no equivalent: `purchaseCreditsDirect()` ends at `window.open(checkout_url, '_blank')`. Stripe completes out of band in another tab, so nothing ever re-reads the balance and the pre-purchase amount stays on screen. ## How we change it - Both legacy call sites open `workspace`. The rail-derived branch in the top-up dialog goes away, along with its now-unused `useBillingRouting` / `useSubscription` reads. - New `watchForTopupBalanceUpdate()` (`src/composables/billing/topupBalanceRefresh.ts`), called right after the checkout tab opens. It waits for the app tab to become visible again, then re-fetches the balance on a `0 / 2s / 5s / 10s / 20s` schedule — the webhook usually lands a beat after the redirect. Retries stop as soon as the balance moves; the watch drops itself after 15 minutes if the user never returns, and a failed poll is logged rather than surfaced, since the purchase itself already succeeded. Cloud and workspace-billing sessions are unaffected: they already selected `workspace`, and their top-ups already refresh through `billingOperationStore`. ## AS IS / TO BE | | AS IS | TO BE | | --- | --- | --- | | Profile menu → Credits | hidden combined Credits + Activity screen | tabbed Plan & Credits | | After Stripe top-up | same hidden screen, stale balance until reload | tabbed Plan & Credits, balance refreshes on return | | Cloud / workspace billing | Plan & Credits | unchanged | ### Screenshots Both taken in the same API-key session against staging, differing only by this PR's commit. **AS IS** — profile menu → Credits lands on the hidden legacy screen: one `Credits` heading with `Activity` stacked underneath, no tabs, and `Plan & Credits` sitting unselected in the sidebar.  **TO BE** — the same action opens `Plan & Credits` with the `Credits` and `Activity` tabs.  ## Verification Local ComfyUI against staging (`--comfy-api-base https://stagingapi.comfy.org`) with a pure API-key session (no Firebase login), which is the state that reproduces this. The build under test also carried #15891, because an API-key session cannot read `/customers/*` without it — so the requests below are only reachable with that PR applied, and the screenshots above differ from each other by this PR's commit alone: - Profile menu → **Credits** opens Plan & Credits with the **Credits** and **Activity** tabs. - **Add credits → Continue to payment** issues `POST /customers/credit` (`201`), opens the Stripe tab, and returns to the tabbed panel. - Simulating the return to the app tab issues `GET /customers/balance` immediately and again on the retry schedule. - The watch survives an early return: a bounce back to the app before paying no longer consumes it, and the return after payment still refreshes. Unit tests: `topupBalanceRefresh.test.ts` (new — no refresh before the tab is visible, refresh on return, retry while unchanged, stop once the balance rises, keep polling when a fetch rejects), plus updated destination assertions in `CurrentUserPopoverLegacy.test.ts` and `TopUpCreditsDialogContentLegacy.test.ts`. 117 tests pass across the touched suites; `pnpm typecheck` clean. ## Note Independent of #15891 — no shared files — but the same API-key session is what surfaces both. **Manage billing** inside this panel needs that PR's `accessBillingPortal` fix to work. https://claude.ai/code/session_01QQZvvG7jZKrEkkT93ezPPw
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1984 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-27T15:51:22.766Z",
"gitSha": "536ffcf0c6d83c543deec730cd0dad698a0d07b7",
"branch": "backport-15892-to-core-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2091.127999999998,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.210999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.4509999999999,
"heapDeltaBytes": -6287332,
"heapUsedBytes": 55242012,
"domNodes": -284,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.648999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2073.1610000000273,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.0550000000001,
"heapDeltaBytes": -5429132,
"heapUsedBytes": 55802184,
"domNodes": -283,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.564999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.609000000003,
"styleRecalcs": 75,
"styleRecalcDurationMs": 39.72,
"layouts": 12,
"layoutDurationMs": 3.7920000000000003,
"taskDurationMs": 895.693,
"heapDeltaBytes": 7681692,
"heapUsedBytes": 70248132,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 108.984,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1871.866999999952,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.818999999999996,
"layouts": 12,
"layoutDurationMs": 3.8609999999999998,
"taskDurationMs": 917.4469999999999,
"heapDeltaBytes": -3069304,
"heapUsedBytes": 59168280,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 107.764,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.8729999999887,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.585,
"layouts": 6,
"layoutDurationMs": 0.678,
"taskDurationMs": 376.97700000000003,
"heapDeltaBytes": 3335940,
"heapUsedBytes": 65730572,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.796,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.0799999999917,
"styleRecalcs": 31,
"styleRecalcDurationMs": 21.334000000000003,
"layouts": 6,
"layoutDurationMs": 0.784,
"taskDurationMs": 370.996,
"heapDeltaBytes": 3312284,
"heapUsedBytes": 65947732,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.912999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 612.5170000000253,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.502,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.652,
"heapDeltaBytes": 11016536,
"heapUsedBytes": 73584260,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 53.574,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 579.8379999999952,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.328000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.279,
"heapDeltaBytes": 10122388,
"heapUsedBytes": 72042188,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 52.876999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.9749999999894,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.868,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.11,
"heapDeltaBytes": -4881868,
"heapUsedBytes": 72138452,
"domNodes": -279,
"jsHeapTotalBytes": -2101248,
"scriptDurationMs": 15.533000000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2072.165000000041,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.408000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.205,
"heapDeltaBytes": -244636,
"heapUsedBytes": 76827492,
"domNodes": -270,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 16.826999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.9460000000154,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.897000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1198.204,
"heapDeltaBytes": -13853012,
"heapUsedBytes": 64133064,
"domNodes": -282,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 316.062,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2176.0570000000143,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.951000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1216.3120000000001,
"heapDeltaBytes": 11932476,
"heapUsedBytes": 89034412,
"domNodes": -285,
"jsHeapTotalBytes": 4153344,
"scriptDurationMs": 315.26899999999995,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3136.757999999986,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.475,
"layouts": 60,
"layoutDurationMs": 8.237,
"taskDurationMs": 1412.951,
"heapDeltaBytes": -1947488,
"heapUsedBytes": 77481692,
"domNodes": -274,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 389.34499999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3184.827999999925,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.196000000000002,
"layouts": 60,
"layoutDurationMs": 8.506,
"taskDurationMs": 1419.915,
"heapDeltaBytes": -12599436,
"heapUsedBytes": 66382308,
"domNodes": -286,
"jsHeapTotalBytes": 5763072,
"scriptDurationMs": 386.834,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2320.4790000000344,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.207999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1564.47,
"heapDeltaBytes": -23744736,
"heapUsedBytes": 63302964,
"domNodes": -248,
"jsHeapTotalBytes": 6549504,
"scriptDurationMs": 503.19000000000005,
"eventListeners": 31,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2306.954000000019,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.204000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1461.346,
"heapDeltaBytes": 11231848,
"heapUsedBytes": 91195236,
"domNodes": 14,
"jsHeapTotalBytes": 7794688,
"scriptDurationMs": 462.246,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2062.463999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.960000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.421,
"heapDeltaBytes": -11031612,
"heapUsedBytes": 74128472,
"domNodes": -275,
"jsHeapTotalBytes": 1568768,
"scriptDurationMs": 18.179000000000002,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.8079999999973,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.1350000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.856,
"heapDeltaBytes": -14025908,
"heapUsedBytes": 63906736,
"domNodes": -282,
"jsHeapTotalBytes": 3403776,
"scriptDurationMs": 15.584000000000001,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.0040000000226,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.10699999999997,
"heapDeltaBytes": 11855436,
"heapUsedBytes": 74783164,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 121.42999999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 610.1699999999255,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.69500000000005,
"heapDeltaBytes": 12005020,
"heapUsedBytes": 74237504,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 124.623,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.8779999999679,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.828000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.073,
"heapDeltaBytes": 6262404,
"heapUsedBytes": 69224048,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.713999999999999,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2032.5259999999616,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.808000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.63800000000003,
"heapDeltaBytes": 1420600,
"heapUsedBytes": 64127048,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.988000000000001,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.6150000000143,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.61000000000001,
"layouts": 16,
"layoutDurationMs": 4.992,
"taskDurationMs": 813.019,
"heapDeltaBytes": -5016804,
"heapUsedBytes": 57588780,
"domNodes": -284,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 87.807,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.5649999999887,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.477,
"layouts": 16,
"layoutDurationMs": 4.568,
"taskDurationMs": 825.6060000000001,
"heapDeltaBytes": 5924696,
"heapUsedBytes": 68712032,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 88.376,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.9130000000223,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.202,
"layouts": 13,
"layoutDurationMs": 13.174000000000001,
"taskDurationMs": 946.2359999999999,
"heapDeltaBytes": 1521204,
"heapUsedBytes": 100071120,
"domNodes": 13673,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 16.654000000000003,
"eventListeners": 2373,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8275.059,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4318.955,
"heapDeltaBytes": 10054084,
"heapUsedBytes": 87282304,
"domNodes": -272,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 1051.997,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8261.344000000008,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4277.483,
"heapDeltaBytes": 9800184,
"heapUsedBytes": 86836196,
"domNodes": -269,
"jsHeapTotalBytes": -1351680,
"scriptDurationMs": 1068.981,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18732.001999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17930.472999999998,
"heapDeltaBytes": -50742660,
"heapUsedBytes": 176167840,
"domNodes": -8312,
"jsHeapTotalBytes": -19058688,
"scriptDurationMs": 136.782,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18579.60700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17539.968,
"heapDeltaBytes": -37470432,
"heapUsedBytes": 180657372,
"domNodes": -8312,
"jsHeapTotalBytes": -16338944,
"scriptDurationMs": 127.798,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22914.372000000014,
"styleRecalcs": 174,
"styleRecalcDurationMs": 21.90399999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22305.967000000004,
"heapDeltaBytes": -38696772,
"heapUsedBytes": 174102944,
"domNodes": -8312,
"jsHeapTotalBytes": -17866752,
"scriptDurationMs": 437.252,
"eventListeners": -16387,
"totalBlockingTimeMs": 178,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22403.863999999998,
"styleRecalcs": 175,
"styleRecalcDurationMs": 20.853999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21675.97,
"heapDeltaBytes": -36422312,
"heapUsedBytes": 194468044,
"domNodes": -8312,
"jsHeapTotalBytes": -22687744,
"scriptDurationMs": 416.74999999999994,
"eventListeners": -16385,
"totalBlockingTimeMs": 158,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 464.97899999997117,
"styleRecalcs": 15,
"styleRecalcDurationMs": 23.049,
"layouts": 3,
"layoutDurationMs": 1.2650000000000001,
"taskDurationMs": 114.57600000000001,
"heapDeltaBytes": 5113440,
"heapUsedBytes": 66848768,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.309000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 114.12699999993947,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.778,
"layouts": 2,
"layoutDurationMs": 0.6539999999999998,
"taskDurationMs": 75.34299999999999,
"heapDeltaBytes": 3092380,
"heapUsedBytes": 65090452,
"domNodes": 108,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.018000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.52 #16116 +/- ##
=============================================
- Coverage 81.99% 81.99% -0.01%
=============================================
Files 1905 1906 +1
Lines 108816 108865 +49
Branches 29686 29693 +7
=============================================
+ Hits 89226 89261 +35
- Misses 19252 19260 +8
- Partials 338 344 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15892 to
core/1.52Automatically created by backport workflow.