Repository navigation
[backport core/1.51] fix(billing): gate subscribe-to-run only on Cloud - #16039
Conversation
## Summary On Local, clicking Run silently did nothing when the active workspace has no active subscription (e.g. 0 credits) — for any workflow, with or without API nodes, on any login method. Scope the subscribe-to-run gate in the queue commands to Cloud so Local always queues. Found during 1.51 QA of the local workspace switcher ([Slack report](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1787740255008649?thread_ts=1787034725.224329&cid=C0932CGKT5K)). ## Root cause The break is an interaction of three pieces: 1. `Comfy.QueuePrompt` / `Comfy.QueuePromptFront` / `Comfy.QueueSelectedOutputNodes` return early when `canAccessSubscriptionFeatures` is false (`useCoreCommands.ts`), with no distribution check. 2. Since the local workspace switcher (#15558), Local routes billing to the workspace rail once workspace context loads (`useBillingRouting`). `useWorkspaceBilling.canAccessSubscriptionFeatures` is `statusData?.is_active ?? false` — unlike the legacy rail (`useSubscription.ts`), it has no `!isCloud → true` exemption, so an unsubscribed/zero-credit workspace reports false on Local. 3. The gate's fallback `showSubscriptionDialog` → `showPricingTable` starts with `if (!isCloud) return` (`useSubscriptionDialog.ts`), so on Local the block is invisible: no dialog, no toast, nothing. ```mermaid flowchart LR A[Run click] --> B[Comfy.QueuePrompt] B --> C{canAccessSubscriptionFeatures?} C -- "Local + workspace rail, is_active=false" --> D[showSubscriptionDialog] D --> E["showPricingTable: if (!isCloud) return"] E --> F[silent no-op — Run does nothing] C -- true --> G[app.queuePrompt] ``` ## How we change it Gate the three queue commands with `isCloud && !canAccessSubscriptionFeatures` — subscription gating is a Cloud concept, and this mirrors the legacy rail's own `!isCloud` exemption. The gate flag itself is left untouched: flipping `useWorkspaceBilling.canAccessSubscriptionFeatures` to true on Local would regress the Plan & Credits UI, which intentionally renders the unsubscribed state on Local (#15828). Insufficient-credit handling for partner nodes is unaffected: the backend still rejects the prompt and the error-catalog path (`insufficient_credits` → top-up dialog) handles it, so Local behavior returns to server-driven. ## AS IS / TO BE - **AS IS**: Local + workspace with 0 credits → Run click is a silent no-op for every workflow (QA video in the Slack thread above). - **TO BE**: Local always queues. OSS workflows run; partner-node workflows surface the backend insufficient-credits error with top-up CTA. Cloud gating is unchanged (dialog still shown when unsubscribed). ## Tests - Unit (`useCoreCommands.test.ts`): Local + `canAccessSubscriptionFeatures=false` queues and shows no dialog (fails against the previous code); Cloud unsubscribed still blocks with the `subscribe_to_run` dialog; Cloud subscribed queues. ## Review Focus - The guard intentionally keys on distribution (`isCloud`), not on billing-rail internals, so bootstrap-time rail flapping on Local can never block Run.⚠️ Needs backport to `core/1.51` — this is a 1.51 release blocker.
🎭 Playwright: ✅ 1825 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-26T12:32:05.696Z",
"gitSha": "15edfa4b053eb41605ab6014408c650cb120d09b",
"branch": "backport-16032-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2119.6630000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.693999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.604,
"heapDeltaBytes": 5380928,
"heapUsedBytes": 70787208,
"domNodes": 18,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 10.657,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2052.2170000000415,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.641000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.767,
"heapDeltaBytes": 4937576,
"heapUsedBytes": 70244820,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 10.489999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2073.0460000000335,
"styleRecalcs": 79,
"styleRecalcDurationMs": 48.07300000000001,
"layouts": 12,
"layoutDurationMs": 3.962,
"taskDurationMs": 1058.253,
"heapDeltaBytes": -18162308,
"heapUsedBytes": 47246572,
"domNodes": -284,
"jsHeapTotalBytes": 22646784,
"scriptDurationMs": 126.24099999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.0719999999947,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.474,
"layouts": 12,
"layoutDurationMs": 3.934,
"taskDurationMs": 922.761,
"heapDeltaBytes": 99960,
"heapUsedBytes": 65450456,
"domNodes": 59,
"jsHeapTotalBytes": 24907776,
"scriptDurationMs": 116.606,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1746.6120000000274,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.661,
"layouts": 6,
"layoutDurationMs": 0.632,
"taskDurationMs": 389.08799999999997,
"heapDeltaBytes": 8083096,
"heapUsedBytes": 73778700,
"domNodes": 76,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 11.231,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.3140000000121,
"styleRecalcs": 33,
"styleRecalcDurationMs": 19.028,
"layouts": 6,
"layoutDurationMs": 0.649,
"taskDurationMs": 431.371,
"heapDeltaBytes": 7701988,
"heapUsedBytes": 73243836,
"domNodes": 79,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 13.849,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 593.449000000021,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.095999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.892,
"heapDeltaBytes": -11482968,
"heapUsedBytes": 53935380,
"domNodes": 18,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 54.469,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 626.9340000000057,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.703999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.572,
"heapDeltaBytes": -11720236,
"heapUsedBytes": 53785216,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 57.977000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.125999999953,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.637000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 695.025,
"heapDeltaBytes": 13019444,
"heapUsedBytes": 73156052,
"domNodes": -283,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 17.486999999999995,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.9109999999664,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.411000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 799.1700000000001,
"heapDeltaBytes": 9108640,
"heapUsedBytes": 68986640,
"domNodes": -281,
"jsHeapTotalBytes": 2195456,
"scriptDurationMs": 20.429000000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2156.677000000002,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.139,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1229.419,
"heapDeltaBytes": 9332880,
"heapUsedBytes": 70795280,
"domNodes": -285,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 314.24,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2464.636999999925,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.698,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1379.244,
"heapDeltaBytes": 9529560,
"heapUsedBytes": 70582572,
"domNodes": -285,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 345.759,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3179.8220000000015,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.574,
"layouts": 60,
"layoutDurationMs": 8.258000000000001,
"taskDurationMs": 1360.0979999999997,
"heapDeltaBytes": 16484524,
"heapUsedBytes": 79299036,
"domNodes": 10,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 382.184,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3445.1010000000224,
"styleRecalcs": 62,
"styleRecalcDurationMs": 14.808000000000002,
"layouts": 60,
"layoutDurationMs": 9.081999999999999,
"taskDurationMs": 1583.9289999999999,
"heapDeltaBytes": 5398560,
"heapUsedBytes": 68650324,
"domNodes": -289,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 424.587,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.5219999999622,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.467,
"heapDeltaBytes": 13226052,
"heapUsedBytes": 73846624,
"domNodes": -283,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 14.896999999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.6410000000078,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.669000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 747.0250000000001,
"heapDeltaBytes": 12875716,
"heapUsedBytes": 74038376,
"domNodes": -283,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 19.388,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.0969999999629,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.824,
"heapDeltaBytes": -10099172,
"heapUsedBytes": 55520000,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 119.36099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.802000000037,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.254000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.521,
"heapDeltaBytes": -9983768,
"heapUsedBytes": 55739388,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 121.69699999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1996.8250000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.333999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.99999999999994,
"heapDeltaBytes": 5381132,
"heapUsedBytes": 70796532,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 7.173000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2010.7739999999694,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.263,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.751,
"heapDeltaBytes": 5343288,
"heapUsedBytes": 70929440,
"domNodes": 18,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 10.595,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.338000000028,
"styleRecalcs": 77,
"styleRecalcDurationMs": 45.512,
"layouts": 16,
"layoutDurationMs": 4.784,
"taskDurationMs": 826.5709999999999,
"heapDeltaBytes": -3603628,
"heapUsedBytes": 61794824,
"domNodes": 64,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 89.60300000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.9029999999302,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.651,
"layouts": 16,
"layoutDurationMs": 4.673,
"taskDurationMs": 811.5980000000001,
"heapDeltaBytes": -3622304,
"heapUsedBytes": 61870576,
"domNodes": 65,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 90.44800000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.0880000001016,
"styleRecalcs": 21,
"styleRecalcDurationMs": 31.285000000000007,
"layouts": 16,
"layoutDurationMs": 12.02,
"taskDurationMs": 1035.58,
"heapDeltaBytes": -7677240,
"heapUsedBytes": 76350832,
"domNodes": 13673,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 18.195999999999998,
"eventListeners": 2375,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8284.335999999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.19499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4203.585,
"heapDeltaBytes": 7021932,
"heapUsedBytes": 66785484,
"domNodes": -280,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 955.4159999999999,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8315.00200000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.36799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4383.167,
"heapDeltaBytes": 3226872,
"heapUsedBytes": 63446916,
"domNodes": -283,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 966.12,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18736.09399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17806.566000000003,
"heapDeltaBytes": -43214136,
"heapUsedBytes": 169480072,
"domNodes": -8312,
"jsHeapTotalBytes": -10424320,
"scriptDurationMs": 131.218,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18756.899999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17729.893,
"heapDeltaBytes": -26453744,
"heapUsedBytes": 171073672,
"domNodes": -8312,
"jsHeapTotalBytes": -12525568,
"scriptDurationMs": 141.865,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22100.932,
"styleRecalcs": 172,
"styleRecalcDurationMs": 21.74799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21326.882999999998,
"heapDeltaBytes": -26613964,
"heapUsedBytes": 184419200,
"domNodes": -8342,
"jsHeapTotalBytes": -11542528,
"scriptDurationMs": 394.47299999999996,
"eventListeners": -16399,
"totalBlockingTimeMs": 97,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22674.529000000006,
"styleRecalcs": 174,
"styleRecalcDurationMs": 25.37600000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22142.772,
"heapDeltaBytes": -33345424,
"heapUsedBytes": 164509740,
"domNodes": -8312,
"jsHeapTotalBytes": -13307904,
"scriptDurationMs": 432.82400000000007,
"eventListeners": -16383,
"totalBlockingTimeMs": 213,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 115.89699999990444,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.705000000000005,
"layouts": 2,
"layoutDurationMs": 1.257,
"taskDurationMs": 84.706,
"heapDeltaBytes": 3087240,
"heapUsedBytes": 67787324,
"domNodes": 112,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 5.700000000000002,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 472.2629999999981,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.967,
"layouts": 3,
"layoutDurationMs": 0.6719999999999998,
"taskDurationMs": 111.90400000000001,
"heapDeltaBytes": 4959344,
"heapUsedBytes": 69585800,
"domNodes": 123,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.473999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
🎨 Storybook: 🚧 Building... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.51 #16039 +/- ##
=============================================
+ Coverage 81.70% 81.71% +0.01%
=============================================
Files 1885 1885
Lines 107291 107291
Branches 29377 29377
=============================================
+ Hits 87657 87668 +11
+ Misses 19290 19279 -11
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #16032 to
core/1.51Automatically created by backport workflow.