Repository navigation
fix: use trusted sources for fork coverage reports - #16003
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 11 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 95 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 2011 passed, 0 failed · 1 flaky📊 Browser Reports
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16003 +/- ##
==========================================
+ Coverage 80.30% 82.62% +2.32%
==========================================
Files 2271 1941 -330
Lines 116734 111718 -5016
Branches 33848 32654 -1194
==========================================
- Hits 93739 92304 -1435
+ Misses 22489 19073 -3416
+ Partials 506 341 -165
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Approving - the guard covers exactly the privileged workflow_run leg, and the body already documents the fork-report fidelity trade.
|
Superseded by #16404, which fixed the same underlying issue (#16002) and merged 2026-09-01, restructuring this workflow file. Recommend closing this PR rather than rebasing. Full contextThis PR's conflict against Rebasing this PR would require either reinventing a resolution that's already been superseded, or discarding #16404's approach in favor of this one — both are scope decisions beyond a mechanical conflict-resolution rebase, so I'm not pushing a force-with-lease resolution. Filed for Christian to confirm close-vs-supersede. |
|
Attempted a conflict-resolving rebase onto current
|
|
Independently re-verified dm61-3's finding: this PR's sole change target (the |
|
@coderabbitai review |
Rate Limit Exceeded
|
|
Do not rebase: merged #16404 supersedes this one-line fix. Head left unchanged; not enqueued. Full context for agent readersCurrent The program bookkeeping push was not attempted further after two mandatory lock-acquisition timeouts; the exact blocked row was handed to the fleet commander. |
|
Closing: superseded by #16404 (merged 2026-09-01, Full context for agent readers
|
Full context for agent readers
Summary
workflow_runhas base-repository credentials, so checkout v7 correctly rejects a fork PR head SHA. This change uses the repository default branch asgenhtmlsource text only for fork-triggered runs. Reusable calls and same-repository runs continue checking out the tested SHA.Changes
workflow_runSHA second, trusted default branch otherwise.The downloaded LCOV remains authoritative. Its
SF:src/...andSF:packages/...source-map paths are merged and validated unchanged. The existingoverride_branch,override_commit, andoverride_prvalues still attribute uploads to the triggering PR head.Security
The privileged workflow never opts into unsafe PR checkout and never fetches fork source. Checkout v7 receives an explicit base-repository branch for fork events, which does not match the fork repository, a PR ref, or the fork head SHA rejected by its pwn-request guard.
Overlap with #15339
Current
mainalready contains #15339's three Codecov attribution inputs via #15225. This PR does not duplicate or alter them; it changes only thegenhtmlcheckout ref.Verification
yamllint --config-file .yamllint .github/workflows/ci-tests-e2e-coverage.yaml: passpnpm dlx oxfmt@0.59.0 --check .github/workflows/ci-tests-e2e-coverage.yaml: passgit diff --check: passactionlint: zero new findings versusorigin/main; both report the same pre-existing SC2086 and SC2129 notices in unchanged shell blocksReview focus
For fork reports, the browsable HTML uses trusted default-branch source text. Codecov still maps LCOV to the exact fork head through
override_commit; the HTML can show line drift when the fork changes covered source files, but no coverage records or attribution are changed.