Skip to content

docs: clarify interim slot compatibility proxy - #15969

Merged
DrJKL merged 1 commit into
mainfrom
docs/adr-0017-input-compatibility-proxy
Aug 26, 2026
Merged

DrJKL merged 1 commit into
mainfrom
docs/adr-0017-input-compatibility-proxy

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Document PR #15779's interim input-slot compatibility Proxy and its intended cleanup in ADR0017.

Changes

  • What: Clarify that the Proxy rehydrates numeric input writes without becoming slot authority, must project future ID-keyed records, and is removed with the class-owned arrays after compatibility coverage is in place.

Review Focus

Confirm the note accurately describes #15779's transitional role and the ADR0017 migration destination.

@DrJKL
DrJKL requested a review from a team August 26, 2026 04:44
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 540ec497-9c6e-4b22-8f90-e72ded21de2e

📥 Commits

Reviewing files that changed from the base of the PR and between 91e8969 and 9e2509f.

📒 Files selected for processing (1)
  • docs/adr/0017-id-based-slot-records-are-the-slot-destination.md

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.


📝 Walkthrough

Walkthrough

The ADR now documents the interim LGraphNode.inputs compatibility Proxy and adds PR #15779 to its references.

Changes

Input-slot ADR

Layer / File(s) Summary
Document input-slot Proxy contract
docs/adr/0017-id-based-slot-records-are-the-slot-destination.md
The ADR documents Proxy conversion of numeric-write slots into NodeInputSlot instances, its non-authoritative state role, its planned replacement, and PR #15779.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 9e250

This documentation-only change clarifies the interim compatibility proxy and its planned migration path; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive The changed file is documentation-only (docs/adr/0017-id-based-slot-records-are-the-slot-destination.md), but the available review metadata does not include the PR title or any commit subjects. The … Provide the PR title and commit subjects, then re-evaluate the check. Based on the available file list, the documentation-only exception would otherwise prevent a failure.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the documentation change: clarifying the interim slot compatibility Proxy.
Description check ✅ Passed The description includes the required Summary, Changes, and Review Focus sections. It explains the Proxy behavior, transitional role, and migration destination. The omitted optional fields are not req…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Website End-To-End Regression Coverage ✅ Passed The PR changes only docs/adr/0017-id-based-slot-records-are-the-slot-destination.md. It does not change files under apps/website/src/ or apps/website/public/. The website end-to-end regression c…
Adr Compliance For Entity/Litegraph Changes ✅ Passed PASS. The changed-file list contains only docs/adr/0017-id-based-slot-records-are-the-slot-destination.md. It does not include src/lib/litegraph/, src/ecs/, or a graph-entity file. The custom ch…
Full details: Description check

Explanation

The description includes the required Summary, Changes, and Review Focus sections. It explains the Proxy behavior, transitional role, and migration destination. The omitted optional fields are not required because no breaking changes, dependencies, or screenshots apply.

Full details: End-To-End Regression Coverage For Fixes

Explanation

The changed file is documentation-only (docs/adr/0017-id-based-slot-records-are-the-slot-destination.md), but the available review metadata does not include the PR title or any commit subjects. The custom check requires an inconclusive result when commit subjects are unavailable.

Full details: Website End-To-End Regression Coverage

Explanation

The PR changes only docs/adr/0017-id-based-slot-records-are-the-slot-destination.md. It does not change files under apps/website/src/ or apps/website/public/. The website end-to-end regression check does not apply.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

PASS. The changed-file list contains only docs/adr/0017-id-based-slot-records-are-the-slot-destination.md. It does not include src/lib/litegraph/, src/ecs/, or a graph-entity file. The custom check therefore does not apply.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/adr-0017-input-compatibility-proxy

Comment @coderabbitai help to get the list of available commands.

@DrJKL
DrJKL enabled auto-merge August 26, 2026 04:48
@github-actions github-actions Bot added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Aug 26, 2026
@DrJKL
DrJKL added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit 9b1baba Aug 26, 2026
64 checks passed
@DrJKL
DrJKL deleted the docs/adr-0017-input-compatibility-proxy branch August 26, 2026 05:12
@huang47 huang47 added the risk:medium PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants