Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2007 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-26T04:32:55.036Z",
"gitSha": "d4f83b326510956d34fdfb6d016f17cb3de11d8b",
"branch": "prototype/15779-input-write-rehydration",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.3549999999955,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.995999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.946,
"heapDeltaBytes": -2253896,
"heapUsedBytes": 69068268,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.376000000000001,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2022.0050000000356,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.397000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.049,
"heapDeltaBytes": -12372884,
"heapUsedBytes": 59422248,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.618,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.828999999968,
"styleRecalcs": 72,
"styleRecalcDurationMs": 29.855,
"layouts": 12,
"layoutDurationMs": 3.293,
"taskDurationMs": 765.221,
"heapDeltaBytes": 1456644,
"heapUsedBytes": 72583336,
"domNodes": -282,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 99.286,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1839.776000000029,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.07399999999999,
"layouts": 12,
"layoutDurationMs": 3.355,
"taskDurationMs": 840.567,
"heapDeltaBytes": -12674060,
"heapUsedBytes": 58714684,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.951,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0679999999925,
"styleRecalcs": 30,
"styleRecalcDurationMs": 20.852999999999998,
"layouts": 6,
"layoutDurationMs": 0.7359999999999999,
"taskDurationMs": 312.386,
"heapDeltaBytes": 4494596,
"heapUsedBytes": 76403180,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 13.117,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9069999999774,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.363,
"layouts": 6,
"layoutDurationMs": 0.647,
"taskDurationMs": 258,
"heapDeltaBytes": 3926552,
"heapUsedBytes": 74896516,
"domNodes": 77,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 11.198999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 678.4890000000132,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.615000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.65100000000007,
"heapDeltaBytes": 6975644,
"heapUsedBytes": 78436712,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 103.602,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 693.0529999999635,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.819000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.166,
"heapDeltaBytes": 6529064,
"heapUsedBytes": 78211424,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 100.678,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2020.6100000000333,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.132999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.848,
"heapDeltaBytes": -2186380,
"heapUsedBytes": 76932408,
"domNodes": -264,
"jsHeapTotalBytes": -2142208,
"scriptDurationMs": 31.371000000000002,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2014.6550000000616,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.7890000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.127,
"heapDeltaBytes": -2354808,
"heapUsedBytes": 77504024,
"domNodes": -267,
"jsHeapTotalBytes": -1880064,
"scriptDurationMs": 31.086000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3207.99999999997,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1916.4549999999997,
"heapDeltaBytes": 7139892,
"heapUsedBytes": 87168012,
"domNodes": -271,
"jsHeapTotalBytes": 1490944,
"scriptDurationMs": 638.2289999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3141.6659999999865,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.158,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1778.6909999999998,
"heapDeltaBytes": 910048,
"heapUsedBytes": 66539428,
"domNodes": 10,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 627.761,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 4129.1009999999915,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.318,
"layouts": 60,
"layoutDurationMs": 9.276,
"taskDurationMs": 1942.977,
"heapDeltaBytes": -3893396,
"heapUsedBytes": 67016368,
"domNodes": 24,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 636.5590000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3888.9019999999164,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.399000000000004,
"layouts": 60,
"layoutDurationMs": 9.216000000000001,
"taskDurationMs": 1753.0149999999999,
"heapDeltaBytes": 4444204,
"heapUsedBytes": 89087852,
"domNodes": -256,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 572.347,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3544.0609999999992,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.136000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2422.152,
"heapDeltaBytes": 15485672,
"heapUsedBytes": 83350672,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 636.5079999999999,
"eventListeners": 190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 3771.1760000000822,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.877000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2566.3849999999998,
"heapDeltaBytes": 25602260,
"heapUsedBytes": 93522316,
"domNodes": 2,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 677.258,
"eventListeners": 190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.6189999999674,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.443999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.245,
"heapDeltaBytes": -3883440,
"heapUsedBytes": 77537272,
"domNodes": -269,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 30.595999999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.2269999999535,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.790000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.80300000000005,
"heapDeltaBytes": -2697140,
"heapUsedBytes": 77621564,
"domNodes": -269,
"jsHeapTotalBytes": -2404352,
"scriptDurationMs": 30.191000000000003,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.4570000000053,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.777000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.933,
"heapDeltaBytes": -8261916,
"heapUsedBytes": 64655576,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 102.519,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 528.0129999999872,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.326,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.45099999999996,
"heapDeltaBytes": -7631308,
"heapUsedBytes": 64209452,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 92.23500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.3130000000065,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.392999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.615,
"heapDeltaBytes": -13498896,
"heapUsedBytes": 58242004,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.236,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.9830000001048,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.225999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.509,
"heapDeltaBytes": -15149040,
"heapUsedBytes": 57506408,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.167000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.3439999999969,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.022000000000006,
"layouts": 16,
"layoutDurationMs": 4.460999999999999,
"taskDurationMs": 801.767,
"heapDeltaBytes": 5520392,
"heapUsedBytes": 77442824,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 91.85,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.8319999999976,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.642,
"layouts": 16,
"layoutDurationMs": 4.515,
"taskDurationMs": 857.486,
"heapDeltaBytes": -9045812,
"heapUsedBytes": 63406448,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 96.798,
"eventListeners": -229,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 836.9119999999839,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.265999999999995,
"layouts": 14,
"layoutDurationMs": 9.962,
"taskDurationMs": 674.4760000000001,
"heapDeltaBytes": 1705384,
"heapUsedBytes": 98429816,
"domNodes": 13671,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 22.032000000000004,
"eventListeners": 2381,
"totalBlockingTimeMs": 67,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12316.300000000012,
"styleRecalcs": 247,
"styleRecalcDurationMs": 45.894999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7018.235000000001,
"heapDeltaBytes": 16798460,
"heapUsedBytes": 96340916,
"domNodes": -277,
"jsHeapTotalBytes": 2768896,
"scriptDurationMs": 2299.59,
"eventListeners": -157,
"totalBlockingTimeMs": 8,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 10916.70600000009,
"styleRecalcs": 248,
"styleRecalcDurationMs": 43.749,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6312.727,
"heapDeltaBytes": 9160272,
"heapUsedBytes": 88045536,
"domNodes": -268,
"jsHeapTotalBytes": 2244608,
"scriptDurationMs": 2117.3669999999997,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12999.117000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12444.819000000001,
"heapDeltaBytes": -42848848,
"heapUsedBytes": 178576268,
"domNodes": -6548,
"jsHeapTotalBytes": -4464640,
"scriptDurationMs": 214.50800000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12844.659999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12260.897,
"heapDeltaBytes": -38942568,
"heapUsedBytes": 178687640,
"domNodes": -6548,
"jsHeapTotalBytes": -14876672,
"scriptDurationMs": 215.10799999999998,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15328.296000000024,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.85700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14898.248,
"heapDeltaBytes": -44282388,
"heapUsedBytes": 163731132,
"domNodes": -6548,
"jsHeapTotalBytes": -1847296,
"scriptDurationMs": 718.131,
"eventListeners": -7473,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14754.165999999941,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.961000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14214.735,
"heapDeltaBytes": -42315516,
"heapUsedBytes": 167804984,
"domNodes": -6552,
"jsHeapTotalBytes": -4976640,
"scriptDurationMs": 658.849,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 111.61499999997204,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.499,
"layouts": 2,
"layoutDurationMs": 0.572,
"taskDurationMs": 79.83999999999999,
"heapDeltaBytes": 3694260,
"heapUsedBytes": 72251816,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.3870000000000005,
"eventListeners": 51,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 440.12100000009013,
"styleRecalcs": 16,
"styleRecalcDurationMs": 19.826000000000004,
"layouts": 2,
"layoutDurationMs": 0.887,
"taskDurationMs": 109.91799999999999,
"heapDeltaBytes": 5813436,
"heapUsedBytes": 73759368,
"domNodes": 145,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.605,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## fix/15667-input-slot-rehydration #15966 +/- ##
==================================================================
Coverage 82.61% 82.61%
==================================================================
Files 1940 1941 +1
Lines 111612 111632 +20
Branches 32587 32109 -478
==================================================================
+ Hits 92208 92227 +19
+ Misses 19065 19057 -8
- Partials 339 348 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Prototype write-time input-slot rehydration so #15779 keeps PromptChain compatibility without scanning or mutating from the
inputsgetter.Changes
NodeInputSlotinstances and collection identity.Review Focus
This is stacked on #15779 as an alternative implementation. Confirm the separate proxy retains native array mutation/reactivity semantics while writes remain reflected in
node._state.inputs. The parent getter scan measured 3.0× to 17.9× slower than a pure getter across 1 to 32 slots; this prototype moves that work to slot writes.Verification: 1,429 LiteGraph tests passed (5 skipped);
pnpm typecheck; targeted oxfmt, oxlint, and ESLint; pre-push knip.Architecture note for agents/posterity
The DQ-08 primer and ADR-0017 establish that ID-keyed store records are the destination authority. Extension-visible slot-class arrays are derived compatibility views, while plain descriptors belong at persistence boundaries.
This PR is only a transitional mitigation under EX-001. It deliberately leaves
node._state.inputsas the store-held container and keeps the stablenode.inputscompatibility Proxy separate. Extension-assigned plain slots are upgraded on write into the underlying array, avoiding mutation and slot-count-dependent scanning on reads.The Proxy and class-owned slot array are not a new long-term authority. Once ID-keyed records land, the compatibility view must read and write those records, and this transitional layer must be removed according to EX-001's exit condition.