Skip to content

refactor: rehydrate input slots on write - #15966

Merged
DrJKL merged 2 commits into
fix/15667-input-slot-rehydrationfrom
prototype/15779-input-write-rehydration
Aug 26, 2026
Merged

DrJKL merged 2 commits into
fix/15667-input-slot-rehydrationfrom
prototype/15779-input-write-rehydration

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Prototype write-time input-slot rehydration so #15779 keeps PromptChain compatibility without scanning or mutating from the inputs getter.

Changes

  • What: Add a stable input-slot compatibility view over the store-held container that upgrades plain indexed writes while preserving existing NodeInputSlot instances and collection identity.
  • Tests: Preserve the compatibility suite, assert the compatibility view remains separate from state, and assert repeated reads do not trigger additional reactive updates.

Review Focus

This is stacked on #15779 as an alternative implementation. Confirm the separate proxy retains native array mutation/reactivity semantics while writes remain reflected in node._state.inputs. The parent getter scan measured 3.0× to 17.9× slower than a pure getter across 1 to 32 slots; this prototype moves that work to slot writes.

Verification: 1,429 LiteGraph tests passed (5 skipped); pnpm typecheck; targeted oxfmt, oxlint, and ESLint; pre-push knip.

Architecture note for agents/posterity

The DQ-08 primer and ADR-0017 establish that ID-keyed store records are the destination authority. Extension-visible slot-class arrays are derived compatibility views, while plain descriptors belong at persistence boundaries.

This PR is only a transitional mitigation under EX-001. It deliberately leaves node._state.inputs as the store-held container and keeps the stable node.inputs compatibility Proxy separate. Extension-assigned plain slots are upgraded on write into the underlying array, avoiding mutation and slot-count-dependent scanning on reads.

The Proxy and class-owned slot array are not a new long-term authority. Once ID-keyed records land, the compatibility view must read and write those records, and this transitional layer must be removed according to EX-001's exit condition.

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 26, 2026
@coderabbitai

coderabbitai Bot commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 468710b5-a36c-4e18-9d47-4150e59eb988

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/26/2026, 04:37:23 AM UTC

Links

🎭 Playwright: ✅ 2007 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1986 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 67ms TBT · 93.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 4ms TBT · 87.9 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.4 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 2ms TBT · 158.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 392ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.3 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -171
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 803ms
canvas-mouse-sweep: script duration 105ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.6 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -168
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 285ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.1 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 476ms
dom-widget-clipping: script duration 102ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 74.7 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 433ms
large-graph-idle: script duration 31ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 73.6 MB
large-graph-idle: DOM nodes -266
large-graph-idle: event listeners -152
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1848ms
large-graph-pan: script duration 633ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.3 MB
large-graph-pan: DOM nodes -131
large-graph-pan: event listeners -86
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 9ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 68
large-graph-zoom: task duration 1848ms
large-graph-zoom: script duration 604ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.4 MB
large-graph-zoom: DOM nodes -116
large-graph-zoom: event listeners -84
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2494ms
legacy-node-drag: script duration 657ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.3 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 190
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 400ms
minimap-idle: script duration 30ms
minimap-idle: TBT 0ms
minimap-idle: heap used 74.0 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -167
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 374ms
subgraph-dom-widget-clipping: script duration 97ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 61.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 374ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 55.2 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 35ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 830ms
subgraph-mouse-sweep: script duration 94ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.2 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -230
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 23ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 674ms
subgraph-transition-enter: script duration 22ms
subgraph-transition-enter: TBT 67ms
subgraph-transition-enter: heap used 93.9 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 45ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6665ms
viewport-pan-sweep: script duration 2208ms
viewport-pan-sweep: TBT 4ms
viewport-pan-sweep: heap used 87.9 MB
viewport-pan-sweep: DOM nodes -273
viewport-pan-sweep: event listeners -144
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12353ms
vue-large-graph-idle: script duration 215ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.4 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 73
vue-large-graph-pan: task duration 14556ms
vue-large-graph-pan: script duration 688ms
vue-large-graph-pan: TBT 2ms
vue-large-graph-pan: heap used 158.1 MB
vue-large-graph-pan: DOM nodes -6550
vue-large-graph-pan: event listeners -7472
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 2
workflow-execution: style recalc count 13
workflow-execution: task duration 95ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.6 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-08-26T04:32:55.036Z",
  "gitSha": "d4f83b326510956d34fdfb6d016f17cb3de11d8b",
  "branch": "prototype/15779-input-write-rehydration",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2032.3549999999955,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.995999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.946,
      "heapDeltaBytes": -2253896,
      "heapUsedBytes": 69068268,
      "domNodes": -282,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 8.376000000000001,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2022.0050000000356,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.397000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 413.049,
      "heapDeltaBytes": -12372884,
      "heapUsedBytes": 59422248,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.618,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1759.828999999968,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 29.855,
      "layouts": 12,
      "layoutDurationMs": 3.293,
      "taskDurationMs": 765.221,
      "heapDeltaBytes": 1456644,
      "heapUsedBytes": 72583336,
      "domNodes": -282,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 99.286,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1839.776000000029,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 35.07399999999999,
      "layouts": 12,
      "layoutDurationMs": 3.355,
      "taskDurationMs": 840.567,
      "heapDeltaBytes": -12674060,
      "heapUsedBytes": 58714684,
      "domNodes": -278,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 109.951,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.0679999999925,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 20.852999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.7359999999999999,
      "taskDurationMs": 312.386,
      "heapDeltaBytes": 4494596,
      "heapUsedBytes": 76403180,
      "domNodes": 76,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 13.117,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.9069999999774,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.363,
      "layouts": 6,
      "layoutDurationMs": 0.647,
      "taskDurationMs": 258,
      "heapDeltaBytes": 3926552,
      "heapUsedBytes": 74896516,
      "domNodes": 77,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 11.198999999999998,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 678.4890000000132,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.615000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.65100000000007,
      "heapDeltaBytes": 6975644,
      "heapUsedBytes": 78436712,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 103.602,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 693.0529999999635,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 6.819000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.166,
      "heapDeltaBytes": 6529064,
      "heapUsedBytes": 78211424,
      "domNodes": 20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 100.678,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2020.6100000000333,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.132999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.848,
      "heapDeltaBytes": -2186380,
      "heapUsedBytes": 76932408,
      "domNodes": -264,
      "jsHeapTotalBytes": -2142208,
      "scriptDurationMs": 31.371000000000002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2014.6550000000616,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.7890000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.127,
      "heapDeltaBytes": -2354808,
      "heapUsedBytes": 77504024,
      "domNodes": -267,
      "jsHeapTotalBytes": -1880064,
      "scriptDurationMs": 31.086000000000002,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3207.99999999997,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.836,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1916.4549999999997,
      "heapDeltaBytes": 7139892,
      "heapUsedBytes": 87168012,
      "domNodes": -271,
      "jsHeapTotalBytes": 1490944,
      "scriptDurationMs": 638.2289999999999,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3141.6659999999865,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.158,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1778.6909999999998,
      "heapDeltaBytes": 910048,
      "heapUsedBytes": 66539428,
      "domNodes": 10,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 627.761,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4129.1009999999915,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.318,
      "layouts": 60,
      "layoutDurationMs": 9.276,
      "taskDurationMs": 1942.977,
      "heapDeltaBytes": -3893396,
      "heapUsedBytes": 67016368,
      "domNodes": 24,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 636.5590000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3888.9019999999164,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 16.399000000000004,
      "layouts": 60,
      "layoutDurationMs": 9.216000000000001,
      "taskDurationMs": 1753.0149999999999,
      "heapDeltaBytes": 4444204,
      "heapUsedBytes": 89087852,
      "domNodes": -256,
      "jsHeapTotalBytes": 217088,
      "scriptDurationMs": 572.347,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3544.0609999999992,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.136000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2422.152,
      "heapDeltaBytes": 15485672,
      "heapUsedBytes": 83350672,
      "domNodes": 0,
      "jsHeapTotalBytes": 5398528,
      "scriptDurationMs": 636.5079999999999,
      "eventListeners": 190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3771.1760000000822,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.877000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2566.3849999999998,
      "heapDeltaBytes": 25602260,
      "heapUsedBytes": 93522316,
      "domNodes": 2,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 677.258,
      "eventListeners": 190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.6189999999674,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.443999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.245,
      "heapDeltaBytes": -3883440,
      "heapUsedBytes": 77537272,
      "domNodes": -269,
      "jsHeapTotalBytes": -1355776,
      "scriptDurationMs": 30.595999999999997,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.2269999999535,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.790000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 376.80300000000005,
      "heapDeltaBytes": -2697140,
      "heapUsedBytes": 77621564,
      "domNodes": -269,
      "jsHeapTotalBytes": -2404352,
      "scriptDurationMs": 30.191000000000003,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 588.4570000000053,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.777000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.933,
      "heapDeltaBytes": -8261916,
      "heapUsedBytes": 64655576,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 102.519,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 528.0129999999872,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.326,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 344.45099999999996,
      "heapDeltaBytes": -7631308,
      "heapUsedBytes": 64209452,
      "domNodes": 20,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 92.23500000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.3130000000065,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.392999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.615,
      "heapDeltaBytes": -13498896,
      "heapUsedBytes": 58242004,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.236,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.9830000001048,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.225999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 381.509,
      "heapDeltaBytes": -15149040,
      "heapUsedBytes": 57506408,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.167000000000002,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1711.3439999999969,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.022000000000006,
      "layouts": 16,
      "layoutDurationMs": 4.460999999999999,
      "taskDurationMs": 801.767,
      "heapDeltaBytes": 5520392,
      "heapUsedBytes": 77442824,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 91.85,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1743.8319999999976,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.642,
      "layouts": 16,
      "layoutDurationMs": 4.515,
      "taskDurationMs": 857.486,
      "heapDeltaBytes": -9045812,
      "heapUsedBytes": 63406448,
      "domNodes": -294,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 96.798,
      "eventListeners": -229,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 836.9119999999839,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 23.265999999999995,
      "layouts": 14,
      "layoutDurationMs": 9.962,
      "taskDurationMs": 674.4760000000001,
      "heapDeltaBytes": 1705384,
      "heapUsedBytes": 98429816,
      "domNodes": 13671,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 22.032000000000004,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 67,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12316.300000000012,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 45.894999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7018.235000000001,
      "heapDeltaBytes": 16798460,
      "heapUsedBytes": 96340916,
      "domNodes": -277,
      "jsHeapTotalBytes": 2768896,
      "scriptDurationMs": 2299.59,
      "eventListeners": -157,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10916.70600000009,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 43.749,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6312.727,
      "heapDeltaBytes": 9160272,
      "heapUsedBytes": 88045536,
      "domNodes": -268,
      "jsHeapTotalBytes": 2244608,
      "scriptDurationMs": 2117.3669999999997,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12999.117000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12444.819000000001,
      "heapDeltaBytes": -42848848,
      "heapUsedBytes": 178576268,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4464640,
      "scriptDurationMs": 214.50800000000004,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12844.659999999976,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12260.897,
      "heapDeltaBytes": -38942568,
      "heapUsedBytes": 178687640,
      "domNodes": -6548,
      "jsHeapTotalBytes": -14876672,
      "scriptDurationMs": 215.10799999999998,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15328.296000000024,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 15.85700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14898.248,
      "heapDeltaBytes": -44282388,
      "heapUsedBytes": 163731132,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1847296,
      "scriptDurationMs": 718.131,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14754.165999999941,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.961000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14214.735,
      "heapDeltaBytes": -42315516,
      "heapUsedBytes": 167804984,
      "domNodes": -6552,
      "jsHeapTotalBytes": -4976640,
      "scriptDurationMs": 658.849,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 111.61499999997204,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 16.499,
      "layouts": 2,
      "layoutDurationMs": 0.572,
      "taskDurationMs": 79.83999999999999,
      "heapDeltaBytes": 3694260,
      "heapUsedBytes": 72251816,
      "domNodes": 109,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.3870000000000005,
      "eventListeners": 51,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 440.12100000009013,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 19.826000000000004,
      "layouts": 2,
      "layoutDurationMs": 0.887,
      "taskDurationMs": 109.91799999999999,
      "heapDeltaBytes": 5813436,
      "heapUsedBytes": 73759368,
      "domNodes": 145,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.605,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 26, 2026
@DrJKL
DrJKL merged commit 7610d6a into fix/15667-input-slot-rehydration Aug 26, 2026
52 checks passed
@DrJKL
DrJKL deleted the prototype/15779-input-write-rehydration branch August 26, 2026 04:38
@codecov

codecov Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                        Coverage Diff                         @@
##           fix/15667-input-slot-rehydration   #15966    +/-   ##
==================================================================
  Coverage                             82.61%   82.61%            
==================================================================
  Files                                  1940     1941     +1     
  Lines                                111612   111632    +20     
  Branches                              32587    32109   -478     
==================================================================
+ Hits                                  92208    92227    +19     
+ Misses                                19065    19057     -8     
- Partials                                339      348     +9     
Flag Coverage Δ
e2e 66.93% <100.00%> (+<0.01%) ⬆️
unit 74.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraphNode.ts 69.53% <100.00%> (-0.07%) ⬇️
src/lib/litegraph/src/node/slotDescriptorView.ts 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants