Repository navigation
[backport core/1.51] fix(workspace): establish workspace context for API-key sessions - #15943
Conversation
) API-key login sessions on Local never established workspace context, so every billing surface fell back to the legacy user-scoped `/customers/*` rail and showed a different customer's data than the one actually being charged. Reported in 1.51 QA by Denys (Slack QA thread, Aug 25): empty workspace name on Plan & Credits, balance always 0, wrong workspace in Manage billing, credits 0 in the profile menu, Credits opening the old combined view, purchase failing with `workspace_billing_required`, and the Activity tab showing another workspace's events. Two gates kept an API-key session off the workspace rail: 1. `WorkspaceAuthGate` (Local branch) only initialized `teamWorkspaceStore` inside `watch(currentUser)`, where `currentUser` is the **Firebase** user. API-key login never sets it, so `initState` stayed `uninitialized` forever. 2. Even if initialization ran, `workspaceApi` auth (`getWorkspaceAuthHeader`) fell back to `getFirebaseAuthHeader()` when no workspace was active — `null` for API-key sessions, so every workspace call threw `User not authenticated`. There was no `X-API-KEY` fallback anywhere in the workspace client. With `activeWorkspace` empty, `useBillingRouting` returned `legacy`, so balance came from `GET /customers/balance` (the user's legacy customer — zeros or a different account's credits), activity from `GET /customers/events` (resolved by *user identity* to the canonical migrated workspace, not the key's workspace), and top-up hit `POST /customers/credit`, which the backend deterministically rejects with 409 `workspace_billing_required` for accounts on workspace billing (`billing_legacy_topup.go`). Meanwhile generation charges were always correct, because the backend binds every API key to exactly one workspace (`workspace_api_keys`) — only the frontend was reading the wrong rail. The server already knows the key's workspace; the frontend now asks instead of guessing. No backend changes — verified against staging with real keys (`GET /api/workspaces/current` returns the bound workspace incl. name/type/role for both personal and team keys, and all `/api/billing/*` reads accept `X-API-KEY`, scoped to that workspace). - `authStore.getWorkspaceAuthHeader` sends the stored API key when there is no Firebase session; the key **is** the workspace credential, so no token minting. `getWorkspaceAuthToken` returns `undefined` for key sessions (unchanged behavior — no JWT exists to mint). - `teamWorkspaceStore` bootstraps an API-key session from `GET /api/workspaces/current`: seeds the single bound workspace, skips session-cookie restore, discovery, and token exchange. An omitted `role` fails closed to `member` so owner-only actions stay hidden instead of 403ing. - `WorkspaceAuthGate` keys Local initialization off the session identity (Firebase uid **or** validated API key) and resets workspace state when that identity changes, so key→email transitions can't reuse stale context. - `CurrentUserPopoverWorkspace` renders a static workspace row for key sessions — no switcher, matching the test-plan contract that API-key auth exposes no workspace discovery/switching. Once `initState` is `ready`, billing routing flips to the workspace rail and all seven findings resolve together (name, balance ×2, portal, Plan & Credits routing, top-up, activity). - Regression (Vitest): `teamWorkspaceStore` API-key bootstrap (seeding, no discovery/token-exchange, role fail-closed, retry-then-error), `authStore` workspace-header priority (API key sent for key sessions, Firebase session still wins when both exist), `WorkspaceAuthGate` (init on key sign-in, cancel on key sign-out, reset on identity change). - E2E user story (Playwright, `apiKeyLoginBilling.spec.ts` + `apiKeyAuthFixture`): boots a key-only session, asserts the popover shows the key's workspace and balance with no switcher, Plan & Credits shows the workspace name/balance, Activity lists the workspace-rail events, and **zero requests hit the legacy `/customers/balance` / `/customers/events` rail**. - Auth priority: the API-key fallback only applies when `currentUser === null`, so Firebase sessions (Local and Cloud) are untouched; unified-cloud-auth branch is untouched. - `resetForIdentityChange` on Local identity swaps is new — previously only Firebase A→B triggered it (via authStore); now key⇄email transitions do too. Captured on a real Local app (`--comfy-api-base https://stagingapi.comfy.org`, build with `VITE_STAGING_CLOUD_BASE_URL=https://stagingcloud.comfy.org`), logged in with a staging **team-workspace** API key (`team2`). | Profile menu (legacy popover, user-scoped balance, no workspace) | Credits → old combined view, personal account's balance & activity | Plan & Credits: empty workspace name | | --- | --- | --- | | <img src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/asis-popover.png" width="280" /> | <img src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/asis-credits-panel.png" width="280" /> | <img src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/asis-plan-credits.png" width="280" /> | | Profile menu: `team2` row, workspace balance, no switcher | Plan & Credits: `team2` header + workspace balance | Activity: `team2` workspace events only | | --- | --- | --- | | <img src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/tobe-popover.png" width="280" /> | <img src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/tobe-plan-credits.png" width="280" /> | <img src="https://raw.githubusercontent.com/dante01yoon/ComfyUI_frontend/assets/pr-15917-screenshots/docs-assets/pr-15917/tobe-activity.png" width="280" /> |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1829 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-26T00:09:04.139Z",
"gitSha": "e2fd434d2579d7a2ad4f118eeb7fab4a261229ea",
"branch": "backport-15917-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2098.585000000014,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.215999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.61199999999997,
"heapDeltaBytes": 5209492,
"heapUsedBytes": 70495748,
"domNodes": 14,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 10.527,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.3400000000051,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.878,
"heapDeltaBytes": 5092324,
"heapUsedBytes": 70530560,
"domNodes": 22,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 6.607000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.8230000000174,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.020999999999994,
"layouts": 12,
"layoutDurationMs": 3.6840000000000006,
"taskDurationMs": 845.75,
"heapDeltaBytes": -122628,
"heapUsedBytes": 65173080,
"domNodes": 56,
"jsHeapTotalBytes": 24645632,
"scriptDurationMs": 100.911,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1797.7440000000229,
"styleRecalcs": 72,
"styleRecalcDurationMs": 33.467,
"layouts": 12,
"layoutDurationMs": 3.836,
"taskDurationMs": 830.313,
"heapDeltaBytes": 62132,
"heapUsedBytes": 65485732,
"domNodes": 53,
"jsHeapTotalBytes": 25694208,
"scriptDurationMs": 100.01499999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.5689999999781,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.548999999999998,
"layouts": 6,
"layoutDurationMs": 0.665,
"taskDurationMs": 355.487,
"heapDeltaBytes": 7817024,
"heapUsedBytes": 73133540,
"domNodes": 77,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 9.349,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2420000000802,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.815000000000003,
"layouts": 6,
"layoutDurationMs": 0.614,
"taskDurationMs": 355.64099999999996,
"heapDeltaBytes": 7664784,
"heapUsedBytes": 73096528,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 9.708,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 666.577999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.096000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.14200000000005,
"heapDeltaBytes": -11298500,
"heapUsedBytes": 54083896,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 58.665000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 564.7799999999847,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.9830000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.28499999999997,
"heapDeltaBytes": -11494932,
"heapUsedBytes": 54042164,
"domNodes": 16,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 51.60600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2010.330999999951,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.0219999999999,
"heapDeltaBytes": 10040996,
"heapUsedBytes": 70265968,
"domNodes": -281,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 15.157,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2013.6549999999716,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.05,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.7180000000001,
"heapDeltaBytes": 12509020,
"heapUsedBytes": 72303048,
"domNodes": -283,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 13.335000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2129.570000000001,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.554999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1088.735,
"heapDeltaBytes": 9635704,
"heapUsedBytes": 71445160,
"domNodes": -289,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 293.728,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2156.5990000000284,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.620000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1113.413,
"heapDeltaBytes": 10351188,
"heapUsedBytes": 71371304,
"domNodes": -285,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 295.734,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3184.6239999999852,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.454999999999998,
"layouts": 60,
"layoutDurationMs": 7.429999999999999,
"taskDurationMs": 1315.075,
"heapDeltaBytes": -3422624,
"heapUsedBytes": 58557792,
"domNodes": -285,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 369.953,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3081.405000000018,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.834,
"layouts": 60,
"layoutDurationMs": 7.725,
"taskDurationMs": 1250.232,
"heapDeltaBytes": 16526408,
"heapUsedBytes": 79277524,
"domNodes": 10,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 364.61199999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.3519999999644,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.797000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.995,
"heapDeltaBytes": 13204820,
"heapUsedBytes": 75835164,
"domNodes": -279,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 14.599999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2056.5780000000586,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.422000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.3629999999999,
"heapDeltaBytes": 13053264,
"heapUsedBytes": 74108096,
"domNodes": -283,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 14.024000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.4600000000305,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.654,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.118,
"heapDeltaBytes": -9833780,
"heapUsedBytes": 55580412,
"domNodes": 18,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 118.08600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.038999999957,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.670000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.57099999999997,
"heapDeltaBytes": -9824332,
"heapUsedBytes": 55601016,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 116.64099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.2389999999837,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.487999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.46200000000005,
"heapDeltaBytes": 5246764,
"heapUsedBytes": 70918876,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 6.361999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.7800000000157,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.374,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.436,
"heapDeltaBytes": 5307580,
"heapUsedBytes": 70931860,
"domNodes": 18,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 5.95,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.8910000000456,
"styleRecalcs": 75,
"styleRecalcDurationMs": 33.977999999999994,
"layouts": 16,
"layoutDurationMs": 4.734,
"taskDurationMs": 717.38,
"heapDeltaBytes": -3629864,
"heapUsedBytes": 61939888,
"domNodes": 60,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 75.27399999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.7209999999823,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.757999999999996,
"layouts": 16,
"layoutDurationMs": 3.992,
"taskDurationMs": 718.826,
"heapDeltaBytes": -3654024,
"heapUsedBytes": 61834324,
"domNodes": 64,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 75.741,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1363.444999999956,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.526000000000003,
"layouts": 14,
"layoutDurationMs": 11.315,
"taskDurationMs": 885.475,
"heapDeltaBytes": -4030168,
"heapUsedBytes": 81205008,
"domNodes": 13673,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 16.543999999999997,
"eventListeners": 2375,
"totalBlockingTimeMs": 122,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8165.600999999981,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.218,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3812.299,
"heapDeltaBytes": 13240916,
"heapUsedBytes": 73805100,
"domNodes": -283,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 914.1499999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8201.399000000038,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.766999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3975.1119999999996,
"heapDeltaBytes": 12855864,
"heapUsedBytes": 73567240,
"domNodes": -280,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 998.7340000000002,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17776.75700000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16905.007999999998,
"heapDeltaBytes": -31106348,
"heapUsedBytes": 166284876,
"domNodes": -8312,
"jsHeapTotalBytes": -13045760,
"scriptDurationMs": 116.74600000000001,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17417.415000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16581.764,
"heapDeltaBytes": -43720676,
"heapUsedBytes": 168118920,
"domNodes": -8312,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 113.229,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20718.794,
"styleRecalcs": 177,
"styleRecalcDurationMs": 17.93299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20146.125,
"heapDeltaBytes": -28868464,
"heapUsedBytes": 183123676,
"domNodes": -8312,
"jsHeapTotalBytes": -14688256,
"scriptDurationMs": 379.68800000000005,
"eventListeners": -16383,
"totalBlockingTimeMs": 51,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21380.12399999991,
"styleRecalcs": 179,
"styleRecalcDurationMs": 18.98799999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20641.697,
"heapDeltaBytes": -32648728,
"heapUsedBytes": 164950060,
"domNodes": -8312,
"jsHeapTotalBytes": -13045760,
"scriptDurationMs": 396.149,
"eventListeners": -16381,
"totalBlockingTimeMs": 45,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 460.3869999999688,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.561000000000003,
"layouts": 3,
"layoutDurationMs": 0.702,
"taskDurationMs": 106.301,
"heapDeltaBytes": 4978180,
"heapUsedBytes": 69599180,
"domNodes": 124,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.731000000000002,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 471.1859999999888,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.746999999999996,
"layouts": 3,
"layoutDurationMs": 0.6559999999999999,
"taskDurationMs": 112.185,
"heapDeltaBytes": 5028092,
"heapUsedBytes": 69669444,
"domNodes": 123,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.058,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.51 #15943 +/- ##
=============================================
- Coverage 81.71% 79.13% -2.58%
=============================================
Files 1885 2212 +327
Lines 107237 112190 +4953
Branches 29816 30996 +1180
=============================================
+ Hits 87627 88786 +1159
- Misses 19273 22947 +3674
- Partials 337 457 +120
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 334 files with indirect coverage changes 🚀 New features to boost your workflow:
|
thedatalife
left a comment
There was a problem hiding this comment.
Not blocking the backport but I left a comment for a cleanup task.
| /** | ||
| * Request body for creating a new workspace. | ||
| */ | ||
| export type CurrentWorkspaceResponse = { |
There was a problem hiding this comment.
It looks like this was inserted in the wrong spot. The jsdoc comment above is for the request body but this is the response body.
Backport of #15917 to
core/1.51Auto-backport failed on cherry-pick conflicts; backported manually. Conflict resolution: dropped the
useBillingCapabilitiesimport and test mock (#15803 is main-only) and ported theCurrentWorkspaceResponseblock into this branch's generated ingest-types (absent from its older generation). Affected unit suites (241 tests) andpnpm typecheckpass on this branch.