Skip to content

[backport cloud/1.52] feat(billing): consolidate embedded checkout frontend - #15941

Merged
comfy-pr-bot merged 2 commits into
cloud/1.52from
backport-14483-to-cloud-1.52
Aug 27, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.52from
backport-14483-to-cloud-1.52

Conversation

@huntcsg

@huntcsg huntcsg commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Backport of #14483 to cloud/1.52.

⚠️ Merge order — this PR is stacked

Base is deliberately set to backport-ingest-types-to-cloud-1.52, not cloud/1.52. GitHub will auto-retarget this PR to cloud/1.52 once the types PR merges.

Verification

pnpm typecheck: 94 → 0.

Before (this branch's feature commit on cloud/1.52, types PR not applied) — exit 2, 94 errors, e.g.:

src/platform/workspace/api/workspaceApi.ts(28,3): error TS2305: Module '"@comfyorg/ingest-types"' has no exported member 'SavedPaymentMethod'.
src/platform/workspace/api/workspaceApi.ts(119,27): error TS2339: Property 'authentication_state' does not exist on type 'BillingOpStatusResponse'.
src/platform/workspace/api/workspaceApi.ts(478,11): error TS2353: Object literal may only specify known properties, and 'promotion_code' does not exist in type 'PreviewSubscribeRequest'.
src/platform/workspace/components/SubscriptionAddPaymentPreviewWorkspace.vue(124,28): error TS2339: Property 'discounts' does not exist on type 'PreviewSubscribeResponse'.
...

After (rebased onto #15939) — exit 0, empty output, 0 errors.

Tests (pnpm vitest run):

Suite Result
src/composables/useUrlActionLoaders.test.ts 6 passed (1 file)
src/platform/workspace/ + src/platform/cloud/subscription/ 1606 passed (88 files)
useFeatureFlags, GlobalDialog, GraphCanvas.firstRunEntry 94 passed (3 files)

Lint/format on the 43 changed TS/Vue files: eslint exit 0, oxfmt --check — "All matched files use the correct format."

Note that green Vitest is not evidence of type safety (Vitest strips types) — the vue-tsc result above is the type-safety evidence.

Rebase

Rebased conflict-free onto the types branch; the feature commit's own conflict resolutions were carried through unchanged.

Conflict resolutions

These were resolved, reviewed and verified in a prior pass and are not re-derived here. They cover two files:

  • src/composables/useUrlActionLoaders.ts
  • src/composables/useUrlActionLoaders.test.ts

Both drop the ?settings deep-link references. Those come from #15808, which is not on this branch — src/composables/useSettingsUrlLoader.ts does not exist on cloud/1.52 (verified absent). No settings references remain in either file.

Judgement call for reviewers 👀

The upstream test isolates a settings-loader failure so it does not abort the boot chain was deleted (its subject, the settings loader, doesn't exist on this branch). Its two tail assertions were folded into the surviving top-up isolation test rather than dropped, so the coverage they provided is retained:

it('isolates a top-up-loader failure so it does not abort the boot chain', async () => {
  mocks.loadTopUp.mockRejectedValueOnce(new Error('boom'))

  const { runUrlActionLoaders } = useUrlActionLoaders()
  await expect(runUrlActionLoaders()).resolves.toBeUndefined()

  expect(mocks.loadPricingTable).toHaveBeenCalledOnce()
  expect(mocks.loadPaymentReturn).toHaveBeenCalledOnce()      // folded in
  expect(mocks.resumePendingPricingFlow).toHaveBeenCalledOnce() // folded in
})

This leaves 6 tests in the file instead of upstream's 7. If reviewers would rather see the assertions dropped with the deleted test, that's a one-line change.

huntcsg and others added 2 commits August 25, 2026 23:23
…act (#15855)

Backport of #15855 to cloud/1.52, combined with a regeneration of the
ingest-types package from the cloud OpenAPI spec.

The generated half is regenerated from the cloud spec rather than
cherry-picked, per team guidance, using the full pipeline from
cloud/.github/workflows/push-ingest-types-to-frontend.yml:

  1. openapi-project -fe (projects the FE-facing spec subset, stripping
     cloud's x-internal / admin / M2M surface)
  2. pnpm generate (pinned @hey-api/openapi-ts 0.97.3)
  3. oxfmt --write src/

Cloud spec: Comfy-Org/cloud@3e3f06a

The regeneration and the ENTERPRISE source support are one commit because
neither compiles without the other: regenerating widens SubscriptionTier
with ENTERPRISE, which breaks useBillingPolicyState.ts (TS1360) and
tierPricing.ts (TS7053), while the source half alone references an
ENTERPRISE member the generated contract does not yet have. Upstream did
not split them either.
Consolidates the complete embedded subscription checkout frontend onto
current `main` as the single review tip, including the design stack,
safety gates, exact quote contract UI, saved methods, and 3DS recovery.

- **What**: Replays and reconciles the frontend work from #14447,
branches.
- **Dependencies**: Requires the combined backend environment for
end-to-end preview validation.

Review exact quote freshness, reactivation safeguards, saved-method
confirmation, and retryable/reconciliation 3DS states together.

Checks run locally: typecheck, browser fixture typecheck, format,
lint/oxlint, knip, 231 billing-focused Vitest tests, and cloud
Playwright test discovery.

AS IS / TO BE screenshots and preview will be attached after the
combined environment exists.

---------

Co-authored-by: Amp <amp@ampcode.com>
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 25, 2026
@huntcsg huntcsg added the backport Backporting a PR onto a release candidate label Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 13bd8ebb-a18d-4126-86f9-6816fda723ad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1978 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1957 / ❌ 0 / ⚠️ 4 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/25/2026, 11:45:18 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 93ms TBT · 82.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.9 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 29ms TBT · 174.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 428ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 77.2 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -151
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 71
canvas-mouse-sweep: task duration 778ms
canvas-mouse-sweep: script duration 95ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.8 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 299ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 63.0 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 294ms
dom-widget-clipping: script duration 43ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.1 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 532ms
large-graph-idle: script duration 15ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 68.3 MB
large-graph-idle: DOM nodes -275
large-graph-idle: event listeners -148
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 950ms
large-graph-pan: script duration 256ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 68.5 MB
large-graph-pan: DOM nodes -272
large-graph-pan: event listeners -149
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 1125ms
large-graph-zoom: script duration 314ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 76.9 MB
large-graph-zoom: DOM nodes 15
large-graph-zoom: event listeners -73
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 48
legacy-node-drag: task duration 1156ms
legacy-node-drag: script duration 372ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.1 MB
legacy-node-drag: DOM nodes 16
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 524ms
minimap-idle: script duration 14ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.1 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -149
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 314ms
subgraph-dom-widget-clipping: script duration 95ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 70.9 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 405ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.5 MB
subgraph-idle: DOM nodes -282
subgraph-idle: event listeners -151
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 648ms
subgraph-mouse-sweep: script duration 69ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 70.6 MB
subgraph-mouse-sweep: DOM nodes -281
subgraph-mouse-sweep: event listeners -166
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 25ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 767ms
subgraph-transition-enter: script duration 14ms
subgraph-transition-enter: TBT 93ms
subgraph-transition-enter: heap used 82.7 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3337ms
viewport-pan-sweep: script duration 825ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.3 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -133
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14369ms
vue-large-graph-idle: script duration 96ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.9 MB
vue-large-graph-idle: DOM nodes -5813
vue-large-graph-idle: event listeners -16392
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 144
vue-large-graph-pan: task duration 16894ms
vue-large-graph-pan: script duration 351ms
vue-large-graph-pan: TBT 29ms
vue-large-graph-pan: heap used 174.6 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16388
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 63ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.4 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 37
Raw data
{
  "timestamp": "2026-08-25T23:55:15.253Z",
  "gitSha": "f567017ec9cfbb7d8c0cc05214bf33a6614bfda7",
  "branch": "backport-14483-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2006.8279999999845,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.325999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.16200000000003,
      "heapDeltaBytes": 19104492,
      "heapUsedBytes": 81191556,
      "domNodes": -283,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.336,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2036.6770000000542,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.591,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.99800000000005,
      "heapDeltaBytes": 18327636,
      "heapUsedBytes": 80805524,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.019000000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1863.8819999999896,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 34.313,
      "layouts": 12,
      "layoutDurationMs": 3.3550000000000004,
      "taskDurationMs": 841.2850000000001,
      "heapDeltaBytes": 9041864,
      "heapUsedBytes": 71279204,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 99.466,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1725.543000000016,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 29.192,
      "layouts": 12,
      "layoutDurationMs": 3.1220000000000003,
      "taskDurationMs": 714.275,
      "heapDeltaBytes": 6207384,
      "heapUsedBytes": 68861632,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 90.605,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1674.1159999999695,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.903999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.624,
      "taskDurationMs": 291.97299999999996,
      "heapDeltaBytes": 3296416,
      "heapUsedBytes": 66263632,
      "domNodes": 77,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 12.682999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.4140000000243,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.292000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.586,
      "taskDurationMs": 305.12300000000005,
      "heapDeltaBytes": 3329736,
      "heapUsedBytes": 65852344,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 8.836,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 510.9130000000164,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.178000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 290.87700000000007,
      "heapDeltaBytes": 10909660,
      "heapUsedBytes": 73747484,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 43.263999999999996,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 495.15099999996437,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.464,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 297.22900000000004,
      "heapDeltaBytes": 10964456,
      "heapUsedBytes": 73231120,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 43.103,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.4749999999954,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.664999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 522.7230000000001,
      "heapDeltaBytes": -7745788,
      "heapUsedBytes": 69723256,
      "domNodes": -277,
      "jsHeapTotalBytes": -1843200,
      "scriptDurationMs": 14.802000000000003,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.8980000000838,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.408999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.772,
      "heapDeltaBytes": -3903328,
      "heapUsedBytes": 73570352,
      "domNodes": -273,
      "jsHeapTotalBytes": -1843200,
      "scriptDurationMs": 15.988,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2105.5150000000253,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 13.59,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 949.4169999999999,
      "heapDeltaBytes": -6081676,
      "heapUsedBytes": 71881120,
      "domNodes": -270,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 253.117,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2093.303999999989,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.353000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 951.0360000000001,
      "heapDeltaBytes": -6238444,
      "heapUsedBytes": 71801152,
      "domNodes": -274,
      "jsHeapTotalBytes": 217088,
      "scriptDurationMs": 258.699,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3060.0029999999947,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 14.195,
      "layouts": 60,
      "layoutDurationMs": 7.133000000000001,
      "taskDurationMs": 1090.811,
      "heapDeltaBytes": 18499300,
      "heapUsedBytes": 97951220,
      "domNodes": 16,
      "jsHeapTotalBytes": 6066176,
      "scriptDurationMs": 308.234,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3089.6979999999985,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.520999999999999,
      "layouts": 60,
      "layoutDurationMs": 7.3020000000000005,
      "taskDurationMs": 1158.542,
      "heapDeltaBytes": -16281372,
      "heapUsedBytes": 63298036,
      "domNodes": 14,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 319.83700000000005,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2214.7259999999847,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 10.771,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1150.9640000000002,
      "heapDeltaBytes": 10984332,
      "heapUsedBytes": 91211672,
      "domNodes": 18,
      "jsHeapTotalBytes": 7008256,
      "scriptDurationMs": 371.236,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2157.907000000023,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.535000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1160.869,
      "heapDeltaBytes": 11251292,
      "heapUsedBytes": 91553388,
      "domNodes": 14,
      "jsHeapTotalBytes": 7270400,
      "scriptDurationMs": 373.612,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.3500000000413,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.904000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 497.19100000000003,
      "heapDeltaBytes": -11917652,
      "heapUsedBytes": 73750668,
      "domNodes": -270,
      "jsHeapTotalBytes": 2351104,
      "scriptDurationMs": 12.789000000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.6970000000747,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.3759999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 550.527,
      "heapDeltaBytes": -12351112,
      "heapUsedBytes": 73254280,
      "domNodes": -274,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 14.239999999999998,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 529.8099999999977,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.305000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 313.135,
      "heapDeltaBytes": 11552876,
      "heapUsedBytes": 74480340,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 92.99300000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 515.9029999999802,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.041999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 315.58799999999997,
      "heapDeltaBytes": 11972500,
      "heapUsedBytes": 74110696,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 97.955,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.6499999999928,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.270000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.641,
      "heapDeltaBytes": -6568108,
      "heapUsedBytes": 55906984,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 5.887000000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.680000000003,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.5219999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.225,
      "heapDeltaBytes": 18585836,
      "heapUsedBytes": 81445328,
      "domNodes": -283,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 6.381999999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1690.587999999991,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 28.865,
      "layouts": 16,
      "layoutDurationMs": 3.493,
      "taskDurationMs": 636.649,
      "heapDeltaBytes": 3129892,
      "heapUsedBytes": 66209624,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 68.25399999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1758.3989999999403,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 28.514,
      "layouts": 16,
      "layoutDurationMs": 3.3510000000000004,
      "taskDurationMs": 658.6759999999999,
      "heapDeltaBytes": 18893392,
      "heapUsedBytes": 81798680,
      "domNodes": -281,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 70.31099999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1218.7860000000228,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 24.98700000000001,
      "layouts": 15,
      "layoutDurationMs": 10.716999999999999,
      "taskDurationMs": 767.1230000000003,
      "heapDeltaBytes": -6157880,
      "heapUsedBytes": 86676604,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 14.362,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 93,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8120.1750000000175,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 38.294,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3315.3259999999996,
      "heapDeltaBytes": -223972,
      "heapUsedBytes": 77028324,
      "domNodes": -268,
      "jsHeapTotalBytes": -569344,
      "scriptDurationMs": 817.782,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8104.264999999941,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.602,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3358.951,
      "heapDeltaBytes": -2629660,
      "heapUsedBytes": 74492968,
      "domNodes": -279,
      "jsHeapTotalBytes": -45056,
      "scriptDurationMs": 831.733,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15137.388999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14307.658,
      "heapDeltaBytes": -42390384,
      "heapUsedBytes": 182134448,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10555392,
      "scriptDurationMs": 98.42099999999999,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14970.89500000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14430.283999999998,
      "heapDeltaBytes": -41780516,
      "heapUsedBytes": 182463420,
      "domNodes": -3314,
      "jsHeapTotalBytes": -8982528,
      "scriptDurationMs": 94.36,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17334.031999999977,
      "styleRecalcs": 146,
      "styleRecalcDurationMs": 15.549000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16936.79,
      "heapDeltaBytes": -31848352,
      "heapUsedBytes": 192963588,
      "domNodes": -8312,
      "jsHeapTotalBytes": -17444864,
      "scriptDurationMs": 346.96,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 46,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17205.152999999995,
      "styleRecalcs": 141,
      "styleRecalcDurationMs": 15.865000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16850.656,
      "heapDeltaBytes": -57982324,
      "heapUsedBytes": 173200772,
      "domNodes": -8312,
      "jsHeapTotalBytes": -23797760,
      "scriptDurationMs": 355.026,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 12,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 82.11000000005697,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 9.915000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.3520000000000001,
      "taskDurationMs": 61.01699999999999,
      "heapDeltaBytes": 3204008,
      "heapUsedBytes": 65821244,
      "domNodes": 109,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.714,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 99.68299999991359,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 14.369,
      "layouts": 2,
      "layoutDurationMs": 0.8169999999999998,
      "taskDurationMs": 65.723,
      "heapDeltaBytes": 3078692,
      "heapUsedBytes": 65015704,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.6450000000000005,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​stripe/​stripe-js@​9.12.1100100100100100

View full report

@codecov

codecov Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.59073% with 170 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...m/workspace/composables/useSubscriptionCheckout.ts 79.18% 55 Missing and 1 partial ⚠️
...nents/SubscriptionRequiredDialogContentUnified.vue 50.00% 32 Missing ⚠️
...platform/workspace/stores/billingOperationStore.ts 89.81% 22 Missing ⚠️
...ponents/SubscriptionTransitionPreviewWorkspace.vue 74.64% 18 Missing ⚠️
...ponents/SubscriptionAddPaymentPreviewWorkspace.vue 87.09% 15 Missing and 1 partial ⚠️
...kspace/components/UnifiedStripePaymentSelector.vue 88.63% 9 Missing and 1 partial ⚠️
...orm/workspace/utils/pendingSubscriptionCheckout.ts 90.32% 6 Missing ⚠️
.../subscription/composables/useSubscriptionDialog.ts 89.18% 4 Missing ⚠️
...kspace/components/SubscriptionSuccessWorkspace.vue 81.81% 2 Missing ⚠️
src/composables/useUrlActionLoaders.ts 90.00% 1 Missing ⚠️
... and 3 more
@@                           Coverage Diff                           @@
##           backport-ingest-types-to-cloud-1.52   #15941      +/-   ##
=======================================================================
+ Coverage                                79.55%   79.57%   +0.01%     
=======================================================================
  Files                                     2235     2240       +5     
  Lines                                   113760   114604     +844     
  Branches                                 31294    32191     +897     
=======================================================================
+ Hits                                     90505    91191     +686     
- Misses                                   22771    22923     +152     
- Partials                                   484      490       +6     
Flag Coverage Δ
e2e 66.24% <4.68%> (-0.21%) ⬇️
unit 73.90% <84.35%> (+0.06%) ⬆️
website-unit 27.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/useFeatureFlags.ts 87.96% <100.00%> (+0.83%) ⬆️
...scription/composables/usePaymentReturnUrlLoader.ts 100.00% <100.00%> (ø)
...tform/cloud/subscription/utils/paymentReturnUrl.ts 100.00% <100.00%> (ø)
.../subscription/utils/subscriptionQuoteFormatting.ts 100.00% <100.00%> (ø)
...subscription/utils/teamSubscriptionCheckoutUtil.ts 100.00% <ø> (ø)
src/platform/telemetry/types.ts 97.05% <ø> (ø)
src/platform/workspace/auth/WorkspaceAuthGate.vue 97.81% <ø> (-0.07%) ⬇️
...nts/SubscriptionRequiredDialogContentWorkspace.vue 100.00% <ø> (ø)
src/composables/useUrlActionLoaders.ts 93.93% <90.00%> (-1.72%) ⬇️
src/main.ts 39.53% <0.00%> (-0.95%) ⬇️
... and 11 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huntcsg huntcsg assigned dante01yoon and unassigned thedatalife Aug 25, 2026
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 25, 2026
Base automatically changed from backport-ingest-types-to-cloud-1.52 to cloud/1.52 August 26, 2026 23:36
@comfy-pr-bot
comfy-pr-bot merged commit fd55ffb into cloud/1.52 Aug 27, 2026
102 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14483-to-cloud-1.52 branch August 27, 2026 00:42
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants