Repository navigation
[backport cloud/1.52] feat(billing): consolidate embedded checkout frontend - #15941
Conversation
…act (#15855) Backport of #15855 to cloud/1.52, combined with a regeneration of the ingest-types package from the cloud OpenAPI spec. The generated half is regenerated from the cloud spec rather than cherry-picked, per team guidance, using the full pipeline from cloud/.github/workflows/push-ingest-types-to-frontend.yml: 1. openapi-project -fe (projects the FE-facing spec subset, stripping cloud's x-internal / admin / M2M surface) 2. pnpm generate (pinned @hey-api/openapi-ts 0.97.3) 3. oxfmt --write src/ Cloud spec: Comfy-Org/cloud@3e3f06a The regeneration and the ENTERPRISE source support are one commit because neither compiles without the other: regenerating widens SubscriptionTier with ENTERPRISE, which breaks useBillingPolicyState.ts (TS1360) and tierPricing.ts (TS7053), while the source half alone references an ENTERPRISE member the generated contract does not yet have. Upstream did not split them either.
Consolidates the complete embedded subscription checkout frontend onto current `main` as the single review tip, including the design stack, safety gates, exact quote contract UI, saved methods, and 3DS recovery. - **What**: Replays and reconciles the frontend work from #14447, branches. - **Dependencies**: Requires the combined backend environment for end-to-end preview validation. Review exact quote freshness, reactivation safeguards, saved-method confirmation, and retryable/reconciliation 3DS states together. Checks run locally: typecheck, browser fixture typecheck, format, lint/oxlint, knip, 231 billing-focused Vitest tests, and cloud Playwright test discovery. AS IS / TO BE screenshots and preview will be attached after the combined environment exists. --------- Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1978 passed, 0 failed · 4 flaky📊 Browser Reports
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-25T23:55:15.253Z",
"gitSha": "f567017ec9cfbb7d8c0cc05214bf33a6614bfda7",
"branch": "backport-14483-to-cloud-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.8279999999845,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.325999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.16200000000003,
"heapDeltaBytes": 19104492,
"heapUsedBytes": 81191556,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.336,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2036.6770000000542,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.591,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.99800000000005,
"heapDeltaBytes": 18327636,
"heapUsedBytes": 80805524,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.019000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1863.8819999999896,
"styleRecalcs": 70,
"styleRecalcDurationMs": 34.313,
"layouts": 12,
"layoutDurationMs": 3.3550000000000004,
"taskDurationMs": 841.2850000000001,
"heapDeltaBytes": 9041864,
"heapUsedBytes": 71279204,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 99.466,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.543000000016,
"styleRecalcs": 71,
"styleRecalcDurationMs": 29.192,
"layouts": 12,
"layoutDurationMs": 3.1220000000000003,
"taskDurationMs": 714.275,
"heapDeltaBytes": 6207384,
"heapUsedBytes": 68861632,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 90.605,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1674.1159999999695,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.903999999999998,
"layouts": 6,
"layoutDurationMs": 0.624,
"taskDurationMs": 291.97299999999996,
"heapDeltaBytes": 3296416,
"heapUsedBytes": 66263632,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.682999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4140000000243,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.292000000000002,
"layouts": 6,
"layoutDurationMs": 0.586,
"taskDurationMs": 305.12300000000005,
"heapDeltaBytes": 3329736,
"heapUsedBytes": 65852344,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.836,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 510.9130000000164,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.178000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.87700000000007,
"heapDeltaBytes": 10909660,
"heapUsedBytes": 73747484,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 43.263999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 495.15099999996437,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.464,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.22900000000004,
"heapDeltaBytes": 10964456,
"heapUsedBytes": 73231120,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 43.103,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.4749999999954,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.664999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.7230000000001,
"heapDeltaBytes": -7745788,
"heapUsedBytes": 69723256,
"domNodes": -277,
"jsHeapTotalBytes": -1843200,
"scriptDurationMs": 14.802000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.8980000000838,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.408999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.772,
"heapDeltaBytes": -3903328,
"heapUsedBytes": 73570352,
"domNodes": -273,
"jsHeapTotalBytes": -1843200,
"scriptDurationMs": 15.988,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2105.5150000000253,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.59,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 949.4169999999999,
"heapDeltaBytes": -6081676,
"heapUsedBytes": 71881120,
"domNodes": -270,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 253.117,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2093.303999999989,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.353000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 951.0360000000001,
"heapDeltaBytes": -6238444,
"heapUsedBytes": 71801152,
"domNodes": -274,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 258.699,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3060.0029999999947,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.195,
"layouts": 60,
"layoutDurationMs": 7.133000000000001,
"taskDurationMs": 1090.811,
"heapDeltaBytes": 18499300,
"heapUsedBytes": 97951220,
"domNodes": 16,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 308.234,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3089.6979999999985,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.520999999999999,
"layouts": 60,
"layoutDurationMs": 7.3020000000000005,
"taskDurationMs": 1158.542,
"heapDeltaBytes": -16281372,
"heapUsedBytes": 63298036,
"domNodes": 14,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 319.83700000000005,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2214.7259999999847,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.771,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1150.9640000000002,
"heapDeltaBytes": 10984332,
"heapUsedBytes": 91211672,
"domNodes": 18,
"jsHeapTotalBytes": 7008256,
"scriptDurationMs": 371.236,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2157.907000000023,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.535000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1160.869,
"heapDeltaBytes": 11251292,
"heapUsedBytes": 91553388,
"domNodes": 14,
"jsHeapTotalBytes": 7270400,
"scriptDurationMs": 373.612,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.3500000000413,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.904000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.19100000000003,
"heapDeltaBytes": -11917652,
"heapUsedBytes": 73750668,
"domNodes": -270,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 12.789000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.6970000000747,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.3759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.527,
"heapDeltaBytes": -12351112,
"heapUsedBytes": 73254280,
"domNodes": -274,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 14.239999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 529.8099999999977,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.305000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.135,
"heapDeltaBytes": 11552876,
"heapUsedBytes": 74480340,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 92.99300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.9029999999802,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.041999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.58799999999997,
"heapDeltaBytes": 11972500,
"heapUsedBytes": 74110696,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 97.955,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.6499999999928,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.270000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.641,
"heapDeltaBytes": -6568108,
"heapUsedBytes": 55906984,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.887000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.680000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.5219999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.225,
"heapDeltaBytes": 18585836,
"heapUsedBytes": 81445328,
"domNodes": -283,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.381999999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.587999999991,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.865,
"layouts": 16,
"layoutDurationMs": 3.493,
"taskDurationMs": 636.649,
"heapDeltaBytes": 3129892,
"heapUsedBytes": 66209624,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 68.25399999999999,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.3989999999403,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.514,
"layouts": 16,
"layoutDurationMs": 3.3510000000000004,
"taskDurationMs": 658.6759999999999,
"heapDeltaBytes": 18893392,
"heapUsedBytes": 81798680,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 70.31099999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1218.7860000000228,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.98700000000001,
"layouts": 15,
"layoutDurationMs": 10.716999999999999,
"taskDurationMs": 767.1230000000003,
"heapDeltaBytes": -6157880,
"heapUsedBytes": 86676604,
"domNodes": 13673,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 14.362,
"eventListeners": 2373,
"totalBlockingTimeMs": 93,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8120.1750000000175,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.294,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3315.3259999999996,
"heapDeltaBytes": -223972,
"heapUsedBytes": 77028324,
"domNodes": -268,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 817.782,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8104.264999999941,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.602,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3358.951,
"heapDeltaBytes": -2629660,
"heapUsedBytes": 74492968,
"domNodes": -279,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 831.733,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15137.388999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14307.658,
"heapDeltaBytes": -42390384,
"heapUsedBytes": 182134448,
"domNodes": -8312,
"jsHeapTotalBytes": -10555392,
"scriptDurationMs": 98.42099999999999,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14970.89500000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14430.283999999998,
"heapDeltaBytes": -41780516,
"heapUsedBytes": 182463420,
"domNodes": -3314,
"jsHeapTotalBytes": -8982528,
"scriptDurationMs": 94.36,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17334.031999999977,
"styleRecalcs": 146,
"styleRecalcDurationMs": 15.549000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16936.79,
"heapDeltaBytes": -31848352,
"heapUsedBytes": 192963588,
"domNodes": -8312,
"jsHeapTotalBytes": -17444864,
"scriptDurationMs": 346.96,
"eventListeners": -16389,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17205.152999999995,
"styleRecalcs": 141,
"styleRecalcDurationMs": 15.865000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16850.656,
"heapDeltaBytes": -57982324,
"heapUsedBytes": 173200772,
"domNodes": -8312,
"jsHeapTotalBytes": -23797760,
"scriptDurationMs": 355.026,
"eventListeners": -16387,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 82.11000000005697,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.915000000000001,
"layouts": 2,
"layoutDurationMs": 0.3520000000000001,
"taskDurationMs": 61.01699999999999,
"heapDeltaBytes": 3204008,
"heapUsedBytes": 65821244,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.714,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 99.68299999991359,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.369,
"layouts": 2,
"layoutDurationMs": 0.8169999999999998,
"taskDurationMs": 65.723,
"heapDeltaBytes": 3078692,
"heapUsedBytes": 65015704,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.6450000000000005,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## backport-ingest-types-to-cloud-1.52 #15941 +/- ##
=======================================================================
+ Coverage 79.55% 79.57% +0.01%
=======================================================================
Files 2235 2240 +5
Lines 113760 114604 +844
Branches 31294 32191 +897
=======================================================================
+ Hits 90505 91191 +686
- Misses 22771 22923 +152
- Partials 484 490 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #14483 to
cloud/1.52.Base is deliberately set to
backport-ingest-types-to-cloud-1.52, notcloud/1.52. GitHub will auto-retarget this PR tocloud/1.52once the types PR merges.[backport cloud/1.52] feat(billing): render the ENTERPRISE tier through the generated contractcloud/1.52alone it produces 94 type errors, every one of them a missing member on a generated@comfyorg/ingest-typestype (SavedPaymentMethod,quote_id,quote_version,discounts,currency,authentication_state,decline_reason,promotion_code,confirmation_token, …).Verification
pnpm typecheck: 94 → 0.Before (this branch's feature commit on
cloud/1.52, types PR not applied) —exit 2, 94 errors, e.g.:After (rebased onto #15939) —
exit 0, empty output, 0 errors.Tests (
pnpm vitest run):src/composables/useUrlActionLoaders.test.tssrc/platform/workspace/+src/platform/cloud/subscription/useFeatureFlags,GlobalDialog,GraphCanvas.firstRunEntryLint/format on the 43 changed TS/Vue files:
eslintexit 0,oxfmt --check— "All matched files use the correct format."Note that green Vitest is not evidence of type safety (Vitest strips types) — the
vue-tscresult above is the type-safety evidence.Rebase
Rebased conflict-free onto the types branch; the feature commit's own conflict resolutions were carried through unchanged.
Conflict resolutions
These were resolved, reviewed and verified in a prior pass and are not re-derived here. They cover two files:
src/composables/useUrlActionLoaders.tssrc/composables/useUrlActionLoaders.test.tsBoth drop the
?settingsdeep-link references. Those come from #15808, which is not on this branch —src/composables/useSettingsUrlLoader.tsdoes not exist oncloud/1.52(verified absent). Nosettingsreferences remain in either file.Judgement call for reviewers 👀
The upstream test
isolates a settings-loader failure so it does not abort the boot chainwas deleted (its subject, the settings loader, doesn't exist on this branch). Its two tail assertions were folded into the surviving top-up isolation test rather than dropped, so the coverage they provided is retained:This leaves 6 tests in the file instead of upstream's 7. If reviewers would rather see the assertions dropped with the deleted test, that's a one-line change.