Skip to content

docs(extensions): tighten ECS migration guidance - #15926

Merged
christian-byrne merged 2 commits into
mainfrom
docs/simplify-ecs-migration-followup
Aug 26, 2026
Merged

christian-byrne merged 2 commits into
mainfrom
docs/simplify-ecs-migration-followup

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Tightens three passages in the ECS extension migration guides so readers can reach the required action faster.

Changes

  • What: Condenses the callback test-coverage note and detached-geometry behavior, and clarifies that extensions use ComfyUI's active Pinia instance rather than creating their own.

Review Focus

This is a child of #15857. Please verify that the shorter callback and geometry wording preserves the documented contracts and that the Pinia guidance keeps extensions on the host application's instance.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 37 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 92 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ea37332a-e18c-41a2-ac8c-8d2908ca0a69

📥 Commits

Reviewing files that changed from the base of the PR and between 4bbafbb and 1311756.

📒 Files selected for processing (3)
  • docs/extensions/connection-callbacks-migration.md
  • docs/extensions/node-geometry-migration.md
  • docs/extensions/serialization-callbacks-migration.md

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Aug 25, 2026
@DrJKL
DrJKL requested a review from christian-byrne August 25, 2026 23:24
@DrJKL
DrJKL marked this pull request as ready for review August 25, 2026 23:28
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 25, 2026
Base automatically changed from docs/ecs-extension-migration-notes to main August 26, 2026 01:25
@DrJKL
DrJKL requested a review from a team August 26, 2026 01:25
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 26, 2026
@christian-byrne
christian-byrne force-pushed the docs/simplify-ecs-migration-followup branch from 0346e98 to 52f89c5 Compare August 26, 2026 02:32
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 26, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Rebased onto post-stack main. Effective diff is the intended 3 guide edits. Format green.

Full context for agent readers
  • Force-pushed rebased head 52f89c5161.
  • Replayed only the two follow-up commits after the obsolete merge-from-main commit, avoiding reintroducing the already-landed parent documentation.
  • Checked the shortened callback sequence, detached geometry behavior, and host-Pinia guidance against the landed implementation; no stale statement needed correction.
  • Verification: git diff --check and scoped oxfmt --check green.

@christian-byrne
christian-byrne force-pushed the docs/simplify-ecs-migration-followup branch from 52f89c5 to 1311756 Compare August 26, 2026 02:40

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — docs/tests only, rebased onto post-#15924 main, CI green. Enqueueing.

@christian-byrne
christian-byrne added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit eb59592 Aug 26, 2026
49 checks passed
@christian-byrne
christian-byrne deleted the docs/simplify-ecs-migration-followup branch August 26, 2026 03:25
@huang47 huang47 added the risk:medium PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium PR risk grade (advisory shadow check; grader-owned) size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants