Repository navigation
docs: clarify ADR-0018 reminting contracts - #15925
Conversation
|
Warning Review limit reachedNext included review available in 38 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 92 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
cee15d8 to
ee1d184
Compare
38cb5d3 to
5f445ea
Compare
|
Rebased onto post-stack Full context for agent readers
|
Full derivation record for program decision D-gl-A6: why duplicate-id reconciliation lives at the merge boundary while registries keep a strict no-collision invariant. Models echo-back convergence, the relationship to CRDT creator-minting (reminting as the import adapter for a non-actor-scoped id space, with the actor-scoped refactor recorded as future work), rejected alternatives (store-side remap, tolerant hybrid), the revisit trigger, and the known serialized-reference remap gap documented in ADR-0008 via #15761. Direction is already carried by ADR-0003's merge-boundary amendment and pinned by the #15720 invariant suite; this ADR makes the reasoning independently reviewable. # Conflicts: # docs/adr/README.md
5f445ea to
54da100
Compare
|
Updated again after #15882 landed. ADR now describes the implemented link remap and the current ADR-0017 title. Full context for agent readers
Current head: |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving — docs/tests only, rebased onto post-#15924 main, CI green. Enqueueing.
Summary
Clarifies ADR-0018's current local remint path, future CRDT requirements, and known link-remapping gap without changing the decision.
Changes
NodeIdrepresentation, separate local retry behavior from globally collision-free CRDT replacement, and describe the link-remapping failure and fix(litegraph): remap serialized link endpoints after node-id remint #15882 scope accurately.Review Focus
Check that the revised wording preserves D-gl-A6 while distinguishing implemented behavior from the future semantic-operation applier.
Child of #15920.