Skip to content

docs: clarify ADR-0018 reminting contracts - #15925

Merged
christian-byrne merged 9 commits into
mainfrom
drjkl/simplify-adr-0018
Aug 26, 2026
Merged

christian-byrne merged 9 commits into
mainfrom
drjkl/simplify-adr-0018

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Clarifies ADR-0018's current local remint path, future CRDT requirements, and known link-remapping gap without changing the decision.

Changes

Review Focus

Check that the revised wording preserves D-gl-A6 while distinguishing implemented behavior from the future semantic-operation applier.

Child of #15920.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 38 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 92 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9e51293e-43b4-4cff-8fdf-552952b6dc1c

📥 Commits

Reviewing files that changed from the base of the PR and between 4bbafbb and 54da100.

📒 Files selected for processing (2)
  • docs/adr/0018-node-id-reminting-at-the-merge-boundary.md
  • docs/adr/README.md

Comment @coderabbitai help to get the list of available commands.

@DrJKL
DrJKL requested a review from christian-byrne August 25, 2026 23:10
@github-actions github-actions Bot added the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Aug 25, 2026
@DrJKL
DrJKL marked this pull request as ready for review August 25, 2026 23:27
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 25, 2026
@christian-byrne
christian-byrne force-pushed the drjkl/simplify-adr-0018 branch from 38cb5d3 to 5f445ea Compare August 26, 2026 02:28
@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Aug 26, 2026
@christian-byrne
christian-byrne changed the base branch from cb__adr-remint-model to main August 26, 2026 02:28
@christian-byrne
christian-byrne requested a review from a team August 26, 2026 02:28
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Aug 26, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Rebased onto post-stack main. ADR index keeps the landed ADR-0017 title. Format green.

Full context for agent readers

christian-byrne and others added 9 commits August 25, 2026 19:38
Full derivation record for program decision D-gl-A6: why duplicate-id
reconciliation lives at the merge boundary while registries keep a strict
no-collision invariant. Models echo-back convergence, the relationship to
CRDT creator-minting (reminting as the import adapter for a non-actor-scoped
id space, with the actor-scoped refactor recorded as future work), rejected
alternatives (store-side remap, tolerant hybrid), the revisit trigger, and
the known serialized-reference remap gap documented in ADR-0008 via #15761.

Direction is already carried by ADR-0003's merge-boundary amendment and
pinned by the #15720 invariant suite; this ADR makes the reasoning
independently reviewable.

# Conflicts:
#	docs/adr/README.md
@christian-byrne
christian-byrne force-pushed the drjkl/simplify-adr-0018 branch from 5f445ea to 54da100 Compare August 26, 2026 02:39
@christian-byrne

Copy link
Copy Markdown
Contributor

Updated again after #15882 landed. ADR now describes the implemented link remap and the current ADR-0017 title.

Full context for agent readers

main advanced to 4bbafbb1ed during this rebase launch. I rebased #15925 again and replaced the now-stale “#15882 pending” section with the landed behavior: LGraph.configure records unambiguous requested→final node-id remints and repoints this payload's link endpoints before node configuration. The text also preserves the duplicate-request ambiguity carve-out and updates ADR-0017's title to “ID-Based Slot Records Own Slot State.”

Current head: 54da1008b4. Scoped oxfmt and git diff --check remain green.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — docs/tests only, rebased onto post-#15924 main, CI green. Enqueueing.

@christian-byrne
christian-byrne added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit b7044a9 Aug 26, 2026
48 checks passed
@christian-byrne
christian-byrne deleted the drjkl/simplify-adr-0018 branch August 26, 2026 03:25
@huang47 huang47 added the risk:medium PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R1 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:medium PR risk grade (advisory shadow check; grader-owned) size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants