Repository navigation
fix(billing): reject an empty payment credential alongside a saved one - #15915
Conversation
The mutual-exclusion guard on subscribe() tested truthiness, so an empty confirmationToken passed it and both credential fields were serialized into the request. Checking presence instead refuses that combination while leaving valid single-credential calls unchanged.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2004 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.36 MB gzip 🔴 +229 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.39 MB (baseline 1.39 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 592 kB (baseline 592 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.49 MB (baseline 3.49 MB) • 🔴 +142 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 15.1 MB (baseline 15.1 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 220 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-25T20:32:48.586Z",
"gitSha": "316bde0092beb577ed9de1bdfb611514cbc11748",
"branch": "wei/fix-mutually-exclusive-credential-guard",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2070.38399999999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.427999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.739,
"heapDeltaBytes": 13668208,
"heapUsedBytes": 82341352,
"domNodes": -280,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.971000000000002,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2036.974999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.82000000000005,
"heapDeltaBytes": 13320884,
"heapUsedBytes": 82357152,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.419,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2191.186000000016,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.717,
"layouts": 12,
"layoutDurationMs": 3.5820000000000003,
"taskDurationMs": 1201.327,
"heapDeltaBytes": -5459324,
"heapUsedBytes": 57570688,
"domNodes": -284,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 151.838,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2158.949000000007,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.082,
"layouts": 12,
"layoutDurationMs": 3.6700000000000004,
"taskDurationMs": 1180.5400000000002,
"heapDeltaBytes": 5681936,
"heapUsedBytes": 75122960,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 144.446,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.5459999999998,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.421000000000003,
"layouts": 6,
"layoutDurationMs": 0.7209999999999999,
"taskDurationMs": 359.65600000000006,
"heapDeltaBytes": 4092344,
"heapUsedBytes": 73091340,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.020999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.750999999941,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.223999999999997,
"layouts": 6,
"layoutDurationMs": 0.7040000000000001,
"taskDurationMs": 359.434,
"heapDeltaBytes": 4078288,
"heapUsedBytes": 72978284,
"domNodes": 73,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.692999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 718.6509999999657,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.46000000000004,
"heapDeltaBytes": -6760644,
"heapUsedBytes": 62635652,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 31.887999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 718.1769999999688,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.817,
"heapDeltaBytes": -6753812,
"heapUsedBytes": 62090224,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 32.11,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.3779999999992,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.885000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.346,
"heapDeltaBytes": -19783116,
"heapUsedBytes": 71020108,
"domNodes": -278,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 41.05,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.74599999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.6640000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.5519999999999,
"heapDeltaBytes": -20904948,
"heapUsedBytes": 69694708,
"domNodes": -282,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 36.281000000000006,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3262.0549999999753,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.623999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2535.733,
"heapDeltaBytes": 19803528,
"heapUsedBytes": 84234104,
"domNodes": -280,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 911.765,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3319.6120000000064,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.366000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2583.011,
"heapDeltaBytes": -24545700,
"heapUsedBytes": 66947760,
"domNodes": -284,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 916.58,
"eventListeners": -151,
"totalBlockingTimeMs": 16,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4399.598000000025,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.401999999999996,
"layouts": 60,
"layoutDurationMs": 8.121000000000002,
"taskDurationMs": 2598.6000000000004,
"heapDeltaBytes": 7066312,
"heapUsedBytes": 79641272,
"domNodes": -266,
"jsHeapTotalBytes": -2142208,
"scriptDurationMs": 882.053,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4384.936999999923,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.915000000000003,
"layouts": 60,
"layoutDurationMs": 8.302,
"taskDurationMs": 2550.208,
"heapDeltaBytes": 14589104,
"heapUsedBytes": 80889916,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 891.636,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3151.1990000000196,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.808000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2048.066,
"heapDeltaBytes": 12964728,
"heapUsedBytes": 80341628,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 199.74999999999997,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3253.808000000049,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.738,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2113.5190000000002,
"heapDeltaBytes": -1625756,
"heapUsedBytes": 70768064,
"domNodes": -287,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 216.29199999999997,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2024.9699999999962,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.823,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.313,
"heapDeltaBytes": -21800292,
"heapUsedBytes": 70446252,
"domNodes": -280,
"jsHeapTotalBytes": 2875392,
"scriptDurationMs": 42.442,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.1079999999738,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.898,
"heapDeltaBytes": 9869344,
"heapUsedBytes": 74812056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.654999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 730.1459999999906,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.406,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.062,
"heapDeltaBytes": 17939400,
"heapUsedBytes": 88027352,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 135.854,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 801.6159999999672,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.333,
"heapDeltaBytes": 18169924,
"heapUsedBytes": 81348456,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 159.613,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.0649999999978,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.505999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.197,
"heapDeltaBytes": -11249720,
"heapUsedBytes": 59009764,
"domNodes": -298,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.659000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.1709999999239,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.620000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.758,
"heapDeltaBytes": 10995396,
"heapUsedBytes": 80589188,
"domNodes": -298,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.791000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1845.5640000000244,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.568000000000005,
"layouts": 16,
"layoutDurationMs": 4.353,
"taskDurationMs": 1088.0420000000001,
"heapDeltaBytes": -4832360,
"heapUsedBytes": 64722356,
"domNodes": -299,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.953,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1845.3269999999975,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.568000000000005,
"layouts": 16,
"layoutDurationMs": 4.932,
"taskDurationMs": 1087.5030000000002,
"heapDeltaBytes": -3974180,
"heapUsedBytes": 66149036,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 112.025,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.2029999999568,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.506999999999998,
"layouts": 13,
"layoutDurationMs": 13.224,
"taskDurationMs": 900.8360000000002,
"heapDeltaBytes": -7611372,
"heapUsedBytes": 87058028,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 28.387999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 121,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12353.89699999996,
"styleRecalcs": 244,
"styleRecalcDurationMs": 38.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9090.704,
"heapDeltaBytes": -11626368,
"heapUsedBytes": 79024992,
"domNodes": -278,
"jsHeapTotalBytes": 2281472,
"scriptDurationMs": 3143.6949999999997,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12247.351999999977,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8923.559000000001,
"heapDeltaBytes": 1449544,
"heapUsedBytes": 92158332,
"domNodes": -222,
"jsHeapTotalBytes": 4640768,
"scriptDurationMs": 3098.5180000000005,
"eventListeners": -149,
"totalBlockingTimeMs": 18,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18610.790000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17672.498,
"heapDeltaBytes": -24875344,
"heapUsedBytes": 180042284,
"domNodes": -6548,
"jsHeapTotalBytes": -5316608,
"scriptDurationMs": 378.618,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18620.813999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17762.423,
"heapDeltaBytes": -29660488,
"heapUsedBytes": 175143412,
"domNodes": -6548,
"jsHeapTotalBytes": -5840896,
"scriptDurationMs": 405.04200000000003,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 23143.614000000012,
"styleRecalcs": 182,
"styleRecalcDurationMs": 22.24899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22834.215999999997,
"heapDeltaBytes": -27677060,
"heapUsedBytes": 182737260,
"domNodes": -6548,
"jsHeapTotalBytes": -2957312,
"scriptDurationMs": 945.6849999999998,
"eventListeners": -7469,
"totalBlockingTimeMs": 203,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23378.562999999987,
"styleRecalcs": 180,
"styleRecalcDurationMs": 23.25900000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23075.648999999998,
"heapDeltaBytes": -25781612,
"heapUsedBytes": 178984072,
"domNodes": -6548,
"jsHeapTotalBytes": 2347008,
"scriptDurationMs": 960.4179999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 303,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 138.51899999997386,
"styleRecalcs": 8,
"styleRecalcDurationMs": 19.915999999999997,
"layouts": 3,
"layoutDurationMs": 0.8460000000000001,
"taskDurationMs": 110.10199999999999,
"heapDeltaBytes": 3474704,
"heapUsedBytes": 69833228,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.446999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 147.16099999998278,
"styleRecalcs": 10,
"styleRecalcDurationMs": 20.62,
"layouts": 2,
"layoutDurationMs": 1.0230000000000001,
"taskDurationMs": 102.52900000000001,
"heapDeltaBytes": 3592408,
"heapUsedBytes": 69972884,
"domNodes": 112,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.605,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthrough
ChangesSubscription validation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The change rejects requests that provide both credential fields, including an empty token, while preserving valid single-credential behavior. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description explains the bug, implementation, scope, regression tests, verification results, and sequencing context. It does not use every template heading, but it provides the required information and is sufficiently complete. Full details: End-To-End Regression Coverage For FixesExplanation The changed-file metadata is available and lists only Resolution Provide the PR title and all commit subjects, then re-evaluate the bug-fix signal. Based on the available description, also confirm whether the author has added a concrete explanation for not adding an end-to-end regression test under Full details: Website End-To-End Regression CoverageExplanation The changed files are ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15915 +/- ##
==========================================
+ Coverage 80.15% 82.51% +2.35%
==========================================
Files 2261 1931 -330
Lines 115517 110559 -4958
Branches 32929 31755 -1174
==========================================
- Hits 92596 91225 -1371
+ Misses 22428 18995 -3433
+ Partials 493 339 -154
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 338 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Verified the issue is real rather than assumed: subscribe() serializes confirmation_token: options.confirmationToken directly, and JSON serialization drops undefined but keeps '', so pre-fix an empty-string token alongside savedPaymentMethodId slipped the truthy guard and sent both credentials. Also verified no caller can regress: the only production path that builds these options is buildPaymentOptions() in useSubscriptionCheckout.ts, which truthy-spreads and therefore emits at most one credential key and never an empty string, so the stricter guard cannot throw for existing callers. SubscribeOptions types both fields as string | undefined (no null), so !== undefined is exhaustive, and the request body remains satisfies SubscribeRequest from @comfyorg/ingest-types. Test was confirmed failing against the unfixed guard per the PR description, and CI is green. Approving; one non-blocking suggestion inline.
…uest JSON drops undefined but keeps an empty string, so a lone empty credential reached the API as a present-but-meaningless value. No caller produces one today, but the guard above is only half the job without this.
7a4df59
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed the follow-up commit 7a4df59 addressing my prior suggestion. The normalization is deliberately placed after the mutual-exclusion guard, which I verified is load-bearing: normalizing first would coerce { confirmationToken: '', savedPaymentMethodId: 'pm_saved' } into a single defined credential and silently stop it throwing — the exact case this PR exists to reject. || undefined is the right operator here since coercing '' is the point (fields are string | undefined, so it differs from ?? only for the empty string), satisfies SubscribeRequest still holds, and I agree omission beats rejection given no reachable producer of an empty credential exists today. New test verified failing against the unfixed serialization per the author's note; CI fully green on this head. Approving; one non-blocking nit inline.
The empty-credential test exercised only the confirmation-token branch, so deleting the sibling normalization would not have failed anything.
dante01yoon
left a comment
There was a problem hiding this comment.
Re-reviewed the delta since my last review (7a4df59 → e3fdc15). The only change is the test addition taking my non-blocking nit: a second subscribe() call with { savedPaymentMethodId: '' } asserting saved_payment_method_id is absent from the serialized body, so both normalization lines are now pinned rather than one being exercised incidentally. The author verified the assertion actually pins the line (reverting only the saved_payment_method_id normalization fails the test), which is the standard that matters. Both review threads are resolved, no source changes since the last approved revision, and CI is fully green on this head. Approving.
|
|
…fy-Org#15965) Manual backport dispatch has been failing on every PR with a single opaque line: `PR #<n> not found or inaccessible.` Two causes, both fixed here. ### 1. The error was swallowed The lookup redirected stderr to `/dev/null`, so an auth failure and a genuinely missing PR produced identical output. The `gh` error is now surfaced in the annotation. ### 2. The job used a token that cannot read PRs `gh pr view <n>` fails with the auto-provided `GITHUB_TOKEN` **even under `permissions: pull-requests: write`**. Interestingly `gh pr list` and `gh pr comment` work with it — only the PR-number lookups fail, which is why the automatic path kept working and only manual dispatch broke. Fixing just the validation step would have moved the failure one step later: `Collect backport targets` and `Backport commits` do the same lookup. So the working token is now a **job-level default**, and the two steps that intentionally use a different token still set it themselves. ### Evidence Runs `32917113697` (Comfy-Org#15804) and `32917122198` (Comfy-Org#15915) both died in `Validate inputs` with `##[error]PR #<n> not found or inaccessible` — both PRs were merged and carried `needs-backport`. ### One token for the whole job Five steps were on the automatic token. Rather than repeat the expression, the working token is a job-level default. `Create PR for each successful backport` still pins `PR_GH_TOKEN` deliberately — PR creation must be the bot. Removing the `github.token` override on `Comment on failures` is safe: it posts as `comfy-pr-bot` instead of `github-actions[bot]` (both bots), and the three `issue_comment` workflows in this repo are gated on specific command bodies (`recheck` and friends), so a failure comment cannot trigger them. ### Not fixed here This does not make conflicted cherry-picks succeed. A backport whose dependency is not on the target branch still fails on conflict, which is a separate problem.
|
…link Addresses review feedback: #16102 (comment)
Summary
workspaceApi.subscribe()guardsconfirmationTokenandsavedPaymentMethodIdas mutually exclusive, but tests truthiness:An empty-string
confirmationTokenis falsy, so it slips the guard and both credential fields are serialized into the request body —confirmation_token: ''alongsidesaved_payment_method_id. Checking presence instead refuses that combination.Scope
One condition and one test. Valid single-credential calls are unchanged: passing only a token, only a saved method, or neither all behave exactly as before, since the guard only fires when both keys are present.
Note this makes the guard stricter in one further case — explicitly passing
undefinedfor one of them still passes, but passing both keys with any defined values now throws, which is what "mutually exclusive" should mean.Verification
subscribe() rejects an empty credential alongside a saved onewas confirmed to fail against the unfixed guard (1 failed / 41 passed) and pass with it (42/42) — not assumed.pnpm typecheckandtypecheck:browserclean.check-binary-sizefailures are pre-existing and environmental.Origin
Found by CodeRabbit on #15803, where it landed as an outside-diff-range comment with no thread. The code is not that PR's — it came from #14483 and reached the branch through a merge from
main— so it is fixed here on its own rather than folded into a capability-migration PR.Sequencing note: #15906 backports #14483 to
cloud/1.51and carries the same guard. Landing this onmainfirst lets that backport pick the fix up, rather than shipping the bug to the release line and needing a second backport.