Skip to content

[backport cloud/1.52] fix: route subscription deep links through billing facade - #15914

Merged
comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-14998-to-cloud-1.52
Aug 25, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.52from
backport-14998-to-cloud-1.52

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14998 to cloud/1.52

Automatically created by backport workflow.

## Summary

Route `/cloud/subscribe` through workspace initialization and the
canonical billing facade. Personal and Team selections now enter the
unified pricing checkout, while active subscriptions use facade-owned
subscription management.

## Root cause

The deep-link view directly chose backend/API families instead of using
server/workspace-derived facade routing:

- Personal checkout called legacy
`/customers/cloud-subscription-checkout`.
- Team checkout called `workspaceApi.subscribe` directly.
- Active subscriptions called legacy `/customers/billing` directly.

This let a selected Team workspace invoke user-scoped legacy APIs from a
personal-tier link and duplicated checkout ownership outside
`useBillingContext` / `useSubscriptionCheckout`.

## Why this change is needed

Checkout routing must be independent from legacy account-operation
routing. The active workspace and billing rail are the source of truth,
while `useSubscriptionCheckout` owns plan resolution,
preview/reactivation confirmation, permissions, billing operation
tracking, payment actions, telemetry, and terminal outcomes.

## AS IS / TO BE

**AS IS**

```mermaid
flowchart TD
  A[cloud/subscribe deep link] --> B{Tier query}
  B -->|Personal| C[performSubscriptionCheckout]
  C --> D[Legacy customers checkout API]
  B -->|Team| E[performTeamSubscriptionCheckout]
  E --> F[Workspace subscribe API]
  A -->|Active subscription| G[accessBillingPortal]
  G --> H[Legacy customers billing API]
```

**TO BE**

```mermaid
flowchart TD
  A[cloud/subscribe deep link] --> B[WorkspaceAuthGate initializes active workspace]
  B --> C[useBillingContext]
  C -->|Active subscription| D[manageSubscription]
  C -->|Personal or Team selection| E[useSubscriptionDialog initialCheckout]
  E --> F[useSubscriptionCheckout]
  F --> G[Workspace billing subscribe and preview APIs]
  D --> H[Portal selected by active billing rail]
```

## API behavior

| Scenario | Checkout / action owner | API behavior |
|---|---|---|
| Personal selection | `useSubscriptionDialog` →
`useSubscriptionCheckout` → `useBillingContext` checkout context |
Workspace/new billing checkout (`/api/billing/*`) |
| Team selection | Same unified checkout path with catalog-backed credit
stop | Workspace/new billing checkout (`/api/billing/*`) |
| Active subscription deep link |
`useBillingContext.manageSubscription()` | Portal selected by the active
workspace billing rail |
| `legacy_stripe` account operations | Billing facade active account
context | Manage/top-up/cancel remain on intentional legacy
`/customers/*` APIs; checkout remains workspace-backed |
| Inactive Founder deep link | Unified personal pricing table | No
unsupported direct Founder checkout; user selects a current purchasable
plan |

## Regression coverage and validation

- Personal selections open unified initial checkout and never call
`performSubscriptionCheckout`.
- Team selections open unified initial checkout with the catalog-derived
stop and never call `performTeamSubscriptionCheckout`.
- Active subscriptions, including active Founder and
Team-workspace/personal-tier cases, call facade `manageSubscription`,
not direct `accessBillingPortal`.
- Missing, invalid, array-valued, and Team-without-stop query behavior
remains covered.
- `/cloud/subscribe` now mounts through `LayoutDefault` /
`WorkspaceAuthGate` so facade routing sees the restored active
workspace.
- The redirect view dismisses the pre-Vue `#splash-loader` on mount
(dismissal previously owned by `CloudLayoutView`; mirrors
`UserSelectView` under `LayoutDefault`), so the unified checkout is
never covered by the splash.
- Team plan-load failures fall back to the generic Team pricing table
instead of aborting the redirect, matching `usePricingTableUrlLoader`
recovery.
- E2E `@cloud` spec `browser_tests/tests/cloudSubscribeDeepLink.spec.ts`
boots the route-mocked real app at
`/cloud/subscribe?tier=creator&cycle=monthly` and asserts the unified
`creator-monthly` confirmation renders with the splash detached and zero
legacy `/customers/*` requests. The spec fails at 6930046 (pre-fix,
splash regression) and passes at head.

Validation:

- `pnpm test:unit
src/platform/cloud/onboarding/CloudSubscriptionRedirectView.test.ts
src/platform/cloud/subscription/composables/usePricingTableUrlLoader.test.ts`
— 51 passed
- `pnpm test:unit src/platform/cloud/ src/platform/workspace/` — 1631
passed
- `playwright test browser_tests/tests/cloudSubscribeDeepLink.spec.ts
--project=cloud` — passed against the cloud dev server
- `pnpm typecheck` — passed
- targeted `oxfmt`, ESLint, Stylelint, Oxlint, and pre-push `knip` —
passed
- independent committed-diff review — no blockers

Residual intentional legacy callers remain in legacy pricing and
`legacy_stripe` resubscribe/pending-checkout recovery. They are outside
this redirect migration and are retained intentionally.

## Screenshots

No intentional visual change. The redirect loading surface and unified
checkout UI are existing components, so screenshots are not applicable.

---------

Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 25, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 25, 2026 18:28
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/25/2026, 06:29:59 PM UTC

Links

🎭 Playwright: ✅ 1980 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1959 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 139ms TBT · 82.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.9 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 74ms TBT · 174.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 545ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.8 MB
canvas-idle: DOM nodes -283
canvas-idle: event listeners -166
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 40ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 903ms
canvas-mouse-sweep: script duration 115ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 54.4 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -151
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 370ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 62.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 375ms
dom-widget-clipping: script duration 56ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.3 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 9ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 638ms
large-graph-idle: script duration 17ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 67.4 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1237ms
large-graph-pan: script duration 341ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 61.0 MB
large-graph-pan: DOM nodes -284
large-graph-pan: event listeners -165
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1412ms
large-graph-zoom: script duration 391ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.6 MB
large-graph-zoom: DOM nodes -252
large-graph-zoom: event listeners -147
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1421ms
legacy-node-drag: script duration 446ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 76.0 MB
legacy-node-drag: DOM nodes 12
legacy-node-drag: event listeners 185
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 639ms
minimap-idle: script duration 16ms
minimap-idle: TBT 0ms
minimap-idle: heap used 64.4 MB
minimap-idle: DOM nodes -284
minimap-idle: event listeners -179
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 391ms
subgraph-dom-widget-clipping: script duration 117ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 70.9 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 499ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.6 MB
subgraph-idle: DOM nodes -282
subgraph-idle: event listeners -166
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 74
subgraph-mouse-sweep: task duration 824ms
subgraph-mouse-sweep: script duration 89ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 54.1 MB
subgraph-mouse-sweep: DOM nodes -283
subgraph-mouse-sweep: event listeners -151
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 13
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 940ms
subgraph-transition-enter: script duration 18ms
subgraph-transition-enter: TBT 139ms
subgraph-transition-enter: heap used 82.8 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4342ms
viewport-pan-sweep: script duration 1057ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.6 MB
viewport-pan-sweep: DOM nodes -279
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16863ms
vue-large-graph-idle: script duration 119ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.9 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16391
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 171
vue-large-graph-pan: task duration 20174ms
vue-large-graph-pan: script duration 430ms
vue-large-graph-pan: TBT 74ms
vue-large-graph-pan: heap used 174.6 MB
vue-large-graph-pan: DOM nodes -8313
vue-large-graph-pan: event listeners -16387
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 106ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.4 MB
workflow-execution: DOM nodes 139
workflow-execution: event listeners 63
Raw data
{
  "timestamp": "2026-08-25T18:41:25.825Z",
  "gitSha": "ada8359fa8ff5d41beba6beea16928a782efa137",
  "branch": "backport-14998-to-cloud-1.52",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2077.4490000000014,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.974000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 577.6129999999999,
      "heapDeltaBytes": 16586088,
      "heapUsedBytes": 78171496,
      "domNodes": -283,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.655000000000001,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2048.516999999947,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.687,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 512.267,
      "heapDeltaBytes": -245000,
      "heapUsedBytes": 61998256,
      "domNodes": -283,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.129999999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1960.6970000000388,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 44.133,
      "layouts": 12,
      "layoutDurationMs": 5.026,
      "taskDurationMs": 940.992,
      "heapDeltaBytes": -4786676,
      "heapUsedBytes": 57792224,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 118.382,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1829.8729999999068,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 36.039,
      "layouts": 12,
      "layoutDurationMs": 3.3609999999999998,
      "taskDurationMs": 864.0409999999999,
      "heapDeltaBytes": -6034812,
      "heapUsedBytes": 56349948,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 112.081,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1732.9899999999725,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.7,
      "layouts": 6,
      "layoutDurationMs": 0.5810000000000002,
      "taskDurationMs": 357.876,
      "heapDeltaBytes": 3185952,
      "heapUsedBytes": 66263096,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.913,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.8359999999584,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.586,
      "layouts": 6,
      "layoutDurationMs": 0.7209999999999999,
      "taskDurationMs": 383.0709999999999,
      "heapDeltaBytes": 3296436,
      "heapUsedBytes": 65580640,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.719000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 602.9179999999883,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.0610000000001,
      "heapDeltaBytes": 10975988,
      "heapUsedBytes": 73649896,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 54.09199999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 594.5930000000317,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.427,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 379.635,
      "heapDeltaBytes": 11220536,
      "heapUsedBytes": 73805480,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 56.91600000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.6779999999808,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.307,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 650.688,
      "heapDeltaBytes": -12714000,
      "heapUsedBytes": 64445388,
      "domNodes": -280,
      "jsHeapTotalBytes": 3928064,
      "scriptDurationMs": 17.281000000000006,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2088.162000000011,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.405000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 625.4569999999999,
      "heapDeltaBytes": -274484,
      "heapUsedBytes": 76932348,
      "domNodes": -271,
      "jsHeapTotalBytes": -1052672,
      "scriptDurationMs": 17.518999999999995,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2274.1080000000125,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.841,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1243.4389999999999,
      "heapDeltaBytes": -14236972,
      "heapUsedBytes": 63959616,
      "domNodes": -285,
      "jsHeapTotalBytes": 4452352,
      "scriptDurationMs": 343.856,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2250.9300000000394,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.241000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1231.115,
      "heapDeltaBytes": -14093588,
      "heapUsedBytes": 64061328,
      "domNodes": -283,
      "jsHeapTotalBytes": -4096,
      "scriptDurationMs": 337.39599999999996,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3165.393999999992,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.680000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.013,
      "taskDurationMs": 1396.411,
      "heapDeltaBytes": -4079164,
      "heapUsedBytes": 75317424,
      "domNodes": -251,
      "jsHeapTotalBytes": 258048,
      "scriptDurationMs": 385.88800000000003,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3217.367999999965,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.316999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.192,
      "taskDurationMs": 1427.661,
      "heapDeltaBytes": -4405612,
      "heapUsedBytes": 74794628,
      "domNodes": -252,
      "jsHeapTotalBytes": -4096,
      "scriptDurationMs": 395.99600000000004,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2252.1750000000225,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.763999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1425.589,
      "heapDeltaBytes": -17349232,
      "heapUsedBytes": 70037772,
      "domNodes": 12,
      "jsHeapTotalBytes": 8425472,
      "scriptDurationMs": 444.39,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2219.3809999999985,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.856999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1415.749,
      "heapDeltaBytes": 9265600,
      "heapUsedBytes": 89274528,
      "domNodes": 12,
      "jsHeapTotalBytes": 7270400,
      "scriptDurationMs": 447.286,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.4669999999878,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.923000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 639.5079999999999,
      "heapDeltaBytes": -12511380,
      "heapUsedBytes": 70705200,
      "domNodes": -285,
      "jsHeapTotalBytes": 4976640,
      "scriptDurationMs": 16.486,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2026.817000000051,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.605999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 639.0689999999998,
      "heapDeltaBytes": -13469480,
      "heapUsedBytes": 64269960,
      "domNodes": -283,
      "jsHeapTotalBytes": 2879488,
      "scriptDurationMs": 16.134000000000004,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 581.735999999978,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.256,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 386.37600000000003,
      "heapDeltaBytes": 12084188,
      "heapUsedBytes": 73917212,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 117.44300000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 580.8220000000119,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.856999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.752,
      "heapDeltaBytes": 11972680,
      "heapUsedBytes": 74854404,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 116.80300000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.9330000000232,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.41,
      "heapDeltaBytes": 6100552,
      "heapUsedBytes": 69062268,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 7.616999999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.4130000000423,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.303000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.772,
      "heapDeltaBytes": -7202272,
      "heapUsedBytes": 55865408,
      "domNodes": -282,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 7.164999999999999,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.5910000000558,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.166000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.882999999999999,
      "taskDurationMs": 828.7249999999999,
      "heapDeltaBytes": -5836516,
      "heapUsedBytes": 56735796,
      "domNodes": -282,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 88.975,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.24100000002,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 35.60000000000001,
      "layouts": 16,
      "layoutDurationMs": 4.667,
      "taskDurationMs": 820.259,
      "heapDeltaBytes": -5885268,
      "heapUsedBytes": 56734852,
      "domNodes": -283,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 88.093,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.7719999999981,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.331999999999997,
      "layouts": 13,
      "layoutDurationMs": 14.020000000000001,
      "taskDurationMs": 939.816,
      "heapDeltaBytes": -6143244,
      "heapUsedBytes": 86775292,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 18.328999999999997,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 139,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8329.508999999973,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.519999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4306.334000000001,
      "heapDeltaBytes": 3106844,
      "heapUsedBytes": 80532452,
      "domNodes": -274,
      "jsHeapTotalBytes": -1089536,
      "scriptDurationMs": 1035.4059999999997,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8599.676000000045,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 38.725,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4376.982,
      "heapDeltaBytes": -3509472,
      "heapUsedBytes": 73816440,
      "domNodes": -283,
      "jsHeapTotalBytes": 4677632,
      "scriptDurationMs": 1079.2649999999999,
      "eventListeners": -163,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17645.30400000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16791.696,
      "heapDeltaBytes": -45071176,
      "heapUsedBytes": 175759312,
      "domNodes": -8312,
      "jsHeapTotalBytes": -31068160,
      "scriptDurationMs": 115.15800000000002,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17908.995000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16933.403000000002,
      "heapDeltaBytes": -52536152,
      "heapUsedBytes": 178344888,
      "domNodes": -8312,
      "jsHeapTotalBytes": -21549056,
      "scriptDurationMs": 122.632,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20905.719000000034,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 18.22299999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20317.965,
      "heapDeltaBytes": -37373296,
      "heapUsedBytes": 193254004,
      "domNodes": -8312,
      "jsHeapTotalBytes": -22163456,
      "scriptDurationMs": 446.77500000000003,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 119,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20603.905000000053,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 17.586999999999964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20029.228000000003,
      "heapDeltaBytes": -45942416,
      "heapUsedBytes": 172884188,
      "domNodes": -8314,
      "jsHeapTotalBytes": -25583616,
      "scriptDurationMs": 413.78200000000004,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 28,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 481.899999999996,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.002,
      "layouts": 3,
      "layoutDurationMs": 1.3639999999999999,
      "taskDurationMs": 127.26199999999999,
      "heapDeltaBytes": 5329428,
      "heapUsedBytes": 67973104,
      "domNodes": 152,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 12.109000000000002,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 107.0039999999608,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 16.332,
      "layouts": 3,
      "layoutDurationMs": 1.397,
      "taskDurationMs": 84.79899999999999,
      "heapDeltaBytes": 2993700,
      "heapUsedBytes": 65054820,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.7700000000000005,
      "eventListeners": 27,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions
github-actions Bot requested a review from thedatalife August 25, 2026 18:29
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 25, 2026
@comfy-pr-bot
comfy-pr-bot merged commit a4fbc6a into cloud/1.52 Aug 25, 2026
96 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14998-to-cloud-1.52 branch August 25, 2026 18:44
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...platform/cloud/onboarding/onboardingCloudRoutes.ts 0.00% 2 Missing ⚠️
...bscription/composables/usePricingTableUrlLoader.ts 50.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.52   #15914   +/-   ##
=============================================
  Coverage              ?   81.96%           
=============================================
  Files                 ?     1905           
  Lines                 ?   108742           
  Branches              ?    30556           
=============================================
  Hits                  ?    89132           
  Misses                ?    19266           
  Partials              ?      344           
Flag Coverage Δ
e2e 66.47% <0.00%> (?)
unit 73.83% <92.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...cloud/onboarding/CloudSubscriptionRedirectView.vue 95.23% <100.00%> (ø)
...bscription/composables/usePricingTableUrlLoader.ts 92.40% <50.00%> (ø)
...platform/cloud/onboarding/onboardingCloudRoutes.ts 72.97% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants