Skip to content

[backport cloud/1.51] fix: route subscription deep links through billing facade - #15912

Merged
comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-14998-to-cloud-1.51
Aug 25, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-14998-to-cloud-1.51

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14998 to cloud/1.51

Automatically created by backport workflow.

## Summary

Route `/cloud/subscribe` through workspace initialization and the
canonical billing facade. Personal and Team selections now enter the
unified pricing checkout, while active subscriptions use facade-owned
subscription management.

## Root cause

The deep-link view directly chose backend/API families instead of using
server/workspace-derived facade routing:

- Personal checkout called legacy
`/customers/cloud-subscription-checkout`.
- Team checkout called `workspaceApi.subscribe` directly.
- Active subscriptions called legacy `/customers/billing` directly.

This let a selected Team workspace invoke user-scoped legacy APIs from a
personal-tier link and duplicated checkout ownership outside
`useBillingContext` / `useSubscriptionCheckout`.

## Why this change is needed

Checkout routing must be independent from legacy account-operation
routing. The active workspace and billing rail are the source of truth,
while `useSubscriptionCheckout` owns plan resolution,
preview/reactivation confirmation, permissions, billing operation
tracking, payment actions, telemetry, and terminal outcomes.

## AS IS / TO BE

**AS IS**

```mermaid
flowchart TD
  A[cloud/subscribe deep link] --> B{Tier query}
  B -->|Personal| C[performSubscriptionCheckout]
  C --> D[Legacy customers checkout API]
  B -->|Team| E[performTeamSubscriptionCheckout]
  E --> F[Workspace subscribe API]
  A -->|Active subscription| G[accessBillingPortal]
  G --> H[Legacy customers billing API]
```

**TO BE**

```mermaid
flowchart TD
  A[cloud/subscribe deep link] --> B[WorkspaceAuthGate initializes active workspace]
  B --> C[useBillingContext]
  C -->|Active subscription| D[manageSubscription]
  C -->|Personal or Team selection| E[useSubscriptionDialog initialCheckout]
  E --> F[useSubscriptionCheckout]
  F --> G[Workspace billing subscribe and preview APIs]
  D --> H[Portal selected by active billing rail]
```

## API behavior

| Scenario | Checkout / action owner | API behavior |
|---|---|---|
| Personal selection | `useSubscriptionDialog` →
`useSubscriptionCheckout` → `useBillingContext` checkout context |
Workspace/new billing checkout (`/api/billing/*`) |
| Team selection | Same unified checkout path with catalog-backed credit
stop | Workspace/new billing checkout (`/api/billing/*`) |
| Active subscription deep link |
`useBillingContext.manageSubscription()` | Portal selected by the active
workspace billing rail |
| `legacy_stripe` account operations | Billing facade active account
context | Manage/top-up/cancel remain on intentional legacy
`/customers/*` APIs; checkout remains workspace-backed |
| Inactive Founder deep link | Unified personal pricing table | No
unsupported direct Founder checkout; user selects a current purchasable
plan |

## Regression coverage and validation

- Personal selections open unified initial checkout and never call
`performSubscriptionCheckout`.
- Team selections open unified initial checkout with the catalog-derived
stop and never call `performTeamSubscriptionCheckout`.
- Active subscriptions, including active Founder and
Team-workspace/personal-tier cases, call facade `manageSubscription`,
not direct `accessBillingPortal`.
- Missing, invalid, array-valued, and Team-without-stop query behavior
remains covered.
- `/cloud/subscribe` now mounts through `LayoutDefault` /
`WorkspaceAuthGate` so facade routing sees the restored active
workspace.
- The redirect view dismisses the pre-Vue `#splash-loader` on mount
(dismissal previously owned by `CloudLayoutView`; mirrors
`UserSelectView` under `LayoutDefault`), so the unified checkout is
never covered by the splash.
- Team plan-load failures fall back to the generic Team pricing table
instead of aborting the redirect, matching `usePricingTableUrlLoader`
recovery.
- E2E `@cloud` spec `browser_tests/tests/cloudSubscribeDeepLink.spec.ts`
boots the route-mocked real app at
`/cloud/subscribe?tier=creator&cycle=monthly` and asserts the unified
`creator-monthly` confirmation renders with the splash detached and zero
legacy `/customers/*` requests. The spec fails at 6930046 (pre-fix,
splash regression) and passes at head.

Validation:

- `pnpm test:unit
src/platform/cloud/onboarding/CloudSubscriptionRedirectView.test.ts
src/platform/cloud/subscription/composables/usePricingTableUrlLoader.test.ts`
— 51 passed
- `pnpm test:unit src/platform/cloud/ src/platform/workspace/` — 1631
passed
- `playwright test browser_tests/tests/cloudSubscribeDeepLink.spec.ts
--project=cloud` — passed against the cloud dev server
- `pnpm typecheck` — passed
- targeted `oxfmt`, ESLint, Stylelint, Oxlint, and pre-push `knip` —
passed
- independent committed-diff review — no blockers

Residual intentional legacy callers remain in legacy pricing and
`legacy_stripe` resubscribe/pending-checkout recovery. They are outside
this redirect migration and are retained intentionally.

## Screenshots

No intentional visual change. The redirect loading surface and unified
checkout UI are existing components, so screenshots are not applicable.

---------

Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 25, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 25, 2026 18:27
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1824 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1803 / ❌ 0 / ⚠️ 4 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/25/2026, 06:30:42 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 118ms TBT · 77.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 159.6 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 54ms TBT · 166.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 510ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.5 MB
canvas-idle: DOM nodes 20
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 948ms
canvas-mouse-sweep: script duration 112ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 54.2 MB
canvas-mouse-sweep: DOM nodes -113
canvas-mouse-sweep: event listeners -74
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 390ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.4 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 382ms
dom-widget-clipping: script duration 53ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 51.9 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 642ms
large-graph-idle: script duration 16ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 68.0 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1171ms
large-graph-pan: script duration 302ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 65.6 MB
large-graph-pan: DOM nodes -284
large-graph-pan: event listeners -148
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1414ms
large-graph-zoom: script duration 385ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 55.5 MB
large-graph-zoom: DOM nodes -288
large-graph-zoom: event listeners -153
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 627ms
minimap-idle: script duration 16ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.4 MB
minimap-idle: DOM nodes -282
minimap-idle: event listeners -164
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 402ms
subgraph-dom-widget-clipping: script duration 121ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.1 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 489ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.8 MB
subgraph-idle: DOM nodes 17
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 36ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 750ms
subgraph-mouse-sweep: script duration 81ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.3 MB
subgraph-mouse-sweep: DOM nodes 62
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 924ms
subgraph-transition-enter: script duration 16ms
subgraph-transition-enter: TBT 118ms
subgraph-transition-enter: heap used 77.2 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2375
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4019ms
viewport-pan-sweep: script duration 936ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 66.2 MB
viewport-pan-sweep: DOM nodes -282
viewport-pan-sweep: event listeners -133
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17228ms
vue-large-graph-idle: script duration 122ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 159.6 MB
vue-large-graph-idle: DOM nodes -8313
vue-large-graph-idle: event listeners -16388
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 178
vue-large-graph-pan: task duration 21262ms
vue-large-graph-pan: script duration 400ms
vue-large-graph-pan: TBT 54ms
vue-large-graph-pan: heap used 166.4 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16381
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 10
workflow-execution: task duration 99ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.5 MB
workflow-execution: DOM nodes 120
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-25T18:40:07.942Z",
  "gitSha": "e6e377528aa00bd0ade011a84a26c0e1ed819a3c",
  "branch": "backport-14998-to-cloud-1.51",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2071.9419999999786,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.526999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 563.414,
      "heapDeltaBytes": 5248820,
      "heapUsedBytes": 70675852,
      "domNodes": 20,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 9.690000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2022.4450000000616,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.469999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 457.582,
      "heapDeltaBytes": 5423100,
      "heapUsedBytes": 70985968,
      "domNodes": 20,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 6.889000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1998.2859999999505,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 52.443000000000005,
      "layouts": 12,
      "layoutDurationMs": 3.915,
      "taskDurationMs": 1067.8139999999999,
      "heapDeltaBytes": -16884028,
      "heapUsedBytes": 48523992,
      "domNodes": -281,
      "jsHeapTotalBytes": 22908928,
      "scriptDurationMs": 122.799,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1789.1949999999497,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 34.986000000000004,
      "layouts": 12,
      "layoutDurationMs": 3.7190000000000003,
      "taskDurationMs": 827.356,
      "heapDeltaBytes": 31604,
      "heapUsedBytes": 65225640,
      "domNodes": 56,
      "jsHeapTotalBytes": 25169920,
      "scriptDurationMs": 101.53899999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.2370000000028,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.215000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.6610000000000001,
      "taskDurationMs": 418.12899999999996,
      "heapDeltaBytes": 8252320,
      "heapUsedBytes": 73534052,
      "domNodes": 77,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 12.587,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.8160000000425,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.942000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.6000000000000001,
      "taskDurationMs": 362.49399999999997,
      "heapDeltaBytes": 8425140,
      "heapUsedBytes": 74203704,
      "domNodes": 78,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 9.286999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 593.447000000026,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.239,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.526,
      "heapDeltaBytes": -10723544,
      "heapUsedBytes": 54804732,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 55.263999999999996,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 576.6780000000153,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 364.96599999999995,
      "heapDeltaBytes": -11361852,
      "heapUsedBytes": 53956864,
      "domNodes": 20,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 51.219,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2033.7480000000028,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.268,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 701.2479999999998,
      "heapDeltaBytes": 13109772,
      "heapUsedBytes": 73217704,
      "domNodes": -281,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 17.980999999999998,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2013.8520000000426,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.678000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 582.679,
      "heapDeltaBytes": 9123756,
      "heapUsedBytes": 69345720,
      "domNodes": -282,
      "jsHeapTotalBytes": 2719744,
      "scriptDurationMs": 13.373999999999997,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2169.488000000001,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.665999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1200.793,
      "heapDeltaBytes": 7328556,
      "heapUsedBytes": 68456880,
      "domNodes": -285,
      "jsHeapTotalBytes": 3436544,
      "scriptDurationMs": 306.428,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2127.8389999999945,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.810000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1140.689,
      "heapDeltaBytes": 8123640,
      "heapUsedBytes": 69157448,
      "domNodes": -283,
      "jsHeapTotalBytes": 3174400,
      "scriptDurationMs": 298.35699999999997,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3178.86900000002,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.203000000000001,
      "layouts": 60,
      "layoutDurationMs": 8.597000000000001,
      "taskDurationMs": 1421.962,
      "heapDeltaBytes": -3713180,
      "heapUsedBytes": 58231168,
      "domNodes": -287,
      "jsHeapTotalBytes": 2981888,
      "scriptDurationMs": 382.625,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3181.3589999999294,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.731000000000002,
      "layouts": 60,
      "layoutDurationMs": 8.136,
      "taskDurationMs": 1406.803,
      "heapDeltaBytes": -3738728,
      "heapUsedBytes": 58248556,
      "domNodes": -288,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 387.709,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.6589999999956,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.9479999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 675.7289999999999,
      "heapDeltaBytes": 13079136,
      "heapUsedBytes": 73761884,
      "domNodes": -281,
      "jsHeapTotalBytes": 2719744,
      "scriptDurationMs": 16.798000000000002,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.3860000000777,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.045000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.969,
      "heapDeltaBytes": 12811704,
      "heapUsedBytes": 73844432,
      "domNodes": -282,
      "jsHeapTotalBytes": 2981888,
      "scriptDurationMs": 14.666000000000006,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 603.3329999999637,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.391,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.69100000000003,
      "heapDeltaBytes": -10008868,
      "heapUsedBytes": 55604124,
      "domNodes": 16,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 120.34800000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 594.4650000000138,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.541999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.50399999999996,
      "heapDeltaBytes": -9991300,
      "heapUsedBytes": 55729720,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 120.709,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.1690000000003,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.182000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 536.728,
      "heapDeltaBytes": 5562800,
      "heapUsedBytes": 71126988,
      "domNodes": 16,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 8.785000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.6089999999358,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.798,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.643,
      "heapDeltaBytes": 5480136,
      "heapUsedBytes": 71141280,
      "domNodes": 18,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 5.856000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.4059999999918,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 38.786,
      "layouts": 16,
      "layoutDurationMs": 4.9559999999999995,
      "taskDurationMs": 782.255,
      "heapDeltaBytes": -3336684,
      "heapUsedBytes": 62258120,
      "domNodes": 61,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 86.94600000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1711.1169999999447,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.211999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.26,
      "taskDurationMs": 718.523,
      "heapDeltaBytes": -3281848,
      "heapUsedBytes": 62108388,
      "domNodes": 62,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 75.72,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.555999999975,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 29.397000000000006,
      "layouts": 15,
      "layoutDurationMs": 11.625999999999998,
      "taskDurationMs": 923.6119999999999,
      "heapDeltaBytes": -6070192,
      "heapUsedBytes": 80949992,
      "domNodes": 13673,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 15.843000000000004,
      "eventListeners": 2375,
      "totalBlockingTimeMs": 118,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8264.656000000003,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 41.004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4162.796,
      "heapDeltaBytes": 3420080,
      "heapUsedBytes": 64176520,
      "domNodes": -282,
      "jsHeapTotalBytes": 3436544,
      "scriptDurationMs": 953.6739999999999,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8210.873999999989,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 39.897,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3874.8530000000005,
      "heapDeltaBytes": 14176744,
      "heapUsedBytes": 74660536,
      "domNodes": -281,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 918,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18363.632999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17522.496,
      "heapDeltaBytes": -45628140,
      "heapUsedBytes": 167024932,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14884864,
      "scriptDurationMs": 117.87500000000001,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17994.72400000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16933.996,
      "heapDeltaBytes": -63056744,
      "heapUsedBytes": 167582584,
      "domNodes": -8313,
      "jsHeapTotalBytes": -13279232,
      "scriptDurationMs": 126.27,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22463.843999999994,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 21.14100000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21720.077,
      "heapDeltaBytes": -21013600,
      "heapUsedBytes": 176627312,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13639680,
      "scriptDurationMs": 409.79200000000003,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 72,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21476.682000000095,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 18.85500000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20803.557999999997,
      "heapDeltaBytes": -38564324,
      "heapUsedBytes": 172276204,
      "domNodes": -8312,
      "jsHeapTotalBytes": -12591104,
      "scriptDurationMs": 390.508,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 458.4340000000111,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 20.311000000000003,
      "layouts": 3,
      "layoutDurationMs": 0.6749999999999998,
      "taskDurationMs": 103.207,
      "heapDeltaBytes": 4991560,
      "heapUsedBytes": 69845612,
      "domNodes": 122,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 6.709,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.5890000000463,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 16.2,
      "layouts": 3,
      "layoutDurationMs": 0.6610000000000001,
      "taskDurationMs": 95.59899999999999,
      "heapDeltaBytes": 4973964,
      "heapUsedBytes": 69549240,
      "domNodes": 117,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 6.236000000000001,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 25, 2026
@github-actions
github-actions Bot requested a review from thedatalife August 25, 2026 18:29
@comfy-pr-bot
comfy-pr-bot merged commit 240ea28 into cloud/1.51 Aug 25, 2026
83 of 86 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14998-to-cloud-1.51 branch August 25, 2026 18:44
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...platform/cloud/onboarding/onboardingCloudRoutes.ts 0.00% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.51   #15912   +/-   ##
=============================================
  Coverage              ?   81.59%           
=============================================
  Files                 ?     1885           
  Lines                 ?   117846           
  Branches              ?    37282           
=============================================
  Hits                  ?    96159           
  Misses                ?    21216           
  Partials              ?      471           
Flag Coverage Δ
unit 73.20% <92.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...cloud/onboarding/CloudSubscriptionRedirectView.vue 95.23% <100.00%> (ø)
...bscription/composables/usePricingTableUrlLoader.ts 98.64% <100.00%> (ø)
...platform/cloud/onboarding/onboardingCloudRoutes.ts 51.35% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants