Repository navigation
[backport cloud/1.52] fix(billing): use user-scoped auth header for customer endpoints - #15910
Conversation
) ## Why this is needed Users who sign in with a **Comfy API key** (no Firebase session) cannot use any user-scoped billing surface: credit balance never loads, credit purchase fails, and the usage/events feed errors out. The same flows work fine for Firebase-authenticated users. ## Root cause The user-scoped `/customers/*` endpoints accept either a Firebase ID token (`Authorization: Bearer …`) or a Comfy API key (`X-API-KEY`) — the backend resolves the user identity from whichever credential is presented. But on the frontend, most call sites requested **only** the Firebase header: - `authStore.fetchBalance()` → `getFirebaseAuthHeader()` → returns `null` for API-key sessions → throws `userNotAuthenticated` - `authStore.addCredits()` → same - `customerEventsService.fetchEvents()` → same → "Authentication header is missing" Only `createCustomer()` had an inline API-key fallback, so the customer record could be created, but every subsequent user-scoped call failed. The credential choice was duplicated ad hoc per call site instead of being defined once. ## How we change it Add one auth-header accessor on `authStore` that encodes the credential rule for user-scoped endpoints, and use it at every user-scoped call site: ```ts const getUserAuthHeader = async (): Promise<AuthHeader | null> => currentUser.value === null ? useApiKeyAuthStore().getAuthHeader() // API-key session → X-API-KEY : await getFirebaseAuthHeader() // signed-in session → Firebase token ``` - `fetchBalance`, `addCredits`, `createCustomer`, `accessBillingPortal`, and `customerEventsService` now all go through `getUserAuthHeader()`. - No frontend-derived identity or state: the frontend only forwards the stored credential; the server keeps deciding whose balance/events/purchase it is. - Workspace-scoped calls are untouched — this helper is never a workspace token. ## AS IS API-key session: the balance/customer calls fail with a missing auth header, so the app treats the session as unauthenticated and bounces the user back to the login dialog.  ## TO BE Same API-key session: user popover renders as authenticated and the credit balance loads (served by the backend from the `X-API-KEY` credential).  ## Tests - New unit tests: API-key session sends `X-API-KEY` for `fetchBalance` / `initiateCreditPurchase`, Firebase token still preferred when signed in, and `userNotAuthenticated` is thrown when neither credential exists (`src/stores/authStore.test.ts`). - `customerEventsService.test.ts` updated to cover the shared accessor. - `accessBillingPortal` covered both ways: an API-key session sends `X-API-KEY` to `POST /customers/billing`, and `userNotAuthenticated` is still thrown when neither credential exists. Without it, Invoice History and Manage billing in the Credits panel stayed unreachable for API-key sessions even though the backend accepts the key there. - 127/127 tests pass across both touched suites.
🎭 Playwright: ✅ 1980 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-25T17:51:11.286Z",
"gitSha": "c9bfe8ed58dbb358f0d52abc9da41c31408748ca",
"branch": "backport-15891-to-cloud-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2171.1010000000215,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.124999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 719.0040000000001,
"heapDeltaBytes": 11655100,
"heapUsedBytes": 73826980,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 12.06,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2032.58500000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.393999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.779,
"heapDeltaBytes": -6570436,
"heapUsedBytes": 54784976,
"domNodes": -283,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.099999999999998,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1886.7739999999458,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.852,
"layouts": 12,
"layoutDurationMs": 3.5460000000000007,
"taskDurationMs": 929.9300000000002,
"heapDeltaBytes": 9635588,
"heapUsedBytes": 72517928,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 118.252,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.1030000000383,
"styleRecalcs": 74,
"styleRecalcDurationMs": 38.536,
"layouts": 12,
"layoutDurationMs": 3.698,
"taskDurationMs": 918.0469999999999,
"heapDeltaBytes": 6669944,
"heapUsedBytes": 69639676,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 118.95199999999998,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.0209999999797,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.518,
"layouts": 6,
"layoutDurationMs": 0.826,
"taskDurationMs": 426.24899999999997,
"heapDeltaBytes": 3430480,
"heapUsedBytes": 65295408,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.601999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.114999999967,
"styleRecalcs": 29,
"styleRecalcDurationMs": 17.057000000000002,
"layouts": 6,
"layoutDurationMs": 0.6190000000000002,
"taskDurationMs": 384.5200000000001,
"heapDeltaBytes": 3224288,
"heapUsedBytes": 65920272,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.105,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 606.9240000000491,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.779,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.70799999999997,
"heapDeltaBytes": 11052680,
"heapUsedBytes": 73207876,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 59.492000000000004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 590.375999999992,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.443000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.46900000000005,
"heapDeltaBytes": 10837668,
"heapUsedBytes": 73852912,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 56.849999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2073.0720000000247,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.321000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.506,
"heapDeltaBytes": -1501236,
"heapUsedBytes": 75696420,
"domNodes": -271,
"jsHeapTotalBytes": -1314816,
"scriptDurationMs": 19.727999999999998,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.6240000000034,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.704,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.917,
"heapDeltaBytes": -13340144,
"heapUsedBytes": 63810352,
"domNodes": -281,
"jsHeapTotalBytes": 4452352,
"scriptDurationMs": 17.445000000000004,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2245.443000000023,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.671000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1292.1000000000001,
"heapDeltaBytes": -13950552,
"heapUsedBytes": 63946348,
"domNodes": -284,
"jsHeapTotalBytes": 1568768,
"scriptDurationMs": 349.95500000000004,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2331.437000000051,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.784999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1322.0829999999999,
"heapDeltaBytes": 12716656,
"heapUsedBytes": 89612924,
"domNodes": -285,
"jsHeapTotalBytes": 4415488,
"scriptDurationMs": 371.489,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3295.7460000000083,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.777,
"layouts": 60,
"layoutDurationMs": 8.032000000000002,
"taskDurationMs": 1497.915,
"heapDeltaBytes": -6908456,
"heapUsedBytes": 72335844,
"domNodes": -287,
"jsHeapTotalBytes": 5500928,
"scriptDurationMs": 407.06399999999996,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3262.945000000059,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.195,
"layouts": 60,
"layoutDurationMs": 7.817999999999999,
"taskDurationMs": 1453.755,
"heapDeltaBytes": -8492668,
"heapUsedBytes": 70948952,
"domNodes": -285,
"jsHeapTotalBytes": 5238784,
"scriptDurationMs": 405.75899999999996,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2623.7239999999247,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.512999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1594.5430000000001,
"heapDeltaBytes": -23389316,
"heapUsedBytes": 63801652,
"domNodes": -252,
"jsHeapTotalBytes": 4976640,
"scriptDurationMs": 525.599,
"eventListeners": 31,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2544.646000000057,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.308000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1492.8760000000002,
"heapDeltaBytes": 11792200,
"heapUsedBytes": 96378740,
"domNodes": 12,
"jsHeapTotalBytes": 7794688,
"scriptDurationMs": 471.90599999999995,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.4260000000013,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.086000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.4769999999999,
"heapDeltaBytes": -11613668,
"heapUsedBytes": 71884972,
"domNodes": -283,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 18.815999999999995,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.582000000015,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.869999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.267,
"heapDeltaBytes": -12234516,
"heapUsedBytes": 73132672,
"domNodes": -280,
"jsHeapTotalBytes": 4190208,
"scriptDurationMs": 16.895999999999997,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.0869999999923,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.841999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.57599999999996,
"heapDeltaBytes": 11691248,
"heapUsedBytes": 74142412,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 120.813,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.4529999999877,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.718,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.083,
"heapDeltaBytes": 11929976,
"heapUsedBytes": 74221828,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 121.1,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.6830000000764,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.601,
"heapDeltaBytes": 16612416,
"heapUsedBytes": 79369096,
"domNodes": -280,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.857000000000001,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.4590000000262,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.851999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.806,
"heapDeltaBytes": 18058760,
"heapUsedBytes": 80892064,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.212,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.668000000037,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.626,
"layouts": 16,
"layoutDurationMs": 4.599000000000001,
"taskDurationMs": 853.707,
"heapDeltaBytes": 5492632,
"heapUsedBytes": 67996352,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 91.199,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.0650000000114,
"styleRecalcs": 73,
"styleRecalcDurationMs": 39.201,
"layouts": 16,
"layoutDurationMs": 4.718,
"taskDurationMs": 882.311,
"heapDeltaBytes": 13217668,
"heapUsedBytes": 75976516,
"domNodes": -285,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 95.62100000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.4549999999417,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.66599999999999,
"layouts": 14,
"layoutDurationMs": 15.185999999999998,
"taskDurationMs": 1015.446,
"heapDeltaBytes": -5941912,
"heapUsedBytes": 83359540,
"domNodes": 13673,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 18.833999999999996,
"eventListeners": 2373,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8762.63700000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4574.8,
"heapDeltaBytes": -4814592,
"heapUsedBytes": 71311016,
"domNodes": -280,
"jsHeapTotalBytes": 4677632,
"scriptDurationMs": 1100.792,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8413.828999999965,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.275999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4380.736,
"heapDeltaBytes": -5208740,
"heapUsedBytes": 71216680,
"domNodes": -283,
"jsHeapTotalBytes": 5201920,
"scriptDurationMs": 1109.1519999999998,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18056.065999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17088.746,
"heapDeltaBytes": -34450820,
"heapUsedBytes": 178166564,
"domNodes": -8312,
"jsHeapTotalBytes": -15507456,
"scriptDurationMs": 120.31099999999999,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17409.28900000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16747.537,
"heapDeltaBytes": -42371168,
"heapUsedBytes": 176253856,
"domNodes": -8312,
"jsHeapTotalBytes": -23814144,
"scriptDurationMs": 111.719,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21037.58000000005,
"styleRecalcs": 173,
"styleRecalcDurationMs": 19.254000000000048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20497.244000000002,
"heapDeltaBytes": -22513840,
"heapUsedBytes": 193464772,
"domNodes": -8312,
"jsHeapTotalBytes": -12152832,
"scriptDurationMs": 416.356,
"eventListeners": -16385,
"totalBlockingTimeMs": 89,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20719.329000000016,
"styleRecalcs": 161,
"styleRecalcDurationMs": 18.635999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20192.96,
"heapDeltaBytes": -19365924,
"heapUsedBytes": 193146604,
"domNodes": -8312,
"jsHeapTotalBytes": -15577088,
"scriptDurationMs": 450.6000000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 143,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 487.9639999999199,
"styleRecalcs": 16,
"styleRecalcDurationMs": 23.814,
"layouts": 3,
"layoutDurationMs": 1.347,
"taskDurationMs": 128.132,
"heapDeltaBytes": 5277132,
"heapUsedBytes": 66747188,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.421,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 465.25999999994383,
"styleRecalcs": 11,
"styleRecalcDurationMs": 18.683,
"layouts": 3,
"layoutDurationMs": 0.5720000000000001,
"taskDurationMs": 106.09299999999999,
"heapDeltaBytes": 4989580,
"heapUsedBytes": 67539956,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.9190000000000005,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.52 #15910 +/- ##
=============================================
Coverage ? 81.97%
=============================================
Files ? 1905
Lines ? 108721
Branches ? 30080
=============================================
Hits ? 89129
Misses ? 19254
Partials ? 338
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15891 to
cloud/1.52Automatically created by backport workflow.