Repository navigation
[backport core/1.52] fix(billing): use user-scoped auth header for customer endpoints - #15909
Conversation
) ## Why this is needed Users who sign in with a **Comfy API key** (no Firebase session) cannot use any user-scoped billing surface: credit balance never loads, credit purchase fails, and the usage/events feed errors out. The same flows work fine for Firebase-authenticated users. ## Root cause The user-scoped `/customers/*` endpoints accept either a Firebase ID token (`Authorization: Bearer …`) or a Comfy API key (`X-API-KEY`) — the backend resolves the user identity from whichever credential is presented. But on the frontend, most call sites requested **only** the Firebase header: - `authStore.fetchBalance()` → `getFirebaseAuthHeader()` → returns `null` for API-key sessions → throws `userNotAuthenticated` - `authStore.addCredits()` → same - `customerEventsService.fetchEvents()` → same → "Authentication header is missing" Only `createCustomer()` had an inline API-key fallback, so the customer record could be created, but every subsequent user-scoped call failed. The credential choice was duplicated ad hoc per call site instead of being defined once. ## How we change it Add one auth-header accessor on `authStore` that encodes the credential rule for user-scoped endpoints, and use it at every user-scoped call site: ```ts const getUserAuthHeader = async (): Promise<AuthHeader | null> => currentUser.value === null ? useApiKeyAuthStore().getAuthHeader() // API-key session → X-API-KEY : await getFirebaseAuthHeader() // signed-in session → Firebase token ``` - `fetchBalance`, `addCredits`, `createCustomer`, `accessBillingPortal`, and `customerEventsService` now all go through `getUserAuthHeader()`. - No frontend-derived identity or state: the frontend only forwards the stored credential; the server keeps deciding whose balance/events/purchase it is. - Workspace-scoped calls are untouched — this helper is never a workspace token. ## AS IS API-key session: the balance/customer calls fail with a missing auth header, so the app treats the session as unauthenticated and bounces the user back to the login dialog.  ## TO BE Same API-key session: user popover renders as authenticated and the credit balance loads (served by the backend from the `X-API-KEY` credential).  ## Tests - New unit tests: API-key session sends `X-API-KEY` for `fetchBalance` / `initiateCreditPurchase`, Firebase token still preferred when signed in, and `userNotAuthenticated` is thrown when neither credential exists (`src/stores/authStore.test.ts`). - `customerEventsService.test.ts` updated to cover the shared accessor. - `accessBillingPortal` covered both ways: an API-key session sends `X-API-KEY` to `POST /customers/billing`, and `userNotAuthenticated` is still thrown when neither credential exists. Without it, Invoice History and Manage billing in the Credits panel stayed unreachable for API-key sessions even though the backend accepts the key there. - 127/127 tests pass across both touched suites.
🎭 Playwright: ✅ 1982 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-25T17:51:05.206Z",
"gitSha": "9435677e7971b30a87cedc9c1bb9681f47bad118",
"branch": "backport-15891-to-core-1.52",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.3680000000345,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.531,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.7850000000001,
"heapDeltaBytes": 20692688,
"heapUsedBytes": 81912156,
"domNodes": -283,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.298000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2074.2190000000846,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.054,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.78200000000004,
"heapDeltaBytes": 16557996,
"heapUsedBytes": 78729572,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.4510000000000005,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1783.444999999972,
"styleRecalcs": 72,
"styleRecalcDurationMs": 33.281,
"layouts": 12,
"layoutDurationMs": 3.1710000000000003,
"taskDurationMs": 814.583,
"heapDeltaBytes": 16633424,
"heapUsedBytes": 79499120,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 105.883,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.4890000000069,
"styleRecalcs": 71,
"styleRecalcDurationMs": 31.378999999999998,
"layouts": 12,
"layoutDurationMs": 3.1979999999999995,
"taskDurationMs": 812.0430000000001,
"heapDeltaBytes": -2344428,
"heapUsedBytes": 59905936,
"domNodes": -281,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 105.45599999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.1189999999806,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.895999999999999,
"layouts": 6,
"layoutDurationMs": 0.551,
"taskDurationMs": 338.584,
"heapDeltaBytes": 3309284,
"heapUsedBytes": 65877084,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.402,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.7880000000505,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.383999999999999,
"layouts": 6,
"layoutDurationMs": 0.6339999999999999,
"taskDurationMs": 347.537,
"heapDeltaBytes": 2820356,
"heapUsedBytes": 64545932,
"domNodes": 75,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.644,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 569.3600000000174,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.4479999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.397,
"heapDeltaBytes": 10635476,
"heapUsedBytes": 73429504,
"domNodes": 18,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 53.909000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 598.2320000000527,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.351999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.397,
"heapDeltaBytes": 10955516,
"heapUsedBytes": 73549652,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 53.825,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.134000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.829999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 600.49,
"heapDeltaBytes": -4710776,
"heapUsedBytes": 72469872,
"domNodes": -272,
"jsHeapTotalBytes": -1839104,
"scriptDurationMs": 17.363,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2087.7139999998917,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.844999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.352,
"heapDeltaBytes": -3071192,
"heapUsedBytes": 74020184,
"domNodes": -272,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 14.767,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2148.116000000016,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.390000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1153.199,
"heapDeltaBytes": -8648220,
"heapUsedBytes": 69269804,
"domNodes": -277,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 319.29400000000004,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2165.8279999999195,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1182.15,
"heapDeltaBytes": 11914724,
"heapUsedBytes": 89152440,
"domNodes": -285,
"jsHeapTotalBytes": 4415488,
"scriptDurationMs": 328.397,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3159.423000000004,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.078000000000001,
"layouts": 60,
"layoutDurationMs": 7.106,
"taskDurationMs": 1409.0320000000002,
"heapDeltaBytes": 17722004,
"heapUsedBytes": 81100844,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 437.44,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3149.6270000000095,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.576000000000004,
"layouts": 60,
"layoutDurationMs": 7.223,
"taskDurationMs": 1338.6480000000001,
"heapDeltaBytes": -1718680,
"heapUsedBytes": 77436204,
"domNodes": -277,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 388.715,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2187.490999999966,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.664000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1401.9910000000002,
"heapDeltaBytes": -15147720,
"heapUsedBytes": 69874664,
"domNodes": 12,
"jsHeapTotalBytes": 7114752,
"scriptDurationMs": 450.204,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2163.8240000000906,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.544000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1367.661,
"heapDeltaBytes": -17187944,
"heapUsedBytes": 69909088,
"domNodes": 10,
"jsHeapTotalBytes": 8425472,
"scriptDurationMs": 434.749,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.3919999999594,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.671,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.934,
"heapDeltaBytes": -12509424,
"heapUsedBytes": 72688456,
"domNodes": -281,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 12.608999999999998,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2063.5300000000143,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.221999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.463,
"heapDeltaBytes": -10272344,
"heapUsedBytes": 75138668,
"domNodes": -271,
"jsHeapTotalBytes": 1830912,
"scriptDurationMs": 14.605,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.9150000000045,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.454,
"heapDeltaBytes": 11524380,
"heapUsedBytes": 74230908,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 121.57300000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.9580000000087,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.498,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.42300000000006,
"heapDeltaBytes": 11546320,
"heapUsedBytes": 74443684,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 114.58900000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.8909999999864,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.41,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.18000000000006,
"heapDeltaBytes": -4816572,
"heapUsedBytes": 57937648,
"domNodes": -280,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5.835000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2055.609000000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.503999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.981,
"heapDeltaBytes": -6795716,
"heapUsedBytes": 55732496,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.804000000000002,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.957000000033,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.189,
"layouts": 16,
"layoutDurationMs": 4.428999999999999,
"taskDurationMs": 770.519,
"heapDeltaBytes": 17651076,
"heapUsedBytes": 80559348,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 81.28,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.3410000000285,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.412,
"layouts": 16,
"layoutDurationMs": 4.577,
"taskDurationMs": 791.487,
"heapDeltaBytes": 18945656,
"heapUsedBytes": 81740736,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 86.226,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.3829999999807,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.862000000000002,
"layouts": 15,
"layoutDurationMs": 14.284,
"taskDurationMs": 867.9159999999997,
"heapDeltaBytes": -2212468,
"heapUsedBytes": 96347792,
"domNodes": 13673,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 14.872999999999998,
"eventListeners": 2373,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8231.086999999945,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.662000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4145.561,
"heapDeltaBytes": 3972428,
"heapUsedBytes": 81243660,
"domNodes": -274,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 1089.032,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8196.875999999975,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3996.1940000000004,
"heapDeltaBytes": 8131480,
"heapUsedBytes": 85264988,
"domNodes": -272,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 1029.267,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16662.49300000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15543.959,
"heapDeltaBytes": -45941848,
"heapUsedBytes": 180853320,
"domNodes": -8312,
"jsHeapTotalBytes": -13676544,
"scriptDurationMs": 103.22999999999999,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16618.298999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15463.305999999999,
"heapDeltaBytes": -31281428,
"heapUsedBytes": 181071164,
"domNodes": -8312,
"jsHeapTotalBytes": -12623872,
"scriptDurationMs": 95.52100000000002,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 19896.959999999977,
"styleRecalcs": 166,
"styleRecalcDurationMs": 15.639000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19435.765999999996,
"heapDeltaBytes": -18214540,
"heapUsedBytes": 194111288,
"domNodes": -8316,
"jsHeapTotalBytes": -18984960,
"scriptDurationMs": 391.668,
"eventListeners": -16388,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19988.105000000018,
"styleRecalcs": 162,
"styleRecalcDurationMs": 15.47799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19498.717,
"heapDeltaBytes": -25216944,
"heapUsedBytes": 192991604,
"domNodes": -8312,
"jsHeapTotalBytes": -21176320,
"scriptDurationMs": 389.498,
"eventListeners": -16387,
"totalBlockingTimeMs": 52,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 108.65400000000136,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.999,
"layouts": 6,
"layoutDurationMs": 1.4529999999999998,
"taskDurationMs": 78.60499999999999,
"heapDeltaBytes": 3153148,
"heapUsedBytes": 64892412,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.685,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 455.5769999999484,
"styleRecalcs": 14,
"styleRecalcDurationMs": 18.998,
"layouts": 3,
"layoutDurationMs": 0.5990000000000001,
"taskDurationMs": 107.97099999999999,
"heapDeltaBytes": 4982896,
"heapUsedBytes": 67382344,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.215999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.52 #15909 +/- ##
=============================================
- Coverage 81.97% 81.97% -0.01%
=============================================
Files 1905 1905
Lines 108679 108716 +37
Branches 30355 30365 +10
=============================================
+ Hits 89086 89115 +29
- Misses 19259 19266 +7
- Partials 334 335 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15891 to
core/1.52Automatically created by backport workflow.