Repository navigation
[backport core/1.51] fix(billing): use user-scoped auth header for customer endpoints - #15907
Conversation
) ## Why this is needed Users who sign in with a **Comfy API key** (no Firebase session) cannot use any user-scoped billing surface: credit balance never loads, credit purchase fails, and the usage/events feed errors out. The same flows work fine for Firebase-authenticated users. ## Root cause The user-scoped `/customers/*` endpoints accept either a Firebase ID token (`Authorization: Bearer …`) or a Comfy API key (`X-API-KEY`) — the backend resolves the user identity from whichever credential is presented. But on the frontend, most call sites requested **only** the Firebase header: - `authStore.fetchBalance()` → `getFirebaseAuthHeader()` → returns `null` for API-key sessions → throws `userNotAuthenticated` - `authStore.addCredits()` → same - `customerEventsService.fetchEvents()` → same → "Authentication header is missing" Only `createCustomer()` had an inline API-key fallback, so the customer record could be created, but every subsequent user-scoped call failed. The credential choice was duplicated ad hoc per call site instead of being defined once. ## How we change it Add one auth-header accessor on `authStore` that encodes the credential rule for user-scoped endpoints, and use it at every user-scoped call site: ```ts const getUserAuthHeader = async (): Promise<AuthHeader | null> => currentUser.value === null ? useApiKeyAuthStore().getAuthHeader() // API-key session → X-API-KEY : await getFirebaseAuthHeader() // signed-in session → Firebase token ``` - `fetchBalance`, `addCredits`, `createCustomer`, `accessBillingPortal`, and `customerEventsService` now all go through `getUserAuthHeader()`. - No frontend-derived identity or state: the frontend only forwards the stored credential; the server keeps deciding whose balance/events/purchase it is. - Workspace-scoped calls are untouched — this helper is never a workspace token. ## AS IS API-key session: the balance/customer calls fail with a missing auth header, so the app treats the session as unauthenticated and bounces the user back to the login dialog.  ## TO BE Same API-key session: user popover renders as authenticated and the credit balance loads (served by the backend from the `X-API-KEY` credential).  ## Tests - New unit tests: API-key session sends `X-API-KEY` for `fetchBalance` / `initiateCreditPurchase`, Firebase token still preferred when signed in, and `userNotAuthenticated` is thrown when neither credential exists (`src/stores/authStore.test.ts`). - `customerEventsService.test.ts` updated to cover the shared accessor. - `accessBillingPortal` covered both ways: an API-key session sends `X-API-KEY` to `POST /customers/billing`, and `userNotAuthenticated` is still thrown when neither credential exists. Without it, Invoice History and Manage billing in the Credits panel stayed unreachable for API-key sessions even though the backend accepts the key there. - 127/127 tests pass across both touched suites.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1832 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-25T17:49:35.560Z",
"gitSha": "4d21c76c691e2c066195f2394d777b56446a3a88",
"branch": "backport-15891-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.468999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.326999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.594,
"heapDeltaBytes": 4985932,
"heapUsedBytes": 70248232,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.614000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1990.4050000000097,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.198000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.51499999999993,
"heapDeltaBytes": 5063544,
"heapUsedBytes": 70541440,
"domNodes": 22,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 6.409,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1865.63000000001,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.293,
"layouts": 12,
"layoutDurationMs": 2.972,
"taskDurationMs": 852.2679999999999,
"heapDeltaBytes": -17999208,
"heapUsedBytes": 47230472,
"domNodes": -280,
"jsHeapTotalBytes": 24481792,
"scriptDurationMs": 83.03399999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.4219999999705,
"styleRecalcs": 73,
"styleRecalcDurationMs": 25.215,
"layouts": 12,
"layoutDurationMs": 2.8320000000000003,
"taskDurationMs": 614.3109999999999,
"heapDeltaBytes": -18226676,
"heapUsedBytes": 47250712,
"domNodes": -279,
"jsHeapTotalBytes": 23171072,
"scriptDurationMs": 79.83399999999999,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1662.5470000000178,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.672,
"layouts": 6,
"layoutDurationMs": 0.502,
"taskDurationMs": 316.74499999999995,
"heapDeltaBytes": 8118524,
"heapUsedBytes": 73574752,
"domNodes": 79,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 8.428999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.9040000000687,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.438999999999998,
"layouts": 6,
"layoutDurationMs": 0.57,
"taskDurationMs": 317.119,
"heapDeltaBytes": 8430372,
"heapUsedBytes": 73977616,
"domNodes": 77,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 8.221999999999998,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 498.27199999998584,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.918,
"heapDeltaBytes": -12796992,
"heapUsedBytes": 52622964,
"domNodes": 20,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 38.916,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 518.5149999999794,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.332999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.203,
"heapDeltaBytes": -11821516,
"heapUsedBytes": 53618988,
"domNodes": 22,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 40.352,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2015.2059999999778,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.612,
"heapDeltaBytes": 12465724,
"heapUsedBytes": 72774260,
"domNodes": -283,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 14.310999999999998,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.7009999999746,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.119999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.913,
"heapDeltaBytes": 12471164,
"heapUsedBytes": 72996388,
"domNodes": -284,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 11.681999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2094.6929999999497,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.554,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 937.4970000000001,
"heapDeltaBytes": 22265624,
"heapUsedBytes": 84139808,
"domNodes": -283,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 237.90400000000002,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2099.0880000000516,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.565999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 915.8329999999999,
"heapDeltaBytes": -2160332,
"heapUsedBytes": 59022624,
"domNodes": -284,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 229.88799999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3085.6359999999654,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.28,
"layouts": 60,
"layoutDurationMs": 6.599000000000001,
"taskDurationMs": 1081.864,
"heapDeltaBytes": 16542068,
"heapUsedBytes": 79344580,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 281.357,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3074.4110000000546,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.025999999999998,
"layouts": 60,
"layoutDurationMs": 6.930000000000001,
"taskDurationMs": 1058.922,
"heapDeltaBytes": 16546204,
"heapUsedBytes": 79229488,
"domNodes": 12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 278.384,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.505999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.795000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.489,
"heapDeltaBytes": 9358308,
"heapUsedBytes": 70820104,
"domNodes": -285,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 13.809999999999995,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2007.107000000019,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.635999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.232,
"heapDeltaBytes": 12126532,
"heapUsedBytes": 73253172,
"domNodes": -282,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 10.358999999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.2889999999675,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.3100000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.57800000000003,
"heapDeltaBytes": -9948772,
"heapUsedBytes": 55579704,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 83.679,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.6400000000622,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.778999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.407,
"heapDeltaBytes": -9919612,
"heapUsedBytes": 55588000,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 88.521,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.4629999999593,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.365,
"heapDeltaBytes": 5630732,
"heapUsedBytes": 71099396,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 5.6720000000000015,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.4969999999812,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.107000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.207,
"heapDeltaBytes": 5510556,
"heapUsedBytes": 71134632,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 5.71,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.1929999999793,
"styleRecalcs": 76,
"styleRecalcDurationMs": 25.851000000000003,
"layouts": 16,
"layoutDurationMs": 3.184,
"taskDurationMs": 590.303,
"heapDeltaBytes": -3819956,
"heapUsedBytes": 61696948,
"domNodes": 62,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 58.343999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.5650000000214,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.307,
"layouts": 16,
"layoutDurationMs": 3.589,
"taskDurationMs": 615.9830000000001,
"heapDeltaBytes": -3776416,
"heapUsedBytes": 61804536,
"domNodes": 62,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 58.488,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.0420000000086,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.169999999999998,
"layouts": 15,
"layoutDurationMs": 8.985999999999999,
"taskDurationMs": 734.5110000000001,
"heapDeltaBytes": -4057624,
"heapUsedBytes": 79666556,
"domNodes": 13673,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 11.875999999999998,
"eventListeners": 2373,
"totalBlockingTimeMs": 113,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8101.895999999953,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.029,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3257.165,
"heapDeltaBytes": 13399684,
"heapUsedBytes": 73957960,
"domNodes": -282,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 756.173,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8105.820999999992,
"styleRecalcs": 249,
"styleRecalcDurationMs": 25.978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3208.232,
"heapDeltaBytes": 14848224,
"heapUsedBytes": 75781556,
"domNodes": -284,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 718.3149999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12572.451999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11713.618,
"heapDeltaBytes": -30061244,
"heapUsedBytes": 167303376,
"domNodes": -8316,
"jsHeapTotalBytes": -14622720,
"scriptDurationMs": 86.559,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12521.208999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11496.604,
"heapDeltaBytes": -23981464,
"heapUsedBytes": 173694740,
"domNodes": -8312,
"jsHeapTotalBytes": -3579904,
"scriptDurationMs": 65.875,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16101.389999999981,
"styleRecalcs": 100,
"styleRecalcDurationMs": 15.076000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15350.998000000001,
"heapDeltaBytes": -25411608,
"heapUsedBytes": 172257804,
"domNodes": -8316,
"jsHeapTotalBytes": -13115392,
"scriptDurationMs": 390.23,
"eventListeners": -16385,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15326.622000000043,
"styleRecalcs": 79,
"styleRecalcDurationMs": 13.39399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14525.321000000002,
"heapDeltaBytes": -24982376,
"heapUsedBytes": 173002472,
"domNodes": -8312,
"jsHeapTotalBytes": -10203136,
"scriptDurationMs": 346.66,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 434.3629999999621,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.548999999999998,
"layouts": 2,
"layoutDurationMs": 0.3109999999999999,
"taskDurationMs": 84.24600000000001,
"heapDeltaBytes": 4996424,
"heapUsedBytes": 69460736,
"domNodes": 128,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5.457,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 449.41399999993337,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.855,
"layouts": 3,
"layoutDurationMs": 0.694,
"taskDurationMs": 90.02,
"heapDeltaBytes": 4961760,
"heapUsedBytes": 69508432,
"domNodes": 123,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6.199000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.51 #15907 +/- ##
===========================================
Coverage 81.68% 81.69%
===========================================
Files 1885 1885
Lines 107199 107236 +37
Branches 29808 29349 -459
===========================================
+ Hits 87565 87603 +38
+ Misses 19299 19289 -10
- Partials 335 344 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15891 to
core/1.51Automatically created by backport workflow.