Repository navigation
[chore] Restore bot-projected ingest types - #15878
Conversation
#15802 regenerated packages/ingest-types by running the generator locally instead of taking the pipeline's output. openapi-ts.config.ts only excludes the webhook and internal rails, while the push-ingest-types-to-frontend pipeline also strips x-internal and the admin rails, so the local run added 43 admin references and 24 admin paths that the projection had never carried. Restores the generated files to their state before that PR. The billing capability contract is unaffected: rollout_defaults_applied, revision and expires_at all predate #15802, and cloud has had no openapi.yaml commits since the projection was taken.
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 1999 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.34 MB gzip 🟢 -1.91 kBDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 591 kB (baseline 591 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 112 kB (baseline 112 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.44 MB (baseline 3.45 MB) • 🟢 -9.88 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 15.1 MB (baseline 15.1 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 220 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-25T04:44:13.943Z",
"gitSha": "ce66270ec0407767ef53194e167a64495c43099b",
"branch": "wei/restore-bot-projected-ingest-types",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2101.4729999999986,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.193000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.6419999999999,
"heapDeltaBytes": 5745460,
"heapUsedBytes": 74557444,
"domNodes": -284,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 13.557999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2041.8819999999869,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.369999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.7489999999999,
"heapDeltaBytes": 12707472,
"heapUsedBytes": 81454652,
"domNodes": -288,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.914,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2212.3169999999845,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.26199999999999,
"layouts": 12,
"layoutDurationMs": 3.4560000000000004,
"taskDurationMs": 1220.863,
"heapDeltaBytes": -5136492,
"heapUsedBytes": 57003620,
"domNodes": -284,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 150.458,
"eventListeners": -189,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2162.9349999999476,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.76100000000001,
"layouts": 12,
"layoutDurationMs": 3.76,
"taskDurationMs": 1216.1259999999997,
"heapDeltaBytes": 3198192,
"heapUsedBytes": 72071180,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 151.032,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.1430000000405,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.194,
"layouts": 6,
"layoutDurationMs": 0.625,
"taskDurationMs": 357.262,
"heapDeltaBytes": 4018840,
"heapUsedBytes": 72860380,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.549999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.7660000000496,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.557999999999996,
"layouts": 6,
"layoutDurationMs": 0.581,
"taskDurationMs": 358.64699999999993,
"heapDeltaBytes": 4102360,
"heapUsedBytes": 72998440,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.69,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 739.5370000000412,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7940000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.76000000000005,
"heapDeltaBytes": -6764796,
"heapUsedBytes": 62528392,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 31.717999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 738.1010000000288,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.2040000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.2560000000001,
"heapDeltaBytes": -6415260,
"heapUsedBytes": 62028320,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 31.179,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2072.911999999974,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.640999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.277,
"heapDeltaBytes": -17980632,
"heapUsedBytes": 72881660,
"domNodes": -271,
"jsHeapTotalBytes": -2101248,
"scriptDurationMs": 37.949999999999996,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2048.5290000000305,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.2490000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.221,
"heapDeltaBytes": -17638236,
"heapUsedBytes": 73225004,
"domNodes": -273,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 40.025000000000006,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 3277.5570000000016,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.934000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2577.9100000000003,
"heapDeltaBytes": -24129980,
"heapUsedBytes": 66934528,
"domNodes": -283,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 915.537,
"eventListeners": -181,
"totalBlockingTimeMs": 17,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3325.179999999932,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.637000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2620.858,
"heapDeltaBytes": -12684872,
"heapUsedBytes": 78395520,
"domNodes": -250,
"jsHeapTotalBytes": 3104768,
"scriptDurationMs": 926.655,
"eventListeners": -151,
"totalBlockingTimeMs": 11,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4388.689999999997,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.254999999999995,
"layouts": 60,
"layoutDurationMs": 8.027,
"taskDurationMs": 2598.5809999999997,
"heapDeltaBytes": -6793632,
"heapUsedBytes": 88718232,
"domNodes": -231,
"jsHeapTotalBytes": 3141632,
"scriptDurationMs": 878.216,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4400.004999999965,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.366999999999997,
"layouts": 60,
"layoutDurationMs": 8.351,
"taskDurationMs": 2602.671,
"heapDeltaBytes": -8301660,
"heapUsedBytes": 80654444,
"domNodes": -266,
"jsHeapTotalBytes": 5464064,
"scriptDurationMs": 873.101,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3223.2999999999947,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.518999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2075.031,
"heapDeltaBytes": 13353336,
"heapUsedBytes": 79946632,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 202.851,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3201.420999999982,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.503999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2088.597,
"heapDeltaBytes": 17073604,
"heapUsedBytes": 84815104,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 213.91700000000003,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.615999999986,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.094,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.7520000000002,
"heapDeltaBytes": -21564976,
"heapUsedBytes": 70607392,
"domNodes": -278,
"jsHeapTotalBytes": 3928064,
"scriptDurationMs": 38.691,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2051.21500000007,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.8370000000001,
"heapDeltaBytes": -21835648,
"heapUsedBytes": 70107076,
"domNodes": -277,
"jsHeapTotalBytes": 3403776,
"scriptDurationMs": 38.669999999999995,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 712.7389999999991,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.579,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.7699999999999,
"heapDeltaBytes": 17896964,
"heapUsedBytes": 87919568,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 132.931,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 711.1850000000004,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.543000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.8000000000001,
"heapDeltaBytes": 18151664,
"heapUsedBytes": 87701496,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 139.71999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.9890000000096,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.262000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.188,
"heapDeltaBytes": 13260820,
"heapUsedBytes": 82964332,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.163,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.5360000000119,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.381,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.74399999999997,
"heapDeltaBytes": -12966304,
"heapUsedBytes": 56504756,
"domNodes": -296,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.21,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1824.9700000000075,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.71,
"layouts": 16,
"layoutDurationMs": 4.719,
"taskDurationMs": 1091.186,
"heapDeltaBytes": 5497912,
"heapUsedBytes": 75122360,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.392,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1883.9150000000018,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.557,
"layouts": 16,
"layoutDurationMs": 4.351000000000001,
"taskDurationMs": 1131.99,
"heapDeltaBytes": -4559248,
"heapUsedBytes": 64988372,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 110.622,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1390.6259999999975,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.214999999999993,
"layouts": 14,
"layoutDurationMs": 13.159,
"taskDurationMs": 931.0539999999999,
"heapDeltaBytes": 19696800,
"heapUsedBytes": 102830116,
"domNodes": 13671,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 29.557,
"eventListeners": 2383,
"totalBlockingTimeMs": 125,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12502.775000000041,
"styleRecalcs": 247,
"styleRecalcDurationMs": 43.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9246.323999999999,
"heapDeltaBytes": 2008576,
"heapUsedBytes": 92347712,
"domNodes": -282,
"jsHeapTotalBytes": 4907008,
"scriptDurationMs": 3183.122,
"eventListeners": -129,
"totalBlockingTimeMs": 17,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12453.10699999993,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.096999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9431.631,
"heapDeltaBytes": -14014756,
"heapUsedBytes": 76818216,
"domNodes": -278,
"jsHeapTotalBytes": 9170944,
"scriptDurationMs": 3280.941,
"eventListeners": -129,
"totalBlockingTimeMs": 28,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18383.283000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17738.203999999998,
"heapDeltaBytes": -35921720,
"heapUsedBytes": 175015060,
"domNodes": -6548,
"jsHeapTotalBytes": -4669440,
"scriptDurationMs": 382.68499999999995,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18553.195999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17792.478,
"heapDeltaBytes": -31341368,
"heapUsedBytes": 178571496,
"domNodes": -6548,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 366.861,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22029.34099999999,
"styleRecalcs": 164,
"styleRecalcDurationMs": 20.704999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21694.51,
"heapDeltaBytes": -28228320,
"heapUsedBytes": 177354400,
"domNodes": -6548,
"jsHeapTotalBytes": 1712128,
"scriptDurationMs": 910.9540000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 110,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22259.971000000063,
"styleRecalcs": 169,
"styleRecalcDurationMs": 20.512000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21863.919,
"heapDeltaBytes": -26922084,
"heapUsedBytes": 177457656,
"domNodes": -6548,
"jsHeapTotalBytes": 774144,
"scriptDurationMs": 903.9509999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 125,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 129.36099999990347,
"styleRecalcs": 10,
"styleRecalcDurationMs": 17.567,
"layouts": 2,
"layoutDurationMs": 0.49799999999999983,
"taskDurationMs": 87.64,
"heapDeltaBytes": 3481184,
"heapUsedBytes": 70418400,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.220000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 106.66800000001331,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.416,
"layouts": 2,
"layoutDurationMs": 0.908,
"taskDurationMs": 73.834,
"heapDeltaBytes": 3294876,
"heapUsedBytes": 66458148,
"domNodes": 127,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 3.553,
"eventListeners": 27,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15878 +/- ##
==========================================
- Coverage 80.09% 80.07% -0.02%
==========================================
Files 2251 2251
Lines 114353 114256 -97
Branches 31618 31618
==========================================
- Hits 91586 91490 -96
+ Misses 22286 22276 -10
- Partials 481 490 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Browser coverage for the workspace-scope behaviour of `GET /api/billing/capabilities`. ## What this PR actually contains The stack was split after this PR was opened, and most of what the original description promised now lives elsewhere. As it stands the diff is four files: | File | What | |---|---| | `browser_tests/tests/workspaceSwitcher.spec.ts` | the scope-refetch spec — switch workspace → capabilities refetched → gated UI flips | | `browser_tests/fixtures/workspaceSwitcherFixture.ts` | derives the workspace from the Bearer token, mirroring how the real endpoint derives scope from auth | | `.storybook/main.ts` | storybook alias for the capabilities composable | | `src/locales/en/main.json` | one locale key | The capabilities fixture, the mock plumbing, and the top-up deep-link changes the old description referred to were moved into #15804. ## Why the switcher spec is the load-bearing one It pins the composable's scope-watch end to end. The fixture resolving the workspace from the Bearer token is deliberate: a fixture that trusted a workspace *parameter* would pass while the composable read the wrong scope — exactly the bug class the scope-watch exists to prevent. ## The stack | PR | What | |---|---| | #15802 | regenerate `ingest-types` — **merged** | | #15878 | restore bot-projected types | | #15803 | capabilities source + auth-gate wiring | | #15880 | expire and invalidate cached snapshots | | #15804 | migrate consumers, drop client-side policy | | #15675 | remaining capability consumers | | **this** | browser coverage | **#15804 is where rendered behaviour changes** — the rest is generated output, a dormant source, and tests. ## Regression completeness Per the audit on this PR: 10 of main's 15 billing e2e specs are untouched by the stack, and the 3 modified specs changed zero assertions — only capabilities-endpoint mocks were added, so their proof value stands. One spec changed assertions (`topUpDeepLink`, personal-owner → non-Enterprise-owner); that is an intended behaviour change and is stated in #15804's description. The two named coverage holes — seat changes and the `BillingStatusBanner` payment states — are being assessed; see the thread on this PR for the disposition.
…cy (Comfy-Org#15804) Points every Cloud billing consumer at the server-resolved capabilities composable and deletes the client-side derivation it replaces. **This is where rendered behaviour changes.** The rest of the stack was generated output, a dormant source, and tests. Three things ride together because splitting them produces a commit that does not build: - the consumer migration, - deleting the six client-side policy files (a consumer still importing them would not compile), - the top-up deep-link loader, which read `canTopUp` off `WorkspacePermissions` — a property this change removes. The loader now awaits capability initialization before reading the flags, so an eligible user does not lose the `?topup=` deep link while both are still at their initial `false`. ## Behaviour reviewers should agree to **An unsubscribed Cloud owner now sees "Add Credits" alongside "Subscribe"**, where they previously saw only "Subscribe". The old behaviour came from a client-side `topUpAccess` inference; that policy now lives server-side, and the resolver returns `can_top_up=true` for a workspace with no subscription row. The component renders what the server grants, so the guard belongs in the resolver — `cloud#7342` addresses it. Enterprise handling is preserved. `Comfy-Org#15855` landed the ENTERPRISE tier while this was in flight and modified the `billingPolicy*` files deleted here; its own description names this stack as the intended end state, with only the tier-label mapping surviving. `useWorkspaceTierLabel`'s `ENTERPRISE: 'enterprise'` and the locale key are retained and byte-identical to that PR. ## Merge checklist — rollout flags With the capability rollout flags **off**, the server returns `can_top_up=true` / `can_subscribe_self_serve=false` for every workspace: every cloud user sees "Add credits" and nobody sees the subscribe upsell. Prod runs a pinned `frontendVersion` (currently `1.51.9`), so merging here does not ship — but this must be settled before a backport reaches a `cloud/1.5x` release branch. - [x] Regenerate `@comfyorg/ingest-types` — Comfy-Org#15802, corrected by Comfy-Org#15878 to the pipeline-projected output - [x] Land `cloud#7342` — merged 2026-08-25 21:18; verified on cloud `main` - [x] Create both flags in staging (`dreamboothy-dev`) — they did not exist; created disabled at 0% mirroring prod - [ ] Validate flags-on in test-v2 — it already runs `cloud#7342` (image `16b468b`, auto-deployed by Image Updater). Note `can_downgrade_to_personal` is rollout-gated too, so downgrade CTAs stay dark until flags-on - [ ] Confirm billing-api is deployed to prod with `cloud#7342`, then set `active: true` and ramp as a canary Known residual: `can_top_up=false` still carries three meanings (not owner / free tier / no subscription), so `CreditsTile`'s `v-else` can show "Upgrade to add credits" to a member who cannot upgrade. Tracked via the proposed `top_up_denied_reason` on the `cloud#7223` discussion. ## Verification `pnpm typecheck`, `typecheck:browser`, `lint` clean. Full unit suite: **17,758 passed**; the 12 `check-binary-size` failures are pre-existing and environmental.
…gh the generated contract (#15939) Backport of #15855 to `cloud/1.52`, combined with a regeneration of the `ingest-types` package from the cloud OpenAPI spec. Enterprise is scoped to the 1.52 release per Jaewon (frontend team lead), with Wei Hai confirming Enterprise targets 1.52. **No new product sign-off is needed** — this behaviour was already reviewed and merged on `main` as #15855. ## Why regeneration and ENTERPRISE support are one commit They cannot be split into two green commits, and upstream didn't split them either: - **Regeneration alone → 3 type errors.** Regenerating widens `SubscriptionTier` with `ENTERPRISE`, which breaks two files: - `useBillingPolicyState.ts` — `TS1360: Type '"ENTERPRISE"' does not satisfy the expected type 'never'` (plus a knock-on `TS2322`) - `tierPricing.ts` — `TS7053: Property 'ENTERPRISE' does not exist on Record<"FREE"|...>` - **#15855's source half alone → 4 type errors**, because it references an `ENTERPRISE` member the generated contract does not yet carry. - **Both together → 0 errors.** ## Generated half: regenerated, not cherry-picked Per team guidance the generated files are regenerated from the cloud spec rather than taken from #15855's diff, using the full pipeline in `cloud/.github/workflows/push-ingest-types-to-frontend.yml`: 1. `go run ./services/ingest/scripts/openapi-project -fe -in services/ingest/openapi.yaml -out <frontend>/packages/ingest-types/openapi.yaml` — the **mandatory** spec-projection step, which strips cloud's `x-internal` / `/admin/` / M2M surface before codegen 2. `pnpm generate` in `packages/ingest-types` (pinned `@hey-api/openapi-ts` **0.97.3**, unchanged) 3. `npx oxfmt --write src/` — raw generator output is 4-space + semicolons; committing without this makes the diff ~99% whitespace noise (24k lines vs 2.8k) **Cloud spec SHA:** `Comfy-Org/cloud@3e3f06a7f43b99fe96b5da066379dbba6433e252` `origin/main` has since advanced to `b47b91183f`, adding 73 spec lines — all of them the `x-internal` `/admin/api/billing/credit-deduction` endpoint. Projecting from either SHA yields a **byte-identical** projected spec, so the SHA choice is immaterial here. `packages/ingest-types/openapi.yaml` is gitignored and is not committed; only `src/*.gen.ts` and `src/index.ts` are. ## Leak guard The projection step is what the previous attempt on this branch skipped, which leaked 52 `Admin*` refs into the generated types and would have tripped the CI leak guard (the same defect #15878 was created to revert). This branch was rebuilt from scratch on `origin/cloud/1.52`. ``` Admin refs in types.gen.ts: 0 Admin refs in zod.gen.ts: 0 Admin refs in index.ts: 0 ``` The CI guard's own regex — `(/admin|/api/internal|/api/webhooks|/m2m|/monitoring|/debug)([^A-Za-z0-9_-]|$)` — also matches **0** times in the projected spec and both generated files. Projection reported `kept 192 ops | excluded 45 x-internal | pruned 40 schemas`. ## Delta shape ``` packages/ingest-types/src/index.ts | 54 + packages/ingest-types/src/types.gen.ts | 744 +++++++++++- packages/ingest-types/src/zod.gen.ts | 2024 ++++++++++++-------------------- ``` `zod.gen.ts` shows large churn because the committed files on `cloud/1.52` are **stale**, not because types were removed: 184 combined `z*Data` schemas are replaced by 186 split `z*Body` / `z*Path` / `z*Query` / `z*Response` schemas. `cloud/1.52` pins the same generator version (0.97.3) with an identical `openapi-ts.config.ts` as `main`, so its committed output simply predates a regeneration. Verification that this output is correct: it is **byte-identical to `origin/main`'s committed `zod.gen.ts` and `index.ts`**, and differs from `main`'s `types.gen.ts` by only 10 lines — three additive documentation/`404: ErrorResponse` entries on the agent-skill-packs routes, present because the pinned spec is slightly ahead of `main`'s last regeneration. No types are removed relative to `main`. ## Verification - `pnpm typecheck` — **green (exit 0)** with #14483 *not* applied - `pnpm vitest run` over the four suites #15855 ships/touches — **102 passed (4 files)**: `tierPricing.test.ts` (new), `useBillingPolicyState.test.ts`, `billingPolicyCapabilities.test.ts`, `useWorkspaceTierLabel.test.ts` - Committed through the normal pre-commit hook (oxfmt + `pnpm lint` + `pnpm typecheck` all passed); **no `--no-verify`** #15855's source half applied cleanly with `git apply --3way` across 10 files: `src/locales/en/main.json`, `billingPolicyCapabilities.ts`/`.test.ts`, `billingPolicyState.ts`, `useBillingPolicyState.ts`/`.test.ts`, `tierPricing.ts` + new `tierPricing.test.ts`, `useWorkspaceTierLabel.ts`/`.test.ts`. ## Merge order This PR is a **prerequisite** for the #14483 embedded-checkout backport, which is stacked on top of it and should merge second.
…pi (#15927) Regenerates `packages/ingest-types` on `cloud/1.51` so the branch carries the billing contract that the embedded-checkout backport [#15906](#15906) consumes. **Types only** — no runtime code, no behaviour change. ## Regenerated, not cherry-picked Per team guidance (Jaewon), this is a regeneration rather than a cherry-pick of `main`'s ingest-types commits. Those commits are interleaved with an `@hey-api/openapi-ts` bump (#15166) and the ENTERPRISE tier addition (#15855), neither of which belongs on a release branch. Regenerating lets us pick the exact contract snapshot 1.51 needs. ## Spec pin: cloud `8c26db3a68`, not current main Source: `Comfy-Org/cloud` @ **`8c26db3a684a0595254c5051cba88b60e40810c8`** (2026-08-21), `services/ingest/openapi.yaml`. That commit is pinned deliberately. It carries **all 17 billing symbols** #14483 needs while **predating the ENTERPRISE tier**: - Verified at the pin: all 17 of `SavedPaymentMethod`, `authentication_state`, `decline_reason`, `payment_intent_client_secret`, `reconciliation_needed`, `confirmation_token`, `quote_id`, `quote_version`, `saved_payment_method_id`, `promotion_code`, `amount_due_cents`, `requires_reactivation_confirmation`, `renewal_at`, `renewal_amount_cents`, `discounts`, `currency`, `payment_method_configuration_id` are present. - Verified at the pin: **zero** `ENTERPRISE` occurrences. Regenerating from **current** cloud main would widen `SubscriptionTier` with `ENTERPRISE`, which trips the `satisfies never` exhaustiveness guard in `useBillingPolicyState.ts` and `tierPricing.ts` — breaking files #14483 never touches, and pulling a product decision into a release branch. **Enterprise is scoped to 1.52** (confirmed by Jaewon and Wei Hai), not 1.51. Generated `SubscriptionTier` on this branch stays at six members: ```ts export type SubscriptionTier = | 'FREE' | 'STANDARD' | 'CREATOR' | 'PRO' | 'FOUNDERS_EDITION' | 'TEAM' ``` ## Pipeline Followed `cloud/.github/workflows/push-ingest-types-to-frontend.yml` exactly — `pnpm generate` alone is **not** sufficient: 1. **Project the spec** (mandatory, BE-2669 security boundary): `go run ./services/ingest/scripts/openapi-project -fe -in services/ingest/openapi.yaml -out <fe>/packages/ingest-types/openapi.yaml` Result: `kept 186 ops | excluded 41 x-internal | removed 36 empty paths + 3 orphaned tag decls | kept 192 schemas, pruned 40 schemas + 1 security scheme` (17070 → 13436 lines). 2. `pnpm generate` using **this branch's own pinned `@hey-api/openapi-ts` 0.93.0** (not bumped; handles this spec cleanly). 3. `npx oxfmt --write src/` — raw generator output is 4-space + semicolons; committed files are oxfmt-normalized. Skipping this makes the diff ~99% whitespace noise (`+11499/−12702` unformatted vs `+413/−7` formatted). Skipping step 1 is what leaked cloud's internal admin surface previously (52 `Admin*` refs), the defect #15878 reverted. **Leak guard:** `git grep -c 'Admin' packages/ingest-types/src/types.gen.ts` → **0**. The workflow's full guard pattern (`/admin|/api/internal|/api/webhooks|/m2m|/monitoring|/debug`) also returns clean on the projected spec, `types.gen.ts` and `zod.gen.ts`. `packages/ingest-types/openapi.yaml` is gitignored and is **not** committed. Only `src/*.gen.ts` and `src/index.ts` are. ## Delta — purely additive ``` packages/ingest-types/src/index.ts | 13 ++ packages/ingest-types/src/types.gen.ts | 282 +++++++++++++++++++++++++++++- packages/ingest-types/src/zod.gen.ts | 125 ++++++++++++++- 3 files changed, 413 insertions(+), 7 deletions(-) ``` - **Zero exported symbols removed** (1014 → 1027; set difference in the removal direction is empty). - **13 new exported types**: `SavedPaymentMethod`, `SubscriptionDiscount`, `CurrentWorkspaceResponse`, `ListSavedPaymentMethods{Data,Error,Errors,Response,Responses}`, `GetCurrentWorkspace{Data,Error,Errors,Response,Responses}`. - All 7 deleted lines are benign: 5 are doc-comment rewordings, and the other 2 are the same union being **widened** — `status: 'pending' | 'succeeded' | 'failed'` → `… | 'reconciliation_needed'` (plus its Zod counterpart). No narrowing anywhere. ## Verification - `pnpm typecheck` → **exit 0, zero errors**, with #14483 **not** applied. Because the spec predates ENTERPRISE this is genuinely types-only: no `satisfies never` breakage and no compatibility shims were needed. - `npx oxfmt --check packages/ingest-types/src/` → clean. - Committed **through** the pre-commit hooks (oxfmt, `oxlint --type-aware`, eslint, whole-project `pnpm typecheck`) — no `--no-verify`. ## Merge order Prerequisite for **#15906** (embedded-checkout backport), which is stacked on this branch and fails typecheck with 94 errors without it. **Merge this first.** Not merged here, auto-merge not enabled.
The V0 draft channel's last contract surface: zAgentDraftSnapshot and the draft_patch/draft_version union members leave agentApiSchema, the recorded fixtures shed their draft lines, and the session switch loses its explicit no-op cases (the event source never subscribes to types outside the union). Retirement is pinned by negative assertions: isAgentEvent stays false for both frames and an emitted draft_patch never reaches the canvas. packages/ingest-types still carries draft tokens: generated files change only through the projection bot (#15878), so those die when the backend spec drops the draft rail.
…cy (#15804) Points every Cloud billing consumer at the server-resolved capabilities composable and deletes the client-side derivation it replaces. **This is where rendered behaviour changes.** The rest of the stack was generated output, a dormant source, and tests. Three things ride together because splitting them produces a commit that does not build: - the consumer migration, - deleting the six client-side policy files (a consumer still importing them would not compile), - the top-up deep-link loader, which read `canTopUp` off `WorkspacePermissions` — a property this change removes. The loader now awaits capability initialization before reading the flags, so an eligible user does not lose the `?topup=` deep link while both are still at their initial `false`. ## Behaviour reviewers should agree to **An unsubscribed Cloud owner now sees "Add Credits" alongside "Subscribe"**, where they previously saw only "Subscribe". The old behaviour came from a client-side `topUpAccess` inference; that policy now lives server-side, and the resolver returns `can_top_up=true` for a workspace with no subscription row. The component renders what the server grants, so the guard belongs in the resolver — `cloud#7342` addresses it. Enterprise handling is preserved. `#15855` landed the ENTERPRISE tier while this was in flight and modified the `billingPolicy*` files deleted here; its own description names this stack as the intended end state, with only the tier-label mapping surviving. `useWorkspaceTierLabel`'s `ENTERPRISE: 'enterprise'` and the locale key are retained and byte-identical to that PR. ## Merge checklist — rollout flags With the capability rollout flags **off**, the server returns `can_top_up=true` / `can_subscribe_self_serve=false` for every workspace: every cloud user sees "Add credits" and nobody sees the subscribe upsell. Prod runs a pinned `frontendVersion` (currently `1.51.9`), so merging here does not ship — but this must be settled before a backport reaches a `cloud/1.5x` release branch. - [x] Regenerate `@comfyorg/ingest-types` — #15802, corrected by #15878 to the pipeline-projected output - [x] Land `cloud#7342` — merged 2026-08-25 21:18; verified on cloud `main` - [x] Create both flags in staging (`dreamboothy-dev`) — they did not exist; created disabled at 0% mirroring prod - [ ] Validate flags-on in test-v2 — it already runs `cloud#7342` (image `16b468b`, auto-deployed by Image Updater). Note `can_downgrade_to_personal` is rollout-gated too, so downgrade CTAs stay dark until flags-on - [ ] Confirm billing-api is deployed to prod with `cloud#7342`, then set `active: true` and ramp as a canary Known residual: `can_top_up=false` still carries three meanings (not owner / free tier / no subscription), so `CreditsTile`'s `v-else` can show "Upgrade to add credits" to a member who cannot upgrade. Tracked via the proposed `top_up_denied_reason` on the `cloud#7223` discussion. ## Verification `pnpm typecheck`, `typecheck:browser`, `lint` clean. Full unit suite: **17,758 passed**; the 12 `check-binary-size` failures are pre-existing and environmental. (cherry picked from commit 6dd12d7)
The V0 draft channel's last contract surface: zAgentDraftSnapshot and the draft_patch/draft_version union members leave agentApiSchema, the recorded fixtures shed their draft lines, and the session switch loses its explicit no-op cases (the event source never subscribes to types outside the union). Retirement is pinned by negative assertions: isAgentEvent stays false for both frames and an emitted draft_patch never reaches the canvas. packages/ingest-types still carries draft tokens: generated files change only through the projection bot (#15878), so those die when the backend spec drops the draft rail.
The V0 draft channel's last contract surface: zAgentDraftSnapshot and the draft_patch/draft_version union members leave agentApiSchema, the recorded fixtures shed their draft lines, and the session switch loses its explicit no-op cases (the event source never subscribes to types outside the union). Retirement is pinned by negative assertions: isAgentEvent stays false for both frames and an emitted draft_patch never reaches the canvas. packages/ingest-types still carries draft tokens: generated files change only through the projection bot (#15878), so those die when the backend spec drops the draft rail.
Summary
Restores
packages/ingest-typesto the pipeline-projected output. #15802 regenerated these files by running the generator locally, which bypassed part of the projection filter.What went wrong
packages/ingest-types/openapi-ts.config.tsexcludes only the webhook and internal rails. Thepush-ingest-types-to-frontendpipeline additionally stripsx-internaloperations and the admin rails before generating. Runningpnpm generateagainst the raw spec therefore emitted operations the projection has never carried:Adminreferences intypes.gen.tsConcretely that added
AdminBillingCancelSubscription,AdminBillingCreditGrant,AdminBillingPlanChangeand related operation types to a public repo. Generated files should change only through the bot's[chore]PRs; this restores that invariant.Why the regeneration wasn't needed
It was done to pull
rollout_defaults_applied,revisionandexpires_atintoBillingCapabilitiesResponsefor the capabilities stack. Those fields were already onmain— they arrived with #15855 via the bot regeneration in #15813. The gap was only ever on the stack's own branch, not on main.Scope
Restores the three generated files to their state at
d853072426(the last pipeline-projected version). Nothing else changes.The billing capability contract is unaffected: all three fields predate #15802,
ENTERPRISEis present in bothtypes.gen.tsandzod.gen.ts, and cloud has had noopenapi.yamlcommits since that projection was taken — so this is current, not a rollback to something stale.Verification
pnpm typecheck— cleanpnpm typecheck:browser— cleancheck-binary-sizefailures are pre-existing and environmental — they fail identically without this change.