Repository navigation
Conversation
The frontend snapshot predated cloud#7229, so BillingCapabilitiesResponse was missing rollout_defaults_applied, revision and expires_at even though the spec marks all three required. Regenerating also picks up the wider drift that accumulated since cloud@7b41d11. Generated with @hey-api/openapi-ts against services/ingest/openapi.yaml.
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1989 passed, 1 failed · 4 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle: 9.14 MB gzip 🔴 +1.76 kBDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 591 kB (baseline 591 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 112 kB (baseline 112 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.45 MB (baseline 3.44 MB) • 🔴 +9.88 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 549 kB (baseline 549 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 14.3 MB (baseline 14.3 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 220 unchanged ⚡ Performance
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe ingest types barrel file adds re-exports for newly generated API types covering billing, deletion, credentials, monitoring, workflows, events, and integrations. ChangesIngest API type exports
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates generated ingest API types and schemas to match the current service contract; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description explains the update, its purpose, generated-output process, verification results, known pre-existing failures, and follow-up work. It does not use every template heading, but it provides the required review context. Full details: End-To-End Regression Coverage For FixesExplanation The required PR metadata is incomplete. The context does not provide the PR title or any commit subjects, so the bug-fix signal required by condition 1 cannot be checked. The context identifies a change under Resolution Provide the PR title, all commit subjects, and the complete Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains only ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #15860 +/- ##
==========================================
+ Coverage 80.02% 80.03% +0.01%
==========================================
Files 2251 2251
Lines 114256 114352 +96
Branches 31145 31145
==========================================
+ Hits 91433 91524 +91
- Misses 22343 22360 +17
+ Partials 480 468 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing — superseded by #15802, which is where this belongs. #15802 was The regeneration is now on |
Summary
Regenerates
@comfyorg/ingest-typesagainst the current cloud ingest spec (cloud@16c40f37e5).Why now
The committed snapshot was generated 2026-08-24T18:54:58Z, 86 minutes before
cloud#7229merged (20:21:22Z). That PR added three fields toBillingCapabilitiesResponseand marked them required in the spec:rollout_defaults_applied— distinguishes a rollout placeholder from a resolved policy valuerevision— pairs with theX-Capability-Revisionheader for cache invalidationexpires_at— the 30s freshness boundNone of them existed in the generated types, so consumers could not read a contract the server was already sending. Regenerating also picks up the wider drift accumulated since
cloud@7b41d11(#15425), which is most of the diff size.Review notes
pnpm generateinpackages/ingest-types(@hey-api/openapi-ts+ Zod plugin), thenoxfmt. No hand edits.openapi.yamlstays gitignored and is fetched from the cloud repo, unchanged from the existing process.Verification
pnpm typecheck— cleanpnpm typecheck:browser— cleancheck-binary-sizefailures are pre-existing and environmental (they fail identically onmainunder the local Node version), not related to this change.Follow-up
Unblocks the freshness work on #15803 (scheduled refetch on
expires_at, invalidation onX-Capability-Revision), which could not be written against fields that did not exist in the types.