Repository navigation
[backport cloud/1.51] feat: open Settings on Plans & Credits from a ?settings= deep link - #15834
Conversation
…15808) ## Summary Adds a `?settings=plan-credits` deep link that opens the Settings dialog on the Plans & Credits panel, so platform.comfy.org can route users straight to the place where they complete billing actions instead of the default Cloud landing. ## Why / context The new subscription and top-up flows won't be packaged into platform.comfy.org in time for launch, so platform redirects users to Cloud for any transaction. Today settings tabs are not URL-addressable — a redirected user lands on the default canvas and has to find Plans & Credits themselves. Closest existing deep links are `?pricing=1` and `?topup=1`; this follows the same URL-action-loader pattern. Slack context: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1787597535486829 ## Changes - **What**: New `useSettingsUrlLoader` reads `?settings=`, strips the param, and opens the Settings dialog via `useSettingsDialog().show()` for values in an explicit allowlist (`plan-credits` → `workspace` panel, the same call the user popover makes). Wired into `useUrlActionLoaders` (cloud-only, runs on app mount) and registered in the preserved-query tracker so the param survives the login redirect, like `?topup=`. - Unrecognized, empty, or non-string values are a silent no-op with the param stripped. ## Review Focus - The allowlist maps URL values to `SettingPanelType` instead of passing the raw param through, so only intentionally exposed panels are URL-addressable. - No permission gate: the Plans & Credits panel renders for every logged-in cloud user (members included), unlike `?topup=`/`?pricing=` which gate on billing permissions. ## Verification AS IS (prod, cloud.comfy.org): visiting `/?settings=plan-credits` logged out redirects to `/cloud/login` and the param is not captured (`sessionStorage['Comfy.PreservedQuery.settings']` is `null`) — the intent is lost after login. TO BE (this branch, real app via `pnpm dev:cloud`): the same visit stashes `{"settings":"plan-credits"}` in `sessionStorage['Comfy.PreservedQuery.settings']` before the login redirect, so the loader opens Plans & Credits once the app mounts after login. Unit tests cover the loader (open/strip/no-op/preserved-query restore) and the aggregator wiring. A logged-in E2E/screenshot isn't reproducible from this environment (cloud E2E in CI runs unauthenticated by design, see `browser_tests/tests/cloud.spec.ts`); will attach a logged-in AS IS / TO BE capture from a testcloud account before merge. ## Screenshots (if applicable) To be added: logged-in capture of the redirect landing on Plans & Credits (requires testcloud account).
🎭 Playwright: ✅ 1827 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-24T22:46:58.371Z",
"gitSha": "c1b065189340e0ffd98766ce646878a2cf55b132",
"branch": "backport-15808-to-cloud-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2068.2620000000043,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.947,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.22299999999996,
"heapDeltaBytes": 5058064,
"heapUsedBytes": 70479044,
"domNodes": 18,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 8.075000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1999.5460000000094,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.587,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.163,
"heapDeltaBytes": 4957380,
"heapUsedBytes": 70457332,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 5.928000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1697.2410000000195,
"styleRecalcs": 73,
"styleRecalcDurationMs": 21.842,
"layouts": 12,
"layoutDurationMs": 2.197,
"taskDurationMs": 566.64,
"heapDeltaBytes": 115804,
"heapUsedBytes": 65497048,
"domNodes": 58,
"jsHeapTotalBytes": 25956352,
"scriptDurationMs": 66.04400000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1700.3029999999626,
"styleRecalcs": 72,
"styleRecalcDurationMs": 22.214,
"layouts": 12,
"layoutDurationMs": 2.367,
"taskDurationMs": 638.0729999999999,
"heapDeltaBytes": -17024160,
"heapUsedBytes": 48423604,
"domNodes": -280,
"jsHeapTotalBytes": 22908928,
"scriptDurationMs": 71.18,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.6669999999763,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.41,
"layouts": 6,
"layoutDurationMs": 0.4549999999999999,
"taskDurationMs": 302.229,
"heapDeltaBytes": 8472432,
"heapUsedBytes": 73809200,
"domNodes": 80,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 6.970000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.119000000047,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.629,
"layouts": 6,
"layoutDurationMs": 0.578,
"taskDurationMs": 293.219,
"heapDeltaBytes": 8187024,
"heapUsedBytes": 73448164,
"domNodes": 80,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 7.851,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 447.6129999999898,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.919,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 272.12399999999997,
"heapDeltaBytes": -10780492,
"heapUsedBytes": 54761352,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 36.514,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 486.3369999999918,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 279.281,
"heapDeltaBytes": -11607784,
"heapUsedBytes": 53714372,
"domNodes": 24,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 37.345,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2018.4980000000223,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.159000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.462,
"heapDeltaBytes": 7519420,
"heapUsedBytes": 68194500,
"domNodes": -283,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 10.487999999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2020.2229999999872,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.901999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.533,
"heapDeltaBytes": 13128960,
"heapUsedBytes": 75697736,
"domNodes": -278,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 11.591999999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2093.1789999999637,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.658000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 847.4750000000001,
"heapDeltaBytes": 8938076,
"heapUsedBytes": 70327140,
"domNodes": -284,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 211.233,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2108.9529999999286,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.270999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 916.31,
"heapDeltaBytes": 628664,
"heapUsedBytes": 61790712,
"domNodes": -282,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 236.35,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3111.5560000000073,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.108,
"layouts": 60,
"layoutDurationMs": 5.2459999999999996,
"taskDurationMs": 975.4240000000001,
"heapDeltaBytes": -8247132,
"heapUsedBytes": 54032696,
"domNodes": -282,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 239.70300000000003,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3070.90299999993,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.071000000000002,
"layouts": 60,
"layoutDurationMs": 5.970999999999999,
"taskDurationMs": 957.152,
"heapDeltaBytes": 16875492,
"heapUsedBytes": 79251444,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 249.44499999999996,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.4690000000387,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.689000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.9100000000001,
"heapDeltaBytes": 12815156,
"heapUsedBytes": 73918424,
"domNodes": -282,
"jsHeapTotalBytes": 2457600,
"scriptDurationMs": 8.491999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.0389999999734,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.434000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.74,
"heapDeltaBytes": 13097308,
"heapUsedBytes": 74111920,
"domNodes": -283,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 11.591000000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 487.8439999999955,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.4689999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.39799999999997,
"heapDeltaBytes": -9991852,
"heapUsedBytes": 55577796,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 77.588,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 486.1549999999397,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.961,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.252,
"heapDeltaBytes": -10105800,
"heapUsedBytes": 55513020,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 80.17099999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1998.4800000000291,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.784000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.548,
"heapDeltaBytes": 5125644,
"heapUsedBytes": 70761408,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 5.113000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.367999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.452000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.394,
"heapDeltaBytes": 5575516,
"heapUsedBytes": 71167628,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 5.66,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.03100000002,
"styleRecalcs": 76,
"styleRecalcDurationMs": 23.821,
"layouts": 16,
"layoutDurationMs": 2.513,
"taskDurationMs": 586.253,
"heapDeltaBytes": -3754880,
"heapUsedBytes": 61959440,
"domNodes": 64,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 53.943999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.2100000000137,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.33,
"layouts": 16,
"layoutDurationMs": 3.3669999999999995,
"taskDurationMs": 573.507,
"heapDeltaBytes": -3940544,
"heapUsedBytes": 61675380,
"domNodes": 64,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 56.16700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.8409999999808,
"styleRecalcs": 21,
"styleRecalcDurationMs": 22.907999999999998,
"layouts": 16,
"layoutDurationMs": 8.424999999999999,
"taskDurationMs": 706.9350000000001,
"heapDeltaBytes": -5810680,
"heapUsedBytes": 78946316,
"domNodes": 13673,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 14.384,
"eventListeners": 2373,
"totalBlockingTimeMs": 112,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8074.67600000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 21.198999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2944.011,
"heapDeltaBytes": 5072160,
"heapUsedBytes": 65224396,
"domNodes": -282,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 664.806,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8121.484999999893,
"styleRecalcs": 248,
"styleRecalcDurationMs": 24.280000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3064.5609999999997,
"heapDeltaBytes": 2422320,
"heapUsedBytes": 63027888,
"domNodes": -283,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 713.176,
"eventListeners": -161,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10875.667999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10320.833,
"heapDeltaBytes": -42091268,
"heapUsedBytes": 169329948,
"domNodes": -8312,
"jsHeapTotalBytes": -8818688,
"scriptDurationMs": 56.646000000000015,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12179.557000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10960.639000000001,
"heapDeltaBytes": -37379160,
"heapUsedBytes": 173483556,
"domNodes": -8312,
"jsHeapTotalBytes": -7020544,
"scriptDurationMs": 80.518,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13648.530999999992,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.264999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12996.185,
"heapDeltaBytes": -14370744,
"heapUsedBytes": 183073516,
"domNodes": -8312,
"jsHeapTotalBytes": -12857344,
"scriptDurationMs": 318.774,
"eventListeners": -16389,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14884.603999999967,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.779000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14101.243,
"heapDeltaBytes": -27855132,
"heapUsedBytes": 182987240,
"domNodes": -8312,
"jsHeapTotalBytes": -14692352,
"scriptDurationMs": 353.079,
"eventListeners": -16389,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 429.75000000001273,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.561,
"layouts": 2,
"layoutDurationMs": 0.326,
"taskDurationMs": 82.40700000000001,
"heapDeltaBytes": 4995384,
"heapUsedBytes": 69468440,
"domNodes": 128,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5.998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 439.7989999999936,
"styleRecalcs": 13,
"styleRecalcDurationMs": 12.942,
"layouts": 2,
"layoutDurationMs": 0.2930000000000001,
"taskDurationMs": 84.869,
"heapDeltaBytes": 4980432,
"heapUsedBytes": 69572628,
"domNodes": 123,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5.843000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.51 #15834 +/- ##
=============================================
Coverage ? 81.58%
=============================================
Files ? 1885
Lines ? 117790
Branches ? 36799
=============================================
Hits ? 96097
Misses ? 21221
Partials ? 472
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15808 to
cloud/1.51Automatically created by backport workflow.