Skip to content

[backport cloud/1.51] feat: open Settings on Plans & Credits from a ?settings= deep link - #15834

Merged
comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-15808-to-cloud-1.51
Aug 25, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.51from
backport-15808-to-cloud-1.51

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #15808 to cloud/1.51

Automatically created by backport workflow.

…15808)

## Summary

Adds a `?settings=plan-credits` deep link that opens the Settings dialog
on the Plans & Credits panel, so platform.comfy.org can route users
straight to the place where they complete billing actions instead of the
default Cloud landing.

## Why / context

The new subscription and top-up flows won't be packaged into
platform.comfy.org in time for launch, so platform redirects users to
Cloud for any transaction. Today settings tabs are not URL-addressable —
a redirected user lands on the default canvas and has to find Plans &
Credits themselves. Closest existing deep links are `?pricing=1` and
`?topup=1`; this follows the same URL-action-loader pattern. Slack
context:
https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1787597535486829

## Changes

- **What**: New `useSettingsUrlLoader` reads `?settings=`, strips the
param, and opens the Settings dialog via `useSettingsDialog().show()`
for values in an explicit allowlist (`plan-credits` → `workspace` panel,
the same call the user popover makes). Wired into `useUrlActionLoaders`
(cloud-only, runs on app mount) and registered in the preserved-query
tracker so the param survives the login redirect, like `?topup=`.
- Unrecognized, empty, or non-string values are a silent no-op with the
param stripped.

## Review Focus

- The allowlist maps URL values to `SettingPanelType` instead of passing
the raw param through, so only intentionally exposed panels are
URL-addressable.
- No permission gate: the Plans & Credits panel renders for every
logged-in cloud user (members included), unlike `?topup=`/`?pricing=`
which gate on billing permissions.

## Verification

AS IS (prod, cloud.comfy.org): visiting `/?settings=plan-credits` logged
out redirects to `/cloud/login` and the param is not captured
(`sessionStorage['Comfy.PreservedQuery.settings']` is `null`) — the
intent is lost after login.

TO BE (this branch, real app via `pnpm dev:cloud`): the same visit
stashes `{"settings":"plan-credits"}` in
`sessionStorage['Comfy.PreservedQuery.settings']` before the login
redirect, so the loader opens Plans & Credits once the app mounts after
login.

Unit tests cover the loader (open/strip/no-op/preserved-query restore)
and the aggregator wiring. A logged-in E2E/screenshot isn't reproducible
from this environment (cloud E2E in CI runs unauthenticated by design,
see `browser_tests/tests/cloud.spec.ts`); will attach a logged-in AS IS
/ TO BE capture from a testcloud account before merge.

## Screenshots (if applicable)

To be added: logged-in capture of the redirect landing on Plans &
Credits (requires testcloud account).
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 24, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 24, 2026 22:36
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1827 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1806 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/24/2026, 10:37:45 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 75.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.2 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 163.5 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 30ms TBT · 174.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 420ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.2 MB
canvas-idle: DOM nodes 19
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 22ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 602ms
canvas-mouse-sweep: script duration 69ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 54.3 MB
canvas-mouse-sweep: DOM nodes -111
canvas-mouse-sweep: event listeners -74
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 298ms
canvas-zoom-sweep: script duration 7ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.2 MB
canvas-zoom-sweep: DOM nodes 80
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 276ms
dom-widget-clipping: script duration 37ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 51.7 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 492ms
large-graph-idle: script duration 11ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 68.6 MB
large-graph-idle: DOM nodes -281
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 882ms
large-graph-pan: script duration 224ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 63.0 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 6ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 966ms
large-graph-zoom: script duration 245ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 63.6 MB
large-graph-zoom: DOM nodes -133
large-graph-zoom: event listeners -72
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 10
minimap-idle: task duration 484ms
minimap-idle: script duration 10ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.6 MB
minimap-idle: DOM nodes -283
minimap-idle: event listeners -149
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 289ms
subgraph-dom-widget-clipping: script duration 79ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.0 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 367ms
subgraph-idle: script duration 5ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.7 MB
subgraph-idle: DOM nodes 21
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 25ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 580ms
subgraph-mouse-sweep: script duration 55ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.0 MB
subgraph-mouse-sweep: DOM nodes 64
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 8ms
subgraph-transition-enter: style recalc duration 23ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 707ms
subgraph-transition-enter: script duration 14ms
subgraph-transition-enter: TBT 112ms
subgraph-transition-enter: heap used 75.3 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2373
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 23ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 3004ms
viewport-pan-sweep: script duration 689ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 61.2 MB
viewport-pan-sweep: DOM nodes -283
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10641ms
vue-large-graph-idle: script duration 69ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 163.5 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16392
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 12ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 70
vue-large-graph-pan: task duration 13549ms
vue-large-graph-pan: script duration 336ms
vue-large-graph-pan: TBT 30ms
vue-large-graph-pan: heap used 174.6 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16389
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 0ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 2
workflow-execution: style recalc count 14
workflow-execution: task duration 84ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.3 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-08-24T22:46:58.371Z",
  "gitSha": "c1b065189340e0ffd98766ce646878a2cf55b132",
  "branch": "backport-15808-to-cloud-1.51",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2068.2620000000043,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.947,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.22299999999996,
      "heapDeltaBytes": 5058064,
      "heapUsedBytes": 70479044,
      "domNodes": 18,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 8.075000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 1999.5460000000094,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.587,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.163,
      "heapDeltaBytes": 4957380,
      "heapUsedBytes": 70457332,
      "domNodes": 20,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 5.928000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1697.2410000000195,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 21.842,
      "layouts": 12,
      "layoutDurationMs": 2.197,
      "taskDurationMs": 566.64,
      "heapDeltaBytes": 115804,
      "heapUsedBytes": 65497048,
      "domNodes": 58,
      "jsHeapTotalBytes": 25956352,
      "scriptDurationMs": 66.04400000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1700.3029999999626,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 22.214,
      "layouts": 12,
      "layoutDurationMs": 2.367,
      "taskDurationMs": 638.0729999999999,
      "heapDeltaBytes": -17024160,
      "heapUsedBytes": 48423604,
      "domNodes": -280,
      "jsHeapTotalBytes": 22908928,
      "scriptDurationMs": 71.18,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1687.6669999999763,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.41,
      "layouts": 6,
      "layoutDurationMs": 0.4549999999999999,
      "taskDurationMs": 302.229,
      "heapDeltaBytes": 8472432,
      "heapUsedBytes": 73809200,
      "domNodes": 80,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 6.970000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1668.119000000047,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.629,
      "layouts": 6,
      "layoutDurationMs": 0.578,
      "taskDurationMs": 293.219,
      "heapDeltaBytes": 8187024,
      "heapUsedBytes": 73448164,
      "domNodes": 80,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 7.851,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 447.6129999999898,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.919,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 272.12399999999997,
      "heapDeltaBytes": -10780492,
      "heapUsedBytes": 54761352,
      "domNodes": 18,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 36.514,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 486.3369999999918,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 5.948,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 279.281,
      "heapDeltaBytes": -11607784,
      "heapUsedBytes": 53714372,
      "domNodes": 24,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 37.345,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2018.4980000000223,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.159000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.462,
      "heapDeltaBytes": 7519420,
      "heapUsedBytes": 68194500,
      "domNodes": -283,
      "jsHeapTotalBytes": 2457600,
      "scriptDurationMs": 10.487999999999998,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2020.2229999999872,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.901999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.533,
      "heapDeltaBytes": 13128960,
      "heapUsedBytes": 75697736,
      "domNodes": -278,
      "jsHeapTotalBytes": 2457600,
      "scriptDurationMs": 11.591999999999999,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2093.1789999999637,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 8.658000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 847.4750000000001,
      "heapDeltaBytes": 8938076,
      "heapUsedBytes": 70327140,
      "domNodes": -284,
      "jsHeapTotalBytes": 2912256,
      "scriptDurationMs": 211.233,
      "eventListeners": -147,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2108.9529999999286,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.270999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 916.31,
      "heapDeltaBytes": 628664,
      "heapUsedBytes": 61790712,
      "domNodes": -282,
      "jsHeapTotalBytes": 3960832,
      "scriptDurationMs": 236.35,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3111.5560000000073,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.108,
      "layouts": 60,
      "layoutDurationMs": 5.2459999999999996,
      "taskDurationMs": 975.4240000000001,
      "heapDeltaBytes": -8247132,
      "heapUsedBytes": 54032696,
      "domNodes": -282,
      "jsHeapTotalBytes": 3768320,
      "scriptDurationMs": 239.70300000000003,
      "eventListeners": -151,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3070.90299999993,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.071000000000002,
      "layouts": 60,
      "layoutDurationMs": 5.970999999999999,
      "taskDurationMs": 957.152,
      "heapDeltaBytes": 16875492,
      "heapUsedBytes": 79251444,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 249.44499999999996,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.4690000000387,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.689000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.9100000000001,
      "heapDeltaBytes": 12815156,
      "heapUsedBytes": 73918424,
      "domNodes": -282,
      "jsHeapTotalBytes": 2457600,
      "scriptDurationMs": 8.491999999999999,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.0389999999734,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.434000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.74,
      "heapDeltaBytes": 13097308,
      "heapUsedBytes": 74111920,
      "domNodes": -283,
      "jsHeapTotalBytes": 2719744,
      "scriptDurationMs": 11.591000000000001,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 487.8439999999955,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.4689999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 288.39799999999997,
      "heapDeltaBytes": -9991852,
      "heapUsedBytes": 55577796,
      "domNodes": 22,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 77.588,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 486.1549999999397,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.961,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 289.252,
      "heapDeltaBytes": -10105800,
      "heapUsedBytes": 55513020,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 80.17099999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1998.4800000000291,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.784000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.548,
      "heapDeltaBytes": 5125644,
      "heapUsedBytes": 70761408,
      "domNodes": 22,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 5.113000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.367999999999,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.452000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 369.394,
      "heapDeltaBytes": 5575516,
      "heapUsedBytes": 71167628,
      "domNodes": 20,
      "jsHeapTotalBytes": 24379392,
      "scriptDurationMs": 5.66,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1717.03100000002,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 23.821,
      "layouts": 16,
      "layoutDurationMs": 2.513,
      "taskDurationMs": 586.253,
      "heapDeltaBytes": -3754880,
      "heapUsedBytes": 61959440,
      "domNodes": 64,
      "jsHeapTotalBytes": 23592960,
      "scriptDurationMs": 53.943999999999996,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1727.2100000000137,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.33,
      "layouts": 16,
      "layoutDurationMs": 3.3669999999999995,
      "taskDurationMs": 573.507,
      "heapDeltaBytes": -3940544,
      "heapUsedBytes": 61675380,
      "domNodes": 64,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 56.16700000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 899.8409999999808,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 22.907999999999998,
      "layouts": 16,
      "layoutDurationMs": 8.424999999999999,
      "taskDurationMs": 706.9350000000001,
      "heapDeltaBytes": -5810680,
      "heapUsedBytes": 78946316,
      "domNodes": 13673,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 14.384,
      "eventListeners": 2373,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8074.67600000001,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 21.198999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2944.011,
      "heapDeltaBytes": 5072160,
      "heapUsedBytes": 65224396,
      "domNodes": -282,
      "jsHeapTotalBytes": 4747264,
      "scriptDurationMs": 664.806,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8121.484999999893,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 24.280000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3064.5609999999997,
      "heapDeltaBytes": 2422320,
      "heapUsedBytes": 63027888,
      "domNodes": -283,
      "jsHeapTotalBytes": 2912256,
      "scriptDurationMs": 713.176,
      "eventListeners": -161,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10875.667999999961,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10320.833,
      "heapDeltaBytes": -42091268,
      "heapUsedBytes": 169329948,
      "domNodes": -8312,
      "jsHeapTotalBytes": -8818688,
      "scriptDurationMs": 56.646000000000015,
      "eventListeners": -16393,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12179.557000000044,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10960.639000000001,
      "heapDeltaBytes": -37379160,
      "heapUsedBytes": 173483556,
      "domNodes": -8312,
      "jsHeapTotalBytes": -7020544,
      "scriptDurationMs": 80.518,
      "eventListeners": -16391,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13648.530999999992,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.264999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12996.185,
      "heapDeltaBytes": -14370744,
      "heapUsedBytes": 183073516,
      "domNodes": -8312,
      "jsHeapTotalBytes": -12857344,
      "scriptDurationMs": 318.774,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 12,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14884.603999999967,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 12.779000000000012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14101.243,
      "heapDeltaBytes": -27855132,
      "heapUsedBytes": 182987240,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14692352,
      "scriptDurationMs": 353.079,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 47,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 429.75000000001273,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 13.561,
      "layouts": 2,
      "layoutDurationMs": 0.326,
      "taskDurationMs": 82.40700000000001,
      "heapDeltaBytes": 4995384,
      "heapUsedBytes": 69468440,
      "domNodes": 128,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 5.998,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 439.7989999999936,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 12.942,
      "layouts": 2,
      "layoutDurationMs": 0.2930000000000001,
      "taskDurationMs": 84.869,
      "heapDeltaBytes": 4980432,
      "heapUsedBytes": 69572628,
      "domNodes": 123,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 5.843000000000001,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 24, 2026
@github-actions
github-actions Bot requested a review from thedatalife August 24, 2026 22:36
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tform/settings/composables/useSettingsUrlLoader.ts 95.23% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.51   #15834   +/-   ##
=============================================
  Coverage              ?   81.58%           
=============================================
  Files                 ?     1885           
  Lines                 ?   117790           
  Branches              ?    36799           
=============================================
  Hits                  ?    96097           
  Misses                ?    21221           
  Partials              ?      472           
Flag Coverage Δ
unit 73.18% <96.15%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/useUrlActionLoaders.ts 96.42% <100.00%> (ø)
...rc/platform/navigation/preservedQueryNamespaces.ts 100.00% <ø> (ø)
src/router.ts 28.26% <ø> (ø)
...tform/settings/composables/useSettingsUrlLoader.ts 95.23% <95.23%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 5506512 into cloud/1.51 Aug 25, 2026
88 of 90 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-15808-to-cloud-1.51 branch August 25, 2026 02:42
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants