Repository navigation
[backport core/1.51] feat: open Settings on Plans & Credits from a ?settings= deep link - #15833
Conversation
…15808) ## Summary Adds a `?settings=plan-credits` deep link that opens the Settings dialog on the Plans & Credits panel, so platform.comfy.org can route users straight to the place where they complete billing actions instead of the default Cloud landing. ## Why / context The new subscription and top-up flows won't be packaged into platform.comfy.org in time for launch, so platform redirects users to Cloud for any transaction. Today settings tabs are not URL-addressable — a redirected user lands on the default canvas and has to find Plans & Credits themselves. Closest existing deep links are `?pricing=1` and `?topup=1`; this follows the same URL-action-loader pattern. Slack context: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1787597535486829 ## Changes - **What**: New `useSettingsUrlLoader` reads `?settings=`, strips the param, and opens the Settings dialog via `useSettingsDialog().show()` for values in an explicit allowlist (`plan-credits` → `workspace` panel, the same call the user popover makes). Wired into `useUrlActionLoaders` (cloud-only, runs on app mount) and registered in the preserved-query tracker so the param survives the login redirect, like `?topup=`. - Unrecognized, empty, or non-string values are a silent no-op with the param stripped. ## Review Focus - The allowlist maps URL values to `SettingPanelType` instead of passing the raw param through, so only intentionally exposed panels are URL-addressable. - No permission gate: the Plans & Credits panel renders for every logged-in cloud user (members included), unlike `?topup=`/`?pricing=` which gate on billing permissions. ## Verification AS IS (prod, cloud.comfy.org): visiting `/?settings=plan-credits` logged out redirects to `/cloud/login` and the param is not captured (`sessionStorage['Comfy.PreservedQuery.settings']` is `null`) — the intent is lost after login. TO BE (this branch, real app via `pnpm dev:cloud`): the same visit stashes `{"settings":"plan-credits"}` in `sessionStorage['Comfy.PreservedQuery.settings']` before the login redirect, so the loader opens Plans & Credits once the app mounts after login. Unit tests cover the loader (open/strip/no-op/preserved-query restore) and the aggregator wiring. A logged-in E2E/screenshot isn't reproducible from this environment (cloud E2E in CI runs unauthenticated by design, see `browser_tests/tests/cloud.spec.ts`); will attach a logged-in AS IS / TO BE capture from a testcloud account before merge. ## Screenshots (if applicable) To be added: logged-in capture of the redirect landing on Plans & Credits (requires testcloud account).
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1825 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-24T22:48:28.842Z",
"gitSha": "dbe249f48807bb6a057648592339d2f0d15815a1",
"branch": "backport-15808-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.7980000000093,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.736,
"heapDeltaBytes": 5193412,
"heapUsedBytes": 70605412,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 6.643000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2037.3469999999543,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.286,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.807,
"heapDeltaBytes": 5077916,
"heapUsedBytes": 70648612,
"domNodes": 18,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 8.558,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2010.8850000000302,
"styleRecalcs": 79,
"styleRecalcDurationMs": 45.579,
"layouts": 12,
"layoutDurationMs": 4.984000000000001,
"taskDurationMs": 987.1709999999999,
"heapDeltaBytes": -61188,
"heapUsedBytes": 65209132,
"domNodes": 61,
"jsHeapTotalBytes": 24907776,
"scriptDurationMs": 129.649,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.4359999999288,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.141,
"layouts": 12,
"layoutDurationMs": 3.058,
"taskDurationMs": 834.664,
"heapDeltaBytes": 21440,
"heapUsedBytes": 65257572,
"domNodes": 58,
"jsHeapTotalBytes": 25694208,
"scriptDurationMs": 113.439,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.21199999999,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.465999999999998,
"layouts": 6,
"layoutDurationMs": 0.5870000000000001,
"taskDurationMs": 395.12500000000006,
"heapDeltaBytes": 7701308,
"heapUsedBytes": 73207380,
"domNodes": 75,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 11.378,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1752.2160000000895,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.06,
"layouts": 6,
"layoutDurationMs": 0.714,
"taskDurationMs": 413.55100000000004,
"heapDeltaBytes": 7871424,
"heapUsedBytes": 73153496,
"domNodes": 75,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 12.579000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 576.7099999999914,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.318999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.229,
"heapDeltaBytes": -11465236,
"heapUsedBytes": 53942356,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 55.951,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 573.9429999999857,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.556999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.573,
"heapDeltaBytes": -11751052,
"heapUsedBytes": 53769072,
"domNodes": 16,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 57.13000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2072.1419999999853,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.5770000000001,
"heapDeltaBytes": 13262416,
"heapUsedBytes": 74101848,
"domNodes": -281,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 16.070999999999994,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2024.152000000072,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.292,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.7470000000001,
"heapDeltaBytes": 11852488,
"heapUsedBytes": 71957904,
"domNodes": -281,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 17.079,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2311.333999999988,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.672999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1276.3329999999999,
"heapDeltaBytes": 14714776,
"heapUsedBytes": 75451240,
"domNodes": -284,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 369.422,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2188.046999999983,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1236.417,
"heapDeltaBytes": 1882036,
"heapUsedBytes": 63010008,
"domNodes": -284,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 326.01000000000005,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3232.522999999958,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.272999999999998,
"layouts": 60,
"layoutDurationMs": 7.5040000000000004,
"taskDurationMs": 1429.68,
"heapDeltaBytes": -400656,
"heapUsedBytes": 61509760,
"domNodes": -287,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 397.93899999999996,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3180.162999999993,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.774000000000001,
"layouts": 60,
"layoutDurationMs": 7.3340000000000005,
"taskDurationMs": 1339.6699999999998,
"heapDeltaBytes": 16918460,
"heapUsedBytes": 79351096,
"domNodes": 10,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 388.84599999999995,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2046.9170000000076,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.826,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.936,
"heapDeltaBytes": 12801844,
"heapUsedBytes": 74287084,
"domNodes": -282,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 15.601999999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1995.849000000021,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.498,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.297,
"heapDeltaBytes": 12659880,
"heapUsedBytes": 73845204,
"domNodes": -284,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 15.531000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 642.071000000044,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.129999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.134,
"heapDeltaBytes": -9957088,
"heapUsedBytes": 55590768,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 119.41600000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 632.694000000015,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.885999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.5679999999999,
"heapDeltaBytes": -9823420,
"heapUsedBytes": 55578464,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 119.64899999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.4289999999883,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.36,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.19800000000004,
"heapDeltaBytes": 5434312,
"heapUsedBytes": 71079436,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 6.599999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.54900000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.097,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.72799999999995,
"heapDeltaBytes": 5354984,
"heapUsedBytes": 70766908,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 6.747000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.5659999999993,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.86300000000001,
"layouts": 16,
"layoutDurationMs": 3.8030000000000004,
"taskDurationMs": 761.641,
"heapDeltaBytes": -3776960,
"heapUsedBytes": 61794768,
"domNodes": 65,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 84.08699999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.061999999998,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.591,
"layouts": 16,
"layoutDurationMs": 4.554,
"taskDurationMs": 792.802,
"heapDeltaBytes": -3774544,
"heapUsedBytes": 61915700,
"domNodes": 62,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 88.64800000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1413.84800000003,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.327000000000005,
"layouts": 14,
"layoutDurationMs": 12.248,
"taskDurationMs": 965.894,
"heapDeltaBytes": -6041372,
"heapUsedBytes": 81317100,
"domNodes": 13673,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 17.115000000000006,
"eventListeners": 2375,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8481.222000000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.267999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4346.941,
"heapDeltaBytes": 13390192,
"heapUsedBytes": 73875000,
"domNodes": -283,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 1059.044,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8391.495000000077,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.18299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4366.508,
"heapDeltaBytes": 7648844,
"heapUsedBytes": 67565228,
"domNodes": -283,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 1081.765,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17889.695000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16943.824,
"heapDeltaBytes": -26736160,
"heapUsedBytes": 171218068,
"domNodes": -8312,
"jsHeapTotalBytes": -13541376,
"scriptDurationMs": 130.78599999999997,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17884.725000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16971.635,
"heapDeltaBytes": -32125500,
"heapUsedBytes": 166300968,
"domNodes": -8312,
"jsHeapTotalBytes": -15933440,
"scriptDurationMs": 126.00499999999998,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21967.935000000012,
"styleRecalcs": 178,
"styleRecalcDurationMs": 21.11200000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21376.508,
"heapDeltaBytes": -14294692,
"heapUsedBytes": 184356436,
"domNodes": -8312,
"jsHeapTotalBytes": -14692352,
"scriptDurationMs": 433.23100000000005,
"eventListeners": -16381,
"totalBlockingTimeMs": 96,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21394.483000000037,
"styleRecalcs": 173,
"styleRecalcDurationMs": 19.477999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20714.901,
"heapDeltaBytes": -27511256,
"heapUsedBytes": 183322764,
"domNodes": -8312,
"jsHeapTotalBytes": -14692352,
"scriptDurationMs": 440.40299999999996,
"eventListeners": -16381,
"totalBlockingTimeMs": 110,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 109.13199999998824,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.356,
"layouts": 6,
"layoutDurationMs": 1.961,
"taskDurationMs": 83.501,
"heapDeltaBytes": 2988008,
"heapUsedBytes": 67690940,
"domNodes": 125,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 5.747000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 458.123999999998,
"styleRecalcs": 15,
"styleRecalcDurationMs": 24.312,
"layouts": 4,
"layoutDurationMs": 1.271,
"taskDurationMs": 114.83299999999998,
"heapDeltaBytes": 4960676,
"heapUsedBytes": 69387044,
"domNodes": 123,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.413000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.51 #15833 +/- ##
===========================================
Coverage 81.68% 81.68%
===========================================
Files 1884 1885 +1
Lines 107172 107198 +26
Branches 29333 29807 +474
===========================================
+ Hits 87541 87566 +25
- Misses 19288 19289 +1
Partials 343 343
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #15808 to
core/1.51Automatically created by backport workflow.