Skip to content

[backport core/1.51] fix(billing): let unsubscribed workspaces add credits on Local - #15830

Closed
dante01yoon wants to merge 5 commits into
core/1.51from
dante/backport-1.51-unsubscribed-local-add-credits
Closed

dante01yoon wants to merge 5 commits into
core/1.51from
dante/backport-1.51-unsubscribed-local-add-credits

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Summary

Backport of #15799 to core/1.51. Resolves QA finding #11 from the 1.51 workspace-switcher test plan (sign-off blocker): a workspace without an active subscription had no way to add credits on Local.

Changes

Review Focus

See #15799 for AS IS / TO BE screenshots and the full analysis.

The Add credits entry points in the profile popover and the Credits
settings tile were gated on canAccessSubscriptionFeatures, which is
false for a workspace without an active subscription. On Local the
subscribe CTA is also hidden, so such workspaces had no way to top up.

Gate the buttons on the billing policy table instead: topUpAccess is
'allowed' for every Local state, and showTopUpCreditsDialog already
enforces the same policy. The Cloud free-tier upsell keeps its previous
behavior via showsSubscribeUpsellUI.
…upsell

The Plan & Credits panel forced the never-subscribed team prompt and its
zero-state tile on every distribution, so a never-subscribed team
workspace on Local lost the Add credits button and gained a Cloud-only
Subscribe CTA. Scope that prompt to Cloud, keeping the ended-team
inactive treatment everywhere so billing, invoices, and reactivation
stay reachable.
Click through to the top-up dialog instead of only asserting the button
renders, so the never-subscribed local team path is covered behaviorally
with the real CreditsTile.
The unsubscribed-local e2e coverage rides localAuthFixture, whose
subscription fixture pins billing_rail to legacy_stripe — the rail whose
Local exemption masks QA finding #11. Add a workspace-rail fixture and
spec so the failing rail stays covered end to end, plus unit coverage
for the unsubscribed Cloud owner and the unsubscribed local team tile.
browser_tests/README.md requires new specs to live in a folder mirroring
the product surface rather than the flat tests/ root.
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 878755ac-2dbf-4f6a-b35e-e6a0b2aec098

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/24/2026, 09:16:48 PM UTC

Links

🎭 Playwright: ✅ 1825 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1804 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 24, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

duplicated

@dante01yoon
dante01yoon deleted the dante/backport-1.51-unsubscribed-local-add-credits branch August 24, 2026 21:17
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##           core/1.51   #15830   +/-   ##
==========================================
  Coverage      81.67%   81.67%           
==========================================
  Files           1884     1884           
  Lines         107167   107172    +5     
  Branches       29329    29333    +4     
==========================================
+ Hits           87525    87537   +12     
+ Misses         19307    19291   -16     
- Partials         335      344    +9     
Flag Coverage Δ
unit 73.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...form/cloud/subscription/components/CreditsTile.vue 98.95% <100.00%> (+0.01%) ⬆️
...rkspace/components/CurrentUserPopoverWorkspace.vue 90.47% <100.00%> (+4.85%) ⬆️
...e/components/SubscriptionPanelContentWorkspace.vue 97.14% <100.00%> (+0.02%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nav-tej pushed a commit to balpreetgrowthnatives/ComfyUI_frontend that referenced this pull request Aug 26, 2026
…15831)

## Summary

Follow-up to Comfy-Org#15799 addressing huang47's review comment there:
`browser_tests/README.md` requires new specs to live in a folder
mirroring the product surface, so `localCreditsWorkspaceRail.spec.ts`
moves from the flat `tests/` root into `tests/billing/`.

## Changes

- **What**: Pure `git mv`, no content changes (imports use the `@e2e`
alias). Could not land inside Comfy-Org#15799 because its branch was locked in
the merge queue. The core/1.51 backport (Comfy-Org#15830) already includes this
move.
mattmillerai pushed a commit that referenced this pull request Aug 29, 2026
## Summary

Follow-up to #15799 addressing huang47's review comment there:
`browser_tests/README.md` requires new specs to live in a folder
mirroring the product surface, so `localCreditsWorkspaceRail.spec.ts`
moves from the flat `tests/` root into `tests/billing/`.

## Changes

- **What**: Pure `git mv`, no content changes (imports use the `@e2e`
alias). Could not land inside #15799 because its branch was locked in
the merge queue. The core/1.51 backport (#15830) already includes this
move.
@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants