Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ❌ 1989 passed, 2 failed · 1 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: 🚧 Building... |
The delete and the migration ride together because removing the policy while a consumer still imports it would not build.
Awaits capability initialization before reading the flags, so an eligible user does not lose the deep link while both are still at their initial false.
0dfc09a to
20d71f0
Compare
09d5ade to
0af6f0e
Compare
20d71f0 to
0894b5c
Compare
|
Closing — folded into #15804. The split put A PR that cannot build in isolation is worse than a slightly larger one, so the deep-link loader and its test now ride with the type change that requires them. The initialization-race fix and its regression test moved along with it. |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## wei/be-8716-c-migrate-consumers #15805 +/- ##
=================================================================
Coverage 82.41% 82.41%
=================================================================
Files 1922 1921 -1
Lines 109289 109438 +149
Branches 30404 30325 -79
=================================================================
+ Hits 90067 90198 +131
- Misses 18883 18907 +24
+ Partials 339 333 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Moves the
?topup=deep-link decision onto the server-resolved capabilities.Includes the initialization-race fix from review. The loader awaits
initialize()before readingcanTopUp/canSubscribeSelfServe, so an eligible user no longer loses the deep link when the decision would otherwise be evaluated while both flags are still at their initialfalse. Its regression coverage is in the updated test alongside it.Isolated so that fix and its test are reviewable without the migration diff around them.
Split out of #15641. Based on #15804.