Repository navigation
[backport cloud/1.51] Test unsubscribed local credit purchase flow - #15801
Conversation
## Summary Correct the Local/Desktop billing E2E precondition so finding #11 is exercised as an unsubscribed user, then verify that the user can open **Plan & Credits** and complete the **Add credits** request flow. The product routing fix and real-app UI change were merged in #15793; this PR is its test-only follow-up. ## Root Cause `localAuthFixture` used `withFreeTier()`, which returns an active Free-tier subscription (`is_active: true`, `subscription_tier: 'FREE'`). Finding #11 concerns a logged-in Local/Desktop user with no active subscription (`is_active: false`). Those are distinct backend states. Billing UI eligibility is derived from the mocked subscription response, including `canTopUp`, so the previous fixture could pass while exercising an active subscriber rather than the reported unsubscribed user story. It therefore did not provide deterministic regression coverage for the failure condition fixed in #15793. ## Fix - Replace `withFreeTier()` with `withUnsubscribed()` so the fixture returns the correct backend state: `is_active: false`, `subscription_tier: 'FREE'`. - Mock customer provisioning for that unsubscribed state using the generated Registry API response type. - Update the E2E name and documentation to describe the actual precondition. - Extend the user story beyond opening the dialog: assert the exact `POST /customers/credit` payload and verify the top-up dialog closes after the accepted purchase request. The E2E now covers the Local profile popover, the routed Plan & Credits surface, absence of Cloud-only subscription actions, and Add credits from both surfaces. Immediate and polled top-up completion routing remain covered by the focused tests merged in #15793. ## AS IS — wrong fixture precondition and legacy destination The fixture modeled an active Free-tier subscriber, not an unsubscribed Local/Desktop user. Under the original product behavior, **Plans and credits** opened the legacy combined Credits + Activity page:  ## TO BE — unsubscribed precondition and Plan & Credits destination The fixture now models the no-active-subscription state from finding #11, and the user story verifies the tabbed Plan & Credits page plus a working Add credits request:  ## Validation - `pnpm exec oxfmt --check browser_tests/fixtures/localAuthFixture.ts browser_tests/tests/localCreditsNoSubscribeUi.spec.ts` - `pnpm exec eslint browser_tests/fixtures/localAuthFixture.ts browser_tests/tests/localCreditsNoSubscribeUi.spec.ts` - `pnpm typecheck:browser` - `git diff --check` - CI browser test matrix passed, including local Chromium shards ## Dependencies None. Based on `main` after #15793. --------- Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1819 passed, 0 failed · 5 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-24T18:43:33.475Z",
"gitSha": "4ceaa82682724c0511432f23286c562fff322774",
"branch": "backport-15797-to-cloud-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.0639999999958,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.213,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.801,
"heapDeltaBytes": 4988340,
"heapUsedBytes": 70187132,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.664999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2011.293999999964,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.097000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.41999999999996,
"heapDeltaBytes": 5110772,
"heapUsedBytes": 70518004,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 7.523000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.3700000000022,
"styleRecalcs": 72,
"styleRecalcDurationMs": 29.180999999999997,
"layouts": 12,
"layoutDurationMs": 2.888,
"taskDurationMs": 655.088,
"heapDeltaBytes": -461004,
"heapUsedBytes": 64874560,
"domNodes": 54,
"jsHeapTotalBytes": 24907776,
"scriptDurationMs": 82.83800000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.3369999999968,
"styleRecalcs": 72,
"styleRecalcDurationMs": 31.017000000000003,
"layouts": 12,
"layoutDurationMs": 3.147,
"taskDurationMs": 666.4590000000001,
"heapDeltaBytes": 29856,
"heapUsedBytes": 65456204,
"domNodes": 54,
"jsHeapTotalBytes": 24121344,
"scriptDurationMs": 88.68299999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.0630000000147,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.913000000000002,
"layouts": 6,
"layoutDurationMs": 0.6109999999999999,
"taskDurationMs": 300.893,
"heapDeltaBytes": 7994324,
"heapUsedBytes": 73507104,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 9.09,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.5349999999835,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.071,
"layouts": 6,
"layoutDurationMs": 0.608,
"taskDurationMs": 299.85200000000003,
"heapDeltaBytes": 8008448,
"heapUsedBytes": 73444672,
"domNodes": 78,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 9.018,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 546.1579999999913,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.397,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.20300000000003,
"heapDeltaBytes": -11752692,
"heapUsedBytes": 53600796,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 45.925999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 545.5579999999145,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.612,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.43300000000005,
"heapDeltaBytes": -10805328,
"heapUsedBytes": 54808252,
"domNodes": 20,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 46.066,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2007.6440000000275,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.299,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.286,
"heapDeltaBytes": 12009824,
"heapUsedBytes": 72678764,
"domNodes": -282,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 14.616999999999997,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2010.242000000062,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.550999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.49199999999996,
"heapDeltaBytes": 12924628,
"heapUsedBytes": 73288196,
"domNodes": -282,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 14.217,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2212.573999999961,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.027000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1001.3879999999999,
"heapDeltaBytes": 7008076,
"heapUsedBytes": 68150572,
"domNodes": -284,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 266.001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2087.564000000043,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.174999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.265,
"heapDeltaBytes": 9525164,
"heapUsedBytes": 70595480,
"domNodes": -281,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 254.857,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3135.05600000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.944,
"layouts": 60,
"layoutDurationMs": 7.478000000000001,
"taskDurationMs": 1185.56,
"heapDeltaBytes": -6533656,
"heapUsedBytes": 55693156,
"domNodes": -288,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 321.826,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3117.246000000023,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.860999999999999,
"layouts": 60,
"layoutDurationMs": 6.895,
"taskDurationMs": 1067.5330000000001,
"heapDeltaBytes": 16928484,
"heapUsedBytes": 79289592,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 314.058,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.3420000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.464,
"heapDeltaBytes": 12773180,
"heapUsedBytes": 73826728,
"domNodes": -283,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 12.942999999999996,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1994.515999999976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.762999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.939,
"heapDeltaBytes": 12813960,
"heapUsedBytes": 73859540,
"domNodes": -282,
"jsHeapTotalBytes": 2719744,
"scriptDurationMs": 12.209999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.0910000000549,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.170000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.41300000000007,
"heapDeltaBytes": -9943384,
"heapUsedBytes": 55532460,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 96.333,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.5269999999919,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.041,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.309,
"heapDeltaBytes": -10029844,
"heapUsedBytes": 55637124,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 93.486,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2004.560999999967,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.236999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.90299999999996,
"heapDeltaBytes": 5377352,
"heapUsedBytes": 70809016,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 5.965999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.9630000000552,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.137000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.982,
"heapDeltaBytes": 5643192,
"heapUsedBytes": 71128228,
"domNodes": 20,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 5.401999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1685.863999999981,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.458000000000002,
"layouts": 16,
"layoutDurationMs": 3.534,
"taskDurationMs": 636.529,
"heapDeltaBytes": -3632364,
"heapUsedBytes": 61921436,
"domNodes": 64,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 73.26500000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.4010000000326,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.631000000000004,
"layouts": 16,
"layoutDurationMs": 3.3480000000000003,
"taskDurationMs": 617.9989999999999,
"heapDeltaBytes": -3649872,
"heapUsedBytes": 61948940,
"domNodes": 65,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 69.43199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 917.4550000000181,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.938999999999997,
"layouts": 15,
"layoutDurationMs": 9.397999999999998,
"taskDurationMs": 727.2639999999999,
"heapDeltaBytes": -5744368,
"heapUsedBytes": 77413940,
"domNodes": 13673,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 11.866000000000001,
"eventListeners": 2373,
"totalBlockingTimeMs": 89,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8139.067000000012,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3422.988,
"heapDeltaBytes": 15121092,
"heapUsedBytes": 75219476,
"domNodes": -282,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 808.077,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8158.493000000021,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3208.056,
"heapDeltaBytes": 19130644,
"heapUsedBytes": 79493568,
"domNodes": -282,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 785.733,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14685.398000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14202.718,
"heapDeltaBytes": -42263416,
"heapUsedBytes": 169532788,
"domNodes": -8312,
"jsHeapTotalBytes": -14323712,
"scriptDurationMs": 89.40399999999998,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14733.731000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14269.747,
"heapDeltaBytes": -42892720,
"heapUsedBytes": 168367892,
"domNodes": -8312,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 99.95100000000001,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17564.272000000015,
"styleRecalcs": 149,
"styleRecalcDurationMs": 15.594999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17136.641,
"heapDeltaBytes": -47794052,
"heapUsedBytes": 163294800,
"domNodes": -8312,
"jsHeapTotalBytes": -15667200,
"scriptDurationMs": 344.396,
"eventListeners": -16387,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17399.8610000001,
"styleRecalcs": 155,
"styleRecalcDurationMs": 16.044000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16968.236999999997,
"heapDeltaBytes": -35653960,
"heapUsedBytes": 163229088,
"domNodes": -8312,
"jsHeapTotalBytes": -13832192,
"scriptDurationMs": 391.207,
"eventListeners": -16383,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "workflow-execution",
"durationMs": 452.575999999965,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.286999999999999,
"layouts": 2,
"layoutDurationMs": 0.307,
"taskDurationMs": 92.64100000000002,
"heapDeltaBytes": 4976472,
"heapUsedBytes": 69607156,
"domNodes": 126,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 15.187000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 443.99799999996503,
"styleRecalcs": 14,
"styleRecalcDurationMs": 16.372,
"layouts": 2,
"layoutDurationMs": 0.369,
"taskDurationMs": 90.132,
"heapDeltaBytes": 4952324,
"heapUsedBytes": 69489392,
"domNodes": 125,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 5.839,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.51 #15801 +/- ##
=============================================
Coverage ? 81.55%
=============================================
Files ? 1884
Lines ? 117711
Branches ? 36773
=============================================
Hits ? 95997
Misses ? 21242
Partials ? 472
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #15797 to
cloud/1.51Automatically created by backport workflow.