Repository navigation
[backport cloud/1.51] Fix local billing routes to open Plan & Credits - #15796
Merged
Merged
Conversation
## Summary Route Local billing entry points to the V1 **Plan & Credits** panel instead of the hidden legacy Credits panel. Root cause: #15239 added the V1 `workspace` / Plan & Credits destination for Local, but three existing workspace-aware call sites still selected the legacy `credits` panel on non-Cloud builds. As a result, the profile **Plans and credits** action and completed top-ups opened the old combined Credits + Activity screen. Cloud already selected `workspace` and was unaffected. Reported in [Slack](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1787569379861219?thread_ts=1787034725.224329&cid=C0932CGKT5K). ## Changes - **What**: Open `workspace` from the Local profile action and from both immediate and polled workspace top-up completion paths. - **Regression coverage**: Assert the Local profile action opens `workspace`; preserve direct tests for immediate and polled top-up completion; update the Local browser user story to require the `Credits` and `Activity` tabs before testing Add credits. ## Review Focus The hidden legacy `credits` panel and `CurrentUserPopoverLegacy` remain unchanged for pre-workspace/legacy flows. This PR only changes call sites that already run with workspace billing context. ## Validation - `pnpm test:unit ...` — 112 tests passed across profile routing, immediate/polled top-up completion, and Local/Cloud Plan & Credits rendering - `pnpm typecheck` - `pnpm typecheck:browser` - `pnpm exec eslint ...` - `pnpm exec oxfmt --check ...` - `pnpm knip` - Local real-app browser flow: profile **Plans and credits** opens tabbed Plan & Credits and Add credits remains available - Cloud browser coverage: V1 workspace navigation and unified credits tile pass unchanged ## Screenshots ### AS IS — Local opens the legacy combined Credits + Activity page  ### TO BE — Local opens the tabbed Plan & Credits page  Co-authored-by: Amp <amp@ampcode.com>
comfy-pr-bot
enabled auto-merge (squash)
August 24, 2026 15:09
Contributor
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1819 passed, 0 failed · 5 flaky📊 Browser Reports
|
dante01yoon
approved these changes
Aug 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.51 #15796 +/- ##
=============================================
Coverage ? 81.55%
=============================================
Files ? 1884
Lines ? 117711
Branches ? 36773
=============================================
Hits ? 95997
Misses ? 21242
Partials ? 472
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #15793 to
cloud/1.51Automatically created by backport workflow.