Repository navigation
[backport core/1.51] Fix local billing routes to open Plan & Credits - #15795
Conversation
## Summary Route Local billing entry points to the V1 **Plan & Credits** panel instead of the hidden legacy Credits panel. Root cause: #15239 added the V1 `workspace` / Plan & Credits destination for Local, but three existing workspace-aware call sites still selected the legacy `credits` panel on non-Cloud builds. As a result, the profile **Plans and credits** action and completed top-ups opened the old combined Credits + Activity screen. Cloud already selected `workspace` and was unaffected. Reported in [Slack](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1787569379861219?thread_ts=1787034725.224329&cid=C0932CGKT5K). ## Changes - **What**: Open `workspace` from the Local profile action and from both immediate and polled workspace top-up completion paths. - **Regression coverage**: Assert the Local profile action opens `workspace`; preserve direct tests for immediate and polled top-up completion; update the Local browser user story to require the `Credits` and `Activity` tabs before testing Add credits. ## Review Focus The hidden legacy `credits` panel and `CurrentUserPopoverLegacy` remain unchanged for pre-workspace/legacy flows. This PR only changes call sites that already run with workspace billing context. ## Validation - `pnpm test:unit ...` — 112 tests passed across profile routing, immediate/polled top-up completion, and Local/Cloud Plan & Credits rendering - `pnpm typecheck` - `pnpm typecheck:browser` - `pnpm exec eslint ...` - `pnpm exec oxfmt --check ...` - `pnpm knip` - Local real-app browser flow: profile **Plans and credits** opens tabbed Plan & Credits and Add credits remains available - Cloud browser coverage: V1 workspace navigation and unified credits tile pass unchanged ## Screenshots ### AS IS — Local opens the legacy combined Credits + Activity page  ### TO BE — Local opens the tabbed Plan & Credits page  Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1813 passed, 0 failed · 8 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-24T15:20:10.843Z",
"gitSha": "c991381037e95433463c11bf1ba32c07dd35b95e",
"branch": "backport-15793-to-core-1.51",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.0999999999751,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.969,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.738,
"heapDeltaBytes": 5134380,
"heapUsedBytes": 70483920,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 6.269,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.5419999999813,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.36,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.458,
"heapDeltaBytes": 5069976,
"heapUsedBytes": 70534264,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 6.3709999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.1329999999607,
"styleRecalcs": 73,
"styleRecalcDurationMs": 27.671,
"layouts": 12,
"layoutDurationMs": 3.1679999999999997,
"taskDurationMs": 783.273,
"heapDeltaBytes": -15611760,
"heapUsedBytes": 49792572,
"domNodes": -282,
"jsHeapTotalBytes": 24219648,
"scriptDurationMs": 89.90599999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1750.5130000000122,
"styleRecalcs": 71,
"styleRecalcDurationMs": 31.374,
"layouts": 12,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 674.9029999999999,
"heapDeltaBytes": 4752,
"heapUsedBytes": 65540008,
"domNodes": 55,
"jsHeapTotalBytes": 25169920,
"scriptDurationMs": 87.48,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.3259999999696,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.043,
"layouts": 6,
"layoutDurationMs": 0.562,
"taskDurationMs": 294.126,
"heapDeltaBytes": 8233156,
"heapUsedBytes": 73746760,
"domNodes": 77,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 8.015999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.7489999999643,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.917000000000002,
"layouts": 6,
"layoutDurationMs": 0.5739999999999998,
"taskDurationMs": 298.03499999999997,
"heapDeltaBytes": 8000624,
"heapUsedBytes": 73447008,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 8.639,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 512.8770000000031,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.686,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.535,
"heapDeltaBytes": -11500056,
"heapUsedBytes": 53939596,
"domNodes": 18,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 44.103,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 503.9319999999634,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.673999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.92900000000003,
"heapDeltaBytes": -11476584,
"heapUsedBytes": 53941184,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 45.888000000000005,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2022.8199999999674,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.827000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.88699999999994,
"heapDeltaBytes": 13196860,
"heapUsedBytes": 73289124,
"domNodes": -282,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 13.071000000000003,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2017.0640000000049,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.992000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.15500000000003,
"heapDeltaBytes": 12900916,
"heapUsedBytes": 73002228,
"domNodes": -282,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 13.944999999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2075.097000000028,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.924000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 910.287,
"heapDeltaBytes": 6258220,
"heapUsedBytes": 67637504,
"domNodes": -284,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 248.37900000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2108.701999999994,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.961000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 977.4300000000001,
"heapDeltaBytes": 159840,
"heapUsedBytes": 61640448,
"domNodes": -283,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 262.882,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3072.051999999985,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.261,
"layouts": 60,
"layoutDurationMs": 6.835,
"taskDurationMs": 1061.912,
"heapDeltaBytes": 17345724,
"heapUsedBytes": 79373636,
"domNodes": 12,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 304.59200000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3073.2419999999934,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.637999999999998,
"layouts": 60,
"layoutDurationMs": 7.131,
"taskDurationMs": 1150.876,
"heapDeltaBytes": 18247728,
"heapUsedBytes": 80850336,
"domNodes": 12,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 343.39799999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1990.1800000000094,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.953999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.9579999999999,
"heapDeltaBytes": 12810292,
"heapUsedBytes": 73884384,
"domNodes": -282,
"jsHeapTotalBytes": 2981888,
"scriptDurationMs": 13.333000000000002,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.8189999999895,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.0440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.947,
"heapDeltaBytes": 12603568,
"heapUsedBytes": 74287252,
"domNodes": -282,
"jsHeapTotalBytes": 3244032,
"scriptDurationMs": 14.142000000000001,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 501.5439999999671,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.338999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.515,
"heapDeltaBytes": -10016796,
"heapUsedBytes": 55594004,
"domNodes": 22,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 92.733,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.564999999995,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.584999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.405,
"heapDeltaBytes": -9954796,
"heapUsedBytes": 55595716,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 99.647,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2020.9820000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.3389999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.259,
"heapDeltaBytes": 5422324,
"heapUsedBytes": 71237184,
"domNodes": 20,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 5.633999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2000.9919999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.781999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.434,
"heapDeltaBytes": 5481532,
"heapUsedBytes": 71091400,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 6.182999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1671.5770000000134,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.072,
"layouts": 16,
"layoutDurationMs": 3.247,
"taskDurationMs": 579.8050000000001,
"heapDeltaBytes": -3779392,
"heapUsedBytes": 61784572,
"domNodes": 64,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 63.65899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.431,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.509,
"layouts": 16,
"layoutDurationMs": 3.437,
"taskDurationMs": 636.927,
"heapDeltaBytes": -3582896,
"heapUsedBytes": 61778156,
"domNodes": 64,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 72.925,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 950.476999999978,
"styleRecalcs": 21,
"styleRecalcDurationMs": 24.403000000000002,
"layouts": 16,
"layoutDurationMs": 9.351999999999999,
"taskDurationMs": 726.8800000000002,
"heapDeltaBytes": 22180552,
"heapUsedBytes": 101196640,
"domNodes": 13673,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 12.178,
"eventListeners": 2373,
"totalBlockingTimeMs": 88,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8111.184999999978,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.623,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3139.459,
"heapDeltaBytes": 14875308,
"heapUsedBytes": 75020120,
"domNodes": -281,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 773.346,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8109.646999999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.687,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3307.3559999999998,
"heapDeltaBytes": 2133696,
"heapUsedBytes": 62361300,
"domNodes": -283,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 801.009,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14649.202000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13954.969000000001,
"heapDeltaBytes": -39150756,
"heapUsedBytes": 172091896,
"domNodes": -8312,
"jsHeapTotalBytes": -8065024,
"scriptDurationMs": 97.954,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14941.798000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14444.003,
"heapDeltaBytes": -38584464,
"heapUsedBytes": 172587328,
"domNodes": -8312,
"jsHeapTotalBytes": -5705728,
"scriptDurationMs": 104.11700000000002,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17386.544000000016,
"styleRecalcs": 158,
"styleRecalcDurationMs": 16.175999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16781.952,
"heapDeltaBytes": -29342216,
"heapUsedBytes": 169387912,
"domNodes": -8312,
"jsHeapTotalBytes": -7802880,
"scriptDurationMs": 348.36699999999996,
"eventListeners": -16387,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17320.54100000005,
"styleRecalcs": 146,
"styleRecalcDurationMs": 15.512000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16847.135,
"heapDeltaBytes": -9143392,
"heapUsedBytes": 189405548,
"domNodes": -8312,
"jsHeapTotalBytes": -6561792,
"scriptDurationMs": 332.82900000000006,
"eventListeners": -16383,
"totalBlockingTimeMs": 13,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 424.2349999999533,
"styleRecalcs": 14,
"styleRecalcDurationMs": 16.622999999999998,
"layouts": 2,
"layoutDurationMs": 0.32900000000000007,
"taskDurationMs": 86.76999999999998,
"heapDeltaBytes": 4948436,
"heapUsedBytes": 69515656,
"domNodes": 126,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5.794999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 431.0939999999164,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.856,
"layouts": 2,
"layoutDurationMs": 0.3009999999999998,
"taskDurationMs": 80.59200000000001,
"heapDeltaBytes": 4929188,
"heapUsedBytes": 69794528,
"domNodes": 123,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 5.558000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.51 #15795 +/- ##
==========================================
Coverage 81.64% 81.64%
==========================================
Files 1884 1884
Lines 107116 107116
Branches 29315 29313 -2
==========================================
Hits 87460 87460
+ Misses 19321 19312 -9
- Partials 335 344 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #15793 to
core/1.51Automatically created by backport workflow.