Skip to content

fix: carry a placeholder's live title and colours onto its replacement node - #15734

Merged
mattmillerai merged 4 commits into
matt/be-8848-placeholder-decorationsfrom
matt/be-8850-node-replacement-serialize
Aug 27, 2026
Merged

mattmillerai merged 4 commits into
matt/be-8848-placeholder-decorationsfrom
matt/be-8850-node-replacement-serialize

Conversation

@mattmillerai

Copy link
Copy Markdown
Member

STACKED — merging lands on matt/be-8848-placeholder-decorations (owned by mattmillerai, #15719), NOT main. #15719 is itself stacked on #15713. Review and land those first; this PR is behaviour-neutral without #15719 (it is the change that makes serialize() return live values on a placeholder).

ELI-5

When a workflow references a node pack you don't have installed, ComfyUI draws a placeholder in its place. You can rename that placeholder and give it a colour, same as any node. Later you install the pack, hit "replace", and the real node appears — but it came back with the title from the file and no colour at all, quietly throwing away the rename and the colour you'd applied. This makes the replacement inherit what's actually on screen.

Summary

The node-replacement flow read a placeholder's load-time snapshot instead of the live node, and dropped its colours entirely; both are now taken from serialize() and applied to the replacement.

Changes

  • What: replaceWithMapping and the default-mapping call in src/platform/nodeReplacement/useNodeReplacement.ts now read node.serialize() rather than node.last_serialization ?? node.serialize(). The ?? node.serialize() arm was dead code — the placeholder collection filter requires n.last_serialization to exist — so every replacement replayed the file's title, and a rename made after load was silently lost. Separately, replaceWithMapping applied only title from the serialized data; color, bgcolor, boxcolor and shape were serialized but never copied, so a recoloured placeholder became a default-coloured replacement node. Those four are now applied alongside title.
  • Breaking: none. Structural fields (type / inputs / outputs / properties / widgets_values) are unaffected: only bare LGraphNode instances carry last_serialization (verified — all three placeholder-creation sites use new LGraphNode(...)), and that branch of serialize() replays those fields verbatim from last_serialization, overlaying only mode / pos / flags / decorations (and live size when expanded). The mapping and widget-transfer logic therefore sees identical input.

Review Focus

  • The riskiest line is dropping the last_serialization short-circuit. Its safety rests on the claim above: everything reaching replaceWithMapping is a bare LGraphNode with last_serialization set, so serialize() takes the placeholder branch. If a subclassed node could ever carry last_serialization, serialize() would derive inputs/outputs from the live (registered) definition instead of replaying the file's, and the mapping would be built against the wrong shape. The three creation sites are LGraph.configure, LGraph's subgraph-unpack path, and the API-format loader in src/scripts/app.ts — all new LGraphNode(...).
  • Propagating colours is only correct because nothing assigns them programmatically as error styling. Swept for this: boxcolor is never assigned anywhere outside serialization, and bgcolor is assigned only by the Note node and by the explicit user colour pickers. Missing-node styling rides on the has_errors flag, which replaceWithMapping already clears. So a colour present on a placeholder is a colour the user put there.
  • Scope sweep. 14 non-test references to last_serialization exist under src/. This PR changes 2 (both in the node-replacement flow). The other 12 are left alone deliberately: 4 are reads that only want .type or the existence check used as the placeholder discriminator (missingNodeScan.ts, useErrorClearingHooks.ts, and the two in the collection filter here), and 8 are the write/definition side (LGraph.ts, src/scripts/app.ts, LGraphNode.ts).
  • Test-helper change. createPlaceholderNode's serialize stub previously returned a frozen object literal that ignored the last_serialization the tests mutate after construction. Once the call site stops reading last_serialization, that stub is wrong — every widget-transfer test would have failed for the wrong reason. It now derives from node.last_serialization plus the node's live fields, mirroring the real placeholder branch. No existing test's assertions changed.
  • Coordination: open PR test: cover widgets_values_named precedence in node replacement #14286 rewrites transferWidgetValue in this same file. No functional overlap with these lines; needs a trivial rebase if it lands first.

Provenance

  • Authored by: agent-work loop
  • Verified: pnpm vitest run src/platform/nodeReplacement src/lib/litegraph/test: 122 passed, 0 failed. pnpm test:unit: 16552 passed, 13 failed — 12 of them in scripts/cicd/check-binary-size.test.ts, reproduced identically with this change stashed (pre-existing, environment-dependent), plus one 5s-timeout flake in a firstRunTour test that passed on re-run. Red-check on the new test: reverting the serialize() read alone fails it on the title, and dropping the four decoration lines alone fails it on the colour — so it discriminates both halves. pnpm typecheck, pnpm lint, pnpm format, pnpm knip: clean.
  • Deviations: The new test builds its placeholder with this suite's existing fromAny mock helper rather than a real LGraphNode instance; the file mocks the whole litegraph module, so a real instance is not constructible there. Verification is the unit suite plus a source sweep — there is no in-app repro in this run for the full missing-node → install-pack → replace journey, so the user-visible outcome is asserted at the composable boundary rather than on screen. The originating tracker issue and its investigation notes are internal and were not readable from this environment; the change was implemented from the specification handed to this run and cross-checked against the code itself.

…t node

replaceWithMapping read the load-time snapshot (last_serialization) instead
of the live node, so a rename applied to a missing-node placeholder was lost
when the pack was installed and the node replaced. Read serialize() instead —
its placeholder branch replays the file's structural fields verbatim while
overlaying the live title, flags and decorations.

The replacement also inherited no colour at all: colour, bgcolor, boxcolor
and shape were serialized but never applied, so a recoloured placeholder came
back default-coloured.
@mattmillerai mattmillerai added the agent-coded Opened by the agent-work code loop label Aug 23, 2026
@mattmillerai
mattmillerai marked this pull request as ready for review August 23, 2026 09:43
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a0b0581d-de5f-437d-94ca-5d1f676ad018

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2013 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1992 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/26/2026, 08:06:08 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 121ms TBT · 99.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.1 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 113ms TBT · 178.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 7
canvas-idle: task duration 536ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 78.1 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -156
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 38ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 81
canvas-mouse-sweep: task duration 1155ms
canvas-mouse-sweep: script duration 141ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.6 MB
canvas-mouse-sweep: DOM nodes -284
canvas-mouse-sweep: event listeners -154
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 349ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.4 MB
canvas-zoom-sweep: DOM nodes 74
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 669ms
dom-widget-clipping: script duration 139ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 75.2 MB
dom-widget-clipping: DOM nodes 14
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 541ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 73.6 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 2339ms
large-graph-pan: script duration 841ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.0 MB
large-graph-pan: DOM nodes -277
large-graph-pan: event listeners 8
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 2346ms
large-graph-zoom: script duration 809ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 87.1 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 11
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 3407ms
legacy-node-drag: script duration 940ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.8 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 192
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 545ms
minimap-idle: script duration 41ms
minimap-idle: TBT 0ms
minimap-idle: heap used 73.7 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 519ms
subgraph-dom-widget-clipping: script duration 141ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 61.8 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 478ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 56.5 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 35ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 1069ms
subgraph-mouse-sweep: script duration 105ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.9 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 896ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 121ms
subgraph-transition-enter: heap used 99.3 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 245
viewport-pan-sweep: task duration 8284ms
viewport-pan-sweep: script duration 2837ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 65.8 MB
viewport-pan-sweep: DOM nodes -275
viewport-pan-sweep: event listeners -129
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17395ms
vue-large-graph-idle: script duration 353ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.1 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7476
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 177
vue-large-graph-pan: task duration 21837ms
vue-large-graph-pan: script duration 943ms
vue-large-graph-pan: TBT 113ms
vue-large-graph-pan: heap used 178.6 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 24ms
workflow-execution: layout count 4
workflow-execution: style recalc count 16
workflow-execution: task duration 130ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.1 MB
workflow-execution: DOM nodes 133
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-08-26T20:17:55.770Z",
  "gitSha": "886b3bae8fb898b8d7e6ab3d675a8412dc34ad29",
  "branch": "matt/be-8850-node-replacement-serialize",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2061.9310000000155,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.020000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.388,
      "heapDeltaBytes": 10589540,
      "heapUsedBytes": 81909824,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 12.436,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2051.398000000063,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.278,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.838,
      "heapDeltaBytes": 10679788,
      "heapUsedBytes": 81925680,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.265000000000002,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2220.4169999999976,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 38.589,
      "layouts": 12,
      "layoutDurationMs": 3.5220000000000002,
      "taskDurationMs": 1153.9379999999999,
      "heapDeltaBytes": 4793664,
      "heapUsedBytes": 76596380,
      "domNodes": -284,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 137.87800000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2122.41599999993,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 38.076,
      "layouts": 12,
      "layoutDurationMs": 3.3739999999999997,
      "taskDurationMs": 1156.2169999999999,
      "heapDeltaBytes": 3894404,
      "heapUsedBytes": 75666312,
      "domNodes": -283,
      "jsHeapTotalBytes": 7331840,
      "scriptDurationMs": 143.90200000000002,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1734.6820000000207,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 13.257000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.5569999999999998,
      "taskDurationMs": 349.5929999999999,
      "heapDeltaBytes": 4169036,
      "heapUsedBytes": 75529296,
      "domNodes": 73,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.713000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.0240000000467,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.835000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.6990000000000001,
      "taskDurationMs": 347.951,
      "heapDeltaBytes": 4605000,
      "heapUsedBytes": 76319004,
      "domNodes": 75,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 11.5,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 944.0569999999866,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.329999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 668.626,
      "heapDeltaBytes": 6434296,
      "heapUsedBytes": 78738100,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 141.64700000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 922.3210000000108,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.159,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 669.104,
      "heapDeltaBytes": 7356492,
      "heapUsedBytes": 78874400,
      "domNodes": 12,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 136.417,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.4750000000245,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.021999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.306,
      "heapDeltaBytes": -1362348,
      "heapUsedBytes": 77025648,
      "domNodes": -267,
      "jsHeapTotalBytes": -1355776,
      "scriptDurationMs": 37.026999999999994,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.56200000007,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.593999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.824,
      "heapDeltaBytes": -1689652,
      "heapUsedBytes": 77394144,
      "domNodes": -272,
      "jsHeapTotalBytes": -1880064,
      "scriptDurationMs": 37.64000000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3154.5409999999947,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.809999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2348.7609999999995,
      "heapDeltaBytes": 1120080,
      "heapUsedBytes": 66480216,
      "domNodes": -276,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 847.624,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3158.499000000006,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2328.317,
      "heapDeltaBytes": 21208172,
      "heapUsedBytes": 86551316,
      "domNodes": -278,
      "jsHeapTotalBytes": 3633152,
      "scriptDurationMs": 834.116,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4209.903999999995,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.24,
      "layouts": 60,
      "layoutDurationMs": 8.097999999999999,
      "taskDurationMs": 2360.5349999999994,
      "heapDeltaBytes": 23716120,
      "heapUsedBytes": 91464788,
      "domNodes": 24,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 810.8409999999999,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4248.235000000022,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.350999999999997,
      "layouts": 60,
      "layoutDurationMs": 7.9590000000000005,
      "taskDurationMs": 2330.996,
      "heapDeltaBytes": 23405988,
      "heapUsedBytes": 91132624,
      "domNodes": 24,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 806.6,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4675.385000000006,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.817000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3423.5350000000003,
      "heapDeltaBytes": 24352808,
      "heapUsedBytes": 91187964,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 943.4879999999999,
      "eventListeners": 192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 4693.182999999976,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.889999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3390.4879999999994,
      "heapDeltaBytes": 23430484,
      "heapUsedBytes": 90772788,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 936.6450000000001,
      "eventListeners": 192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.2790000000205,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.3859999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 524.2560000000001,
      "heapDeltaBytes": 12050388,
      "heapUsedBytes": 77193512,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 41.733,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2051.845000000071,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.7569999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 564.9390000000001,
      "heapDeltaBytes": -3558760,
      "heapUsedBytes": 77398968,
      "domNodes": -273,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 40.982,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 760.9239999999886,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.171000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 545.48,
      "heapDeltaBytes": -7697472,
      "heapUsedBytes": 65120540,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 147.292,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 694.2629999999781,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 493.49299999999994,
      "heapDeltaBytes": -7362712,
      "heapUsedBytes": 64492488,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 134.804,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2051.2520000000336,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.257,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.23699999999997,
      "heapDeltaBytes": -10896564,
      "heapUsedBytes": 61537620,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.442000000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2057.007999999996,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.602000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.56699999999995,
      "heapDeltaBytes": -14711908,
      "heapUsedBytes": 57030344,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.292999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1863.3480000000304,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 35.518,
      "layouts": 16,
      "layoutDurationMs": 4.507,
      "taskDurationMs": 1080.643,
      "heapDeltaBytes": 5936084,
      "heapUsedBytes": 78797440,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 105.472,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1839.4920000000639,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 35.065,
      "layouts": 16,
      "layoutDurationMs": 4.412,
      "taskDurationMs": 1057.4589999999998,
      "heapDeltaBytes": -4898632,
      "heapUsedBytes": 67838636,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 105.015,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1350.9619999999813,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 30.333999999999993,
      "layouts": 15,
      "layoutDurationMs": 13.502000000000002,
      "taskDurationMs": 895.799,
      "heapDeltaBytes": 21681400,
      "heapUsedBytes": 104074372,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 28.525999999999996,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 121,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12196.177000000034,
      "styleRecalcs": 244,
      "styleRecalcDurationMs": 37.214999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8198.451000000001,
      "heapDeltaBytes": -10098348,
      "heapUsedBytes": 68850600,
      "domNodes": -275,
      "jsHeapTotalBytes": 1265664,
      "scriptDurationMs": 2809.142,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12322.367999999984,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 38.659,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8369.901,
      "heapDeltaBytes": -9406660,
      "heapUsedBytes": 69133376,
      "domNodes": -274,
      "jsHeapTotalBytes": 2052096,
      "scriptDurationMs": 2865.2329999999997,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18371.329,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17488.687,
      "heapDeltaBytes": -48704256,
      "heapUsedBytes": 176961820,
      "domNodes": -6548,
      "jsHeapTotalBytes": -864256,
      "scriptDurationMs": 348.582,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18032.0210000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17301.661000000004,
      "heapDeltaBytes": -29300604,
      "heapUsedBytes": 177628008,
      "domNodes": -6548,
      "jsHeapTotalBytes": 724992,
      "scriptDurationMs": 357.803,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22445.816000000035,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 21.49599999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22087.96,
      "heapDeltaBytes": -18134504,
      "heapUsedBytes": 187435868,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1753088,
      "scriptDurationMs": 975.8370000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 195,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21923.992,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 18.96199999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21586.564,
      "heapDeltaBytes": -20952192,
      "heapUsedBytes": 187175092,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2002944,
      "scriptDurationMs": 910.4449999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 487.4170000000504,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 29.814999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.3669999999999998,
      "taskDurationMs": 158.29700000000003,
      "heapDeltaBytes": 6228136,
      "heapUsedBytes": 74828816,
      "domNodes": 154,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.688,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 132.07199999999375,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 17.265,
      "layouts": 3,
      "layoutDurationMs": 1.434,
      "taskDurationMs": 101.462,
      "heapDeltaBytes": 3816424,
      "heapUsedBytes": 72282760,
      "domNodes": 111,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.928,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 23, 2026
@mattmillerai mattmillerai added the cursor-review Trigger multi-model Cursor agent review on this PR label Aug 23, 2026
@codecov

codecov Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                          Coverage Diff                          @@
##           matt/be-8848-placeholder-decorations   #15734   +/-   ##
=====================================================================
  Coverage                                 79.47%   79.48%           
=====================================================================
  Files                                      1947     1947           
  Lines                                    118503   118508    +5     
  Branches                                  34001    33998    -3     
=====================================================================
+ Hits                                      94181    94193   +12     
+ Misses                                    23823    23815    -8     
- Partials                                    499      500    +1     
Flag Coverage Δ
e2e 66.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/nodeReplacement/useNodeReplacement.ts 81.96% <100.00%> (+0.93%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

Found 4 finding(s).

Severity Count
🟡 Medium 2
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

Take a single serialize() snapshot before onRemoved() and the _nodes /
_nodes_by_id overwrite, and pass it to both the default mapping and the
widget/property transfer so the two cannot read divergent state.

Also make the test's placeholder serialize() mock mirror production: drop
the recorded decorations before overlaying the live ones, filter with
Boolean, and apply the class-default title guard.
…ions' into matt/be-8850-node-replacement-serialize

# Conflicts:
#	src/platform/nodeReplacement/useNodeReplacement.test.ts
#	src/platform/nodeReplacement/useNodeReplacement.ts
@vercel

vercel Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
comfy-ui-frontend-desktop-ui Ready Ready Preview Aug 26, 2026 8:04pm

Request Review

@mattmillerai
mattmillerai merged commit 56a9f2d into matt/be-8848-placeholder-decorations Aug 27, 2026
84 of 85 checks passed
@mattmillerai
mattmillerai deleted the matt/be-8850-node-replacement-serialize branch August 27, 2026 22:40
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026

This branch was successfully deployed

1 active deployment
Preview – comfy-ui-frontend-desktop-ui — c5e2db9c Deployed Aug 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-coded Opened by the agent-work code loop cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned) size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants